From nobody Sat Feb 7 14:34:30 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECE573D6688; Tue, 20 Jan 2026 22:11:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768947079; cv=none; b=lzOcZRk0C5a6mzFEERhW5S6rTWk0Upc1jsfqcknF9sMm7c6IeeY8kwDZQ0uWC6gbulgESkrHCK4a8P8qQ81Gf5kMsw1YtkBws2J7K1wMB8/YnNDgUnHZrafjF2hOeQAT4ubzAKokepjjMeI+vbk8g+zifqPepMK1RWmwcMZFMLs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768947079; c=relaxed/simple; bh=9AQ04Q45KYJvgiQU6eyRgu+IU8LONLjTjfGyl0Bpwi4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JndacWyDmmmOI0AgnY2duerMngjsqbtOon5+vYACAE8wF1MLiPOsQJ2G8F8ArTZtqkxUr/uLvwZhKs2ZjrrMD3A7lw5vIQiR6um98ywTI2Nlb0iO7KwrzUubLQSoUen1gsb7zyTucpnkf83rBmZvmBHJNf8pCIgz5ElGTL6q3sQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Vhq6UHwL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Vhq6UHwL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BCBAC19422; Tue, 20 Jan 2026 22:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768947078; bh=9AQ04Q45KYJvgiQU6eyRgu+IU8LONLjTjfGyl0Bpwi4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Vhq6UHwLs31n5OYRl7O4R6lW97+tl/MF6JcSIT63Pd7IwWpvfk8P6A6V86ZqNMOFJ mj0A8aLa/ttnmSidn4G0iJZ9/liTYZnWRL4px5vRMt+cBjXngxVjQ+NQ5py7uLYN1x OG7bWeg9Wr+d14dvfZGoxkJEqd2U6ehSpgF8+IiuGAV4qalcCd1lbhc3AQPVfKcfM4 kckSPHH6jLcZQ0Quf1ROKXtjJJfZRvZjrmuDjTqkKKU82v0kZA3DXawS4zAoBlqMU9 eDjxqzJVr/aV2RE0WPr6KYcx1Q7351fcQKZftFX7zKG7W+ermQlxCyw2/eOlqOhW0m WhL3/X9EXzMXQ== From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Thomas Gleixner , James Clark , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH 1/4] perf tests sw-clock: Mark the volatile tmp variable as __maybe_unused Date: Tue, 20 Jan 2026 19:08:57 -0300 Message-ID: <20260120220900.366451-2-acme@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260120220900.366451-1-acme@kernel.org> References: <20260120220900.366451-1-acme@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnaldo Carvalho de Melo As it is just used to waste some cycles, not being used as all, to silence some compilers. Noticed with gcc version 16.0.1 20260115 on fedora 44: tests/sw-clock.c: In function '__test__sw_clock_freq': tests/sw-clock.c:31:22: error: variable 'tmp' set but not used [-Werror= =3Dunused-but-set-variable=3D] 31 | volatile int tmp =3D 0; | ^~~ Signed-off-by: Arnaldo Carvalho de Melo Reviewed-by: Ian Rogers --- tools/perf/tests/sw-clock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/perf/tests/sw-clock.c b/tools/perf/tests/sw-clock.c index 4a2ad7176fa07be0..b6e46975379cd5ef 100644 --- a/tools/perf/tests/sw-clock.c +++ b/tools/perf/tests/sw-clock.c @@ -5,6 +5,7 @@ #include #include #include +#include #include =20 #include "tests.h" @@ -28,7 +29,7 @@ static int __test__sw_clock_freq(enum perf_sw_ids clock_id) { int i, err =3D -1; - volatile int tmp =3D 0; + volatile int tmp __maybe_unused =3D 0; u64 total_periods =3D 0; int nr_samples =3D 0; char sbuf[STRERR_BUFSIZE]; --=20 2.52.0 From nobody Sat Feb 7 14:34:30 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C56153BBA06; Tue, 20 Jan 2026 22:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768947082; cv=none; b=WnLIEizKB8IN1n5glV7cHKThZqGMhZYpOBXMzITtX3JZk4jFsDsP5gOEYoS2P+IHd9Sa/NJa9AnhfHPQFlT4h+KXSBPW8IPGQPQiQ4kqByNwzublhM8EtewZE5c4L1MA0rfuLRc2CQ/8GQ52Qh/XCvJuLxyU2ihrYsNxGkt0Qjw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768947082; c=relaxed/simple; bh=2D5vgF6AZ4BggNPQLEURklEG7352xqjAuCBH4p2jCOQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=orOqXh828FWEPQRQtGvWWGNiSoJ9xp8rRqp7t7wHe5U08P3B4lb049YBkGTHvhlncoYn5EfZQpbo7tNPL/8k+TUDD5Ovn9SyWqqMR7lKCiLTCCd/j2emGumHggcGNuT4KXOSxTz5WW+pWpsAG6Va++St7M27P0XM6mAAlQa24hg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hjF99C07; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hjF99C07" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74FADC16AAE; Tue, 20 Jan 2026 22:11:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768947081; bh=2D5vgF6AZ4BggNPQLEURklEG7352xqjAuCBH4p2jCOQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hjF99C0737vAQhpqBsqvZACvdS15L/5I7a5zYf2seQUICFrTfbqGhEU7LezUf7XKj q28DbwYc6D5hQYTDehKie+6RnhS018Sst5vSt2Ff0+5/3EMeAjVPqSi41/DYR0Wobz lcLXHOOR4PqvwUhQeJ9YB6/949pqBgmUH654jE2tS4kNy517Nvkh9MWOZ4XTq7ieJt 41aOFUDOqUGfALyAfTZDBFnT7mEh+Bv6rVvarxIpLUcVfPTbZO2o5UrdOfkBodG/q3 7Lqilsp2Hl5UfFS+8+El3raOKe0QCOb36RBFOfcFDbE+TFbSWp1sSzggI8UmM1nChu lJDZa6N+uzMoA== From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Thomas Gleixner , James Clark , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH 2/4] perf trace: Deal with compiler const checks Date: Tue, 20 Jan 2026 19:08:58 -0300 Message-ID: <20260120220900.366451-3-acme@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260120220900.366451-1-acme@kernel.org> References: <20260120220900.366451-1-acme@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnaldo Carvalho de Melo The strchr() function these days return const/non-const based on the arg it receives, and sometimes we need to use casts when we're dealing with variables that are used in code that needs to safely change the returned value and sometimes not (as it points to really const areas). Tweak one such case. Signed-off-by: Arnaldo Carvalho de Melo Reviewed-by: Ian Rogers --- tools/perf/builtin-trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index 58a32adafddff7f5..8df5ca44e4f91529 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -5190,7 +5190,7 @@ static int trace__parse_events_option(const struct op= tion *opt, const char *str, } =20 while (1) { - if ((sep =3D strchr(s, ',')) !=3D NULL) + if ((sep =3D strchr((char *)s, ',')) !=3D NULL) *sep =3D '\0'; =20 list =3D 0; --=20 2.52.0 From nobody Sat Feb 7 14:34:30 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F6D92D662F; Tue, 20 Jan 2026 22:11:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768947085; cv=none; b=WfzbRzbDjtV54pa0i5YGHVb/dZwNUi7QFtvRV1ACtP9pyYxJoBP3TMRgvf8hEdPn5r1rhdqOaplFk9Vah1heA+DHqwcSh6AHE1sGvtyEMthxDCivcffM5Qa+VE7MpVFLEk+oit3EWrVVLlotxdjOA5Z5UcqtMdJ9CZyEV3JFcoA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768947085; c=relaxed/simple; bh=RxIm06w4RCsyoUx1X3ErpEBF6qQYRq4597Bqwj1grxw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tshngWwGfPg5R5ydekZMIxYRiguDbRBgTaOQCfVvwwEaKirF+qvgOtUQ4t8bWYeofoNBXdroBql7M8eWtsWsI+gyrSsQt4/yhvhJtk4M5KkZzeEehcPctltaSu5p+AM5kC0I3qF6v8HcKbM0+jgaY9OMuOXBwieBg7W+b0v9gKo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eVm/d9yc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eVm/d9yc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F10FC2BC86; Tue, 20 Jan 2026 22:11:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768947084; bh=RxIm06w4RCsyoUx1X3ErpEBF6qQYRq4597Bqwj1grxw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eVm/d9ycqmM7ttaNF6+TX+xpidQbJpIgFRJAJVcGgtL0lCxcM1hCtm05TgMofdHcr wF27FYdqicukK9bjJdAgSUq3tXEeHfcU6/Hfsma5Exhtn7EHNknYDtsxFMnBXLBpkk cKXIuGs0lgstcRPFBmuHJNOp9eQYPVqQklHbiWa9HYLg3dr3sIQH0GVZ8eEWM23wNe PusyvFLDu9zmMOfB7RJd87E8rv1bk8o3RKOguA/40Hf2cwhmtPJq6SpyxVbGj/nkDa l9DJzBzdftFJMU0e4d7sZ5CDkElM0Cdq3TdUIneLu5JxR9+X1nih+vUI/Wua5sOPbp R0FwoY3vboJqw== From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Thomas Gleixner , James Clark , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH 3/4] perf list: Don't write to const memory Date: Tue, 20 Jan 2026 19:08:59 -0300 Message-ID: <20260120220900.366451-4-acme@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260120220900.366451-1-acme@kernel.org> References: <20260120220900.366451-1-acme@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnaldo Carvalho de Melo Something now detected on fedora 44, where strchr() returns const if it is passed a const pointer: util/print-events.c: In function 'print_sdt_events': util/print-events.c:89:29: error: initialization discards 'const' qualifi= er from pointer target type [-Werror=3Ddiscarded-qualifiers] 89 | char *bid =3D strchr(sdt_name->s, '@'); | ^~~~~~ Fix it by using strnchr() if strchr finds the separator instead of temporarily scrubbing it with '\0'. Signed-off-by: Arnaldo Carvalho de Melo Reviewed-by: Ian Rogers Suggested-by: David Laight --- tools/perf/util/print-events.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/tools/perf/util/print-events.c b/tools/perf/util/print-events.c index 8f3ed83853a9e468..898cf426509790cd 100644 --- a/tools/perf/util/print-events.c +++ b/tools/perf/util/print-events.c @@ -97,14 +97,11 @@ void print_sdt_events(const struct print_callbacks *pri= nt_cb, void *print_state) } else { next_sdt_name =3D strlist__next(sdt_name); if (next_sdt_name) { - char *bid2 =3D strchr(next_sdt_name->s, '@'); - - if (bid2) - *bid2 =3D '\0'; - if (strcmp(sdt_name->s, next_sdt_name->s) =3D=3D 0) - show_detail =3D true; - if (bid2) - *bid2 =3D '@'; + const char *bid2 =3D strchr(next_sdt_name->s, '@'); + + show_detail =3D bid2 ? + strncmp(sdt_name->s, next_sdt_name->s, bid2 - next_sdt_name->s) =3D= =3D 0 : + strcmp(sdt_name->s, next_sdt_name->s) =3D=3D 0; } } last_sdt_name =3D sdt_name->s; --=20 2.52.0 From nobody Sat Feb 7 14:34:30 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E137500971; Tue, 20 Jan 2026 22:11:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768947088; cv=none; b=ChuoPoNcZgPLSGYIBIwHPgP5zuZi7jsVQwdb+Ra6yr63SG8+9Dh4rv/n2IwhTBfrxzMxd4RIDFwdMgbZryM881KrXshDCfW8JvaWmyUjpwDP62PRYnydWhJ68jsvmx/8q9Vy0k2VYU8Aw0Jj9g2Ic5Rw2tBUVrIbeL2ibOG92tk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768947088; c=relaxed/simple; bh=2pqEONvGIfXTlzH0fJxXCe1oZHZRHM1wULCH7ZJHrfQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qyZ4T+5NGeGbrrVOHawUPtZxTXGdhMU0873amAGP6Wh1mag0YT5bxsECmuzP8XXBtggoJEtVZaXLL19/Gyil4u8nNNBQeYIKIPJUGhJIxGHPJSZzu7gn+Rfimk4PhntlkBj2SmXW9uJUIPlwRmYO+e26l1YsMbZGhpYPyn59CdM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GpKRJfjr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GpKRJfjr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA38EC19422; Tue, 20 Jan 2026 22:11:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768947087; bh=2pqEONvGIfXTlzH0fJxXCe1oZHZRHM1wULCH7ZJHrfQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GpKRJfjrztyiiEMNtWFZwKCkXeHx6alZpgqN4Zy4eQpCnBAi7Q6GPq6uVPOmmuTbp hnQPx/jja8z0RV7fT2C4nD8M9tZbzA/t2zIPPg3s3RcMLCOZTaG/yecTHM60iPdTCr FNktK80cPHVcSXq0yvxxfbUlu/xRjy7N4IffUsz4ZEZiEpX22fkpGZOrjtS6nMDQFN 6b/HVSEHp+ljqrj/6LMxhVWwopzS8+MvnMHV/mLqPB2cg7EZJOacteTo50M7Oh9EVF zpMH36V8sUY89T1Ielm1UzMZgkjef6GjV4OTuZ8j/WxKFAB6EALaVLoWaKX381zZnW fqVwVwfA0DVZA== From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Thomas Gleixner , James Clark , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH 4/4] perf list: Signal changing const memory is ok Date: Tue, 20 Jan 2026 19:09:00 -0300 Message-ID: <20260120220900.366451-5-acme@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260120220900.366451-1-acme@kernel.org> References: <20260120220900.366451-1-acme@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnaldo Carvalho de Melo In this case its a temp list that is created just for listing events and will be deleted at the end, so just cast it to get rid of the compiler warning. Signed-off-by: Arnaldo Carvalho de Melo Reviewed-by: Ian Rogers --- tools/perf/util/print-events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/print-events.c b/tools/perf/util/print-events.c index 898cf426509790cd..57c06f6bca1fced6 100644 --- a/tools/perf/util/print-events.c +++ b/tools/perf/util/print-events.c @@ -86,7 +86,7 @@ void print_sdt_events(const struct print_callbacks *print= _cb, void *print_state) =20 strlist__for_each_entry(sdt_name, sdtlist) { bool show_detail =3D false; - char *bid =3D strchr(sdt_name->s, '@'); + char *bid =3D (char *)strchr(sdt_name->s, '@'); char *evt_name =3D NULL; =20 if (bid) --=20 2.52.0