From nobody Sun Feb 8 23:24:45 2026 Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C08AB3A1CE7 for ; Tue, 20 Jan 2026 20:02:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768939330; cv=none; b=NWd0cp9jTXoTdc52kYiszRGbiwl2z6YCAgT+YE3+kjvKuY1qNoo497phshbUKglui1iWqEWL4gIPPhTyv8cJ390kBVyyftzZ6GaKJtCJjFq5Dpqb7UQ2JuKdB4uHoJwij5o3vR5jiQfrvsKJMkM6I0cmpKvqMcm27rd5FMkcx9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768939330; c=relaxed/simple; bh=6MEVPmY+/4uufPcJ2T8jNc5x6LCDzPCUZ1cUQcoT9mw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xv806AobagCtY995RW5F7GlkBbCnBN9hbhP3Flhb3nTS6OmHCTlWT7sxQ6HM90QHRWFE+nIvstdpXWyGWKwyoi5q09ptemHhbWpgWXiKZyDQW/ponywrBbg/aJaIY8qK9lHcVp4G4JprqQxV0dcMR1FXpgsns6h7leFND7NuJDY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SThdaPJs; arc=none smtp.client-ip=209.85.222.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SThdaPJs" Received: by mail-ua1-f54.google.com with SMTP id a1e0cc1a2514c-93f523bba52so110294241.1 for ; Tue, 20 Jan 2026 12:02:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768939326; x=1769544126; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6sAyltQ9Ju5LJsjrxN+RFppegkQgHbMR0ZkUv+EPidQ=; b=SThdaPJszRpKCEegJr78IL91zuLxSA2L86WqdHUDzjjfWPxkrNxLzEEXEXioP2iNO0 HKFpWdW8DKMzXaITpxfA6qwdNUQc9hk1+mH+Ss+19+5T2VoJ6IwrcKr7JBCJJGNqto9J wvYnN4EF7WAphpnIh+bsRp5SsnrY16ZKGUhh0GgrDjlHbVjZVvTy3kkAqPrFdVgFeZHn r4ljjhYpmQyQ8slKmnRTuT2N/xnPPuQ+v8/jz5zyhIQCBGL1GDcl3YTO/bw0S6aDFfei oMguctXgkUHeEyiaK1KU7+PirAHUmpGDgmK+dhVOgx6+lOjjcxJTYKTsDIq9Nde+hLf9 0QQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768939326; x=1769544126; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6sAyltQ9Ju5LJsjrxN+RFppegkQgHbMR0ZkUv+EPidQ=; b=AJYqz2lBuI5WAXxtaS2cSjBv+ZykdNstoPAms0gW4jMZjClw42sLGCytWB7P0+bQU3 eQlu1ESVtcWefUdaENU6gJ6iutHH+g04KTTvE5acsaVHznlaOaYRSyyun2R6jL3Fl6UG FT14hWH+1T2Vx7Oy5YNhmXqJXavtqxdnVUov78ppjEhiFG9IbTrv/qyB/RTFF4ONblX0 aN90X1so1ZzOg2v1DYOo0edhGBkHsez+eXNmNSSDnLQgW6k7xSygrUV3QUpX4KIJIFcQ vVv76L/Lnc7ZEMcFj7KZD5PPzng1uIbTMTI3NTRKB+xuIgS5eYG7zSQiu0Xl8+VhuHEh FpRw== X-Forwarded-Encrypted: i=1; AJvYcCWaBoCbrUxGF/mwS0UB5LMin7Gc3RHADOkUQ7oacmFSY8t94sx1xiJ5zH9PkW2TpePzAeppNn/9bikW8PM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywe1T72l5P8BBIFDmSQfD0eFSr6sssJ2AnLe34jTSk1iXFz/ACA blnvMADp7ldV4EyfOO2D4XMOVMjReOarTilt2pHKVY4NbU+1ZsOhR/WD X-Gm-Gg: AZuq6aKudlETQipiUcF3zkp1+qXRpPoktMT1ahKFPXu++MoN4aIndRS2RaHtVfd8d6V QOBWWi1sLhPmGwAKh6weXfjvKa2nRruFSqFeYL5+nhwGwUtm87BRSl2fMp279zHpJowo1FInaAo NOr4VKQzcUdQBxswNkxmC2pOumAHGj1NEsCib5CoP4OYNY0JCb551QSjrO2N+3exVIZ35//0/yU LukTZgJzbhlIDJoPlhr2uY/0ud913rB2n6pSln0BIkxnShHW2zDChnlNbjcrqFgCVaayMrsNcW+ i5zzr4dt6h0JFWjCimeDJZI4Z3wec6LTGz4X5jZeatQ9CQQLfV2b00SJ6GIaQmqoso5gFl2Rr/y xRX+bgsfBE7e38BnfYXUkFwmDfCe3WPutMr9dgGyEs2V+U5UCseB89xshT15/6I8jBWtyxR6Kpl U4ygfO7WhZ0ciuYZNbAY7iSmXhXKRRa//y4mzhlLnxJp8ntNadW7wiulPgpI8qPZlmugLJbA== X-Received: by 2002:a05:6102:3a07:b0:5ef:a312:e70c with SMTP id ada2fe7eead31-5f1a55d2200mr6149316137.20.1768939325072; Tue, 20 Jan 2026 12:02:05 -0800 (PST) Received: from benjamin-desktop-fedora.mynetworksettings.com ([141.154.77.127]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c6a7298472sm1112863585a.53.2026.01.20.12.02.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 12:02:04 -0800 (PST) From: Benjamin Wheeler To: srimanachanta@gmail.com Cc: bentiss@kernel.org, jikos@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] HID: steelseries: Clean up hid send_report functions Date: Tue, 20 Jan 2026 15:02:00 -0500 Message-ID: <20260120200202.1225216-2-benjaminwheeler0510@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260120200202.1225216-1-benjaminwheeler0510@gmail.com> References: <20260112041941.40531-1-srimanachanta@gmail.com> <20260120200202.1225216-1-benjaminwheeler0510@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" These functions do the same thing, so combine them into one with a parameter. Use helper functions to keep callsites the same. Signed-off-by: Benjamin Wheeler --- drivers/hid/hid-steelseries.c | 45 ++++++++++++++++------------------- 1 file changed, 21 insertions(+), 24 deletions(-) diff --git a/drivers/hid/hid-steelseries.c b/drivers/hid/hid-steelseries.c index a0046fbc830b..63b086fa6df0 100644 --- a/drivers/hid/hid-steelseries.c +++ b/drivers/hid/hid-steelseries.c @@ -829,9 +829,13 @@ static int steelseries_battery_register(struct steelse= ries_device *sd) return 0; } =20 -/* Helper function to send feature reports */ -static int steelseries_send_feature_report(struct hid_device *hdev, - const u8 *data, size_t len) +/** + * Send an hid report to the device. + * Supported types are output reports and feature reports. + */ +static int __steelseries_send_report(struct hid_device *const hdev, + const u8 *const data, const size_t len, + const enum hid_report_type type) { u8 *buf; int ret; @@ -840,8 +844,9 @@ static int steelseries_send_feature_report(struct hid_d= evice *hdev, if (!buf) return -ENOMEM; =20 - ret =3D hid_hw_raw_request(hdev, data[0], buf, len, HID_FEATURE_REPORT, + ret =3D hid_hw_raw_request(hdev, data[0], buf, len, type, HID_REQ_SET_REPORT); + kfree(buf); =20 if (ret < 0) @@ -852,28 +857,19 @@ static int steelseries_send_feature_report(struct hid= _device *hdev, return 0; } =20 -/* Helper function to send output reports */ -static int steelseries_send_output_report(struct hid_device *hdev, - const u8 *data, size_t len) +static inline int steelseries_send_feature_report(struct hid_device *const= hdev, + const u8 *const data, + const size_t len) { - u8 *buf; - int ret; - - buf =3D kmemdup(data, len, GFP_KERNEL); - if (!buf) - return -ENOMEM; - - /* Use raw_request with OUTPUT_REPORT type for devices without Interrupt = OUT */ - ret =3D hid_hw_raw_request(hdev, data[0], buf, len, HID_OUTPUT_REPORT, - HID_REQ_SET_REPORT); - kfree(buf); - - if (ret < 0) - return ret; - if (ret < len) - return -EIO; + return __steelseries_send_report(hdev, data, len, HID_FEATURE_REPORT); +} =20 - return 0; +static inline int steelseries_send_output_report(struct hid_device *const = hdev, + const u8 *const data, + const size_t len) +{ + // NOTE: Output report (HID_OUTPUT_REPORT) is for devices without Interru= pt OUT + return __steelseries_send_report(hdev, data, len, HID_OUTPUT_REPORT); } =20 /* Sidetone level attribute */ @@ -2170,3 +2166,4 @@ MODULE_AUTHOR("Bastien Nocera "); MODULE_AUTHOR("Simon Wood "); MODULE_AUTHOR("Christian Mayer "); MODULE_AUTHOR("Sriman Achanta "); +MODULE_AUTHOR("Benjamin Wheeler "); --=20 2.52.0