From nobody Tue Feb 10 11:56:28 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B3E243C067 for ; Tue, 20 Jan 2026 13:33:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768916034; cv=none; b=PxicNTWho8WSB992/bhhLT4g9R0IU0uIP8Hru121TD8SYbYe7DqoI0AhWmVzd8681klrAY1+7JDMNQWuahNIxVEEA0y4xjkzsfLnYJgDKdmUMqloKAtk9AoXwejQjR8alh/eMGI/Rf1bNBF41aEJTdODJwSAQQVF0Gdn/lCr/uw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768916034; c=relaxed/simple; bh=hrsUEoSTkdNYFm8WzseU1HUqOXHvGZY2m9IltHxuiXU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FDG3o3TtJkI/DXwCOfb5KwfGzWXUici8bffiMuN0z/+QzeFGGx8NIUaOLZRZOCP6TRU3f29dtZo7kjy51076VCaKa2skIJCjTxmpc3N/c3kO8jw7+B9d4QS0Te0YrsMfhzPcKnEOHS1ytZZ4tRtp+H+7EzMlvVFbkjuH+mnzHNY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=NoZvxrsy; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="NoZvxrsy" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42fbc305552so3928396f8f.0 for ; Tue, 20 Jan 2026 05:33:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1768916031; x=1769520831; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Or2PvAUr6ZHPTcmvHehxrdDkv+cU8AUyLZ4ALfe+ybo=; b=NoZvxrsyD1xGhuk4FK7nw7eqjfhLs9D60QPao7OO+n5kWBeZcHd2T5nUz/A0xt56dn m2qQO5+yAQb4M/Kyku7dzyzTDYzH3iPaFXRzVWlbCV9I4/wR5bUkM1oZAQDyp2bFrjXQ JLk6Sn1ycvQxb+aHX9DoT1C2ofKbDlmnMgvIxjd+HihSfg0cXijfk2tnDjjpNwGX6fP5 V0m+5QCfo8U7UK3hmzQsveM/vatxSw566g2+/DXXI0nutyHFtTfPxYG8PSGNOWoUSKPB 5rg1/Su0oDKeTxeQD2SM2P1jkZS646Vb2tjL5P2rfDgOrPsZTdJ8OxJz6YSAxMPJpPdO V4mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768916031; x=1769520831; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Or2PvAUr6ZHPTcmvHehxrdDkv+cU8AUyLZ4ALfe+ybo=; b=btKyoSVru1PiX/c7CafOh3CcRSRREIx0dVLEBOdWonk2YA7o2/6u7cxzTGRRpwMcyz +HOYjwwC41iVvZ/Rfhks2Egs102GtLRaXD8mIxhDupHayt9IxBbg5pqe/sSg+hfYySlr EZ1okZtp1riBuekLKLX/q7DXP5xLgbvdhvWgS/0FJyAD9KBFFCIsb6nEPX9SSy74Cqq3 bqSTnsejcB8dncc+W9pskF4n0bZ1dPDQa3yVgEhhGIRn4MAw9DmOE4+1ce4CSPCIXpKl bZASMFr4hcWRGqnWLySig+rH0+5gtzofwRRsMfrF25cyazIMZdI4/arZN4kYkls8BKWA o9nw== X-Forwarded-Encrypted: i=1; AJvYcCWJlQ48QafOfKsVvt0FPjDOy5wT5atSdARa3BPJKrMkUcL6szKsc7EgIkUBq1h46fu1tmSm3g8Lz9aSDJA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzt/jvVCa+o+/Nq7omk1k9VRmWlq2w5qVrKcVjhcRKuP/km6yQc /UJv1WRTMqHwgjXXa75ll5+2M5C2B3pEt58gUANnLR+54i/Ccqd8tXnU5i4AtLGw4Kw= X-Gm-Gg: AZuq6aIHJQUSZYz9yw2KpRo24G8Au7i+1Z/j03UDJG6Bs6ynnm+R3hxmHVksOUIdtGq QaHUXiD6S5lUXT6aj7iF9pj56EHmN9avP/g1ZYmwCNfbIqGo3byY7s18gtCFQrnZjqMG9sSlDAd puxhBfsO6OfijSrk4RXUvRry3Kfm8+LNV3vWQ5vdSRUoIzcmvuMOYUbVER/nSO+N2hUXIj5QusF UMrx6dct4EuaYX0xnrrhzxCeAUAk0RWIJd92s2sxqf/SJmx0ipqQHmP5HltPW8miqUL1ZiV7sTX cC/oGBoyczcoYGd5VAzf5pzfTHqZN7wLlbjZCzodAABQA0qbyHo0Ti5hs3ObTE+njwxdNz5hYQm eFdme9d3QOzQkE3CLZijDGy+IK+wHRLrBrllpVnq8nodEakrssMxH/ysvRUhoBWMHUGYGEJ+63E GMIdYFvnHKkOwcLkKumyqnATTU0lVC1gQ2mRHIe8k= X-Received: by 2002:a5d:5889:0:b0:430:ff81:2961 with SMTP id ffacd0b85a97d-4356a082ebfmr20516546f8f.51.1768916030840; Tue, 20 Jan 2026 05:33:50 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356996dad0sm29331439f8f.27.2026.01.20.05.33.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 05:33:50 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: vkoul@kernel.org, geert+renesas@glider.be, biju.das.jz@bp.renesas.com, fabrizio.castro.jz@renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea Subject: [PATCH v8 8/8] dmaengine: sh: rz-dmac: Add device_{pause,resume}() callbacks Date: Tue, 20 Jan 2026 15:33:30 +0200 Message-ID: <20260120133330.3738850-9-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260120133330.3738850-1-claudiu.beznea.uj@bp.renesas.com> References: <20260120133330.3738850-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Add support for device_{pause, resume}() callbacks. These are required by the RZ/G2L SCIFA driver. Signed-off-by: Claudiu Beznea --- Changes in v8: - reported residue for paused channels as well Changes in v7: - use guard() instead of scoped_guard() - in rz_dmac_device_pause() checked the channel is enabled before suspending it to avoid read poll timeouts - added a comment in rz_dmac_device_resume() Changes in v6: - set CHCTRL_SETSUS for pause and CHCTRL_CLRSUS for resume - dropped read-modify-update approach for CHCTRL updates as the HW returns zero when reading CHCTRL - moved the read_poll_timeout_atomic() under spin lock to ensure avoid any races b/w pause and resume functionalities Changes in v5: - used suspend capability of the controller to pause/resume the transfers drivers/dma/sh/rz-dmac.c | 49 +++++++++++++++++++++++++++++++++++++--- 1 file changed, 46 insertions(+), 3 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index 27c963083e29..caa3335bf95d 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -141,10 +141,12 @@ struct rz_dmac { #define CHANNEL_8_15_COMMON_BASE 0x0700 =20 #define CHSTAT_ER BIT(4) +#define CHSTAT_SUS BIT(3) #define CHSTAT_EN BIT(0) =20 #define CHCTRL_CLRINTMSK BIT(17) #define CHCTRL_CLRSUS BIT(9) +#define CHCTRL_SETSUS BIT(8) #define CHCTRL_CLRTC BIT(6) #define CHCTRL_CLREND BIT(5) #define CHCTRL_CLRRQ BIT(4) @@ -814,11 +816,18 @@ static enum dma_status rz_dmac_tx_status(struct dma_c= han *chan, if (status =3D=3D DMA_COMPLETE || !txstate) return status; =20 - scoped_guard(spinlock_irqsave, &channel->vc.lock) + scoped_guard(spinlock_irqsave, &channel->vc.lock) { + u32 val; + residue =3D rz_dmac_chan_get_residue(channel, cookie); =20 - /* if there's no residue, the cookie is complete */ - if (!residue) + val =3D rz_dmac_ch_readl(channel, CHSTAT, 1); + if (val & CHSTAT_SUS) + status =3D DMA_PAUSED; + } + + /* if there's no residue and no paused, the cookie is complete */ + if (!residue && status !=3D DMA_PAUSED) return DMA_COMPLETE; =20 dma_set_residue(txstate, residue); @@ -826,6 +835,38 @@ static enum dma_status rz_dmac_tx_status(struct dma_ch= an *chan, return status; } =20 +static int rz_dmac_device_pause(struct dma_chan *chan) +{ + struct rz_dmac_chan *channel =3D to_rz_dmac_chan(chan); + u32 val; + + guard(spinlock_irqsave)(&channel->vc.lock); + + val =3D rz_dmac_ch_readl(channel, CHSTAT, 1); + if (!(val & CHSTAT_EN)) + return 0; + + rz_dmac_ch_writel(channel, CHCTRL_SETSUS, CHCTRL, 1); + return read_poll_timeout_atomic(rz_dmac_ch_readl, val, + (val & CHSTAT_SUS), 1, 1024, + false, channel, CHSTAT, 1); +} + +static int rz_dmac_device_resume(struct dma_chan *chan) +{ + struct rz_dmac_chan *channel =3D to_rz_dmac_chan(chan); + u32 val; + + guard(spinlock_irqsave)(&channel->vc.lock); + + /* Do not check CHSTAT_SUS but rely on HW capabilities. */ + + rz_dmac_ch_writel(channel, CHCTRL_CLRSUS, CHCTRL, 1); + return read_poll_timeout_atomic(rz_dmac_ch_readl, val, + !(val & CHSTAT_SUS), 1, 1024, + false, channel, CHSTAT, 1); +} + /* * -----------------------------------------------------------------------= ------ * IRQ handling @@ -1164,6 +1205,8 @@ static int rz_dmac_probe(struct platform_device *pdev) engine->device_terminate_all =3D rz_dmac_terminate_all; engine->device_issue_pending =3D rz_dmac_issue_pending; engine->device_synchronize =3D rz_dmac_device_synchronize; + engine->device_pause =3D rz_dmac_device_pause; + engine->device_resume =3D rz_dmac_device_resume; =20 engine->copy_align =3D DMAENGINE_ALIGN_1_BYTE; dma_set_max_seg_size(engine->dev, U32_MAX); --=20 2.43.0