From nobody Tue Feb 10 17:34:46 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD73C438FF7 for ; Tue, 20 Jan 2026 13:33:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768916030; cv=none; b=GlM2DPkivhxqZp0AxBMPtEH4bWpRvac5Hz3mq3v08Xcd/MKYIEol1n71MPZyp2JfiGb4w36HSrl7aoQR/RbxUv/cxPV+nNvhbEymvgi5PIsE3cjXBKuud6/LS/9PNcjkujGWOzjDUt9BZyMdpkniFoB0vKmNHTJMvV3wMqj+7cY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768916030; c=relaxed/simple; bh=Srrns1UbIhd+W/08Zz/FajPVxyWsymnEvTSHjcquxoA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IeE2/ySOBqFeCJwOGWFIH4HogMtDuALB/wRIWauGslNkFSbYa7gPjIG8p/WeFk6oK7FD0xpfoEG0kqCy2sC8HUcL6p32dXVf1p6xvnL9l5CG0TPcXWvtY7FQycF9bOAlp9Z5mGR9olGs5CpUtCqtUzKcTR8ARFM0r4G9EHvN7/k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=IuORIvlC; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="IuORIvlC" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-43596062728so173041f8f.1 for ; Tue, 20 Jan 2026 05:33:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1768916027; x=1769520827; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MV8DeVgKKaG/bWcnGvfHKBTE2gBrbH2K1tyqM9pJWLk=; b=IuORIvlCBulJHSjzNd7BlDcuIfjId1s25m2v3ni88fAn/0FWB9FQIJy/SXKqnyHYvD xolALuacTXK3Hr6R1OEcKYtG8YqHUKVpArhzTTyTH0sIXCb/zNnx2N35VcGNcwVYmKcO F/rCtYzDpm3tc/ffsS8tzhRW4ty8ujuBqc5K6Omk2hxP2m1FC8NmaioOQCNHPVtMGMG8 4d/jFzcKvOeqJibqtzHE15qDZbOnRD2QmAvS+LkGdRAcXd2Mn5sVZXyr2u64+fRHhuIr BraKOy+WwP90NblFxE4Cx9RrwR0OIYIonWJBFBr3V+u7+1lIeoCa9iXSn9uLcVjVxMpw LJDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768916027; x=1769520827; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MV8DeVgKKaG/bWcnGvfHKBTE2gBrbH2K1tyqM9pJWLk=; b=lUbhrq6BMe8kxb0WaDNHrkd1vIGsL1iRqhPxpQi06ykhZscr1eWm+OVtIXmpPb2AZT ODzEzrqYz6TImW5ewUsodP99wOrPmzN+o/b3jvA02ohk2fcK5jyIq93GI9S3SjoTTuyh 7Mq6o6fpmsbf6i1xPcywjdyOo8Rfal3Vz+1xVtF5OIgvwp3CSawy+zS+sFsKn+nVzkEs 6BgLHyRqBYxKYRBzWPxqkpR8GtGYEi6uh1sN+VVuiCgsjHqYoSdHKaCzNgE8NowQRtM8 /+whSV6Mnmql58dEoJSYrNYRtReWgdgrEGjhHhAQzM1b1+Oorm4CgfR9+A7sHWrEJIl3 1JUw== X-Forwarded-Encrypted: i=1; AJvYcCWmry7a8cF0nuYDJv/39ypU+yOyHv8XgQ+y383HxtPjGj/Zru6Sn3hqVQHaHoa4VwYcNxipfLy9nM0pPWM=@vger.kernel.org X-Gm-Message-State: AOJu0YzvBO2Wc+Fvln2sY+/eVOqLuNPpXe4RRmgxsPnKtF+HHkkTJeUh Q7enOhV5odbfHr05Oxz7SG3wN1ytrxR3vA7FDn+WU1n3FjFl2I0tbTlBuNHaUrfbFJ8= X-Gm-Gg: AZuq6aIztkZsMLsP2pCLV9HiNnuVCF+B+4mr7bmV8ps3JC3XuUfrsGLLh/RoL2Ex4yH pLMQUmsplrfDpRJqQYXd+sTCbaLLVxSgNIwOXkDDCnapIypef5SxtxPy9kJ23YP2nhPJQ1p4FMK E75l0/dpKq8jzxh5BC3eat99dv8wsNbC7qit5HpezuXd/29jyusD7bV2KK5UoTc1m7XpzHRoGXs NwVgl3ckREUy9DE4hqfsnfmKvgBE5hYdypzdpYYqV6zriRZnmfXWiEjQa6kXvFaTccbnJxHjZia 5bXZIflvREV4vazbWxxRdO9vau7hlyjIncb52llgxlqUVrqQ3myZqqpqjmeM0XxcSAWo/WCNM2o IHfSD3io7w0sllbnylfX9LxR6LamvOChnCZCyrLiehqHould2bvt7YqMZKwkRW9xlpSh9ovgJ9i cZiQ30YdBHdD1F3kkd3KjWexrxVmVGOnRfTD1XykI= X-Received: by 2002:a05:6000:25c3:b0:435:953e:5897 with SMTP id ffacd0b85a97d-435953e5bbcmr1722508f8f.25.1768916027069; Tue, 20 Jan 2026 05:33:47 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356996dad0sm29331439f8f.27.2026.01.20.05.33.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 05:33:46 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: vkoul@kernel.org, geert+renesas@glider.be, biju.das.jz@bp.renesas.com, fabrizio.castro.jz@renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea Subject: [PATCH v8 5/8] dmaengine: sh: rz-dmac: Drop unnecessary local_irq_save() call Date: Tue, 20 Jan 2026 15:33:27 +0200 Message-ID: <20260120133330.3738850-6-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260120133330.3738850-1-claudiu.beznea.uj@bp.renesas.com> References: <20260120133330.3738850-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea rz_dmac_enable_hw() calls local_irq_save()/local_irq_restore(), but this is not needed because the callers of rz_dmac_enable_hw() already protect the critical section using spin_lock_irqsave()/spin_lock_irqrestore(). Remove the local_irq_save()/local_irq_restore() calls. Signed-off-by: Claudiu Beznea --- Changes in v8: - none Changes in v7: - none Changes in v6: - none Changes in v5: - none, this patch is new drivers/dma/sh/rz-dmac.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index cc540b35dc29..1d2b50d6273b 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -273,15 +273,12 @@ static void rz_dmac_enable_hw(struct rz_dmac_chan *ch= annel) { struct dma_chan *chan =3D &channel->vc.chan; struct rz_dmac *dmac =3D to_rz_dmac(chan->device); - unsigned long flags; u32 nxla; u32 chctrl; u32 chstat; =20 dev_dbg(dmac->dev, "%s channel %d\n", __func__, channel->index); =20 - local_irq_save(flags); - rz_dmac_lmdesc_recycle(channel); =20 nxla =3D channel->lmdesc.base_dma + @@ -296,8 +293,6 @@ static void rz_dmac_enable_hw(struct rz_dmac_chan *chan= nel) rz_dmac_ch_writel(channel, CHCTRL_SWRST, CHCTRL, 1); rz_dmac_ch_writel(channel, chctrl, CHCTRL, 1); } - - local_irq_restore(flags); } =20 static void rz_dmac_disable_hw(struct rz_dmac_chan *channel) --=20 2.43.0