From nobody Tue Feb 10 14:33:29 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8955C42B75B for ; Tue, 20 Jan 2026 13:33:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768916026; cv=none; b=uDOI5VikNVmIwzQhxfnaO2E/dSNN8v0G10/DlPQ+Z8JnbXdXUU1Jm30iI9VD1lvQD6cyCFRlovTw+0sCckKJyrYsyedis6upOg77gplj1XnHjc7uqTzpZZBiy3MYSEX/2/bV3ezsGP5VEOfXqVJ3SkNjftwLS8/dIZFehq4IHYM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768916026; c=relaxed/simple; bh=7+lvctd+mOS+R5PxlA728yD1a8tDc2B4cTOJJy3B6f8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ILMBcztx5/VOYUCsBpOL8KkyUnxR/XzMi/xqhZJVUtAbQCU9U8jwd7iqae2qmmAGLZfc8+0Wx5qIs13RU4vC4ceOhazqg9Yt23GiiN3Z+TYoimT3RrIwN9EbjARPSAkGwmGNhlOVgVzsK6r7NoI4/PpdusydOKjDvB6DIHtoVtU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=CixNRAjb; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="CixNRAjb" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42fb2314eb0so4380943f8f.2 for ; Tue, 20 Jan 2026 05:33:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1768916022; x=1769520822; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Qrf/4ha8LTjYdiPZBpuP6fOy7D8F/H7Z7s3chjS0gfM=; b=CixNRAjb1G7T/nvjjGu1aiejOEP11qt1eKZW0mQqAGGRuYhR27bOOZXWbccdlt4dWb ji4onEXm2JU308Fc5rQpT4eDvd3w4QFlZwDeV3HUGLTCT9VkRQQDP/0WaYSgQM6n3NLs CM2lp1cOY0k/PjunQMV+nBt3j6c4SiN644V8eZS09FRMrObhEdpoCNLQQEEJWBOk7J4Q BD50aL7qo5VaO4GojuqlrliqWVmymr9/q7Mm91QrMP6EBLxVkUGXwwzfH5MxrZb7ERQ4 7rgyU4mIwRP9liiBCdRdPypFfmeK6A1ezHtQtdt2EPTqL2dF7Q0Sin2z2i3LyDgfdjRU 2FxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768916022; x=1769520822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Qrf/4ha8LTjYdiPZBpuP6fOy7D8F/H7Z7s3chjS0gfM=; b=LnvD2QhTrnPpaP1y//EpsbumV9/3WnYw4tlpQr1uXwQp1LH/oA0FUr9OF4D/bicmkr bkkF2tNMtGeP9fTBWpL8Z3uLnZn+QTgxU2wOqpFYFKjLmzIOcUt1RCn4SKSWApXSy1iA pMMCM1RcTNlJp9b2iNSg/dgcnyqa6VfJ0W0sSEBOeIvuzsFxI6iLZD9Uzpi5W0bsc9FL eein8JokMcy/MtW5C3jxJb+BqL/52GyaZtq/IkCfa8JHdEwGy5+VEqtlEXuqMXPAoFZw B3FOQBYun7WNAvxHMf8SCp2C8Rs9pVgUoKEz2r34IEKh3l5Ed7+5So6GuQctey7qQbK2 NbVw== X-Forwarded-Encrypted: i=1; AJvYcCUotjcZggM0xFcKUuQIgHZyqKcWZR9zbdHcWuxqIIHl+R5cyCf/W4YWCIj4Y/LpsvronsjZ6Qkcw4O4LJg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5v8pJiIR72cOI0Yq7fHN0RM3A3V8zXJiNuAwt7f4qcQNzstAo 7+q8X/hwDUFQFXt8pDo4xvmJ5vls3yKhx7eDg75026xZnBZEq7HT9hUcUDE/Nxqno1g= X-Gm-Gg: AZuq6aJhVcgVA0GRitsRBmoefPqHhgPHlP7k28U9GuxqHSidKSoARZ46s0o7eh8Efvo 6lS6FECgyWZgIAgEA++rO6/vZyiVp23zPeRJ7RYeN+yRjjzCQRjX6YrwTg/Q0oFGeymfFT3xMBL lmevCdSxFOurYECKTn4q9beHjx9lOC0B+RjBYRO/cC29wPn0Th1n/ta27VNePkGPqw63AS/wD14 M8NBblvtQOdbn7ps9c6M+EwZauywM+c/3NsXrzpY+GdAKC6aqim3Ap71K/ymGvLqQppdpsz/a9c jaeJ9zM6WkAZTOa3lfZmM5K0LDr3QB3owcuzR3f74FPx/7D3ethFPJDenauYTUtUCocPbIP8Sz0 RRbxim3vA09IgH1qpxkIkHlH4Van3bEj5KWrLifYqu+ZxTaujgEZ9lnyZdwMknY0kIc+TGwFn/C xUX1bXX5xc/hntzMX/vnMakn9GK6gtbpB1TNFKZ90= X-Received: by 2002:a05:6000:2481:b0:430:fdfc:7dd3 with SMTP id ffacd0b85a97d-4358ff62780mr2583333f8f.50.1768916021652; Tue, 20 Jan 2026 05:33:41 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.31]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356996dad0sm29331439f8f.27.2026.01.20.05.33.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 05:33:41 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: vkoul@kernel.org, geert+renesas@glider.be, biju.das.jz@bp.renesas.com, fabrizio.castro.jz@renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea , stable@vger.kernel.org Subject: [PATCH v8 1/8] dmaengine: sh: rz-dmac: Protect the driver specific lists Date: Tue, 20 Jan 2026 15:33:23 +0200 Message-ID: <20260120133330.3738850-2-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260120133330.3738850-1-claudiu.beznea.uj@bp.renesas.com> References: <20260120133330.3738850-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea The driver lists (ld_free, ld_queue) are used in rz_dmac_free_chan_resources(), rz_dmac_terminate_all(), rz_dmac_issue_pending(), and rz_dmac_irq_handler_thread(), all under the virtual channel lock. Take the same lock in rz_dmac_prep_slave_sg() and rz_dmac_prep_dma_memcpy() as well to avoid concurrency issues, since these functions also check whether the lists are empty and update or remove list entries. Fixes: 5000d37042a6 ("dmaengine: sh: Add DMAC driver for RZ/G2L SoC") Cc: stable@vger.kernel.org Signed-off-by: Claudiu Beznea --- Changes in v8: - none Changes in v7: - none Changes in v6: - none Changes in v5: - none, this patch is new drivers/dma/sh/rz-dmac.c | 57 ++++++++++++++++++++++------------------ 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index 3dde4b006bcc..36f5fc80a17a 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -10,6 +10,7 @@ */ =20 #include +#include #include #include #include @@ -453,6 +454,7 @@ static int rz_dmac_alloc_chan_resources(struct dma_chan= *chan) if (!desc) break; =20 + /* No need to lock. This is called only for the 1st client. */ list_add_tail(&desc->node, &channel->ld_free); channel->descs_allocated++; } @@ -508,18 +510,21 @@ rz_dmac_prep_dma_memcpy(struct dma_chan *chan, dma_ad= dr_t dest, dma_addr_t src, dev_dbg(dmac->dev, "%s channel: %d src=3D0x%pad dst=3D0x%pad len=3D%zu\n", __func__, channel->index, &src, &dest, len); =20 - if (list_empty(&channel->ld_free)) - return NULL; + scoped_guard(spinlock_irqsave, &channel->vc.lock) { + if (list_empty(&channel->ld_free)) + return NULL; + + desc =3D list_first_entry(&channel->ld_free, struct rz_dmac_desc, node); =20 - desc =3D list_first_entry(&channel->ld_free, struct rz_dmac_desc, node); + desc->type =3D RZ_DMAC_DESC_MEMCPY; + desc->src =3D src; + desc->dest =3D dest; + desc->len =3D len; + desc->direction =3D DMA_MEM_TO_MEM; =20 - desc->type =3D RZ_DMAC_DESC_MEMCPY; - desc->src =3D src; - desc->dest =3D dest; - desc->len =3D len; - desc->direction =3D DMA_MEM_TO_MEM; + list_move_tail(channel->ld_free.next, &channel->ld_queue); + } =20 - list_move_tail(channel->ld_free.next, &channel->ld_queue); return vchan_tx_prep(&channel->vc, &desc->vd, flags); } =20 @@ -535,27 +540,29 @@ rz_dmac_prep_slave_sg(struct dma_chan *chan, struct s= catterlist *sgl, int dma_length =3D 0; int i =3D 0; =20 - if (list_empty(&channel->ld_free)) - return NULL; + scoped_guard(spinlock_irqsave, &channel->vc.lock) { + if (list_empty(&channel->ld_free)) + return NULL; =20 - desc =3D list_first_entry(&channel->ld_free, struct rz_dmac_desc, node); + desc =3D list_first_entry(&channel->ld_free, struct rz_dmac_desc, node); =20 - for_each_sg(sgl, sg, sg_len, i) { - dma_length +=3D sg_dma_len(sg); - } + for_each_sg(sgl, sg, sg_len, i) + dma_length +=3D sg_dma_len(sg); =20 - desc->type =3D RZ_DMAC_DESC_SLAVE_SG; - desc->sg =3D sgl; - desc->sgcount =3D sg_len; - desc->len =3D dma_length; - desc->direction =3D direction; + desc->type =3D RZ_DMAC_DESC_SLAVE_SG; + desc->sg =3D sgl; + desc->sgcount =3D sg_len; + desc->len =3D dma_length; + desc->direction =3D direction; =20 - if (direction =3D=3D DMA_DEV_TO_MEM) - desc->src =3D channel->src_per_address; - else - desc->dest =3D channel->dst_per_address; + if (direction =3D=3D DMA_DEV_TO_MEM) + desc->src =3D channel->src_per_address; + else + desc->dest =3D channel->dst_per_address; + + list_move_tail(channel->ld_free.next, &channel->ld_queue); + } =20 - list_move_tail(channel->ld_free.next, &channel->ld_queue); return vchan_tx_prep(&channel->vc, &desc->vd, flags); } =20 --=20 2.43.0