From nobody Mon Feb 9 15:06:53 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BAF5426ECB for ; Tue, 20 Jan 2026 13:14:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768914863; cv=none; b=iRSsc3M8vkDRGTiEtp/n0Mh+Yt3kudaXvvACERR+HDEzyCEn7SKWNZx6VlRgZAc9rOIat5BWFVHur2C9zdYmHiLxIDmU/VYqn13sbwHz1+S+D9QuNe2h9qIAWVCBWNkw/1kH3jjMIuG0oX7PjVdWH82SRJ9cOs74Gnz9ps0kyTw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768914863; c=relaxed/simple; bh=bNzuToZL7oP976VTBihDPM3cRjrXvvsC0pdVBKfsRrE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Hlf6NCwsCTwVHRUUesfi0u//M96eqCQ7NUABpWZYLCUC8pz5IbqpsPbBcqgSVKIEnQduC03cQGtfTGibZhzGB9L302VK7JruNFmB445BiUELhTY/E1bD6dVb5mKe9i4PwVqBTGIwGz7W58UGGrTLUHHp03GPzp9awcS5JYbbD/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HDu9nDAl; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HDu9nDAl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768914861; x=1800450861; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bNzuToZL7oP976VTBihDPM3cRjrXvvsC0pdVBKfsRrE=; b=HDu9nDAlDgiAJTNJ01AVtpgMp2K0Qk/9y3jra8atN2Uj9xN6FLRnJZUq /Z47w7LpC6qm++VadkSVv5uDDk4XOq14OeZmbTK0p42Uncp71wNm1GiWl Sq8C07wQGZrHCTGi39is+VbbUMdqrhJ1FK/bhgGe70qkgS+p5tlA8b9+1 yI8W+enbcT5P708x1PyT+tV6+1LuKBkRE8UdLPtPvNTqn18OulEInBhbS gv6wUwquiSlTbwtJu29dnQC1wSUKmC6K7MMRzehEWGCdF0mdbTrzXxYjT sMxO6MVWS7ri6oGo5Yvd/tDwdZyD7FOTJ2F3MiJN9VZgRE9HYM1+afTex Q==; X-CSE-ConnectionGUID: C858TjCZS4ytG/TbjrwxUA== X-CSE-MsgGUID: BvEFmfUwQT2WlyqYwxb9VQ== X-IronPort-AV: E=McAfee;i="6800,10657,11676"; a="95595354" X-IronPort-AV: E=Sophos;i="6.21,240,1763452800"; d="scan'208";a="95595354" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2026 05:14:18 -0800 X-CSE-ConnectionGUID: rIKrCRFIS3W8H+2A3noWuw== X-CSE-MsgGUID: BKcjTNniTmyVQQZIHwtcaw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,240,1763452800"; d="scan'208";a="243707589" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa001.jf.intel.com with ESMTP; 20 Jan 2026 05:14:16 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 1842199; Tue, 20 Jan 2026 14:14:15 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Benson Leung , Abhishek Pandit-Subedi , Jameson Thies , Andrei Kuchynski , Tzung-Bi Shih Subject: [PATCH v1 1/2] platform/chrome: cros_typec_switch: Don't touch struct fwnode_handle::dev Date: Tue, 20 Jan 2026 14:12:30 +0100 Message-ID: <20260120131413.1697891-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260120131413.1697891-1-andriy.shevchenko@linux.intel.com> References: <20260120131413.1697891-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The 'dev' field in struct fwnode is special and related to device links, There no driver should use it for printing messages. Fix incorrect use of private field. Fixes: affc804c44c8 ("platform/chrome: cros_typec_switch: Add switch driver= ") Signed-off-by: Andy Shevchenko --- drivers/platform/chrome/cros_typec_switch.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/platform/chrome/cros_typec_switch.c b/drivers/platform= /chrome/cros_typec_switch.c index 8d7c34abb0a1..d8a28d4e51a8 100644 --- a/drivers/platform/chrome/cros_typec_switch.c +++ b/drivers/platform/chrome/cros_typec_switch.c @@ -230,20 +230,20 @@ static int cros_typec_register_switches(struct cros_t= ypec_switch_data *sdata) =20 adev =3D to_acpi_device_node(fwnode); if (!adev) { - dev_err(fwnode->dev, "Couldn't get ACPI device handle\n"); + dev_err(dev, "Couldn't get ACPI device handle for %pfwP\n", fwnode); ret =3D -ENODEV; goto err_switch; } =20 ret =3D acpi_evaluate_integer(adev->handle, "_ADR", NULL, &index); if (ACPI_FAILURE(ret)) { - dev_err(fwnode->dev, "_ADR wasn't evaluated\n"); + dev_err(dev, "_ADR wasn't evaluated for %pfwP\n", fwnode); ret =3D -ENODATA; goto err_switch; } =20 if (index >=3D EC_USB_PD_MAX_PORTS) { - dev_err(fwnode->dev, "Invalid port index number: %llu\n", index); + dev_err(dev, "%pfwP: Invalid port index number: %llu\n", fwnode, index); ret =3D -EINVAL; goto err_switch; } --=20 2.50.1 From nobody Mon Feb 9 15:06:53 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7099B3DA7EA for ; Tue, 20 Jan 2026 13:14:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768914860; cv=none; b=GkBi25tHF0pbFd8RrcZNzNPnIXZd2eNwDul09WcN020D1qmH3tEZ4luMt2pfK9XJSgj8RO0S9ReHli24gZau5cBZ+bRS0UCFPDjSQei0+Y97g0yT2x+de6zbUmV+D64ZyJCiIJVKm0K55qhDL5iLSYVZM3FRX0XGkzGvbkiL9hY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768914860; c=relaxed/simple; bh=IsVAU4KfzrnB2HrF7PabY9ogQ5sJ8ttV9gteU16eWPE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eP3PiqH7pbPjxAFrZ9WOTdBBxAjOTAXD+6zTYdADEzcxR7tswcWvQXCq5S4BbfXFKACPcosEIk1vTAaTgREIm+NkDXW28FVbG3QU0XE18csZT/9Xa2iEMBqPCLVTXkROlR1kMPJxohWS7b6OFm7+xVUQAGFwh2n8hsyRvNRxqUI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FpgBCiUs; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FpgBCiUs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768914859; x=1800450859; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IsVAU4KfzrnB2HrF7PabY9ogQ5sJ8ttV9gteU16eWPE=; b=FpgBCiUsa0wc6a9QiMEr2STCeTOfxK2fUx1V12KqrNVw+22fPNQp/7EN WUupdo4UjtLmC0rPQxVUpykjtsznKI+6YOs67YWZomw87GQm4Y6CONxqe NziDLaMBfM5J5UgoPo/8kM2/eh1hmEfC0qRmUycFyY78yb72M5ufc7RgQ vcAqy1Y2/ciB4pk+QVspDYnvrCZBsq8hsGJBbRPH0k6oDVNK0SxC6bF/U lDGMYYoWy6H0QsLygwi+ZbkkQLKTMza2saQ250ibnIAbeIeniOP8+he/P dQOo8oQrPodM/Q+gNWGvNDia/XnHB6Ii8R+UHd0vpdTp+MO2DJLVsYFMK Q==; X-CSE-ConnectionGUID: f2uLmTHoQSu1Qsw9akZRFQ== X-CSE-MsgGUID: 55ojknCvRdqWswlFfUUQQA== X-IronPort-AV: E=McAfee;i="6800,10657,11676"; a="70174840" X-IronPort-AV: E=Sophos;i="6.21,240,1763452800"; d="scan'208";a="70174840" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2026 05:14:18 -0800 X-CSE-ConnectionGUID: r/EcAOvaT5CA0Z3jStTdmg== X-CSE-MsgGUID: l5VcyZs4RHys7l8V5TAccg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,240,1763452800"; d="scan'208";a="210967673" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa004.fm.intel.com with ESMTP; 20 Jan 2026 05:14:16 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 1C4A89B; Tue, 20 Jan 2026 14:14:15 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Benson Leung , Abhishek Pandit-Subedi , Jameson Thies , Andrei Kuchynski , Tzung-Bi Shih Subject: [PATCH v1 2/2] platform/chrome: cros_typec_switch: simplify code with acpi_get_local_u64_address() Date: Tue, 20 Jan 2026 14:12:31 +0100 Message-ID: <20260120131413.1697891-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260120131413.1697891-1-andriy.shevchenko@linux.intel.com> References: <20260120131413.1697891-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Now we have a helper so there's no need to open-code. Signed-off-by: Andy Shevchenko --- drivers/platform/chrome/cros_typec_switch.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/platform/chrome/cros_typec_switch.c b/drivers/platform= /chrome/cros_typec_switch.c index d8a28d4e51a8..fe0eddd2cf45 100644 --- a/drivers/platform/chrome/cros_typec_switch.c +++ b/drivers/platform/chrome/cros_typec_switch.c @@ -211,9 +211,8 @@ static int cros_typec_register_switches(struct cros_typ= ec_switch_data *sdata) struct cros_typec_port *port; struct device *dev =3D sdata->dev; struct fwnode_handle *fwnode; - struct acpi_device *adev; - unsigned long long index; int nports, ret; + u64 index; =20 nports =3D device_get_child_node_count(dev); if (nports =3D=3D 0) { @@ -228,17 +227,9 @@ static int cros_typec_register_switches(struct cros_ty= pec_switch_data *sdata) goto err_switch; } =20 - adev =3D to_acpi_device_node(fwnode); - if (!adev) { - dev_err(dev, "Couldn't get ACPI device handle for %pfwP\n", fwnode); - ret =3D -ENODEV; - goto err_switch; - } - - ret =3D acpi_evaluate_integer(adev->handle, "_ADR", NULL, &index); - if (ACPI_FAILURE(ret)) { + ret =3D acpi_get_local_u64_address(ACPI_HANDLE_FWNODE(fwnode), &index); + if (ret) { dev_err(dev, "_ADR wasn't evaluated for %pfwP\n", fwnode); - ret =3D -ENODATA; goto err_switch; } =20 --=20 2.50.1