From nobody Sun Feb 8 03:58:21 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37299428822 for ; Tue, 20 Jan 2026 12:33:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768912386; cv=none; b=OtN72/Tssge/MDGfvM1AYPZdtiPlTfrWgC4MNKSsMvEGHZIsG1nO/0EMPDA/tJz+LPKI1L5WSwyfDaoC4aJVhaD72XO9yyN4+038U07hpXZqNAyqqjDDpA53gjVpTgV833lbZrLF/sJFE4939XYsy/vt6OzwnBQSY532MRWEcW8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768912386; c=relaxed/simple; bh=EKTGZ6DcLIWjUFSU+UjyJBMTXMrL/FZqPyXbwAxDHHc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bitdvzH/NnH2V+9kbVfOW7ngnIQ0TeRkp7CzGs2FuOlvfRVKggdqkhFE98boilr8pd14DA+8g3NGeXL1VLrd2hA+K77haEl3jPwibofLGkIbHW0MAEh/dKVYZyjhc0LJce/azDetUjUAa7ZiyGtsSLD1BqvjBJtxF3n/EKvvtsk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T+hdnmRq; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T+hdnmRq" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c0c24d0f4ceso1882976a12.1 for ; Tue, 20 Jan 2026 04:33:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768912384; x=1769517184; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=keDji4cMBAhJaJa9OQyxQbi4+chPzvJPkxTIvGyDwEs=; b=T+hdnmRqXL9+sfWhPFUB+M0CZX31w7dw6hRDBWgrE6sREJDbTExgVyt2P43LWyXDk8 a4J4eBii6uMl5GqqK8sY5QoPkx6LaxOcYrDzmxTqKoqSqkg6Cq5XWgt6QPpXiSLJQKrg r4GL7geq7yCi0msauti6/uKPUbKa78L6hZMoH5I1AoRu7k2jcqt3r1Zu/B5qS0Xfxwl1 M7TjsuKsiU5EcaiyGsJEL+ahipYH8RnThRKBhdZWMe2yKh5IwMadLOzhRA9Rswq0D5S/ h31RVLmZDX/0N13km8DiTnaJ4EKAiN7mAmhXRWHR+pUdqvrjQRa7xmEopru8l/Bw9fYX q+2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768912384; x=1769517184; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=keDji4cMBAhJaJa9OQyxQbi4+chPzvJPkxTIvGyDwEs=; b=CK9K1QyaDbqY/omO0V8DjNmUJlQHoyPIf9fMytOqLTnlw1Ci7OckKnxVyJ/OjH0FIV 4PTtL5dwd3WDVihVtc8UCztPFpMFM2HnQFBt+kpYqwAvu4k3vDAbfV5KU6wOgS/+oi8j dBEyg7hd5yiIY8n/ube8KLreVTnSDTsJUVSKOh9u01F5qbB7IaQxRhLzJVrwY8SaExKs 79mm0ga18USvD9vcv72J+f0mGElDWZtwDDzZdWts9fzaDfU/Hqu15bcR5PtIRmgLit7G EIwREHVb2I6JipDwH8xiG891R9KZEDjUzu80p/+289/8jkUbwFVewZ72CiHHWbRiiXMz GgiA== X-Gm-Message-State: AOJu0YyXe4CNA8kMq0sawcVlXOdKPTdBEkchkhkbqaXrcAQ/j7kW1u+z rd/9DXHeJtJwJ7YhPVI6aILDbkCGBWE27oT/L/NsKO4o73u6b991KhDTje1wfA== X-Gm-Gg: AZuq6aJEDGT8xiD+9hpo5l//6uJK4rWHlP6TI8BC31qyKeAFr+8hgYGNIo+A+xYkqI1 55RS7ZE5oBLwLCCMFsDKa7ttNOJKriipqncf6SOhCMBzlhAAjFT/Si6njbZWK9noRJY2gKz210H qCbAWv4u+piaz0XInwOZgb9ElgM+jCMAdmmlYbTWXusG1SmDUND/DBrv/DTo2ahgIy+Vl7/tm7F t3Uq5TRkZPuK8HfxPmBIau2z3v5L3FAt1XuN3HfdB9SoxmDtVw2qaUVdilAiWP163OJD9l4Rr80 CLsYNhKcyPvIEhro9cnsWfpPesFTdAVI3pfnvlRfWdLc7W+s4K+k3XstDD2LjypR/PvbGFYwn4t 0P0CDyvRJ6P8dWlA16KAQQD2EB07lrQJhHl0xJCLJaC3PQKWYFpBGNIKmGYAnOPXGoCj0y9Xo/q yjRRuJSHpkRwZ4z1p8HS8v0bgG8tN4Mw32lJg= X-Received: by 2002:a17:902:ec8d:b0:2a3:e89c:593e with SMTP id d9443c01a7336-2a71885a582mr142973495ad.4.1768912383816; Tue, 20 Jan 2026 04:33:03 -0800 (PST) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.239]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a7190ce415sm126361295ad.35.2026.01.20.04.33.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 04:33:03 -0800 (PST) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: linux-kernel@vger.kernel.org Cc: mingo@kernel.org, peterz@infradead.org, Zhan Xusheng Subject: [PATCH] sched: cleanup sched_update_scaling() return type and usage Date: Tue, 20 Jan 2026 20:32:57 +0800 Message-ID: <20260120123257.40875-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function sched_update_scaling() always returned 0 and callers never checked its return value. This patch removes the return value and changes the function to return void for clarity. The usage of the return value in kernel/sched/debug.c has also been updated to reflect this change. This cleanup improves code readability and eliminates unnecessary logic. Tested: - Kernel compiled successfully - sched_update_scaling() invoked without errors - No regressions in scheduler-related functionality Signed-off-by: Zhan Xusheng --- kernel/sched/debug.c | 3 +-- kernel/sched/fair.c | 4 +--- kernel/sched/sched.h | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index 41caa22e0680..d74c02297b42 100644 --- a/kernel/sched/debug.c +++ b/kernel/sched/debug.c @@ -189,8 +189,7 @@ static ssize_t sched_scaling_write(struct file *filp, c= onst char __user *ubuf, return -EINVAL; =20 sysctl_sched_tunable_scaling =3D scaling; - if (sched_update_scaling()) - return -EINVAL; + sched_update_scaling(); =20 *ppos +=3D cnt; return cnt; diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index e71302282671..234437ddd4c0 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -1004,7 +1004,7 @@ struct sched_entity *__pick_last_entity(struct cfs_rq= *cfs_rq) /************************************************************** * Scheduling class statistics methods: */ -int sched_update_scaling(void) +void sched_update_scaling(void) { unsigned int factor =3D get_update_sysctl_factor(); =20 @@ -1012,8 +1012,6 @@ int sched_update_scaling(void) (normalized_sysctl_##name =3D sysctl_##name / (factor)) WRT_SYSCTL(sched_base_slice); #undef WRT_SYSCTL - - return 0; } =20 static void clear_buddies(struct cfs_rq *cfs_rq, struct sched_entity *se); diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 93fce4bbff5e..c9ef6cd7b754 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -2168,7 +2168,7 @@ extern int group_balance_cpu(struct sched_group *sg); extern void update_sched_domain_debugfs(void); extern void dirty_sched_domain_sysctl(int cpu); =20 -extern int sched_update_scaling(void); +extern void sched_update_scaling(void); =20 static inline const struct cpumask *task_user_cpus(struct task_struct *p) { --=20 2.43.0