From nobody Sat Feb 7 08:45:34 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BA174218AD for ; Tue, 20 Jan 2026 11:15:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768907721; cv=none; b=eZY1VBtYWdLcpqPRfsD5T7noWi3MRq5jkiaQB716zGe5HQg9yQocJQcS4RA5ou+wuCeWMtpUEoMoZfond/ZAgTcDloFkQATepTL56mJkLV74NayNZlVaBMXKCeAcE90trnGQcIttK7spQlZ/Gn4SBJmVvqQIVWQJ7VBHMd5oz9s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768907721; c=relaxed/simple; bh=EKTGZ6DcLIWjUFSU+UjyJBMTXMrL/FZqPyXbwAxDHHc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jY0X7FFb/oVVRLMYSJpvwh7putjYewQ9oR+D+cb5kXcO10lMicQr7iXsDtLt9cGyZSQKN6x8/u9tYxJQcX1qf6nYblbieSkVVAHRqsSPrkST4Aiwk7Lufw8j87xJMt8U7S1n8lMwNs4zt0l5tQu818drVYBZtwN5bE6V+zO0U2Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aJbviPWw; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aJbviPWw" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2a0d0788adaso33990635ad.3 for ; Tue, 20 Jan 2026 03:15:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768907719; x=1769512519; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=keDji4cMBAhJaJa9OQyxQbi4+chPzvJPkxTIvGyDwEs=; b=aJbviPWw5/XwYbHvehF0Pc97lEUB5BcSUKVHIs2WtUShu/LTQ2XwriDyrbQxI/yp7x 7b1sLabmNUFkqrV/vYlgL1vv+zopwpO3Hi4shHOxoc6cm2nEy+HgssG1L2a3W6b4tChi zNr7JY/Bd39oYMMqSpz4u14kU6JtvkbcPtwsH4HSJ7La4YRACBfekOhRY+7s0YPLPsSq nTnHHp46usJU7fdtKt9BvrLmRyvDicF3U+lvTynH6cfjiMl4MH8d4nuoEEpvHXwsckt5 Ayv+9nQ/7ajg9DYLVbLgtqbf1hnBHaurDKHyoXIfmHYDUTxI9T15m3oDsmmpQ9n97219 jMsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768907719; x=1769512519; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=keDji4cMBAhJaJa9OQyxQbi4+chPzvJPkxTIvGyDwEs=; b=gQHreDKIpDM2CqX/n9nvdgtcblPMBH0oHZT2IUbiTD+DYolWuRUhyA94EdPLpIF8N2 02KNZ2+mKA0/3YafrkDDwY0MxOhQ5IiJH0HRibXBLwMTebhl5waw28sNGFhwfgvGA+s6 wfvSfqTUXUt841t1ACafmhaGhptlYf3yjG76TFxlNbLNFM7z6/n4HNZg3UwsZ6Hgy/yg zKLbp0vklAyKJlHTSDEBuzGABj3WW+7DmRCt3LiatlNuIgqycvnEZhnNJ0wNdCrkx+Ip sFPnTdhinqjUqyrJ5x+Fh0UO3Ap+k2H3Maq8SGW70SE20JJpUziRWB+gtUF5BgK4NoNJ prCw== X-Gm-Message-State: AOJu0YyepUZXoDzOG1GPL3OxgV5ZCAGrJW8CBbnyb07hADmZhOPzVrYi S2nmlY0iWUvVOihUtB0CALG/G6bGCrZ+2W3/vIdVbjAB7PiYjy75iw/d8siwTw== X-Gm-Gg: AZuq6aJmpROmfaYmiXVIKh+VizeB/Yrh8lSXEqR65/xzqVMFmX3lmGBISEA6Gns4SiB 22GX/CwIrYVRK9XDoCeNfvDJCwotsO0oAP6ne8mpY0Ky5InX6dmOd4WM8aUXFEv2mbvW81ffQez hIb/bG7/7oPYbx12pAKCVE1DrJmMKO6P1nIuoAIqaRYVj1FnGYY8W5c0swlBpB2wIPET4lz6GI3 XnALq0bM61SvVxbT4F4Y74PbVjzhWnGVSWsDonWVI6bIXoivANcMrtVoL+gK9MX4imzYARaSuLu mdUCMsBqB5qbS6hkZecja69gHxWVg0KAKJbdkkicmJX8HLMHcVGcW/gVGrmEvn7Nb59A06BqbpE iJZr8OJk7FBTWpEU55fZ9M+rEzVD2tlmOJMIotwFUJNLeF7JuZeE4tATEbC6Erq+X6esz1pdPAL MDHfluaWDiS/h+S1PEa3jICVC7kc/LC4C1C3eJsA2cLwylhQ== X-Received: by 2002:a17:903:13ce:b0:297:c048:fb60 with SMTP id d9443c01a7336-2a76a389391mr16236975ad.25.1768907718977; Tue, 20 Jan 2026 03:15:18 -0800 (PST) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.239]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a773de1fe7sm12554445ad.82.2026.01.20.03.15.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 03:15:18 -0800 (PST) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: linux-kernel@vger.kernel.org Cc: mingo@kernel.org, peterz@infradead.org, Zhan Xusheng Subject: [PATCH] cleanup sched_update_scaling() return type and usage Date: Tue, 20 Jan 2026 19:15:13 +0800 Message-ID: <20260120111513.40512-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function sched_update_scaling() always returned 0 and callers never checked its return value. This patch removes the return value and changes the function to return void for clarity. The usage of the return value in kernel/sched/debug.c has also been updated to reflect this change. This cleanup improves code readability and eliminates unnecessary logic. Tested: - Kernel compiled successfully - sched_update_scaling() invoked without errors - No regressions in scheduler-related functionality Signed-off-by: Zhan Xusheng --- kernel/sched/debug.c | 3 +-- kernel/sched/fair.c | 4 +--- kernel/sched/sched.h | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index 41caa22e0680..d74c02297b42 100644 --- a/kernel/sched/debug.c +++ b/kernel/sched/debug.c @@ -189,8 +189,7 @@ static ssize_t sched_scaling_write(struct file *filp, c= onst char __user *ubuf, return -EINVAL; =20 sysctl_sched_tunable_scaling =3D scaling; - if (sched_update_scaling()) - return -EINVAL; + sched_update_scaling(); =20 *ppos +=3D cnt; return cnt; diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index e71302282671..234437ddd4c0 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -1004,7 +1004,7 @@ struct sched_entity *__pick_last_entity(struct cfs_rq= *cfs_rq) /************************************************************** * Scheduling class statistics methods: */ -int sched_update_scaling(void) +void sched_update_scaling(void) { unsigned int factor =3D get_update_sysctl_factor(); =20 @@ -1012,8 +1012,6 @@ int sched_update_scaling(void) (normalized_sysctl_##name =3D sysctl_##name / (factor)) WRT_SYSCTL(sched_base_slice); #undef WRT_SYSCTL - - return 0; } =20 static void clear_buddies(struct cfs_rq *cfs_rq, struct sched_entity *se); diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 93fce4bbff5e..c9ef6cd7b754 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -2168,7 +2168,7 @@ extern int group_balance_cpu(struct sched_group *sg); extern void update_sched_domain_debugfs(void); extern void dirty_sched_domain_sysctl(int cpu); =20 -extern int sched_update_scaling(void); +extern void sched_update_scaling(void); =20 static inline const struct cpumask *task_user_cpus(struct task_struct *p) { --=20 2.43.0