From nobody Mon Feb 9 08:49:26 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F09303D666F for ; Tue, 20 Jan 2026 10:26:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768904793; cv=none; b=XNQowlR4yVWIxXPuzCvb+dcbKroOO9LGdTWNnEdiPOFbu6+l4lLuV7meRiNtCXwuKMCWoGxVL8/9e5lOJU9E2PRCkjOLm4r1gml1amTCfakl3vp/Sc9hFLgMmHSLLMm3XewUTe2/rE2ZrgFgcX/E7hBZGE0mxJCwFD8Hs9y2+FE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768904793; c=relaxed/simple; bh=zCleVcGWF3LQAGWKm7AV0lcRoNZo70NfMQHcUw43ULM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fmCwLXSj70El+4/RuVdhkPGJKV4DxFOHfJSTWMyy3iULA0y1xbo7PoBPWcg0ENvVmlKSNtR2i9K286aFUw9u2GPsgvVmGpUKmosrQB0+m/q4SeoXbOy63um0LP+oyYWe14hldrOv4hLMdPR4nNo+v9I7W5ObhW+ux7tZ50f5o/I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b=BJyoRxJ1; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b="BJyoRxJ1" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-81f3d6990d6so3065159b3a.3 for ; Tue, 20 Jan 2026 02:26:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20230601.gappssmtp.com; s=20230601; t=1768904790; x=1769509590; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=49OXAQs7f2z82XtuVxobrL4L2hbPd0maL3HiSxfoyj8=; b=BJyoRxJ1sChwmEhsrhBjfBLiO84/4Y2hR1XLHhbJMNPkuh41BglbU9LTpxT4Z3ZWwy 8PQcBYvIGF0DqNbzKJST9J5APXBsw7ZwzEfxEqEmXPRP8qYe8Cm4bDu7gFZiuEpVjcOE ij1Qwbh9NFDnLjoGZ1FiaojHCmuHjLdJPMy4jrBMoO2+kDw3l3+H8cG3V6+rGjK3FTdp /eSPr2FVqE2kumeC2k9C/3XJeBegfuzRcCqGwXnmGeOmFb6hsCuCkTUVBEci3J0XsBkL uOCprL1s9vK3CTpLMmNXdnVlRd3gi8tTqG6yffixn2BOWFLYqkV3qYNHKybuOf/btitx JBzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768904790; x=1769509590; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=49OXAQs7f2z82XtuVxobrL4L2hbPd0maL3HiSxfoyj8=; b=sprIsG6G1ayChIwl7i/0yVuA6CaCJ1bWfZNBby+S2/nirT/3vIRXp5R9YXvNs2JFUd GpNnOrLR8X4htb2n30b1LjTre2VKuaIB2dk0483QC0Z01rSa8cobgpFsJpSCkisNr0l9 8bT4+pkOhi236hA50aSqNnTRqWAvJJVw8IPb5yu0MCuq4gXIIbTFzbevcWOLP2bD1wuU nEl/PO7LgYGRc1JGGoF4j7+S8eYtMSvi9hjpnlhieVBFFQc6JlwNQ8RDon3Sk/UuFQGJ yRnnnDnfEZsi38paER0HWxNB/ErSxGGrCC3kxRHH5a7oeklEz+3X8kpYRqcXLKjbQoQg EgdA== X-Forwarded-Encrypted: i=1; AJvYcCVx8Nmm6UMrG1RcdLokdj0aNRvKkwM7Ca4f1IAQxSECv1Lcaz3sOEvP6uQArrQ3v3n7BjVu9tHtrmIn9VQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyeS00W8jmkYpLfgGDuYqYDmEeM66mwkRFhvo3zErRNTEFuxmQN oaRCOHAr5pk3niFZ97o4Fq9JwQWEjI5fCFWa9+mh1aQ6cU3jAvx+yX1nuaIia8K5aes= X-Gm-Gg: AZuq6aIpEuGWxWZ3LkFiU8WbwtNYwBx5YVO3ToMQwuFBgHuSDLACXPiXsbqk52rtt1C IblRkZasDU1LyARtdJwaSAeAswbyzBEAr4/rJg8V6g4+kp4m/AXymOFhKznfFcnMJ8xIoejp4Lm SdCc071Z08vw8XB25/Tw5kXFSDoFs3cl+lpRKFt0FYJEtnYahw45Fs6v8bcRVc4AzwPgAccB5c3 BaR57yFJFDQrYBnEgobbJH/4kKpBz/YhF9562ajbc2xfugJvFV2DA8x5pfY6B83bEUTFsjOc1iN HVzKIt1w3iLZOF9RZ5htKOjmQsSIo2YGa0JiXTP8g4CKeu9ZzsSO2pIwYv4fNuXhTVR447CA8NS /ch2qAqU4DX8RZ8S+HSZNUMFXqIZQYk5vtnex5UnJuHuRxitBYjWfD3HtVIfyudNkY2nFDEE7jB 4tebbdt7QyA6+VCSHUJHxqkYSr8kcE3WnCKHWBfZecSy0VfJXkd19QrKSKpr0Xke9dyI8LZWYU9 8SWLdT/hGxDaw== X-Received: by 2002:a05:6a00:180e:b0:81f:2b84:6eed with SMTP id d2e1a72fcca58-81fa03b2c84mr11751950b3a.68.1768904789879; Tue, 20 Jan 2026 02:26:29 -0800 (PST) Received: from localhost.localdomain ([103.158.43.16]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-81fa108bf0bsm11987337b3a.9.2026.01.20.02.26.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 02:26:29 -0800 (PST) From: Abdun Nihaal To: lee@kernel.org Cc: Abdun Nihaal , linux-kernel@vger.kernel.org Subject: [PATCH v3] mfd: mc13xxx-core: Fix memory leak in mc13xxx_add_subdevice_pdata() Date: Tue, 20 Jan 2026 15:56:20 +0530 Message-ID: <20260120102622.66921-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated for cell.name using kmemdup() is not freed when mfd_add_devices() fails. Fix that by using devm_kmemdup(). Fixes: 8e00593557c3 ("mfd: Add mc13892 support to mc13xxx") Signed-off-by: Abdun Nihaal --- v2->v3: - Use devm_kmemdup() to fix the memory leak as suggested by Lee Jones v1->v2: - Added the include of slab.h to ensure kfree is declared before use, to fix the compiler warning pointed out by kernel test robot. v2 link: https://lore.kernel.org/all/20251127044500.44820-1-nihaal@cse.iitm= .ac.in/ drivers/mfd/mc13xxx-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c index 920797b806ce..786eab3b2d03 100644 --- a/drivers/mfd/mc13xxx-core.c +++ b/drivers/mfd/mc13xxx-core.c @@ -377,7 +377,7 @@ static int mc13xxx_add_subdevice_pdata(struct mc13xxx *= mc13xxx, if (snprintf(buf, sizeof(buf), format, name) > sizeof(buf)) return -E2BIG; =20 - cell.name =3D kmemdup(buf, strlen(buf) + 1, GFP_KERNEL); + cell.name =3D devm_kmemdup(mc13xxx->dev, buf, strlen(buf) + 1, GFP_KERNEL= ); if (!cell.name) return -ENOMEM; =20 --=20 2.43.0