From nobody Mon Feb 9 19:30:56 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CC673D2FF0 for ; Tue, 20 Jan 2026 09:22:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768900969; cv=none; b=WL/m5FxoSBIkBT659N7GQIIkuEa8CmH3UZt340KiIZ5cuk6bFu2hAc3BXzJ2qSOXooAaHPc6l9pI5m0U8pUeQ9K8VNExt2TTi6ZQ1qY3ZlcnlmnNNrs6LzwS159JIcrHvL2iJCQ8w8zJukIYYnjRPa79Lrdf0Yyjpxza0lourKw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768900969; c=relaxed/simple; bh=aXepxHEM+bUanCG6M2YQkdGsjdUrPkO4BtQqkZ7jSTg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UcP7UkTwuNcIMfY2EIK3ni6upSmbuKg8sKKebA1OtxTVyYQVV6dClG6j8ojFKO+XWmk5CY1sK1P5ZYWkgtHb5a2o7FRUVC11mm58f5UQOvruT3irWQsTUKpZ+nvPC1pf1QocMs2ZnZiz5y6nNy8JlQ5CVrk49Wlt1/hvEBHPBb0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X97+D+iN; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X97+D+iN" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2a1022dda33so31783655ad.2 for ; Tue, 20 Jan 2026 01:22:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768900967; x=1769505767; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9vCyzApzHRVDFWMwd6G0sX6h4LUY1dkAl+mfLdsoDQo=; b=X97+D+iNrIv1FwwnCTOTeKmEmoksQTrcoSlj9CoAIe98D4q0w/wgAt6UaFVDSclRD3 GsFDtok5AfVYyZpQ5enZDJlhM0pA5iQVWMjolS/3DDw4RWyuf7kwk6bwOuXmDdPVGHNo VfDi2oggg96zONg0XcF1RpHbkdurRekiombCPfaQlzg8gyE2dQHh5rEtOfGGILzwCpCL 0nzgY7gYmOEl3U+QLQwORdAovd1LVTXK23mAEjMoS/4cSppSirBfzTa3bvZzHBGvM61B Kr0ELIflwwlrlimRtP+RJBTnke+mXsGPMFbT3PxAleIlJ9HkE5JE39YwF0FvgkjdRzxt 8qaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768900967; x=1769505767; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9vCyzApzHRVDFWMwd6G0sX6h4LUY1dkAl+mfLdsoDQo=; b=W+26S4+7yh1GfhdPaZ5C0fKRQRTiDB7h4SJXJgx3Wol1juU3ENvE34Ou2SXyRnPJO0 vpmaAjjrbFsAwHZnNej1p2BX5mGHv0apl+Sn6tPNu3nP/oHoxXsyglWeRjRTlovP+Bl7 XCFS8SxfmH53jMBBOMc2Fgs0fBayUzMze2CVIcWJ3U/Xpjaf/aSNjpe0bK4fAjlf+zxo WCX74vgqycQGbOP3oY1UqxpX0s+OHqTeKIp0ey1/mDqWSWx4nMRlhNTQYwWLx1H7xdUP mkMb2hGLKObkG5ysH3MErWzokMOCfDp/77WJNcaa+HbdmR/kcRgks4/YuDD9sJchB5oo ACNQ== X-Forwarded-Encrypted: i=1; AJvYcCWsQrZ1TJS13d+/VG5e4jsV1todY4mLRJYsDZSgXtYBSTbI7QRc0UDLhA6oWUSqq2PbrWkwqAdSa5tkF7E=@vger.kernel.org X-Gm-Message-State: AOJu0YyGZu2vXihwN2PBbNOvWXepYvx7aPBAAwx4U8osm5gUCdnl7EVV HeXfZqQhbfUXJ0xx49dkyMBJT1BqfCNgNzUXvVxC5QkpapSfSf4gpsid X-Gm-Gg: AZuq6aL8v9Wnr5ZIUsdzQiEOD3iZMJk6anJSnajTQ53NkxqoJRo0u/D3QLFlGQniC0H xGiDmcVVCIbSLp9djypCDkxHWej5bdLG/FZej6Md9oqbrwyOvQGY6WuVBoNalm6a58/03qaB2y9 wYS7AUIdhZQnMmhwJgj2z1QNp6H0uUlxnvxUS9pWSw8o3KHdAxqYfutYODns55oDXDp98BP2JrO P+7E2+0mAffjhutlUCRwfVMchj21y12yy48NJqzU0UIxmnQuwWY3lUeTVnVYZetUth/eQ8gkZua upSKxUsG2yY7Nr9fJFpS4TBbwsQ4h3BrxCDOa8CyrsI7C1ph7fnj/UAN5NhdxB+Y/MeaF6N2/0e dSLPyCOP73kJWjERqIrCp8zWns5oEKpfGAAx9zafVItecmaYo0PA7uD95LsJNer7uQ34dlHmpN4 Kw+W69x2Yb30ySMu58TaikwFQusJxOzFQMxPrMuM7R78r0y9HwnFEkhg== X-Received: by 2002:a17:903:13ce:b0:297:c048:fb60 with SMTP id d9443c01a7336-2a76a389391mr13454865ad.25.1768900966610; Tue, 20 Jan 2026 01:22:46 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a719412d38sm107330435ad.87.2026.01.20.01.22.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 01:22:46 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Sabrina Dubroca , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Nikolay Aleksandrov , Ido Schimmel , Simon Horman , Mark Bloch , Petr Machata , Stanislav Fomichev , Carolina Jubran , Breno Leitao , Shigeru Yoshida , linux-kernel@vger.kernel.org, bridge@lists.linux.dev Subject: [PATCH net-next 1/4] u64_stats: Introduce u64_stats_copy() Date: Tue, 20 Jan 2026 17:21:29 +0800 Message-ID: <20260120092137.2161162-2-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260120092137.2161162-1-mmyangfl@gmail.com> References: <20260120092137.2161162-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The following (anti-)pattern was observed in the code tree: do { start =3D u64_stats_fetch_begin(&pstats->syncp); memcpy(&temp, &pstats->stats, sizeof(temp)); } while (u64_stats_fetch_retry(&pstats->syncp, start)); On 64bit arches, struct u64_stats_sync is empty and provides no help against load/store tearing, especially for memcpy(), for which arches may provide their highly-optimized implements. In theory the affected code should convert to u64_stats_t, or use READ_ONCE()/WRITE_ONCE() properly. However since there are needs to copy chunks of statistics, instead of writing loops at random places, we provide a safe memcpy() variant for u64_stats. Signed-off-by: David Yang Reviewed-by: Ido Schimmel --- include/linux/u64_stats_sync.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/include/linux/u64_stats_sync.h b/include/linux/u64_stats_sync.h index 457879938fc1..849ff6e159c6 100644 --- a/include/linux/u64_stats_sync.h +++ b/include/linux/u64_stats_sync.h @@ -79,6 +79,14 @@ static inline u64 u64_stats_read(const u64_stats_t *p) return local64_read(&p->v); } =20 +static inline void *u64_stats_copy(void *dst, const void *src, size_t len) +{ + BUILD_BUG_ON(len % sizeof(u64_stats_t)); + for (size_t i =3D 0; i < len / sizeof(u64_stats_t); i++) + ((u64 *)dst)[i] =3D local64_read(&((local64_t *)src)[i]); + return dst; +} + static inline void u64_stats_set(u64_stats_t *p, u64 val) { local64_set(&p->v, val); @@ -110,6 +118,7 @@ static inline bool __u64_stats_fetch_retry(const struct= u64_stats_sync *syncp, } =20 #else /* 64 bit */ +#include =20 typedef struct { u64 v; @@ -120,6 +129,12 @@ static inline u64 u64_stats_read(const u64_stats_t *p) return p->v; } =20 +static inline void *u64_stats_copy(void *dst, const void *src, size_t len) +{ + BUILD_BUG_ON(len % sizeof(u64_stats_t)); + return memcpy(dst, src, len); +} + static inline void u64_stats_set(u64_stats_t *p, u64 val) { p->v =3D val; --=20 2.51.0 From nobody Mon Feb 9 19:30:56 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6E033D647D for ; Tue, 20 Jan 2026 09:22:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768900973; cv=none; b=hfyJ46zxfLW0jlvlSWnHOucsl2J1fQvPNg+uQQ69W4c3oG+lNj5q9EJRazifwnhNgcxFiXRHhhGwtmn6RHXbNAcA+hYdaN8UB/damkF2djbjTl2mYRfFRJ1RiQd9UsnS1jff/OCBs0+w09658Z0BwOuaALpRgbGESwP+Roz5Zew= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768900973; c=relaxed/simple; bh=LFXvvsnSHomS3qAx5n0cKtlDgaxDB0LHfzSintTiwXo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Hqm1yaLHLg+LiJnH5EJvlhEayRUNY5gPqknzbbBNYqs4dxWxOMFOIw1ngQuG3h+VGjBQhMU6VxCTFERdGnI2WJW7SFS5XiQ1cY5DG2BxIIjLjztl0NqfL59sDk6IEBYnIymS2BJNxoJFE+iVZI6rXZXDXOelJE1uGxNl5j8THSQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fiZe1j/B; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fiZe1j/B" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2a110548cdeso34228575ad.0 for ; Tue, 20 Jan 2026 01:22:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768900971; x=1769505771; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7a8I7+iCrEMhwpiceFoy5kG8jHorqo1UmmUWGOAZBtw=; b=fiZe1j/BXr1FrRzwSLfhD1ADVYsuQtfaokw/bq4udTp3QyS4GU914y2+kKVUq2X43m HakVM2oqcXyRHiJjHn/GIN7xemP0chYox2G6aiU4y8PFdOhPtseo8GUqQKjrylOItg5k 8eBhbfVaBp/cVp7wJ1/08rYxObD4hAnMXhIG7dNo0SV93LSCTx5u9hZC7D7nLJq861Ew xXdrfYlPYtiMt3MHOaVhMQ4gjWsNua3J6yB6CehA3ibqdSvCVLYk7vo5BMwcfvXDpQJ5 ZTCUILcBFira8rMpECLmi8tL0u9+8/8B88XnCInDiXiJ6pDOIj7ENjXK14IJgvKMH3SU WzPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768900971; x=1769505771; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7a8I7+iCrEMhwpiceFoy5kG8jHorqo1UmmUWGOAZBtw=; b=JEyWUszeAkcR/yPehSDhFXKmmOifgrykJ2Yve14TcK3xY7jRDWp6/hUIlPqRHWusCd wps2VWYfrV7twdZ/YioEhcM4cOvkPxE8Vva17tFxWdBlEHokYLCMiGg1S6JQCP8hHW0e EQYWtZD8u/fNbw4WLdCj3YJJSG+NMdap7HCLf9rBjenZKEkvdAf1kCg2sB8U9R3y9+mD iHwk6z0KTMUZJEYktZ7vRXd8flcdbLeNOCGzR3Ti6lPsfbBybIIZjta/kGE4tH3/yAs4 zrSqjUHWef29zjxJwA16FTGOvm8U47IMeDKgkYGWyvFo/evnLV9wMid/ISynTryJWqXq qmTw== X-Forwarded-Encrypted: i=1; AJvYcCWBjPDceL/Kg9uWNZRedv9GK+/PGLHieEVOVWRl3Tuu0q1f5qv98SX3M4GEJQQL6Fg9eRa3gN9uiC2mIJY=@vger.kernel.org X-Gm-Message-State: AOJu0YwHrmBXW0TICTgPEY4pZvph6DfLa2KCeXFpVrDDlyNYXQPptO0i xhRpjFLkkm9UlY/xsgky2ao9UfufvWqmWNw4I4tPgEWWggzcRTZ1oqhn X-Gm-Gg: AZuq6aIUq9YaDM3BhAAHVZwpcayTzfCE4stHxCqLvn1PpIMQ+BZmOR/JYp7BqbwZv9S VOemjcFOi1BzugygF5/vSp+9vpn8bEZIQx1SOUH+EjqTo3XfyEr9FtrH0YN9oaHDMiXe4jiwHsm UJLTjnx+NYO2+/pwwsi/mDHqVbeSBbSlCcNH68RlIB3fklaAUx2AoqbBhA8Sn+Uq4/bNN7iLzP6 k+bnQA70fFRRIJVkOfF7gtM1H7ek5ZcsjYLRq5CSNgNX4gz+p6Pn5ztCy2kgCi7RrpU9FqlY2xK 12CLN9fHVnulMmB0bEOeKgTPgKa3AhE1IY86jWkQhSJnw4z/cEwYTcBgwB6VgCbb98J9fVi+Q+h akqgfzBcf/R3YpnZDXfxiOBLRdlhtq6YBw3eHZdKxjxKcucPaX7GJyx7PZrEm900EhWIf7qS/i8 puNtG4RsZWwa2ECfS8rT+By62OmDF85oIdrfOaIh8rimhi4Ijao1k0Bw== X-Received: by 2002:a17:903:948:b0:2a1:10f6:3c1 with SMTP id d9443c01a7336-2a717551dd1mr133844815ad.26.1768900970966; Tue, 20 Jan 2026 01:22:50 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a719412d38sm107330435ad.87.2026.01.20.01.22.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 01:22:50 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Nikolay Aleksandrov , Ido Schimmel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , bridge@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH net-next 2/4] net: bridge: mcast: fix memcpy with u64_stats Date: Tue, 20 Jan 2026 17:21:30 +0800 Message-ID: <20260120092137.2161162-3-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260120092137.2161162-1-mmyangfl@gmail.com> References: <20260120092137.2161162-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On 64bit arches, struct u64_stats_sync is empty and provides no help against load/store tearing. memcpy() should not be considered atomic against u64 values. Use u64_stats_copy() instead. Signed-off-by: David Yang Reviewed-by: Ido Schimmel --- net/bridge/br_multicast.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index d55a4ab87837..dccae08b4f4c 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge/br_multicast.c @@ -5201,7 +5201,7 @@ void br_multicast_get_stats(const struct net_bridge *= br, =20 do { start =3D u64_stats_fetch_begin(&cpu_stats->syncp); - memcpy(&temp, &cpu_stats->mstats, sizeof(temp)); + u64_stats_copy(&temp, &cpu_stats->mstats, sizeof(temp)); } while (u64_stats_fetch_retry(&cpu_stats->syncp, start)); =20 mcast_stats_add_dir(tdst.igmp_v1queries, temp.igmp_v1queries); --=20 2.51.0 From nobody Mon Feb 9 19:30:56 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6097C3D6679 for ; Tue, 20 Jan 2026 09:22:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768900976; cv=none; b=BJjNySecBDC21QYeQXEMJLem87Zx2uwPlvxIxFOgfAr3Ol3coAtGVVtkbinbMedJYLmc8pK2CXoNjEMFNT0BovMJeLI7/doL41ycoUkmw08E2ZOsf1n7Yt/aF2tizlu5BqEQyBUE1zsJw+VLRSlUAbFw3N7R72nsV6IYZVnlM7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768900976; c=relaxed/simple; bh=75S9BycuIxuSzaBu+FNNZEZiK2ibG6IN1JQgbts7XXk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XXjRdXQ6rrxK4vGAcAINrFXfi/cLapZTKUdohAHt6f9FLEX7Z/GHNCd2WxqybDCoKYC1KcCSM4GlHpms7B2cmnr1V7E68ob2K8hrrQgeoKRAYIJgFwnRQdsdG9zv9jsGWz8BErLKrlWtJT9wV6Cl1LgjUzGVZ89w3o+bRByilok= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iNhJhpq7; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iNhJhpq7" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2a09757004cso45967295ad.3 for ; Tue, 20 Jan 2026 01:22:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768900974; x=1769505774; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AIajvYJtpjLxUNB+rknTUd6Yd1pBkxIf665PlB4VuA4=; b=iNhJhpq7+d6loRSPikO0dolz4Ud7Z1zCqpfh5YCz9obiKcrvStAod/9yJ37xoHSf4q VjdPwrvnCysy+uzqd7reDrCFOUtFTz7kkgV1WEH1DVDx5bfJByx8qKOva5iBXOZalXgm X0ckLwEYzJ5PIfScH9WhWNIfst/1harDR+6KENWpW5VXC0nmHsSgjlQ9YsTaNz5JjuOy dcZC+090RErBW2rRGbRC0FQpswtCVYHfkFKal6eTY0WM7aSa+jles9GDvHsWxSqTQD6s F6+TYR7CGAQ8XY8dqYQqzkY6G48K7BvrjV3Y7mEqzRzVEei63CGy2WD7Ixt1JJFsyJER UykQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768900974; x=1769505774; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AIajvYJtpjLxUNB+rknTUd6Yd1pBkxIf665PlB4VuA4=; b=GbW5XASMrQ6mkjDJONp97CS7DmT4Ma4c+HCcN5u/DvBbfXL+sGxhR0hZ7S8tiiH4Qd ZoipUcjtar6iPQYSVALipVUeMIN07N9pKiewwT6pWQb3VNsRTBImHgRfTrkMHN9VFO++ EOb7behZbdTYoaIEKmzNbJvaUt/pthpIiaOr+S8kNBY6H3yaINNRflrBRgps6pRSm2be 79aRulll68nMC9ljYkkC69dDdoD34Z7E5FDI3Spyf6uitrB0CIrVqQtIRikQzSDvbP68 JD+65KhonpLW2XqrIQRJPIBIZKt/U1aeU2UDkujpeL69ET04qXuytcwF3wXETZLYSNsk daqg== X-Forwarded-Encrypted: i=1; AJvYcCWf4Y21Ud/gQ5XyWE+//WgEnjfribxJ+I7p9trnK/wrFJQXHY1K0VkVr2OjGprhwIB/NVm9jwtywZ45L+A=@vger.kernel.org X-Gm-Message-State: AOJu0YxieY9NmgwUf65mw8y3q/O8RrIAZ4EdJA35MhNh58syAQEcdzQp aRM2fcQdEBtQqnHLT2KXTmkyCshv902w3Kod8fHAQEky4skkoLmWzZS5 X-Gm-Gg: AZuq6aJ4f1cje6SD6ySZ6Es1xN/0UzskWz/pqfBFc5VrqQzKMpDB8PE55yHBhNAftn6 1YWW9EMtn3vrQr12vn4NmerOiHxPqxWCzJsTOtGq6LxVCoA3rnFBROin4PgICejBZgsq5gCCd75 L6QyqaaMHIeH89V4z8jJJNGWky5OpFkmiL8VcXJcxSL2y1xWLWKWjy9XA5fWwK1p1Ac3Y+ucI2A e3xmELcwF6qw7JiLNBtDgYwJlTiRzj9pJCNHeKbYsm/U7SOk5r5/8hbWytQA7Xr97bv9e05nHQN CtYROu44ubcgFqMC1ssFkLM2DV1KKSJTrqB0llMADsXNxAEoZ/53Y1VaI/4EbXlVL8CkBW4FekR mEKAag/zI68G6a7g5M+27/3xzYLALVH+vbzHItuNMbH1FqKMXJcSkeir6bOqXybFX+W1KnbdbyP 1dlWKdnNjjOZRE5tZPoU5HuGBqVdJbjtecIk2fnoSlUQtpqIJVwypaCQ== X-Received: by 2002:a17:903:b07:b0:295:9db1:ff32 with SMTP id d9443c01a7336-2a7175c4de4mr125725985ad.48.1768900974617; Tue, 20 Jan 2026 01:22:54 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a719412d38sm107330435ad.87.2026.01.20.01.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 01:22:54 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Sabrina Dubroca , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [PATCH net-next 3/4] macsec: fix memcpy with u64_stats Date: Tue, 20 Jan 2026 17:21:31 +0800 Message-ID: <20260120092137.2161162-4-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260120092137.2161162-1-mmyangfl@gmail.com> References: <20260120092137.2161162-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On 64bit arches, struct u64_stats_sync is empty and provides no help against load/store tearing. memcpy() should not be considered atomic against u64 values. Use u64_stats_copy() instead. Signed-off-by: David Yang Reviewed-by: Ido Schimmel --- drivers/net/macsec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c index 5200fd5a10e5..c2cb2d20976b 100644 --- a/drivers/net/macsec.c +++ b/drivers/net/macsec.c @@ -2806,7 +2806,7 @@ static void get_rx_sc_stats(struct net_device *dev, stats =3D per_cpu_ptr(rx_sc->stats, cpu); do { start =3D u64_stats_fetch_begin(&stats->syncp); - memcpy(&tmp, &stats->stats, sizeof(tmp)); + u64_stats_copy(&tmp, &stats->stats, sizeof(tmp)); } while (u64_stats_fetch_retry(&stats->syncp, start)); =20 sum->InOctetsValidated +=3D tmp.InOctetsValidated; @@ -2887,7 +2887,7 @@ static void get_tx_sc_stats(struct net_device *dev, stats =3D per_cpu_ptr(macsec_priv(dev)->secy.tx_sc.stats, cpu); do { start =3D u64_stats_fetch_begin(&stats->syncp); - memcpy(&tmp, &stats->stats, sizeof(tmp)); + u64_stats_copy(&tmp, &stats->stats, sizeof(tmp)); } while (u64_stats_fetch_retry(&stats->syncp, start)); =20 sum->OutPktsProtected +=3D tmp.OutPktsProtected; @@ -2943,7 +2943,7 @@ static void get_secy_stats(struct net_device *dev, st= ruct macsec_dev_stats *sum) stats =3D per_cpu_ptr(macsec_priv(dev)->stats, cpu); do { start =3D u64_stats_fetch_begin(&stats->syncp); - memcpy(&tmp, &stats->stats, sizeof(tmp)); + u64_stats_copy(&tmp, &stats->stats, sizeof(tmp)); } while (u64_stats_fetch_retry(&stats->syncp, start)); =20 sum->OutPktsUntagged +=3D tmp.OutPktsUntagged; --=20 2.51.0 From nobody Mon Feb 9 19:30:56 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83AE33D7D71 for ; Tue, 20 Jan 2026 09:23:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768900981; cv=none; b=BK3u9FSV4KOuVkLNuAi4wa3Utvhn6rjrIFUdsY1Ur0tXQlkcicXbnVW5LIA3zsVVL1liXyoG4aRUsVjHzoxAGQ6Lf/FhVtxghZRYb1+tXDzP56wDpoAzcSxBUukHN095r4ZIeBP0OCJDJ0HFcnJI9zZvSdfKnadn6iqGW8W9sWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768900981; c=relaxed/simple; bh=CSmRzLwnwCsA/vnTMKg639sKOpJB+31aFmQ83gXmJ/M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=asfrN5G7DmGpYPqaIu0GwauaH/Dfb+WGeAREBPxhH+PDw3CwwmHa3W0EEjuSYlgYsPp3tIhRZy8mlKWSqlb8hoZKwGdZ7/GqtLgB4LafXaiSTnxE0dCwZgqhVGYGzKXGdcjFgkWKZQuC5w6/P1RhP6GxyaRNh9xZOMOvk1ZwKcQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h2oaYKzO; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h2oaYKzO" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-81f3b4ae67bso2720930b3a.1 for ; Tue, 20 Jan 2026 01:23:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768900980; x=1769505780; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eaEU7JqPQPZcp4mwlpZjeBbbu3WMdRPp729xKwSniOE=; b=h2oaYKzOuK3JCKmEomsMC6kSiO/2RovGhDd+VD2xnB+EEYmyNvJ3iH4jcniGlBcMPC NebJVB3nAaFOXs+kgswAxUSLVWBoIQYUdZIQICCZh7xRTLhsKxR3OLqcwPxdqD3dptQV fMupfCfvM214RCkk4/dEL64ImFQW6WY+w7fMlksN2nYAPEo+j8cNcnL7vOSdfMXS756y l8CcEAeEPX5VzVWlZf/LkmLe9Ds8SfhzUro9GZHvF8pqSljxAFJQ5+rf/SyFmZ7FJWXs hkZc8KoqXZwNT2zpItCgB8HJKxutpjNn7r+dqw93R/RXazmyApKYNO+TZ/Oz0FeDDyMd p2vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768900980; x=1769505780; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eaEU7JqPQPZcp4mwlpZjeBbbu3WMdRPp729xKwSniOE=; b=vhwPksEJG7N4QNcr+yi9I8EtjLIUn4M9Tbln+XGiWtMjAB6Uk9e868EBOP0XZ9kTmh plTZpSirUy1TIuDwJM3mZjpJvDooQ7qpfL5+O+/UQwOhj1eT+jrNZqi9Z0OkW1Kvczb6 v+3sSUJiyh2FDSBuMy3o7o6VVlAubiCip9H3RUWrvC9qa9dbeak7jEN6CKxFfHmckbjy kUrgQcUdoxesviL+YpXtGTGi9vHWXcCtcvwET9vclVlNQJYX0n2BJbJoExPKpQs8hp9V 1AVO6Ze50NKOCxVLmWIvZFNIGDq6xOEwdXrCeF61Yh6ANWDasV6qpvR8l/xdKyOBrJKB 6Waw== X-Forwarded-Encrypted: i=1; AJvYcCUhQK3rn5NHzyzNN5zn31/25V4fDuIep4gOiZmRE9lcYCvUkopHtkqcjfEyh8M1wmR4TjaxLyJXai0ZZoU=@vger.kernel.org X-Gm-Message-State: AOJu0YwhAvAuWXxsug/vM/bEZY+RypfXYW7uaK6k6UI9jX+jweY9BkYI MiS+Hk0uUNDw3j/4QWXfbq23eLor3bueVaJQj+/KzyI8JaBUluwSc01Q X-Gm-Gg: AY/fxX5Frbf72/zfE9sBzXWfWGTRi54wrjt6OLH7XUvtQf5F9NkmiaaSTBq29a6UV3Q X3ykDrq7Zdqhfa79In1RzeYMrvPXtwuWNiVvWpOB5dE4I63tUNqIQqmVQAhNm+xDg4CeBBrzcmJ F7IOF/UAntELi8iEQktnM8V94XtpKno5Db5rUBACnquI7cydZG1h8ZVi3gLC34OFewdcfVJ9EN+ m9YuolBZj+bCGrpQ10j5nL7+1M4ap4Maxssb8Gljqq89A2aacvfEeNb6RXnld2ki//Nt6aTiBXL 8s54atbpbGoAEmBYP4hygr5kGvTEuasL/YNCOnf59yKev3eJZlZV/1O0BGSb65cWz93oXdnfUi+ /JmO2K+cyKZ01zQ6xNzkbmjflyd6YRdWvkBEnGzmnvC0q5Fd9AXFC+z2g35pfOr62wL6wPujD+L My4ihpEw3ENL5wNmsSXRLLfXOGorgeE6UMAdi+qpewynI56HejEWe8ng== X-Received: by 2002:a05:6a20:2d08:b0:38d:fc34:c88d with SMTP id adf61e73a8af0-38dfe7b6e2dmr14284967637.55.1768900979811; Tue, 20 Jan 2026 01:22:59 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a719412d38sm107330435ad.87.2026.01.20.01.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 01:22:59 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ido Schimmel , Nikolay Aleksandrov , Mark Bloch , Shigeru Yoshida , Breno Leitao , Stanislav Fomichev , Carolina Jubran , linux-kernel@vger.kernel.org Subject: [PATCH net-next 4/4] vxlan: vnifilter: fix memcpy with u64_stats Date: Tue, 20 Jan 2026 17:21:32 +0800 Message-ID: <20260120092137.2161162-5-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260120092137.2161162-1-mmyangfl@gmail.com> References: <20260120092137.2161162-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On 64bit arches, struct u64_stats_sync is empty and provides no help against load/store tearing. memcpy() should not be considered atomic against u64 values. Use u64_stats_copy() instead. Signed-off-by: David Yang Reviewed-by: Ido Schimmel --- drivers/net/vxlan/vxlan_vnifilter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vxlan/vxlan_vnifilter.c b/drivers/net/vxlan/vxlan_= vnifilter.c index adc89e651e27..cde897d92f24 100644 --- a/drivers/net/vxlan/vxlan_vnifilter.c +++ b/drivers/net/vxlan/vxlan_vnifilter.c @@ -126,7 +126,7 @@ static void vxlan_vnifilter_stats_get(const struct vxla= n_vni_node *vninode, pstats =3D per_cpu_ptr(vninode->stats, i); do { start =3D u64_stats_fetch_begin(&pstats->syncp); - memcpy(&temp, &pstats->stats, sizeof(temp)); + u64_stats_copy(&temp, &pstats->stats, sizeof(temp)); } while (u64_stats_fetch_retry(&pstats->syncp, start)); =20 dest->rx_packets +=3D temp.rx_packets; --=20 2.51.0