From nobody Sun Feb 8 05:37:07 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB2653B9602 for ; Tue, 20 Jan 2026 08:07:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768896463; cv=none; b=idv2db7ffibqhsw7I1o+FNyqg+IPiXbVdyYzKQ6XxENpk/sv7+VJloCRkzsh+6iYGZbW1N98yFSTHYkir+cfmf87aNhOsveK1PkJJvjaJXJH+0s7FFDqqLVjUsQxxYrF8LGenuK83QmY59OGzt4k87bFg6wPdmg242jqRyt9A+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768896463; c=relaxed/simple; bh=8cXCHWqSFqAhb/0yrvwMCQYeAmlW3lL6PDpwp+nTw6c=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=J5ClcEnjH7ekxPfFv4ZWwF33H/ZTwYBEhoxmCIPRpHIPu3EjVGwn+FucAC6kI4oLhd9KiNJI/CIwmestX7rDvd0bbCPCyXxXlSpwqo+0CcwblcN0BaTcWo61FcZkEXQdzPTArZ2A94zpkG+A5mPX0/x7HKTBsdKUv5eh0qZQc3k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QM6kXlGN; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QM6kXlGN" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2a0fe77d141so33432845ad.1 for ; Tue, 20 Jan 2026 00:07:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768896461; x=1769501261; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Syo4ZZwZwDuvqR8s7EAD3Gw1DEsI3pVtXVpUzZjtTyk=; b=QM6kXlGNHluP18bDdUqkPr6aIDZEMXEPsLo7AHiBVPYJtXwmoAQb25suvpxtNBUeJ0 iwMo6g0UIHqpo/ax/YF/xeXqUh8eQWTOAopuCXCIagmapi3i0oYNVdcTsXUYAHjlhfOw rTwVNoVrgGJI9IaW0IQwXuwzQyCAV7VXSl/1o9riXmpch0rSnMQIoMM+LDJW20nTfLg5 L2JMGD9lQNZaUQt3Y2RJ7STtbew6LOtf2IntTa4FmZx2CG/FcJOWFE8g4JldsuC44f7O Z1ZVU+J7DH3oZALfybJmJsLTqEviVOk2PHhKdzxUhiVweL9UT+iLwvU7z5+J/98NMAAZ mJLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768896461; x=1769501261; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Syo4ZZwZwDuvqR8s7EAD3Gw1DEsI3pVtXVpUzZjtTyk=; b=jmYU07hV83bZthI6EN+kNwj3dgbuKfz1CzyxHtHLA4kCJRON5aQhOedge54osY7biP CnZhvBiFW7EUmDiekkBMGlBjdBbrfdju6zIslrGFOrXz46iHHjduCoGzUblmHT7d5VGJ kihN6hnoJZKKx2LGpCIovTFTHwRHRKp2Bg1UxXlbVuS9dhKeYWyfPniR4JdCTCgcCN0P cUX4w1dKCsJtfGopwh4JUgPZ4fZBAhMbEOFs/46dY/DDunKEZMX911RN/mbuAxgT/GjT mIwmCDGXKBU1iKGSn/j85rDGGmbSgGRCKrke0Ve9jMZipRpbTuWu19NSWuisouvKB2jc lKlA== X-Forwarded-Encrypted: i=1; AJvYcCWa4NOTrjFF5XhqQrEq6Itz3sS9KKuSr52nBjPMsVp++30X5l1c/IMwGub10hFGEWI3NhnzqeCRLzWrZrA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/9tQJ4D420l2q3c5RO1cX/ji9FgHhWceOJCh1JnmDlB09rX1P KoqYjZPeuVFJ9k/Z237T8IeBQeP0DfojYvmN0xMKqb0HHFdxy/fwxUNb X-Gm-Gg: AZuq6aJG00P+liMX/GbGCkstf8Jap2fO7ZLfxJQyuQVQCBLyRCt0G0PFWa6HtI4tZPP 5PxBW35C7e0OVrQVPWTwdW1C6aHl787xPNJYTqAuFjZp0uiDnTa9732MO8CgMv2DoAQ1aJM/7EW pQak0e6dKHqEsKJrCw6fVZE7qS+RwE+NMhwjmGjCgZMjYT8247Q9EekN4o0ISTuI4TfuHkpVXF5 1rnqZtSbRXMpGZ+yTOLummRJoHlUlNxLU3BRJFBH0L+PDC7Q4Ky9RFoFYMW8w82UM0wtCW39vO+ j1MZm26nstG27LCBf8Du5HBO048gKP725bZC12VugCFKeLH9pQoONgM3g0/AOSWPCl+z21w5Shu 3iRUtGHfCU/AecHLt9Bn42OqdtRiG3InDir2GM/GHAR1n+d7ONW1+ySUDKJeOm3Rqc8NgY3dPm+ kaAdP7HI/gkQEFNyktjyY39WLD7Orwv7+OsGkY4FhNNPv8ny7Y3mxGggdMtRjRnvdoIY8LMVrzs rhgJEkKNHRMb/wpyiwn2cZX54ssLsBijakuWXpxMVSK/Q== X-Received: by 2002:a17:902:f544:b0:2a0:ba6d:d0ff with SMTP id d9443c01a7336-2a717533f7fmr123178715ad.16.1768896460959; Tue, 20 Jan 2026 00:07:40 -0800 (PST) Received: from 8d75dc141a66.ap-southeast-2.compute.internal (ec2-54-252-206-51.ap-southeast-2.compute.amazonaws.com. [54.252.206.51]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a7193decfcsm115731655ad.60.2026.01.20.00.07.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 00:07:40 -0800 (PST) From: Wei Li To: tony@atomide.com, haojian.zhuang@linaro.org, linusw@kernel.org Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Wei Li , stable@vger.kernel.org Subject: [PATCH] pinctrl: single: fix refcount leak in pcs_add_gpio_func() Date: Tue, 20 Jan 2026 08:07:35 +0000 Message-Id: <20260120080735.548853-1-unsw.weili@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" of_parse_phandle_with_args() returns a device_node pointer with refcount incremented in gpiospec.np. The loop iterates through all phandles but never releases the reference, causing a refcount leak on each iteration. Add of_node_put() calls to release the reference after extracting the needed arguments and on the error path when devm_kzalloc() fails. This bug was detected by our static analysis tool and verified by my code review. Fixes: a1a277eb76b3 ("pinctrl: single: create new gpio function range") Cc: stable@vger.kernel.org Signed-off-by: Wei Li --- drivers/pinctrl/pinctrl-single.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-sin= gle.c index 998f23d6c3179..d85e6c1f63218 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -1359,6 +1359,7 @@ static int pcs_add_gpio_func(struct device_node *node= , struct pcs_device *pcs) } range =3D devm_kzalloc(pcs->dev, sizeof(*range), GFP_KERNEL); if (!range) { + of_node_put(gpiospec.np); ret =3D -ENOMEM; break; } @@ -1368,6 +1369,7 @@ static int pcs_add_gpio_func(struct device_node *node= , struct pcs_device *pcs) mutex_lock(&pcs->mutex); list_add_tail(&range->node, &pcs->gpiofuncs); mutex_unlock(&pcs->mutex); + of_node_put(gpiospec.np); } return ret; } --=20 2.34.1