From nobody Sat Feb 7 11:38:21 2026 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D35EA1CD2C for ; Tue, 20 Jan 2026 11:37:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768909071; cv=none; b=LrUHH6YT7lgQaZAwIxZcZHnzbAc6rui4gW1+BdlkWmjyf+RT6kh5ijeVuNju+mWMRLpEBswA1NQTYmpIWcKR3350+4DhJxvttuH4WJ7IyCFBe1+wwskF1msio3bgktkDEKq3cmc9+AgnXxVYteAM7Rfb+RrqK1hoPay3WWyL/GY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768909071; c=relaxed/simple; bh=ETsLcSZWKB9eq3Cr6keAewRWPWzheGP6F9hf6pabzj8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=soDmzEwpwzOiEYrynJ6isYP81jkzIVHvF/LIeFOWJ0lvqKmfo+w7rbI0/XoZ32vy6DkHQLTLQdkuAoOiHQY75DIjM1ycbfVMEavFIr4fMxEnhDRNG6/MxNc6Fdf7yDzZsDGRbg9fI2P6cCosM1FyQuYDNplsj3qRpcH+Gs4ciqo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hO4tXOYl; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hO4tXOYl" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-81e7477828bso2880789b3a.0 for ; Tue, 20 Jan 2026 03:37:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768909069; x=1769513869; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=k6Xceg2OD/lxCrNfx6j5iuRJOA2fkoLkdUN/b0QbNS4=; b=hO4tXOYlAQeAchz3r7E2MjGnMLN26umwf+WIpVktKLpULe6I/qQVojtmWSpmWaF1aV F4WvX3Yk4IzbZMQYfYB+JvCe70VI9XWUjZ15fjDJQkLej1tSFwZLu0lLZy+KqugyOQPE q1MzTqgNA7Q2cMKtqwY5bsXIktbSyDGUHCU+wB8AnmIrIw/g+uBENIukroH85G4cNhEn Fh0QLd3/G9NE0ndvRpMxA1GV72pvf52BfBs+mCUeg2S7ImTsMJ1aThjgvqDHZCittLrV uVxz6MmgM5ewOrcH/Zq/5HE3ZHNbG61bl28E0SCqtINhlAUksb1Ylaamy4bIZ1zZK8jF wvtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768909069; x=1769513869; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k6Xceg2OD/lxCrNfx6j5iuRJOA2fkoLkdUN/b0QbNS4=; b=YArjPOE8roTD7xqE2Ya/pf/6CRmEWyd72XjUuxp+V2FW9dVnL6/hxEY1b3VUYJkn31 GDzvgg5rPhi/Civ+hzC3if18B5qHE0T1XaLASnEwgjWxX/HNq69J/67IlDmb1Z+EsT35 sdjHxE9eNshlRbBjOYXsUcHSBS/qm1C6iJOf6TwSFz5B7PY4GCrwpThPTBwaHuEV6/tb SbLEhZy+IhD+j6F5SvesRkEezUIzgarofHIlU7BZSk1ZC6u+WVKPItkEqhozhXmbS2C6 z6S+qWn9/P6OOO/wfmwlASCozg3Iu4H5O4Y3JYHKs27Sbp0feD/V6Yd6kVMwDqbaEqpB g16w== X-Forwarded-Encrypted: i=1; AJvYcCUUHGg9hkpIHtQaEQzfiSQXkCvzho7axQ/QMZnpxmqeJCobBBb0O0gm5TVoFE/UgMTi8h53oBXXFm0a/OA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9ifBzj9XzbfoFk4Y6bchPBrmusvliQK9jo3r8W1Sgg1NO73Fl g99J8ibKTiePnQqg88V8IWygYEPKLTZ/xaGgFBMK4mEalPXtk3E0+Eqnzkb0vQ== X-Gm-Gg: AY/fxX6Z3+UN7aEITDIqZTHlxh/qaj6OTmJM6OhElWpZwY37tW0yjG6bollGh3lj72C PsA1eEP2/WDoZStqbtSXyClCBH8/7qj+xcC52egyv4GV4jaE6/zYmkax5/oms6tKktVlkZpLMz6 XnpJ5NZdZFDcmYjklpWgkERnIoDMdlwDF1WJ9UJNhM87l77o+b382Lr0v+O+fNthxsHyoP5flnq g4NZZDrY5jHOj0FkV+hOtKo0GnWlDUEtGtLt2z4aMbVmEQCCi+htH0neqZ6rO2gY1oxJDYRmJQw oscRa/m3iSLk/+ckQ+hETHk8sMAZIZ6h8P+6qn2uHFGsTBFRSfuvzb3AYDBMB8Dqw6TFFeFmE8N fwv90BFuZqSsgd/snjeOJHi2FCR/TDvIuTBquuzDUINsGj/Ph+xjzo0JC+e2n9kQo7NeIIz7j4C JaPqKnpa+V6XspqHnWEhx8/wCjWA== X-Received: by 2002:a05:6a00:929c:b0:81e:4a9e:f809 with SMTP id d2e1a72fcca58-81f8efbbe25mr13964911b3a.2.1768909069116; Tue, 20 Jan 2026 03:37:49 -0800 (PST) Received: from [127.0.1.1] ([2001:861:3201:3d10:9fa0:1400:5c26:1419]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c5edf264b9csm11462134a12.15.2026.01.20.03.37.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 03:37:48 -0800 (PST) From: Gary Bisson Date: Tue, 20 Jan 2026 12:36:59 +0100 Subject: [PATCH] drm/mediatek: mtk_dsi: enable hs clock during pre-enable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260120-mtkdsi-v1-1-b0f4094f3ac3@gmail.com> X-B4-Tracking: v=1; b=H4sIANpob2kC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDQyMD3dyS7JTiTF0jy1STZAuTVPMkYwsloOKCotS0zAqwQdGxtbUAlxA E9VgAAAA= X-Change-ID: 20260120-mtkdsi-29e4c84e7b38 To: Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Gary Bisson X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1768909063; l=2852; i=bisson.gary@gmail.com; s=20251201; h=from:subject:message-id; bh=ETsLcSZWKB9eq3Cr6keAewRWPWzheGP6F9hf6pabzj8=; b=vFf5Qdlbwe4FiGiI83Db84ydmZAaWLQ3TMiZXuLTGwCAwsOUAzY4UJTj0cTS0qPmPPd3VjN5F RL5WhoIxZDkAMo+KcW2ej0+SI1Sze9wVe2bNPa23aYLM49ontoyVwcq X-Developer-Key: i=bisson.gary@gmail.com; a=ed25519; pk=eaOrLwovHUZBMoLbrx+L1ppj+AH+TfgxkVhIEyrhkeE= Some bridges, such as the TI SN65DSI83, require the HS clock to be running in order to lock its PLL during its own pre-enable function. Without this change, the bridge gives the following error: sn65dsi83 14-002c: failed to lock PLL, ret=3D-110 sn65dsi83 14-002c: Unexpected link status 0x01 sn65dsi83 14-002c: reset the pipe Move the necessary functions from enable to pre-enable. Signed-off-by: Gary Bisson --- Tested on Tungsten510 module with sn65dsi83 + tm070jdhg30 panel. Left mtk_dsi_set_mode() as part of the enable function to mimic what is done in the Samsung DSIM driver which is known to be working the TI bridge. --- drivers/gpu/drm/mediatek/mtk_dsi.c | 35 +++++++++++++++++------------------ 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/= mtk_dsi.c index 0e2bcd5f67b7..b560245d1be9 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -672,6 +672,21 @@ static s32 mtk_dsi_switch_to_cmd_mode(struct mtk_dsi *= dsi, u8 irq_flag, u32 t) } } =20 +static void mtk_dsi_lane_ready(struct mtk_dsi *dsi) +{ + if (!dsi->lanes_ready) { + dsi->lanes_ready =3D true; + mtk_dsi_rxtx_control(dsi); + usleep_range(30, 100); + mtk_dsi_reset_dphy(dsi); + mtk_dsi_clk_ulp_mode_leave(dsi); + mtk_dsi_lane0_ulp_mode_leave(dsi); + mtk_dsi_clk_hs_mode(dsi, 0); + usleep_range(1000, 3000); + /* The reaction time after pulling up the mipi signal for dsi_rx */ + } +} + static int mtk_dsi_poweron(struct mtk_dsi *dsi) { struct device *dev =3D dsi->host.dev; @@ -724,6 +739,8 @@ static int mtk_dsi_poweron(struct mtk_dsi *dsi) mtk_dsi_set_vm_cmd(dsi); mtk_dsi_config_vdo_timing(dsi); mtk_dsi_set_interrupt_enable(dsi); + mtk_dsi_lane_ready(dsi); + mtk_dsi_clk_hs_mode(dsi, 1); =20 return 0; err_disable_engine_clk: @@ -769,30 +786,12 @@ static void mtk_dsi_poweroff(struct mtk_dsi *dsi) dsi->lanes_ready =3D false; } =20 -static void mtk_dsi_lane_ready(struct mtk_dsi *dsi) -{ - if (!dsi->lanes_ready) { - dsi->lanes_ready =3D true; - mtk_dsi_rxtx_control(dsi); - usleep_range(30, 100); - mtk_dsi_reset_dphy(dsi); - mtk_dsi_clk_ulp_mode_leave(dsi); - mtk_dsi_lane0_ulp_mode_leave(dsi); - mtk_dsi_clk_hs_mode(dsi, 0); - usleep_range(1000, 3000); - /* The reaction time after pulling up the mipi signal for dsi_rx */ - } -} - static void mtk_output_dsi_enable(struct mtk_dsi *dsi) { if (dsi->enabled) return; =20 - mtk_dsi_lane_ready(dsi); mtk_dsi_set_mode(dsi); - mtk_dsi_clk_hs_mode(dsi, 1); - mtk_dsi_start(dsi); =20 dsi->enabled =3D true; --- base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 change-id: 20260120-mtkdsi-29e4c84e7b38 Best regards, --=20 Gary Bisson