From nobody Sun Feb 8 16:24:18 2026 Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06A1F37F0E3 for ; Tue, 20 Jan 2026 06:21:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768890087; cv=none; b=dVe5q9L58c4LU62Fdw1mNSyW9Jg2C2MxFehqZtNoQmfl4Dyii33GIPEpWyK7s0mD8PmYbtLqOo2RWmVWg5mwhQYyIaUlrJCxFhS/P1uBwFcy8VtwJldhfWCQiL6t3MX2mpZv9R1brEHzTiagUBP9nw/vHI8M3F5WWvFsDG6iYfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768890087; c=relaxed/simple; bh=R6AtgfHNFuyoDu3Dt8So6HbHkHEi4svHf3KFVpxGpRY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M2zVvXFgrfJolvfSsL3Ke/NekPoLaIc7xfhWqqucXwerv5HI6iVux7C9X93sEmt364U9PajK/Zd1HmJ2lR9LC8SBn7G3FSGC2RY6yKXbcc1UFXwbJZJKYj01q3oOae/CUNLtNDxRGwMBRF1eD9wg6ChPd0m5Y9fYe77mnALdWpA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C3KAM4V+; arc=none smtp.client-ip=209.85.222.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C3KAM4V+" Received: by mail-ua1-f47.google.com with SMTP id a1e0cc1a2514c-94120e0acbeso3010077241.2 for ; Mon, 19 Jan 2026 22:21:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768890085; x=1769494885; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RvaFKco8z0TcIBUmMpdNSTwRtZj3x2smNoAu0imBUvA=; b=C3KAM4V+GS5+Ez8w/HTF/une3gdoJQoiYI996ruNMpSlB3VSGoopswE0qLXLdA9wt/ Yy3QBOq1WqUp5wILnxd7KY7ZwtKnM5Go98nx14VZGDm5DeqKx8w/hwTRtZh1jsaXIX7U atfQdpx8NP6E2JZ9rKmxb0Q1B++OLN/sAEMtjlX8lxG16z1OB+3WkQsAxjVt2JJ32aoU HGGW+2JJReQsF5jt1r5+qbbFJICdyUOCgzJ9MVi81q0bDofrR20d/Y5sXIVAdpxS0lfc tqrFI/UrZ+IPiBfBF44zsQUf/m7FABvnVcyFwRlaYtY6tRuWYMiyBWNiP9MxHEYM92d/ shPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768890085; x=1769494885; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=RvaFKco8z0TcIBUmMpdNSTwRtZj3x2smNoAu0imBUvA=; b=voZA0tmKhU6oaeemHOIkJHOdjXtG5CYJ3+5x/8g7wnHyQdEzCMAvKATyE4FLqlltf5 0Rf0XI+eSCms5x24JrtJDqIQsexO9v+dA9ekEdhPYy2QR5MGRXA8jBwlcKweu/NWZnlQ dcrzus01rSCXSagznJT8L/V9sbmQELhr42Hk445/9R8DfNexwZNDyCGm6rkVC7QYnO7E ArCme87jVAXAQxJdunXyshlsboX96bFETXI1Dmj4nfPQ9UDGdSMWv8Lcxnx65vJ2ZDc4 R7JNsSEqg2ddKbOv2uaTIqAWYKoWPR4wfaMCuTKeHCdHubCTw8F/fFoLudm0NpdFukih c3gg== X-Forwarded-Encrypted: i=1; AJvYcCWzvJE2otzyG4IkLLYDzIIo+7fBS1EovWQKqnlXYUV8RYU7Co9vkvCkMpkeeekw1GRyVL11zRiSGix4fn0=@vger.kernel.org X-Gm-Message-State: AOJu0YwHWQx46zbrmBCvnlxFkYhhI4uabnnFV6YIltoqdZvYboVpr6IH OKe9LRX+AVC35xX/0ieCNKo+j0UA7ODxj9UUFPJoKc3nx37KIZtiQaTg X-Gm-Gg: AZuq6aIdqkz+m0oFsUjp7/oTe8zZIBjhZ6TyZlJ5O+aoonuycDje3aRc1L2R+TRxVbk 2UQnozHWEfPe96Ylg3XukPgm/7hBE1KjMK6X2aqfvWbwmfXrnLrZIEPriv71z1yWIMlmIIsA9a3 Wh0J9Duw466v23t/ZfKIwpEQC4JbcQeCpCBk6h4VSn10/T5dk/PnR4tgaOGHfeOlDqG830G9AOE BhOW7hiP1D93VoglSe7/82b+PsJxvyFmWuUrIMR4f4kQSNmmqsq+BccqW2xWL4yAde7kySJrYTp /ZbNp7DQtdlJeN+ey9oeHHkw/DRIpwwttwhtYIN30PxCzFtJCuH6rgasEW2vGM1TKi29/BHIjC/ oy9UZ88PkahbOWD2Azau5aV7Qd92kps1zs6gAeYCVKzpfnP/aobZy4KlInwjljfm4EUkZTN3sVb MaTmGvQjQ0UmlK X-Received: by 2002:a05:6102:c0c:b0:5ed:a24:1a98 with SMTP id ada2fe7eead31-5f1a55e599emr4178016137.44.1768890084657; Mon, 19 Jan 2026 22:21:24 -0800 (PST) Received: from [192.168.100.253] ([2800:bf0:82:11a2:7ac4:1f2:947b:2b6]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5f1a6900c1esm4057944137.3.2026.01.19.22.21.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 22:21:24 -0800 (PST) From: Kurt Borja Date: Tue, 20 Jan 2026 01:20:46 -0500 Subject: [PATCH v5 6/7] iio: health: max30102: Use IIO cleanup helpers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260120-lock-impr-v5-6-d4d22347041f@gmail.com> References: <20260120-lock-impr-v5-0-d4d22347041f@gmail.com> In-Reply-To: <20260120-lock-impr-v5-0-d4d22347041f@gmail.com> To: Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Benson Leung , Antoniu Miclaus , Gwendal Grignou , Shrikant Raskar , Per-Daniel Olsson Cc: David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Guenter Roeck , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, Kurt Borja X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2086; i=kuurtb@gmail.com; h=from:subject:message-id; bh=R6AtgfHNFuyoDu3Dt8So6HbHkHEi4svHf3KFVpxGpRY=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDJn5cld4PVkXr+ucZnJwyS918f2KXWyhifIiBqXPPnDtW DTBSOlmRykLgxgXg6yYIkt7wqJvj6Ly3vodCL0PM4eVCWQIAxenAEzkhzXD/3wb/gNpl18+bNt8 9Nl/N9u7+uz7G8+HMO85r9p15cMGEWmG/9kLLLl/R1kvsVLoET5XJW8pd0Z0ekKpYf/HXzz/F61 3YwcA X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Use IIO_DEV_GUARD_CURRENT_MODE() cleanup helper to simplify and drop busy-waiting code in max30102_read_raw(). Reviewed-by: David Lechner Reviewed-by: Nuno S=C3=A1 Signed-off-by: Kurt Borja --- drivers/iio/health/max30102.c | 33 +++++++++------------------------ 1 file changed, 9 insertions(+), 24 deletions(-) diff --git a/drivers/iio/health/max30102.c b/drivers/iio/health/max30102.c index 6918fcb5de2b..47da44efd68b 100644 --- a/drivers/iio/health/max30102.c +++ b/drivers/iio/health/max30102.c @@ -467,44 +467,29 @@ static int max30102_read_raw(struct iio_dev *indio_de= v, int *val, int *val2, long mask) { struct max30102_data *data =3D iio_priv(indio_dev); - int ret =3D -EINVAL; + int ret; =20 switch (mask) { - case IIO_CHAN_INFO_RAW: + case IIO_CHAN_INFO_RAW: { /* * Temperature reading can only be acquired when not in * shutdown; leave shutdown briefly when buffer not running */ -any_mode_retry: - if (!iio_device_try_claim_buffer_mode(indio_dev)) { - /* - * This one is a *bit* hacky. If we cannot claim buffer - * mode, then try direct mode so that we make sure - * things cannot concurrently change. And we just keep - * trying until we get one of the modes... - */ - if (!iio_device_claim_direct(indio_dev)) - goto any_mode_retry; + IIO_DEV_GUARD_CURRENT_MODE(indio_dev); =20 - ret =3D max30102_get_temp(data, val, true); - iio_device_release_direct(indio_dev); - } else { - ret =3D max30102_get_temp(data, val, false); - iio_device_release_buffer_mode(indio_dev); - } + ret =3D max30102_get_temp(data, val, !iio_buffer_enabled(indio_dev)); if (ret) return ret; =20 - ret =3D IIO_VAL_INT; - break; + return IIO_VAL_INT; + } case IIO_CHAN_INFO_SCALE: *val =3D 1000; /* 62.5 */ *val2 =3D 16; - ret =3D IIO_VAL_FRACTIONAL; - break; + return IIO_VAL_FRACTIONAL; + default: + return -EINVAL; } - - return ret; } =20 static const struct iio_info max30102_info =3D { --=20 2.52.0