From nobody Sun Feb 8 14:52:03 2026 Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AB3A36CDF8 for ; Tue, 20 Jan 2026 06:21:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768890083; cv=none; b=DcvZw+yuf8qccRLcp/GPwOYw518wARKQqjskYfHdL60qbk5R3/jSe8lxs5E973q/0oIAuQ3W8fKDtq2yBknFtzQeZBCPS4nYlr4Pj48skNbr1aijJhXyYEk69ajYpvr6LZ+vBV80mBFnf3KnKt1F1fYarCzaqiZ5Y0u46Cz8pEE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768890083; c=relaxed/simple; bh=gk4uEOkebbeY+cZwYTy+/3fKoRkuSLvWkzrfvmHqOLM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=a+7IRz9rQKy4e8B54bKtdla59x+aB0CwD6QjtBGZAaBiQvZpJQAlJCh6YR/w9jDnei6yH4Cx80XThSYMB1HN+XS915VAGIhvKt9ifr7UgsfcMaXsbbrgmkPgo9QcFb8ah9B9iGmRU72zf2jPMyJ6/7u5HePkcWaC5YBFH/cpQ4o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D7Y3FEH2; arc=none smtp.client-ip=209.85.222.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D7Y3FEH2" Received: by mail-ua1-f44.google.com with SMTP id a1e0cc1a2514c-93f5905e698so1503755241.0 for ; Mon, 19 Jan 2026 22:21:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768890080; x=1769494880; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ILl543DXo8pvw93JPMvlHELZN9bV6WaivIpMWAbJAoM=; b=D7Y3FEH2Oc7aXQcA+SAcaWUJs6lsWXG4IFcYPBrizcDTQKcUqu72Qp+tt7HRctOyux iHTy2h4dJFZXaXWGnQtR7SY8LXsd0qAwERiCCfoS5pXUHoo7SZVcXqCGdst1DbToZJNR dBPwdtY55nEP32L67UQAjg441RfNlxYKLoUF2csNlzDu0ILTyiMtnJTVe54q9lFqgx0p PEy4PI6aWe/PXOKYQrJt29yO/8s/ZjJ3yODNnEu1yrwN6qIzGYKI8cHrFraXdmjPDM4J GhmYx8EqKyt2sPFoEOdQKwO0Kcecdcr/AYMfCLjI6ILNtGA4pEUsmHId1rNxMCoGvktb Ek9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768890080; x=1769494880; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ILl543DXo8pvw93JPMvlHELZN9bV6WaivIpMWAbJAoM=; b=F8het3mQkI57hYqqM6qnF262ixGNKEtTuYUNz6Y5L2u5+8rDvgqOUo1lDZWsrp5SZE 3SrpaGQjajPkKdmtm0XQps4J/JZd5REcgh//Diwm6dgdA/rv82kmyrK2rqJOCanbeb41 qV4gGlz/NHLg83FFknqdcaTVQ6H4HSWjxzi03YyQ6xCz4QrXVQHVzBwm0aVzLsHX+mnM AQKnfCn1AYihTWw7ukGbQM7QGAD9aAEop38vjuhKkyE+YO+1iId5QoN2knYhu3ssD4Cf JTUAeqSWp2AnfPzO+TUVDs+oB/fdUz1OlnAwNYN/3tZevTXZ5szItKtTzLT68+HXZu03 xYLg== X-Forwarded-Encrypted: i=1; AJvYcCW8jyK2hS6SESavigbWBD7idqFcP9yIvtVp1GOF6UUUH4kG1D2loxEN/HyPKnLXi++hYf2GnVmt6o907oo=@vger.kernel.org X-Gm-Message-State: AOJu0YyN7G6QblU47Rp8kAo/uNa1tIooYGOGbxqiPOpPIZ/D8VAxIpxC vtgJ+nl14wIbyp0Tau4lFzbd2FZ/2s9H3D1k7KasUY8GOz2aiN6e83wR X-Gm-Gg: AZuq6aJJAL56SP9wooYSrSSTDPyu/S8Rgp8NJ7qY6YtwW30OvjlY2MN5oahejGtaDLl yLiBDrLdHX1jvE7XckpO2NGBdSotua1Eq355x7eaHeHwLaVsaND+/w5d6pb27BWLBPrKfH0Rb0t hSUe7ssy83W03ZgCqxHppZsgU0MFwmdlhRFrHRK0xzI3GyEzbTxPkgA7waLuzH2svyPgUqOrQ6o p46zoyeS36gyxcIrA4NAGBCNOcWoQD6dTQdj2BjqzjUx3b4oRrJbAYUKcck8JSF8M0mYuej/8bJ wLq4t8wpniFq3tfUlwKdnp6nhFfzbmQu40n0YUUjWqLTDPYOHk6mj8LDh9mxtXUCP/CXkU/Od1M nghUzI6LUSIZg8qXbaEo8U6ckl3DO3rT+LEswjBWDlWBpS9I26xWaGsMNbgG64T08C5JgmsdLM1 PvZ18WEzDG3yS3 X-Received: by 2002:a05:6102:c94:b0:5db:3cda:cc3b with SMTP id ada2fe7eead31-5f1a55a2fddmr4131087137.34.1768890079962; Mon, 19 Jan 2026 22:21:19 -0800 (PST) Received: from [192.168.100.253] ([2800:bf0:82:11a2:7ac4:1f2:947b:2b6]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5f1a6900c1esm4057944137.3.2026.01.19.22.21.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 22:21:19 -0800 (PST) From: Kurt Borja Date: Tue, 20 Jan 2026 01:20:44 -0500 Subject: [PATCH v5 4/7] iio: core: Add cleanup.h support for iio_device_claim_*() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260120-lock-impr-v5-4-d4d22347041f@gmail.com> References: <20260120-lock-impr-v5-0-d4d22347041f@gmail.com> In-Reply-To: <20260120-lock-impr-v5-0-d4d22347041f@gmail.com> To: Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Benson Leung , Antoniu Miclaus , Gwendal Grignou , Shrikant Raskar , Per-Daniel Olsson Cc: David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Guenter Roeck , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev, Kurt Borja X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3613; i=kuurtb@gmail.com; h=from:subject:message-id; bh=gk4uEOkebbeY+cZwYTy+/3fKoRkuSLvWkzrfvmHqOLM=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDJn5cpd9jkpauCy8c6Mr7FDbP7X+bXcND+wMvSkQ6RpVG ihSwDyvo5SFQYyLQVZMkaU9YdG3R1F5b/0OhN6HmcPKBDKEgYtTACZS8J7hn+oz17uT5/z/GWBk 0ccgsO+oyKal69KrXsRZn+p/MMMsYikjw+8dyw7LRUv+mJujZuS5yCbm46LESNWlYXrNHxM21u1 l4QcA X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Add guard classes for iio_device_claim_*() conditional locks. This will aid drivers write safer and cleaner code when dealing with some common patterns. These classes are not meant to be used directly by drivers (hence the __priv__ prefix). Instead, documented wrapper macros are provided to enforce the use of ACQUIRE() or guard() semantics and avoid the problematic scoped guard. Suggested-by: Andy Shevchenko Reviewed-by: David Lechner Reviewed-by: Nuno S=C3=A1 Acked-by: Andy Shevchenko Signed-off-by: Kurt Borja --- include/linux/iio/iio.h | 65 +++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 65 insertions(+) diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h index 36bd14e93a75..a9ecff191bd9 100644 --- a/include/linux/iio/iio.h +++ b/include/linux/iio/iio.h @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -740,6 +741,70 @@ static inline bool iio_device_try_claim_buffer_mode(st= ruct iio_dev *indio_dev) */ #define iio_device_release_buffer_mode(indio_dev) __iio_dev_mode_unlock(in= dio_dev) =20 +/* + * These classes are not meant to be used directly by drivers (hence the + * __priv__ prefix). Instead, documented wrapper macros are provided below= to + * enforce the use of ACQUIRE() or guard() semantics and avoid the problem= atic + * scoped guard variants. + */ +DEFINE_GUARD(__priv__iio_dev_mode_lock, struct iio_dev *, + __iio_dev_mode_lock(_T), __iio_dev_mode_unlock(_T)); +DEFINE_GUARD_COND(__priv__iio_dev_mode_lock, _try_direct, + iio_device_claim_direct(_T)); + +/** + * IIO_DEV_ACQUIRE_DIRECT_MODE() - Tries to acquire the direct mode lock w= ith + * automatic release + * @dev: IIO device instance + * @claim: Variable identifier to store acquire result + * + * Tries to acquire the direct mode lock with cleanup ACQUIRE() semantics = and + * automatically releases it at the end of the scope. It most be always pa= ired + * with IIO_DEV_ACQUIRE_ERR(), for example (notice the scope braces):: + * + * switch() { + * case IIO_CHAN_INFO_RAW: { + * IIO_DEV_ACQUIRE_DIRECT_MODE(indio_dev, claim); + * if (IIO_DEV_ACQUIRE_FAILED(claim)) + * return -EBUSY; + * + * ... + * } + * case IIO_CHAN_INFO_SCALE: + * ... + * ... + * } + * + * Context: Can sleep + */ +#define IIO_DEV_ACQUIRE_DIRECT_MODE(dev, claim) \ + ACQUIRE(__priv__iio_dev_mode_lock_try_direct, claim)(dev) + +/** + * IIO_DEV_ACQUIRE_FAILED() - ACQUIRE_ERR() wrapper + * @claim: The claim variable passed to IIO_DEV_ACQUIRE_*_MODE() + * + * Return: true if failed to acquire the mode, otherwise false. + */ +#define IIO_DEV_ACQUIRE_FAILED(claim) \ + ACQUIRE_ERR(__priv__iio_dev_mode_lock_try_direct, &(claim)) + +/** + * IIO_DEV_GUARD_CURRENT_MODE() - Acquires the mode lock with automatic re= lease + * @dev: IIO device instance + * + * Acquires the mode lock with cleanup guard() semantics. It is usually pa= ired + * with iio_buffer_enabled(). + * + * This should *not* be used to protect internal driver state and it's use= in + * general is *strongly* discouraged. Use any of the IIO_DEV_ACQUIRE_*_MOD= E() + * variants. + * + * Context: Can sleep + */ +#define IIO_DEV_GUARD_CURRENT_MODE(dev) \ + guard(__priv__iio_dev_mode_lock)(dev) + extern const struct bus_type iio_bus_type; =20 /** --=20 2.52.0