From nobody Mon Feb 9 12:11:28 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F083A43CEDD for ; Tue, 20 Jan 2026 12:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768913574; cv=none; b=C6LsjKKykZsy0wLKY/ZWme0qthcmNDdKn0Uq/pdrIZrScnDJ0R6OxlUMkTs3Y+h+zTVjrcYi+lbnkLa+fnmMZe98pemGfm7qcQNOQogPed+RQk7TDrdZeJ5J/RBbamf6wI+nmxNxj62q4UxfUv+BCjIj2Bb5m+WYl0gKWqwdc28= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768913574; c=relaxed/simple; bh=NMjz6QW82APUPZl8CmhkRZvslMCCC/6N8F6HTClBBj0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=BrEv3VT6LJFQyepYNi23wmvIYdZwABk7Vw1J3QBnxnFTbieygFQF+YXAVSGZbbwAFB0/SFuxuzyHrCtMwbg4IXeGmzFa7Jw4iN+IL0lKQ1/K3HGdX07ni6tVUumEO4MSR0WqeKne29TgkSyoN/1riS86R0zyhHAARdNlk7uhPoU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1viBDt-0000q7-E1; Tue, 20 Jan 2026 13:52:41 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1viBDt-001aQW-2t; Tue, 20 Jan 2026 13:52:41 +0100 Received: from hardanger.blackshift.org (p54b152ce.dip0.t-ipconnect.de [84.177.82.206]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id E77F34D3399; Tue, 20 Jan 2026 12:52:40 +0000 (UTC) From: Marc Kleine-Budde Date: Tue, 20 Jan 2026 13:52:30 +0100 Subject: [PATCH] can: gs_usb: gs_usb_receive_bulk_callback(): fix error message Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260120-gs_usb-fix-error-message-v1-1-6be04de572bc@pengutronix.de> X-B4-Tracking: v=1; b=H4sIAI56b2kC/yWM0QqCQBAAf0X2uYW9OxDrVyLCO1fdII3dDEH8d 7d6HJiZDYxV2OBSbaD8EZN5cginCsrYTgOjdM4QKdYUIuFg98Uy9rIiq86KTzZr3aNMnPompXM o4PlL2aXf+nr7sy35weX9/cG+HyXMzVt8AAAA X-Change-ID: 20260120-gs_usb-fix-error-message-0b0e3f83391c To: Vincent Mailhol Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Jakub Kicinski , Marc Kleine-Budde X-Mailer: b4 0.15-dev-47773 X-Developer-Signature: v=1; a=openpgp-sha256; l=1692; i=mkl@pengutronix.de; h=from:subject:message-id; bh=NMjz6QW82APUPZl8CmhkRZvslMCCC/6N8F6HTClBBj0=; b=owEBbQGS/pANAwAKAQx0Zd/5kJGcAcsmYgBpb3qQrOd5okeMSn/3Vv5n9cVU0L3AXHdftHhJO TKzWchJxkCJATMEAAEKAB0WIQSf+wzYr2eoX/wVbPMMdGXf+ZCRnAUCaW96kAAKCRAMdGXf+ZCR nMHKB/98djy9/lvCgiLDe8btY0W8DaEB/D5Mh2+aeP1eJjAi6VjFT8imS3mGKN/MBoxpKcV6QaH xvBo92LFBtACurJEZQh7buPmcKV37Xwa/CISshSXmrbCA3cgVPFcCwp+bNKmBhurtmW1L5xRh7A UxndPn1exUe55gIaU+7DarFhTDID5njxtDRjVTLWiblx8KH0UC0GZMDCzutJfz3ghs22wORENgE MCDT+uxzhzP1dbn8trPqtumdGf0to6B/KmuAnhLuajRggKMGXSgyKIgSRTpYzQCrLIAhyorY5u1 oDtHwvqVELEDVt6yda/wz96LPdHJEY4Xdr3z4CfXIH69WZuJ X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sinc commit 79a6d1bfe114 ("can: gs_usb: gs_usb_receive_bulk_callback(): unanchor URL on usb_submit_urb() error") a failing resubmit URB will print an info message. In the case of a short read where netdev has not yet been assigned, initialize as NULL to avoid dereferencing an undefined value. Also report the error value of the failed resubmit. Fixes: 79a6d1bfe114 ("can: gs_usb: gs_usb_receive_bulk_callback(): unanchor= URL on usb_submit_urb() error") Reported-by: Jakub Kicinski Closes: https://lore.kernel.org/all/20260119181904.1209979-1-kuba@kernel.or= g/ Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/gs_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c index 192338b481f2..d8b2dd74b3a1 100644 --- a/drivers/net/can/usb/gs_usb.c +++ b/drivers/net/can/usb/gs_usb.c @@ -610,7 +610,7 @@ static void gs_usb_receive_bulk_callback(struct urb *ur= b) { struct gs_usb *parent =3D urb->context; struct gs_can *dev; - struct net_device *netdev; + struct net_device *netdev =3D NULL; int rc; struct net_device_stats *stats; struct gs_host_frame *hf =3D urb->transfer_buffer; @@ -768,7 +768,7 @@ static void gs_usb_receive_bulk_callback(struct urb *ur= b) } } else if (rc !=3D -ESHUTDOWN && net_ratelimit()) { netdev_info(netdev, "failed to re-submit IN URB: %pe\n", - ERR_PTR(urb->status)); + ERR_PTR(rc)); } } =20 --- base-commit: 58bae918d73e3b6cd57d1e39fcf7c75c7dd1a8fe change-id: 20260120-gs_usb-fix-error-message-0b0e3f83391c Best regards, -- =20 Marc Kleine-Budde