From nobody Sat Feb 7 22:21:34 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05C142DB7AF; Mon, 19 Jan 2026 20:42:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768855321; cv=none; b=hfRaq4RP+hhKQCbEx1whTZuYOS6lMw4bUWRHVmYzQyFwn5gvcMfE6MM7lbVUbX34WN2SUEtCVZ+A4Y8sAG/3qCjXWrKI+ErFuG5t/X+ITvrAm2X4a0duZ5hPm20aL4HpBSxORP9xNBlKF0OUrJPp5dLfEDVUOMP8MvQ6LUwQotM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768855321; c=relaxed/simple; bh=wK7kwTXUEiZv21y6ZXZQd3Cigz4S8TqeTbOgdka3mGA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qdkUy6rMJ1+W2m309uBTmBrSu8+8OD0EufCGpmay0+wTtccMeHL3X1AStWSbQzUdsumRTFje0D7YssJegCRfsENE5/dgwgM8QibDZ8TxyYFky8a6QqsxsxCO/m7PCQy1bHfC+7Qsql53K6/H9oCR9b4clesr7kG16bxb9Nnykp0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GbRz+9D9; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GbRz+9D9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768855321; x=1800391321; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=wK7kwTXUEiZv21y6ZXZQd3Cigz4S8TqeTbOgdka3mGA=; b=GbRz+9D9XH4IQZkbhcEMdJxgoE5IuPK0DJS6SXhg0DoyBcoCq2H+3oXm l0jx/CqCGX/6XBIN/+buxTf1DDjUN1vUK3vi14SIslBnJMTYUgCkt3pLx le/RAMpy5/FclxfsWLZu988dCaS3SiV3EE9RscjGkd15LgSP28FN3vHBh Vj3d+03DVtPHkIimKOC39GV7KW3mXqCjlFy+FJE+V14laN4imXl+csCng SZX6yQqJBobf8u/ot3Z0nH44diXcVZNDbPvhr2rRb21mv8oyVzPGmbpg3 ni5C4MxuDAsMu3wVeaRDo0PYhraexPF4bRyztekerzjUGRYqcG5OhWavr g==; X-CSE-ConnectionGUID: 8oizC8QgQ3G2S4kP0ucUfw== X-CSE-MsgGUID: 7RiOtHCeTqKU4CeKDL4spQ== X-IronPort-AV: E=McAfee;i="6800,10657,11676"; a="70230318" X-IronPort-AV: E=Sophos;i="6.21,238,1763452800"; d="scan'208";a="70230318" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2026 12:41:58 -0800 X-CSE-ConnectionGUID: IWnn+rC8TMaLjZVkYQI8dA== X-CSE-MsgGUID: TnWgMIr1QU6BhkTBkwIUwg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,238,1763452800"; d="scan'208";a="236620588" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa002.jf.intel.com with ESMTP; 19 Jan 2026 12:41:55 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 2CA2099; Mon, 19 Jan 2026 21:41:54 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , Christian Brauner , Petr Mladek , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: Al Viro , Jan Kara , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton , David Disseldorp Subject: [PATCH v1 1/4] initramfs: Sort headers alphabetically Date: Mon, 19 Jan 2026 21:38:38 +0100 Message-ID: <20260119204151.1447503-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260119204151.1447503-1-andriy.shevchenko@linux.intel.com> References: <20260119204151.1447503-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Sorting headers alphabetically helps locating duplicates, and makes it easier to figure out where to insert new headers. Signed-off-by: Andy Shevchenko --- init/initramfs.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/init/initramfs.c b/init/initramfs.c index 6ddbfb17fb8f..750f126e19a0 100644 --- a/init/initramfs.c +++ b/init/initramfs.c @@ -1,25 +1,25 @@ // SPDX-License-Identifier: GPL-2.0 -#include #include -#include -#include -#include -#include -#include #include -#include #include -#include -#include +#include +#include #include +#include +#include +#include #include #include #include #include -#include -#include -#include #include +#include +#include +#include +#include +#include +#include +#include =20 #include "do_mounts.h" #include "initramfs_internal.h" --=20 2.50.1 From nobody Sat Feb 7 22:21:34 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 910E4296BAF; Mon, 19 Jan 2026 20:41:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768855320; cv=none; b=pSbK3cCun7W1i3iNpiXFzJDL2skQaIkXYvx1qUfA8Sp3h42GA1+Y4U1riyaMezV7iNDyR9lT/Lk2UJAx4UO2Ll65orFy7DaAB+yPs9sA8ucEpEEJ7Hu9zfyuJeZojqA/EUczz4sZjErQqPQJjMSRJxjP67qASEtlG6mY6oLHm4M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768855320; c=relaxed/simple; bh=5Q6XCjEsARYIYUYKlBepTkKJq5PGeWKS2tjnPAaYDOo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fBqi/NTzSuSyKLoZRrCa2ypwnEmPVu+8nsdoe82I4Oe1WY+hPgSWOqq2EhGQmxC7DpHkRNwlk9TcLZH8t4CryPrIHsXR0SoaSyWp/DGqaI0g2eQtdodPVxLSFM1JcObRlORiGPja4V875VLCLT9QFzUTyCxtQiJVEW2t9ZBOi+A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=bTNqI2DA; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bTNqI2DA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768855319; x=1800391319; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5Q6XCjEsARYIYUYKlBepTkKJq5PGeWKS2tjnPAaYDOo=; b=bTNqI2DAvoLKLDzlWKDzmk5YlsxoEVSylcTbpbiX027CmBw/bTxfvLWs PbW+uWRkIXXjI88KEeen1vnIOlLQbwxpjPVra5YdVbHgflvdrDMFzHTwB DxrS7fA2qNNP3nAWSK0jWCQ9vEDWzzs0PzoAHuwcbHq2mDsuv8WHawQ/3 cmBhW5MqwizJdYzqhEVqLx3MDOMO6ysqFdWQ87gKngBp6j7UqNl0SpH5Y 9JFRlVM5kQKX8eAUxFtzaeqYuzoBrZ2MoFFtQ8jYtl3nqBD5bWuX5h3nv +8vRpr/1sm88//eOiLV/wAVukODCBUGjYQESlnWIsPeLnVYMD36uHEU8S w==; X-CSE-ConnectionGUID: 1Wbd7JuaSceXLZp1x2d4Qg== X-CSE-MsgGUID: Ryu2CYzPTQSzh4SdX8Bi6g== X-IronPort-AV: E=McAfee;i="6800,10657,11676"; a="73695304" X-IronPort-AV: E=Sophos;i="6.21,238,1763452800"; d="scan'208";a="73695304" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2026 12:41:58 -0800 X-CSE-ConnectionGUID: CNxJ7ThpSvWV//vb1F/JQQ== X-CSE-MsgGUID: Hu0VLnLBRp2QdDBaHrQzRw== X-ExtLoop1: 1 Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa003.fm.intel.com with ESMTP; 19 Jan 2026 12:41:55 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 30A699B; Mon, 19 Jan 2026 21:41:54 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , Christian Brauner , Petr Mladek , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: Al Viro , Jan Kara , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton , David Disseldorp Subject: [PATCH v1 2/4] initramfs: Refactor to use hex2bin() instead of custom approach Date: Mon, 19 Jan 2026 21:38:39 +0100 Message-ID: <20260119204151.1447503-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260119204151.1447503-1-andriy.shevchenko@linux.intel.com> References: <20260119204151.1447503-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is a simple_strntoul() function used solely as a shortcut for hex2bin() with proper endianess conversions. Replace that and drop the unneeded function in the next changes. Signed-off-by: Andy Shevchenko --- init/initramfs.c | 36 ++++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/init/initramfs.c b/init/initramfs.c index 750f126e19a0..8d931ad4d239 100644 --- a/init/initramfs.c +++ b/init/initramfs.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include #include @@ -21,6 +22,8 @@ #include #include =20 +#include + #include "do_mounts.h" #include "initramfs_internal.h" =20 @@ -192,24 +195,25 @@ static __initdata u32 hdr_csum; =20 static void __init parse_header(char *s) { - unsigned long parsed[13]; - int i; + __be32 header[13]; + int ret; =20 - for (i =3D 0, s +=3D 6; i < 13; i++, s +=3D 8) - parsed[i] =3D simple_strntoul(s, NULL, 16, 8); + ret =3D hex2bin((u8 *)header, s + 6, sizeof(header)); + if (ret) + error("damaged header"); =20 - ino =3D parsed[0]; - mode =3D parsed[1]; - uid =3D parsed[2]; - gid =3D parsed[3]; - nlink =3D parsed[4]; - mtime =3D parsed[5]; /* breaks in y2106 */ - body_len =3D parsed[6]; - major =3D parsed[7]; - minor =3D parsed[8]; - rdev =3D new_encode_dev(MKDEV(parsed[9], parsed[10])); - name_len =3D parsed[11]; - hdr_csum =3D parsed[12]; + ino =3D be32_to_cpu(header[0]); + mode =3D be32_to_cpu(header[1]); + uid =3D be32_to_cpu(header[2]); + gid =3D be32_to_cpu(header[3]); + nlink =3D be32_to_cpu(header[4]); + mtime =3D be32_to_cpu(header[5]); /* breaks in y2106 */ + body_len =3D be32_to_cpu(header[6]); + major =3D be32_to_cpu(header[7]); + minor =3D be32_to_cpu(header[8]); + rdev =3D new_encode_dev(MKDEV(be32_to_cpu(header[9]), be32_to_cpu(header[= 10]))); + name_len =3D be32_to_cpu(header[11]); + hdr_csum =3D be32_to_cpu(header[12]); } =20 /* FSM */ --=20 2.50.1 From nobody Sat Feb 7 22:21:34 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6073F2F690D; Mon, 19 Jan 2026 20:42:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768855321; cv=none; b=F3DvsFIhlfz4CuUHrgf94SWTh8t8zvYpFUmKOgdXN0rssLnFlLb4wMyOlgEaGzF9bT+iwreHzwI58UOqelQvELYcjZeyODfzs5CdxF0WiPVUNl3deXgTO2oHTlrWebzkK0f/tSvbudOgbHPTA2otAhOgvV9DVeINDwhbEG0Uwj0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768855321; c=relaxed/simple; bh=FTuuK2lbsKxW1TqNcpwiwlVgmoiY1ioRmAfUVOmsQ34=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gJEcZz3rLdvdAOZ+PhaA+0h/OrO/P8gqAeHej9aT+MFwUc7NnLXDLBp3egKPcVwc1HVF2PCjzrKnlfya8Vel6Zgkp3PAiW4O5QiGQeu2MXgT9VnzoVzYAXcd19NIVO6BkID+QutBqB2XjThWZZnFLG3a0NzXg0xLHu+i2v7DqCY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gOAB6xdI; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gOAB6xdI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768855321; x=1800391321; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FTuuK2lbsKxW1TqNcpwiwlVgmoiY1ioRmAfUVOmsQ34=; b=gOAB6xdIYtVr6+4tewnylRRff2iJTS6vWAmhwLxK8bFvEki+ETJhvCFJ 7Wlw9jQKghEeHgUSPyYqwHtKU9diuC3YYJSA8HFX6Jh/FqdA4oCcG4RYU MCZ2czFKH3qhzg7xjuvBLA79KcHQunnacQvhcBvsxNMGWxoYJaSbNUB2k 5T7M8RDYYZ2wWbR4vUnekXOfV4i/ZLNaVDLrxn0kSHD5p849kMgPr7+6/ WU/+ZYL3AQ2E7z6F3UekVcyvs/nHUMoeSDg3PBzv5abhOoz0pnzvRroOh B5aT2Z5gA1OZGvMGD1hTPQfab5/4Xtwo68vdm2u7yZ3fDK21tAGxysA/r A==; X-CSE-ConnectionGUID: nyaeEUIOSKy5Be5t5ltPxQ== X-CSE-MsgGUID: 0WZnAGuBS3SKR1kKboB4ow== X-IronPort-AV: E=McAfee;i="6800,10657,11676"; a="70230329" X-IronPort-AV: E=Sophos;i="6.21,238,1763452800"; d="scan'208";a="70230329" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2026 12:41:59 -0800 X-CSE-ConnectionGUID: n4zaTZTMQLS5I5QZZCbd1g== X-CSE-MsgGUID: tCEdBISeQ3KKML7ycrMaZA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,238,1763452800"; d="scan'208";a="236620587" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa002.jf.intel.com with ESMTP; 19 Jan 2026 12:41:55 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 353BB9D; Mon, 19 Jan 2026 21:41:54 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , Christian Brauner , Petr Mladek , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: Al Viro , Jan Kara , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton , David Disseldorp Subject: [PATCH v1 3/4] vsprintf: Revert "add simple_strntoul" Date: Mon, 19 Jan 2026 21:38:40 +0100 Message-ID: <20260119204151.1447503-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260119204151.1447503-1-andriy.shevchenko@linux.intel.com> References: <20260119204151.1447503-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" No users anymore and none should be in the first place. This reverts commit fcc155008a20fa31b01569e105250490750f0687. Signed-off-by: Andy Shevchenko --- include/linux/kstrtox.h | 1 - lib/vsprintf.c | 7 ------- 2 files changed, 8 deletions(-) diff --git a/include/linux/kstrtox.h b/include/linux/kstrtox.h index 6ea897222af1..7fcf29a4e0de 100644 --- a/include/linux/kstrtox.h +++ b/include/linux/kstrtox.h @@ -143,7 +143,6 @@ static inline int __must_check kstrtos32_from_user(cons= t char __user *s, size_t */ =20 extern unsigned long simple_strtoul(const char *,char **,unsigned int); -extern unsigned long simple_strntoul(const char *,char **,unsigned int,siz= e_t); extern long simple_strtol(const char *,char **,unsigned int); extern unsigned long long simple_strtoull(const char *,char **,unsigned in= t); extern long long simple_strtoll(const char *,char **,unsigned int); diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 800b8ac49f53..52ea14a08d3a 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -129,13 +129,6 @@ unsigned long simple_strtoul(const char *cp, char **en= dp, unsigned int base) } EXPORT_SYMBOL(simple_strtoul); =20 -unsigned long simple_strntoul(const char *cp, char **endp, unsigned int ba= se, - size_t max_chars) -{ - return simple_strntoull(cp, endp, base, max_chars); -} -EXPORT_SYMBOL(simple_strntoul); - /** * simple_strtol - convert a string to a signed long * @cp: The start of the string --=20 2.50.1 From nobody Sat Feb 7 22:21:34 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B7AD2F28EF; Mon, 19 Jan 2026 20:42:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768855321; cv=none; b=E5OPCRVKuojIH/0QxLn4uLytHb/BUOC68WcvZdOdmbmtfE41ssfHi3/0ojGgQIUwM+oGf6cp/sJ84CM9ENyxtyUQQlh9XhCoWGciDVIHnRLrvZ9yKb5Q8RR06NEHGJWV4ltlaO+8Mzgj8XRnNjTIedB7U5GdPGawjwyerpWxLr8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768855321; c=relaxed/simple; bh=VUhri3d7VyauDsHJzIbJLk+19FEXBT199psKUOzW3cI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GMldFRnBf8ume286lxicct+YuGZb9SaolFTKnxdX65UMNvKQfsPN/KwQCO1bybDnWAHiCIMDab+ZKkLEXqg19/tm0JkrFQsIY8yg6Y2vPVkbADoob/YmEdxP7uVz/MhXY1cj5C77XxwnmjgRNHyKuXYEQ2TTyjtCJBjTQibjmXo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=m3tohigi; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="m3tohigi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768855321; x=1800391321; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VUhri3d7VyauDsHJzIbJLk+19FEXBT199psKUOzW3cI=; b=m3tohigiBFQVfCxJnaRB12Jhjlpk4j3mrT4WFauohQmDhOBxmZqkK6MB gopo8WCc8/UF2RMtwLxlgv3Gnw24X9hG1dMa9PZCIT5L7IfF5V6d+EX9s 4GEc1zM32ktxM3KuQY3weaCOqCt0UUpdms/9fFcca+2lpygksypJYlTED WvOVX396nyb4Y/Z452pMW5K9KNi6F4ztBKaz+XHjHVE3Vbu+rvAWn+p8P yaw8X8r/xKEXCIX2YoFwj+iEzdevumsuqAfE4V+mOqLD006vn6ptQdaP/ OjcqG1t9YoeNumlWJt5H5ZGXYmFWQ/DRcs76CjVkUgiQ1lqFVMLJlRZJO A==; X-CSE-ConnectionGUID: KvwBKGbiTmeMRmmyE14qZA== X-CSE-MsgGUID: ZsGlXU00Sm+vsFNLiIBMog== X-IronPort-AV: E=McAfee;i="6800,10657,11676"; a="73695310" X-IronPort-AV: E=Sophos;i="6.21,238,1763452800"; d="scan'208";a="73695310" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2026 12:41:59 -0800 X-CSE-ConnectionGUID: HXrRidrqRPqbAUxLLH27HA== X-CSE-MsgGUID: FKpgtP8JQUOt3UH89k2mWA== X-ExtLoop1: 1 Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa003.fm.intel.com with ESMTP; 19 Jan 2026 12:41:55 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 39A479E; Mon, 19 Jan 2026 21:41:54 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , Christian Brauner , Petr Mladek , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: Al Viro , Jan Kara , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton , David Disseldorp Subject: [PATCH v1 4/4] kstrtox: Drop extern keyword in the simple_strtox() declarations Date: Mon, 19 Jan 2026 21:38:41 +0100 Message-ID: <20260119204151.1447503-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260119204151.1447503-1-andriy.shevchenko@linux.intel.com> References: <20260119204151.1447503-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is legacy 'extern' keyword for the exported simple_strtox() function which are the artefact that can be removed. So drop it. While at it, tweak the declaration to provide parameter names. Signed-off-by: Andy Shevchenko --- include/linux/kstrtox.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/kstrtox.h b/include/linux/kstrtox.h index 7fcf29a4e0de..6c9282866770 100644 --- a/include/linux/kstrtox.h +++ b/include/linux/kstrtox.h @@ -142,9 +142,9 @@ static inline int __must_check kstrtos32_from_user(cons= t char __user *s, size_t * Keep in mind above caveat. */ =20 -extern unsigned long simple_strtoul(const char *,char **,unsigned int); -extern long simple_strtol(const char *,char **,unsigned int); -extern unsigned long long simple_strtoull(const char *,char **,unsigned in= t); -extern long long simple_strtoll(const char *,char **,unsigned int); +unsigned long simple_strtoul(const char *cp, char **endp, unsigned int bas= e); +long simple_strtol(const char *cp, char **endp, unsigned int base); +unsigned long long simple_strtoull(const char *cp, char **endp, unsigned i= nt base); +long long simple_strtoll(const char *cp, char **endp, unsigned int base); =20 #endif /* _LINUX_KSTRTOX_H */ --=20 2.50.1