From nobody Sun Feb 8 05:59:47 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B598628466D for ; Mon, 19 Jan 2026 16:08:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768838908; cv=none; b=sxn1Ppy0wEq3J+AkzD2DQ42lLwgIGAc2XDDlIj09KbgZR3H4uGdG9kpok4rXX2sVpqWVFkeCUa84+jSygaxOcHqYLfm65sOh1FVardok6qfTgqretp9fGMpP7d6c2q5X3RKiJFFMsXx1E77kPQPRNI6rWjNi5CVkK6Nljxr5Fz0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768838908; c=relaxed/simple; bh=F7zYr1/Lw5722rlFffY20iAOuz07Wmj5fhMcJSroAco=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MF7WHo03jdSsyTZAwAVsVuGx50bYDIh90T/vDNooBCza8QaX0flWm3eMlbGarlJOdQqHnNZrTjA8JqHopLBDuck70B0YthzLSAt+dbAVV4+yPtCiTMSUfNh4qYL5vRxC7dTpyVElcCilCGMt8CSgPt51nmLdrp8xLnp5q9S3ptc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lo3Qt7da; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lo3Qt7da" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-81e8a9d521dso2636874b3a.2 for ; Mon, 19 Jan 2026 08:08:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768838906; x=1769443706; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=R21ZqxoWB5P1YvOncSffb6UWp294VxNKOVm4tYrHNOM=; b=lo3Qt7daK4iYdYvchqGkGuIqtFLGzQRdpp8Ejvi2OJEoKHoXOY488xjhkPj1feU3N0 nSd0lwGJAKL+KMwgx2hSLAnnR+tSNK2atZVN70xm9TZCrp0eLivdhzHqpLyEL0dh66uQ 5iiTEqgUVPC87pE26MUAI05LDNxtmsmDmLClglt8kYpaNzylKRKOi+rCZ02DrkzgpTfd 5l9UHRcY5N3MC6dwtS06D8TTbeBWy+UqQGM5NEVQwQxniDOCX518FWVbBP4J039WX9k2 j/0QpbA7v73KmHgQX7uZZr8JNYRQSsTNdhI3YczrM/bLMuMhnvxz/sVOMKpp0evGsXEF sI/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768838906; x=1769443706; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R21ZqxoWB5P1YvOncSffb6UWp294VxNKOVm4tYrHNOM=; b=hT4D2EWW9j1QN+JrmxNXxslZu2FBh8u9Gq00FKCmHLb0iGSOfjv4jY4SpyQhqo4fld CeqesLDNG5BD5l19KJ1+6r+kl7FfOMkgm0lAauLoRI2fpg5LWqHADlltwP83rY0jun85 oAqayhLsHif+r6TxlpBPEDwVQ667welWybIwCtkq8WaV9vzpnF1j2AfuiZFgIVlaFWtV 5V4A8fLIGjv2NEmJH5FADt4MyW6+3WzRsNqAqrGzXU0wT9Y6/wvpdZSuGarZCb/YWBQN xpvoMKoOEotpCriegStR0/pDtoFeaDG8z0xJG+DBj2o3wE//Hu9uFIcpjZXZOdwTuNhr OLeA== X-Forwarded-Encrypted: i=1; AJvYcCV7vfJM/at4xBB6b1m0kOvOwJPGXpK1XZS9oFkNGmy3w50U1q1ceHwOdxLjrD3XtR2IALS/n8Dzuqar6Zc=@vger.kernel.org X-Gm-Message-State: AOJu0YwfWkmHU8AStXazU2DZwmSmLMUN4CB1AdYVA6dWX4apDgaWFY5U JHwhqotzr/T/juCBDEQMmMwpmsbw+60vBrPvmM5YAuTjznyO/FdLUMc3 X-Gm-Gg: AY/fxX4xdE6pJqpFxAQcvvGv+51BUMET8xvvcPdzYhPGUMQqa/nsjQuUZJtLTyplwUH FpnONlwfkdhN79x7A+ZFBGW9EKFCWz6IoB+7AlpLbY9JjuIiyIvQW5ixFWmRvcNR/Nk5QaxPud1 wkrbVQPZchYzQSN8XSForu308bClOnHPdw5Hfkc2JmRX5X2q2SH0qOBlebiRwQz6TpZqk0aH5N5 sPxC15yFwqiOq0ZFK9a5Izw2Sn7vwtMjBq4iK9zBoNdnf8aGDXzgI0iJIxghhAQHBKlSFsGHpeb Kyl/HbpSgMDN89GAPEfTRCr+GpxKLLEhWYXwQzf1LowXY6WvVDBXZ70Ib3M04+K1eSPCRqziHg2 0SxiEk6lD/Do49/OZJ/KuVNQj0BuY6idIr0ZHK62LXuHu3932rzQMHTqxil9cZ4R08tf9FnQ3tU adn1Rz4TC86prUHun26jHSTAJDdTldLShoCRSJZK5jFLUgQXKN3EDUVA== X-Received: by 2002:a05:6a21:3984:b0:364:13ca:3702 with SMTP id adf61e73a8af0-38e00d1572cmr8299751637.42.1768838905918; Mon, 19 Jan 2026 08:08:25 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c5edf251a6csm9509094a12.13.2026.01.19.08.08.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 08:08:24 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Jian Shen , Salil Mehta , Jijie Shao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Huazhong Tan , Yunsheng Lin , Peng Li , linux-kernel@vger.kernel.org Subject: [PATCH net] net: hns3: fix data race in hns3_fetch_stats Date: Tue, 20 Jan 2026 00:07:37 +0800 Message-ID: <20260119160759.1455950-1-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In hns3_fetch_stats(), ring statistics, protected by u64_stats_sync, are read and accumulated in ignorance of possible u64_stats_fetch_retry() events. These statistics are already accumulated by hns3_ring_stats_update(). Fix this by reading them into a temporary buffer first. Fixes: b20d7fe51e0d ("net: hns3: add some statitics info to tx process") Signed-off-by: David Yang --- .../net/ethernet/hisilicon/hns3/hns3_enet.c | 69 ++++++++++--------- 1 file changed, 36 insertions(+), 33 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/= ethernet/hisilicon/hns3/hns3_enet.c index 7b9269f6fdfc..a47464a22751 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -2530,44 +2530,47 @@ static netdev_features_t hns3_features_check(struct= sk_buff *skb, static void hns3_fetch_stats(struct rtnl_link_stats64 *stats, struct hns3_enet_ring *ring, bool is_tx) { + struct ring_stats ring_stats; unsigned int start; =20 do { start =3D u64_stats_fetch_begin(&ring->syncp); - if (is_tx) { - stats->tx_bytes +=3D ring->stats.tx_bytes; - stats->tx_packets +=3D ring->stats.tx_pkts; - stats->tx_dropped +=3D ring->stats.sw_err_cnt; - stats->tx_dropped +=3D ring->stats.tx_vlan_err; - stats->tx_dropped +=3D ring->stats.tx_l4_proto_err; - stats->tx_dropped +=3D ring->stats.tx_l2l3l4_err; - stats->tx_dropped +=3D ring->stats.tx_tso_err; - stats->tx_dropped +=3D ring->stats.over_max_recursion; - stats->tx_dropped +=3D ring->stats.hw_limitation; - stats->tx_dropped +=3D ring->stats.copy_bits_err; - stats->tx_dropped +=3D ring->stats.skb2sgl_err; - stats->tx_dropped +=3D ring->stats.map_sg_err; - stats->tx_errors +=3D ring->stats.sw_err_cnt; - stats->tx_errors +=3D ring->stats.tx_vlan_err; - stats->tx_errors +=3D ring->stats.tx_l4_proto_err; - stats->tx_errors +=3D ring->stats.tx_l2l3l4_err; - stats->tx_errors +=3D ring->stats.tx_tso_err; - stats->tx_errors +=3D ring->stats.over_max_recursion; - stats->tx_errors +=3D ring->stats.hw_limitation; - stats->tx_errors +=3D ring->stats.copy_bits_err; - stats->tx_errors +=3D ring->stats.skb2sgl_err; - stats->tx_errors +=3D ring->stats.map_sg_err; - } else { - stats->rx_bytes +=3D ring->stats.rx_bytes; - stats->rx_packets +=3D ring->stats.rx_pkts; - stats->rx_dropped +=3D ring->stats.l2_err; - stats->rx_errors +=3D ring->stats.l2_err; - stats->rx_errors +=3D ring->stats.l3l4_csum_err; - stats->rx_crc_errors +=3D ring->stats.l2_err; - stats->multicast +=3D ring->stats.rx_multicast; - stats->rx_length_errors +=3D ring->stats.err_pkt_len; - } + ring_stats =3D ring->stats; } while (u64_stats_fetch_retry(&ring->syncp, start)); + + if (is_tx) { + stats->tx_bytes +=3D ring_stats.tx_bytes; + stats->tx_packets +=3D ring_stats.tx_pkts; + stats->tx_dropped +=3D ring_stats.sw_err_cnt; + stats->tx_dropped +=3D ring_stats.tx_vlan_err; + stats->tx_dropped +=3D ring_stats.tx_l4_proto_err; + stats->tx_dropped +=3D ring_stats.tx_l2l3l4_err; + stats->tx_dropped +=3D ring_stats.tx_tso_err; + stats->tx_dropped +=3D ring_stats.over_max_recursion; + stats->tx_dropped +=3D ring_stats.hw_limitation; + stats->tx_dropped +=3D ring_stats.copy_bits_err; + stats->tx_dropped +=3D ring_stats.skb2sgl_err; + stats->tx_dropped +=3D ring_stats.map_sg_err; + stats->tx_errors +=3D ring_stats.sw_err_cnt; + stats->tx_errors +=3D ring_stats.tx_vlan_err; + stats->tx_errors +=3D ring_stats.tx_l4_proto_err; + stats->tx_errors +=3D ring_stats.tx_l2l3l4_err; + stats->tx_errors +=3D ring_stats.tx_tso_err; + stats->tx_errors +=3D ring_stats.over_max_recursion; + stats->tx_errors +=3D ring_stats.hw_limitation; + stats->tx_errors +=3D ring_stats.copy_bits_err; + stats->tx_errors +=3D ring_stats.skb2sgl_err; + stats->tx_errors +=3D ring_stats.map_sg_err; + } else { + stats->rx_bytes +=3D ring_stats.rx_bytes; + stats->rx_packets +=3D ring_stats.rx_pkts; + stats->rx_dropped +=3D ring_stats.l2_err; + stats->rx_errors +=3D ring_stats.l2_err; + stats->rx_errors +=3D ring_stats.l3l4_csum_err; + stats->rx_crc_errors +=3D ring_stats.l2_err; + stats->multicast +=3D ring_stats.rx_multicast; + stats->rx_length_errors +=3D ring_stats.err_pkt_len; + } } =20 static void hns3_nic_get_stats64(struct net_device *netdev, --=20 2.51.0