From nobody Sun Feb 8 02:56:04 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C19A37E2F8 for ; Mon, 19 Jan 2026 15:35:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768836929; cv=none; b=BA2gDyeJS7+F0PXHnN+gBrtnwFcSFr90iLLVDSSL7a/H/k77KU/y2vtPqxfBGGyonpKZQ/PhBAPaa+plwp1oUDzlHm2r18svn1WHq29VqLuWoZKxjCqpX0L6gzdS8WVULSNmpdXBMOnqxijSrTvPB5icsmiAaHKamq9esHofyFI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768836929; c=relaxed/simple; bh=ANxeWm8qe9YMWOTnYYf0JGWyOXcfAn/iIUIToXjjCS0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JUWrZaw/X1QNQfrI4OA3LeHMlsPBy5KOJFpItk0K5wswZ0fTUpkHYuqScv5yno6ze6TACIg1ezEWhkYAiioPOeKzbNRv1KZ2Mou3PXMSaGo4Sf/4hRWI2t2Ks8DZBeKTgwARSVaNRJwe22/zdJVzYuCqPn/FTFU/hDVqjmJNfbQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HHiDpr6F; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HHiDpr6F" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2a09d981507so33623945ad.1 for ; Mon, 19 Jan 2026 07:35:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768836926; x=1769441726; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1vJ5eVw9QUDTsNOtQAd/rmkbee4hLGoma0JU12f0lc8=; b=HHiDpr6FgoXjF2qKLmYD53LN/Sxa9tNPbbTc1nGqX5gGEkUZ+XaN3WxI8w/+bhA2p8 ncw07DAS+8UYgIdtW2PP/AMP9tLdS+/rxtkrlr3axqWcgkOWuJPP4oPT9X6oOaXtyyAB jBpJNzn6TfWHWLwJ1Tf4EpUzEhVV1NOZCTF/LHaNNnzCR7t1qEIItaGhw69Uqvvd113c qjEJ5h/SWlQR7pzyxf7f0g5Al1qzyc8mC227ogGMgFDzm8Pjuvvv3Ad6x9NkPwg+gwOE +Tvg0lwBgpMx22al6Q5yX3Iazdds4iMGjNvSZELo7pM/oRzgIhCoZqqnrSsJWtdQvImK HTvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768836926; x=1769441726; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1vJ5eVw9QUDTsNOtQAd/rmkbee4hLGoma0JU12f0lc8=; b=OX6vJzdbclpWt/u1eh7opumgeNMWU5XoehdbtV4lOrXwFGz1sZy1hJ4qwoUNfD8QEh XPcphD00S0XqSl/D3DlX5WnJdtrYyFTf0P5dFm4nCCXaLfaH/lH5GQ6nVMCZppiZ0hjU oPpugCdXEMk5vL3Oip3Q6DsurCl6g10r3aZoRzl/yK8kdrIj3hDWZGo9Uwl1iXDFEQ+J vCJnWugB8eqmfarfdS0Dek9KznsqbjAWj5/N86Ro9YmlGWnA4KhmqnhIscEPkNxjSm4y ddR7zsKpt2Vg4zak7y9VshRX6LXJYigU1JqoUBB+M3ONDZd2GQs4VRWUdum93biwzmNa FnRg== X-Forwarded-Encrypted: i=1; AJvYcCX1KdPX8KdIE0txH3mRpxpK/VRviv6QyWZAQ7j3N3/FH3x5I3BgWvYRwOUkanPE/HEk5W2d4fVxDzhcq3E=@vger.kernel.org X-Gm-Message-State: AOJu0Yxt01qr4PViS26jfx73ga4l7rNoQWI4WKGm3Z5Gnt/xoF/wD/z9 0jNGniKWQtKVUTvLaj4HxQb7Nlkqv3PXTvSzx1OdmCXguUX2qOcT9TSY X-Gm-Gg: AZuq6aIEwDQp2wX1Lz9/lRysi1CZHog8YZDF1TdE1tTD0VDRxm5ecxt17171zMOnP/W bKYfV7ktjtg8b8GExDBD0MaiTo8QaguGjMZdxZVW0INeuUEYiYqFSvBlt47WI24trqkxh3OCTIA OP0Pbaf339mSCxTIQ/Q0Dbf21TOIpey5wc/cEUmzlXXp/vz8c0Z0/tY3KNerdkJimXGKyv943FH shGb4sh6mcQOqrQocfNQwcAsDJl/ozXSyals8jxES7E7CLzURVrGwturpiQ6Hw+PNm5J8Wq0Fe4 CrO34kJGdQUzO6Pix+tdhkPf26c5NjCX4Ips6DF74xDoPGe1385MkbFgUx51Q5C5roW76elM6n7 X8ShoFNv3BDfDMMdaQxP6Y5Bx+2H+rGbuhkRdlOb2mZWYjMD89CaDYvt939i5Sl9mJ9G+j6xavh Vb+rYtyIwuZFmjoJrOnEOJBB3gNzmTbPycsoM7kHAwcyaeEIgZ0eCMYQ== X-Received: by 2002:a17:902:c408:b0:2a0:9a3b:d2a4 with SMTP id d9443c01a7336-2a700990d72mr136181445ad.10.1768836925823; Mon, 19 Jan 2026 07:35:25 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a7190eeefasm97601865ad.43.2026.01.19.07.35.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 07:35:25 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sathya Perla , Padmanabh Ratnakar , linux-kernel@vger.kernel.org Subject: [PATCH net] be2net: fix data race in be_get_new_eqd Date: Mon, 19 Jan 2026 23:34:36 +0800 Message-ID: <20260119153440.1440578-1-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In be_get_new_eqd(), statistics of pkts, protected by u64_stats_sync, are read and accumulated in ignorance of possible u64_stats_fetch_retry() events. Before the commit in question, these statistics were retrieved one by one directly from queues. Fix this by reading them into temporary variables first. Fixes: 209477704187 ("be2net: set interrupt moderation for Skyhawk-R using = EQ-DB") Signed-off-by: David Yang Reviewed-by: Vadim Fedorenko --- drivers/net/ethernet/emulex/benet/be_main.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethe= rnet/emulex/benet/be_main.c index 5bb31c8fab39..995c159003d7 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -2141,7 +2141,7 @@ static int be_get_new_eqd(struct be_eq_obj *eqo) struct be_aic_obj *aic; struct be_rx_obj *rxo; struct be_tx_obj *txo; - u64 rx_pkts =3D 0, tx_pkts =3D 0; + u64 rx_pkts =3D 0, tx_pkts =3D 0, pkts; ulong now; u32 pps, delta; int i; @@ -2157,15 +2157,17 @@ static int be_get_new_eqd(struct be_eq_obj *eqo) for_all_rx_queues_on_eq(adapter, eqo, rxo, i) { do { start =3D u64_stats_fetch_begin(&rxo->stats.sync); - rx_pkts +=3D rxo->stats.rx_pkts; + pkts =3D rxo->stats.rx_pkts; } while (u64_stats_fetch_retry(&rxo->stats.sync, start)); + rx_pkts +=3D pkts; } =20 for_all_tx_queues_on_eq(adapter, eqo, txo, i) { do { start =3D u64_stats_fetch_begin(&txo->stats.sync); - tx_pkts +=3D txo->stats.tx_reqs; + pkts =3D txo->stats.tx_reqs; } while (u64_stats_fetch_retry(&txo->stats.sync, start)); + tx_pkts +=3D pkts; } =20 /* Skip, if wrapped around or first calculation */ --=20 2.51.0