From nobody Sun Feb 8 23:41:22 2026 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A54FC244660 for ; Mon, 19 Jan 2026 12:21:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768825305; cv=none; b=KTl4y5/3JhVTK159WB5q0qC8oHhoPQ7C0uFXWeGY6rEEIEBK+7HISo20gj0muyFmoFSRhnlU3bXeuInuyPtmYEDpNzqXbnr3VW59sb0raBYL1j5SrLQyHso8e1DAlLgQK+dFDyybAV47kJFc+93tHD3LSkbrygYwbjx6CckmO9Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768825305; c=relaxed/simple; bh=Tx69mvC65DOjZMSxdCXvNva3L9SCwkWXxa5G1Zc5JDk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BokQPLL4vQEIgufDCzklaEdvmEx8ydmz0Fc0yWzQkPgCjTfN3IKp2UJCl1JJbiRBbe6AfvYUtpumtAXh+f8jg/kMUwvtaW2uCbyJfnI8CS0kjBwXC1nxqb6Tkuohf0BPWkP1RRq8FNvrugmx9HJoTf3OhMr3caVuR9fk6YNCT3c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h543gYg6; arc=none smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h543gYg6" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-7927b3e5253so33685407b3.1 for ; Mon, 19 Jan 2026 04:21:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768825303; x=1769430103; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4xpUlBJUkRI9BEvvEPmE2BefrFSelS9EOH7w/G+TnZM=; b=h543gYg6/dCw73cTR1zG0Dv5mRuuvf8pST9H8svO9s4+bolJf4YfTJ+gsgZhNP4rbN 6fNHWXeRD581csJzweSUH5UqRPls8Eqoo/AkGkYYukay7jmRD0Tl8FKLziCOESKEd3ZB aHV2S9sGudmyilqSfw5EoIDyDZnrxP2iSx0oVois5mf4d0sCgSNuFjB85/lXfoMkowMv GWh0AC4zdC8yYtFl4txwpjshe5m7b2roYZbDQrhG6kcqXPqXjBx501+JXcQUC8f4Mo3Y zsWBkWVMqH3cgvWYAqJZ76HsayP8yj2pAowYeWAMzFYl8p/xRYaLrYxvtw8uQ5ADoIj8 0B4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768825303; x=1769430103; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4xpUlBJUkRI9BEvvEPmE2BefrFSelS9EOH7w/G+TnZM=; b=Ck5VUqWnugFg+SLlaEOjJAmbYSgQ20WWzeosS88gRqzHvfnnN+JYbgl8wF8X2Z0YmA MWpgO4jF5pYhO1ZLZh686gXBnlpctG+V7UNhZiyv2hjuuwYprLXjzeoskBUudKV0Cr/J S/Y18BbhsdbTkwY8uQSmYE02oyOLn2VVyHYTt1dKbKGsbHD3qNqOubnH4Kae3PuYiok8 wCBxwwMPOSaUS04X2xFC802dh9vrkAOR3BBHAFFs9pgiFOXpOqrYfdTfAOvTypEZx0kc 23jB/81gWFuFoh2pRoMYOACrErYAfZE0/ZOUrwWdcn9gmozoCwjhpZgSqm4jut0UpOUJ SF+Q== X-Forwarded-Encrypted: i=1; AJvYcCVxaeeXdeQv4Q5F6lPtTqPswLwiINX7ekbuZWHgOgW1KQaHK7zlVDojy62jgHYoeV7E3OuOwcHJSMO2ExA=@vger.kernel.org X-Gm-Message-State: AOJu0YzTfiwXQJ5BUN1lhhtBdoQMxYl8hxSh4p4zbX6ssBnXOdG2TjX/ jKozlktnudq2kPsU7xXgIApVAAQYWIHTn9M4eK/gO1syacXoE0NIVnUA X-Gm-Gg: AZuq6aKojtWP9pCEwyugR8PxacRA3FvMi2ZpqV9X/y5vEkMjmRsEt56N1Zc8XGImtB/ QXjbpf/EA0ua3QqE86SFwcCw4WoA+k663hy/KmlupTLJpGAxKqZplWtajoyI4gFYVwXUb8lomOz 3k9Jg8iW1YgmDZUKQ2PE2P/MMsq0QVwkXlV4iaXahoO6IU/DD0wRaootsuOlCE4aI9rH9AL7alC VRPaLWjWxxuRZsatu3CU5NKMkHOY1WKKokygDuwq3vG/oUDRHJ9t3iRsjGZunQGKiULKDj61UXs WzX798Dx/CgdNKAWguOhY6Mi6oNfsbarcyLLNgTdpplTLdR5QrCOfPjg7yCOdys1xGBFTGI4wv/ FRHjcZ99g5ZqMwxRRlC7qSMIDjycJtSNYzvCqJGw629AXpcG3nKHUu7x3r2d76YCBZTvWcQY+66 IqnbXqOnOJdro6IqciA2IvsGcNdEE= X-Received: by 2002:a05:690c:60c7:b0:78c:2473:ae79 with SMTP id 00721157ae682-793c5393a8emr70353737b3.39.1768825302663; Mon, 19 Jan 2026 04:21:42 -0800 (PST) Received: from msi2.sky.cl ([2600:1700:65a1:210::47]) by smtp.gmail.com with ESMTPSA id 00721157ae682-793c66f326bsm39600677b3.19.2026.01.19.04.21.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 04:21:42 -0800 (PST) From: Zhengmian Hu To: john.johansen@canonical.com, john@apparmor.net, apparmor@lists.ubuntu.com Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Zhengmian Hu Subject: [PATCH 1/1] apparmor: avoid per-cpu hold underflow in aa_get_buffer Date: Mon, 19 Jan 2026 07:21:19 -0500 Message-ID: <20260119122119.3648154-2-huzhengmian@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260119122119.3648154-1-huzhengmian@gmail.com> References: <20260119122119.3648154-1-huzhengmian@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Zhengmian Hu --- security/apparmor/lsm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c index 9b6c2f157..a6c884ba6 100644 --- a/security/apparmor/lsm.c +++ b/security/apparmor/lsm.c @@ -1868,7 +1868,8 @@ char *aa_get_buffer(bool in_atomic) if (!list_empty(&cache->head)) { aa_buf =3D list_first_entry(&cache->head, union aa_buffer, list); list_del(&aa_buf->list); - cache->hold--; + if (cache->hold) + cache->hold--; cache->count--; put_cpu_ptr(&aa_local_buffers); return &aa_buf->buffer[0]; --=20 2.52.0