From nobody Sun Feb 8 02:26:11 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5291431690A for ; Mon, 19 Jan 2026 11:45:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768823150; cv=none; b=WXtMlEzvRb34utY+OWw++nza3Trv+tLto2bif2YrYI+hG5bTTdSEZ32lG8chSo4fatXmkmER9DL47QoU/1mLi4CmFnnYL8gFoKzLhhWzfOYYnVn+3XHOthdIVoLKPhDgc9s6PjQbItVWTYdwKaYRyC2IReaPdLemYFcMhauJ+X4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768823150; c=relaxed/simple; bh=MdxPX5vDGx8RVZ3ew+j6WVs+YpCVDTtm7KRBwWIvH8A=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nfR1W2fYk8TrJ9dAnH/etT6XGgO2VtMCwx69jqyXLgGCdXVCXq3ZirFjKYpTA1QIXP4yiJx1/hYuxCg9VsMGJTiL6NGkPtIJxxCWiXi2823C8nYiPE3IqwXXs8vw/riH1JPYXYnxhOts+/lNdwtXfMiO4l43hIr+MHrQQJwIvUc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qzvn8v+F; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qzvn8v+F" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-81f4c0e2b42so2110073b3a.1 for ; Mon, 19 Jan 2026 03:45:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768823149; x=1769427949; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ywd+1igsU00ra/a+wq9SjR4y0NT8aUrg5BsV8nmKV+A=; b=Qzvn8v+FYvfKKRcDP3Vl+wxt3lLtFGSYX04zX6IyfIn4ecpU9GN4xGabbkC0JCcyA6 zgKLiuiwqCsGb4qFkXmF2GoWmHYEBfRNQwxM8xdiLQObWbuDqWr0dnBDp7XyZWu8cpwq 4gPAGAJ7WjHZfj7iGyyJI2iccv1+nslLiKQAHw+w792kcecM8kIibON0RmfkfKgZ1Zo7 Wc9I8wvLXzsiSyi1yV9mcgEeq8rvUWWALlMds5wsgS5FzuOjLplG7PUkyvOgc2imBR+Q JhqAKhV8NDCpbw8/Tt7fv+Rd0C9AV73d6N678lOQBMtO7NnWG51dQZumWBngTXP5YZAd Am0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768823149; x=1769427949; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ywd+1igsU00ra/a+wq9SjR4y0NT8aUrg5BsV8nmKV+A=; b=M0p2LXo/aNYQ3ZAOtXCgW0a2Ly3P/qEpvCPzHB0s90C24BEwLkQnNj284VRFphZmpa EAt9O911uRV+0EJX2uhdkk3XC72mt3h40Dg+X5+nAPANu3njCIxX374iiu6HvHtlSlWN 4JK22kvldKoBPrFdB/T7TN1YbtxihYdIH++OSDjKkLh9wijPK97H8JKzzqAspm5ii6Ef BdmLyCEYepIBW/DhBPpWuPf9RDyxA1pbObMjf7QEdJexGAl8tnUQfRjyedA7cOMPww3Y joiowoSg6MuFliyuofhzRE2TS8eI8ijxn9XOifjpVmTXGUHu638RfMloLB6tdyPOHqEB +v8g== X-Forwarded-Encrypted: i=1; AJvYcCURmCXaGgRJIeY8dMPhulvZ+9AP/ijlRzpX9r7r23Wwb0HS24N2GqmB1vmDwGhj3XURvvCYjtX8VTxswoo=@vger.kernel.org X-Gm-Message-State: AOJu0YyvjSDZhL/18/qE4TIldL4PG+wELHYmZwvKvTvhd7kHv/nCAH23 Er+CrJVtYnWcY4Dnl+d9Bsrysu2mfxiOgjSespzBCP7Qlm7NJOd1ZL3M X-Gm-Gg: AY/fxX4WQ5VHguU9peAghoS3HwBQAdMnofTlyWYrJuC9RCgGTCGDX0OwVAM39/XQxuZ VH2VhO7jBb2W+hmgTY8YJ4n1vwOEwbblmv5LBJ5wLhwQ6sP5slpeKt3Ldbo86PGv2kc3d92TliZ JWAU3MYjHJuKX8tEhPokSedLE463h1xn3us7J6B0WEfM0ScQZUoRo2ddtv/BCCERPARRcbR1KcQ TdQR+Lbd73C3pSR+2dtCJzq1m6NOjUChWKYjcms0GFeoKBXO+LncfL7JBVkWwc5AgJquq7S+wvt hpYoMv7LSRIy3YtRJJcaFvirZ1ROpb5MbXky/2fb9biMftR6I/WP7oz/C7Tjk8TrLImWUS43Hnn 9fD4ht03kSJ8a9grP05zHmFLmSgoxbM9DgDW87Ra+0tfEI/waukiYwa9u6lVwy7fut4IA3ZuRT9 oZBMp8GAwDvgQV0+WVIpEJqCx6ms9IcP0suBrUdaVHxeAYOrQY5WuhbWQgcEKhIXa/SLBHMTL2e aEVc9NyNWL/gkBfVebFchjQE+rSto22UlixhzugpYnTaGM= X-Received: by 2002:a05:6a00:3395:b0:81f:3ed8:fd29 with SMTP id d2e1a72fcca58-81fa01ec37bmr10340752b3a.36.1768823148672; Mon, 19 Jan 2026 03:45:48 -0800 (PST) Received: from c8971f1abf06.ap-southeast-2.compute.internal (ec2-54-252-206-51.ap-southeast-2.compute.amazonaws.com. [54.252.206.51]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81fa108b252sm9127160b3a.7.2026.01.19.03.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 03:45:48 -0800 (PST) From: Weigang He To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Weigang He Subject: [PATCH v2] scripts/tracepoint-update: fix memory leak in add_string() on failure Date: Mon, 19 Jan 2026 11:45:42 +0000 Message-Id: <20260119114542.1714405-1-geoffreyhe2@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When realloc() fails in add_string(), the function returns -1 but leaves *vals pointing to the previously allocated memory. This can cause memory leaks in callers like make_trace_array() that return on error without freeing the partially built array. Fix this by freeing *vals and setting it to NULL when realloc() fails. This makes the error handling self-contained in add_string() so callers don't need to handle cleanup on failure. This bug is found by my static analysis tool and my code review. Signed-off-by: Weigang He --- scripts/tracepoint-update.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/tracepoint-update.c b/scripts/tracepoint-update.c index 90046aedc97b9..5cf43c0aac891 100644 --- a/scripts/tracepoint-update.c +++ b/scripts/tracepoint-update.c @@ -49,6 +49,8 @@ static int add_string(const char *str, const char ***vals= , int *count) array =3D realloc(array, sizeof(char *) * size); if (!array) { fprintf(stderr, "Failed memory allocation\n"); + free(*vals); + *vals =3D NULL; return -1; } *vals =3D array; --=20 2.34.1