From nobody Sat Feb 7 18:21:30 2026 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B8B01E32A2 for ; Mon, 19 Jan 2026 04:05:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768795504; cv=none; b=X2/9jNtELAwjfLlKYkrbmRB2g++/yiZn2GawFVCf2X0dYgcjjfYQgLlixIrs2bis1vW//L7T4luYA9Yy9EmyuRBy6gAx+rU58pZI6IlYkDp5huri/f+ZL9VKxLUhQgjg7hlRgtVowxWjGmMVGtbGitbyH7yPLB9rgnf39e61A60= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768795504; c=relaxed/simple; bh=DP9HAMMwIYto+P5rMnIHFSuOC/aVeMGzuMoS/A+qAX0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Nfs8Cz1DdWhx6s5TR2TrCjMWhaaLcqRACgf2O6dRx8vuXCzv9eaFQUBA+CLim/RSHsUDkADzB0UFJg2wrJbk+TWcihrEgw/s62RTZEbzO1X7O4JHuW41k7PXf0lyaHCeL27b69f8VLspnknpTelPKI9+AcYx9p3vw95B+YaSVpQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XDW0RiOV; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XDW0RiOV" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-121a0bcd376so2780752c88.0 for ; Sun, 18 Jan 2026 20:05:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768795500; x=1769400300; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5VRBT4LITV3AyG+vNWtghFdo8qraq6nhI75e8iz5bbQ=; b=XDW0RiOVMXvo8p1X2wIhbSxpApXlgExegB+tnvKLupPLk/KcQA3K/mz9BTkyFisFwb ib1Bo/S6jbjN6C6Lo4Nu9oMfB+CA2O1wdo+EeHiC2vI+/QnjSzsU6ysHakpZjPW3U0UV tvab1Zgc/bNHr+wEjuOkNX/xQcnUPs98lN7MHTffYl7U+Em6Gaw0VW5oiI5r2n5q5L7n YVUWZC/2/AcgT0ZttxFgMClA9ueSWOVk6AujXqdXSQvjsWu7fDt2YkSV+9nl7rNOWZ6+ 9Kl4t2LAakELTkhL457D1T3J1LOX02tJu225PrSkZYqO/MB93ieNYDQWyR9vC2LJrGEn YLIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768795500; x=1769400300; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5VRBT4LITV3AyG+vNWtghFdo8qraq6nhI75e8iz5bbQ=; b=t3X3jgYqjERQrQavqv0vIwIq6Qd3UxB02+VIb6I7lOevNE0NmV3odPXt4c/9VLlq5q z/mhZTihK8QDiWTx3QbkjMzFdrwDKQkFv/5vqWPUtNSBaDpJ85GTe4tlgYOJaZ11oDsu FI42u655iytaCsKaRswngJ+1D9JFabyUVSQ+PRXHCFVblwdl/pDEA+RmQkf41TJ54V7O yiwKmfoE8h2NRbreot0QVNnBFV0NU5FV3wqd0aSf8PqE+9KGa2Vb2S8GVPiJPtvvhJDl duCzoP7kAz7IN2evN0R5LYZDWgFgw8Hwx2OAlOXc6CH5lwFKP5Cc5zg8ROgoUU4AwMqZ sMOA== X-Forwarded-Encrypted: i=1; AJvYcCWEr14vvm3u4vrudqn96hzaBA+J0Vi00gMsT+w7H3v4Y0h9FWhzx0jnir0AaH+tQtj5Jn/ERsqCk0Rurfw=@vger.kernel.org X-Gm-Message-State: AOJu0YxZfdbxUCL36IYc8/819MamY/8JbGYuGk9wqoLcU/B+O61mB4cp jH7fFWXDkYPAzUKCA+/n8wRB748PwR+tEEvdNUPXannmggrVGZTf9DUV X-Gm-Gg: AY/fxX40Ssy//33/HRrXtfOCThvcxNSyrqIbFZLT5zawS8BY6IYh9PguFNxf60rR373 FvCZs0kAesnXS4g/mdbACuQRD6IgypqRb7obdij6lPgNMmcyMpQJiWXTp3jjf6gz5DuTNH+O7gS 7Ms+fl6EyVkj6Fm4M8rt0jFPBAWg0jZ6WqFScs6qWXfxkI17wrmvUEW9dGsK2GrABwPICrQxyI8 sDTQlU9UVY0YELcy2PCYvCSTuC8o3JXjfBtzDS6ORrQlTl6Ig9pvnnAUmT+RmyfliorRHvYZMkt 5ow9K2ApBMxxxzDpjYvEj07MToJDQgn9ewmbBVqtrxL1njt7Ry5ybrpZYsWvkdfM1AirkSNU1Kj 1sPfUEhAmnqDv4aGW+rte4ZAaKn4e2LIWjdfkRkwmHtwAYjtXJCifidX94pNE7SkBl6/jHQTkKG Y1FA3cb9lsRQ== X-Received: by 2002:a05:7300:8c9f:b0:2b4:5153:42c4 with SMTP id 5a478bee46e88-2b6b411576dmr9318510eec.27.1768795499700; Sun, 18 Jan 2026 20:04:59 -0800 (PST) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6bd8e7cd9sm10406493eec.16.2026.01.18.20.04.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 20:04:59 -0800 (PST) From: Inochi Amaoto To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Joel Stanley Cc: Inochi Amaoto , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li Subject: [PATCH net-next v2 1/2] net: ethernet: litex: use devm_register_netdev() to register netdev Date: Mon, 19 Jan 2026 12:04:44 +0800 Message-ID: <20260119040446.741970-2-inochiama@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260119040446.741970-1-inochiama@gmail.com> References: <20260119040446.741970-1-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use devm_register_netdev to avoid unnecessary remove() callback in platform_driver structure. Signed-off-by: Inochi Amaoto Reviewed-by: Andrew Lunn --- drivers/net/ethernet/litex/litex_liteeth.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ether= net/litex/litex_liteeth.c index 829a4b828f8e..67ad1058c2ab 100644 --- a/drivers/net/ethernet/litex/litex_liteeth.c +++ b/drivers/net/ethernet/litex/litex_liteeth.c @@ -232,6 +232,7 @@ static void liteeth_setup_slots(struct liteeth *priv) =20 static int liteeth_probe(struct platform_device *pdev) { + struct device *dev =3D &pdev->dev; struct net_device *netdev; void __iomem *buf_base; struct liteeth *priv; @@ -282,7 +283,7 @@ static int liteeth_probe(struct platform_device *pdev) =20 netdev->netdev_ops =3D &liteeth_netdev_ops; =20 - err =3D register_netdev(netdev); + err =3D devm_register_netdev(dev, netdev); if (err) { dev_err(&pdev->dev, "Failed to register netdev %d\n", err); return err; @@ -294,13 +295,6 @@ static int liteeth_probe(struct platform_device *pdev) return 0; } =20 -static void liteeth_remove(struct platform_device *pdev) -{ - struct net_device *netdev =3D platform_get_drvdata(pdev); - - unregister_netdev(netdev); -} - static const struct of_device_id liteeth_of_match[] =3D { { .compatible =3D "litex,liteeth" }, { } @@ -309,7 +303,6 @@ MODULE_DEVICE_TABLE(of, liteeth_of_match); =20 static struct platform_driver liteeth_driver =3D { .probe =3D liteeth_probe, - .remove =3D liteeth_remove, .driver =3D { .name =3D DRV_NAME, .of_match_table =3D liteeth_of_match, --=20 2.52.0 From nobody Sat Feb 7 18:21:30 2026 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D88CE264A97 for ; Mon, 19 Jan 2026 04:05:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768795505; cv=none; b=RqOAoDfrIfzdtZuLT28r8opbG2ouRzIbpr9tbReHixNVCtg7RGGRj60Ijhra4UDHShtjx0ssjVaKXJSqBl2cXOue819ypNUzMqoWNHiBIklOTRgG71KEmsW5aBihccI4LQGCPKCGMm8C19shDkTrEAw3JlB1zlnBFdQYGxrP2qY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768795505; c=relaxed/simple; bh=omMMPGLjuB3hgtLBWeCI0UZ/vyg/Gcf6AiHP8eo/Mw0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dm3UZ/2rE2r8g1BX3OYWoqbv2cpNhzopR9tDc27ViVgsRh8L1VCKdZ3xg23reR3IxgLlg+SvLeZD5W8AKMdQk+XSAu2hXdO+E0Z0RVpZsvcBRkXdvm3xqtIBX57YctjAdPmv0bVCaKhMvhjK9Rqs9alTgqSvqy6HK4QF3wTsfsM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Po6hv+6Y; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Po6hv+6Y" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-2b4520f6b32so5128776eec.0 for ; Sun, 18 Jan 2026 20:05:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768795503; x=1769400303; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FW6sIGklWV66uTVJF/toqGaRQQswtCudkXmUdFld8dk=; b=Po6hv+6Y26Oin6eXmznY9osMeNxNSjWAMJiTQqWZSJ+As4MXAH0ILvq6bChslP1ZeK 0AftyyR8Mkq1dpPo2DKUYLmAk0JiibriS1enZ9OY67AXXUsX72N4vf/GKBRjTWIAz0oK LDZAZoCp+j+0gw3+hfLxsoTqJNTWBY55yriEFtNEZ6YZ2AmVxJLDm+vliXxSME9I8SDA tahMCxADsQiMKvI8W0EiZRdb4h0YqX3aRay9RQ+ql5PavXoqCcrsoVTPhXD6vsdXLCFv dLFWBGii6Dug1hw6pGwlAcJp/Nkd6NW7fBjJw102O089En/nI7zMAoneQ5pmFI5vf7+m 7ngQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768795503; x=1769400303; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FW6sIGklWV66uTVJF/toqGaRQQswtCudkXmUdFld8dk=; b=P1zOed0oW1d+Q06SGzfGLTB/L10c6vwEBAezZ23JAOJ498aLWkCq4VUohrYazJL55N JNeVholCHxbJzMUKBXQ3V4CGcTHdfiP8ejspAh8b5ZRzzLY0yGYtsx6ouua8iVmehjao l1sCqX937hZ1ZkoEpVQcVr24jUUvL/s8i/csRPEvX/xxZWV0wl7EkgG4awAOU/Xu94Zf p5AnzTVkQPilqtuSU/VDoVo8clseBcN1gIPZL512I+eHk33KNlJpRnHdrQHlj5FkvSWt y8mjY+7p74FPfnhSV3defWWoEY2Vmpoi9I7r730n3osN1Xfv+jixAgl/poa/sPtzXbM7 wvQg== X-Forwarded-Encrypted: i=1; AJvYcCUsOMGu5Y2ayct1FbFFvLN9KTXM4/5ggxFA1OSW5O1VbBzBx6nSCYpCIwlQcgtBz2bjADxSRP+W6832SI4=@vger.kernel.org X-Gm-Message-State: AOJu0YwcCGCmSSvf+IwxJ+W15GNtGBMwk8PCjb5/PmTofTNtJ1yCXNH+ /AvuE9gr6Pl6AQqCDpxIILJodJzohrhkH15c0vXMYMyLQtwI+XiJTR8Z X-Gm-Gg: AY/fxX4dwHxwgfs3azUjpjcJxvN/fab8khZiGOaE5siXdRY5WleRLxGIo2EuW6RPnaz 3SspCX3Re7x4WyL0GgFVHie5dcNSuvACIJngJ4AzFmoeTc6EbVRkvTHOqKOW/2CRq33stDBrf0t GdvWFI+BbswR1uY0rvIIU9fo50/4Y7pR6HvF7FF6IZZ8W8XrRgGldAIH0v75TfZLMkVihGvf/oX rtuaesFlIKX7x4CtZCi+/4bMtkeSWbxkN58ebPesGeY944JLgbNpSxJSfXeXgQNKsfmgBkm5rSj UCpXkp7CKk1XbRSOWcTFKxJpw+pCjha34YjnAbYBhMBbt4whg+vaKms3omqFyR19C3Y9huvPERk ALzmXJ9sFtWB09PAzCUvaLXSOEScbjhoE7U0AN9gm9y7lvYzb+Nqa/o3o3GpmW1H2FchnTS4vts pXHf9yqjw87g== X-Received: by 2002:a05:7300:578f:b0:2a4:3593:4668 with SMTP id 5a478bee46e88-2b6b3ecb93fmr6102555eec.4.1768795502831; Sun, 18 Jan 2026 20:05:02 -0800 (PST) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6b36564ffsm11452811eec.28.2026.01.18.20.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 20:05:02 -0800 (PST) From: Inochi Amaoto To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Joel Stanley Cc: Inochi Amaoto , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li Subject: [PATCH net-next v2 2/2] net: ethernet: litex: use device pointer to simplify code. Date: Mon, 19 Jan 2026 12:04:45 +0800 Message-ID: <20260119040446.741970-3-inochiama@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260119040446.741970-1-inochiama@gmail.com> References: <20260119040446.741970-1-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As there is already a device pointer in the probe function, replace all "&pdev->dev" pattern with this predefined device pointer. Signed-off-by: Inochi Amaoto Reviewed-by: Andrew Lunn --- drivers/net/ethernet/litex/litex_liteeth.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ether= net/litex/litex_liteeth.c index 67ad1058c2ab..670f2a406d7d 100644 --- a/drivers/net/ethernet/litex/litex_liteeth.c +++ b/drivers/net/ethernet/litex/litex_liteeth.c @@ -238,7 +238,7 @@ static int liteeth_probe(struct platform_device *pdev) struct liteeth *priv; int irq, err; =20 - netdev =3D devm_alloc_etherdev(&pdev->dev, sizeof(*priv)); + netdev =3D devm_alloc_etherdev(dev, sizeof(*priv)); if (!netdev) return -ENOMEM; =20 @@ -247,10 +247,9 @@ static int liteeth_probe(struct platform_device *pdev) =20 priv =3D netdev_priv(netdev); priv->netdev =3D netdev; - priv->dev =3D &pdev->dev; + priv->dev =3D dev; =20 - netdev->tstats =3D devm_netdev_alloc_pcpu_stats(&pdev->dev, - struct pcpu_sw_netstats); + netdev->tstats =3D devm_netdev_alloc_pcpu_stats(dev, struct pcpu_sw_netst= ats); if (!netdev->tstats) return -ENOMEM; =20 @@ -277,7 +276,7 @@ static int liteeth_probe(struct platform_device *pdev) priv->tx_base =3D buf_base + priv->num_rx_slots * priv->slot_size; priv->tx_slot =3D 0; =20 - err =3D of_get_ethdev_address(pdev->dev.of_node, netdev); + err =3D of_get_ethdev_address(dev->of_node, netdev); if (err) eth_hw_addr_random(netdev); =20 @@ -285,7 +284,7 @@ static int liteeth_probe(struct platform_device *pdev) =20 err =3D devm_register_netdev(dev, netdev); if (err) { - dev_err(&pdev->dev, "Failed to register netdev %d\n", err); + dev_err(dev, "Failed to register netdev %d\n", err); return err; } =20 --=20 2.52.0