From nobody Tue Feb 10 06:26:42 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF3B930E0D6 for ; Mon, 19 Jan 2026 10:40:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768819241; cv=none; b=dAG0EUyivCCfkzVapaFZFRZR+j1w9EDo+2tkke+YEH4gmcsbmlJtt7EjrsqgBLrvG6zwGPd9hGfpVjxpH6KKXRy4xTor5wLovft2Rh2dS+nA/YsyQisa/d/gp3yA0Q6D8N4P+DMf7NqNch7MmL3MNDEwWk64JXRleYuwYJxtqME= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768819241; c=relaxed/simple; bh=w0g7AInxJuR27u9srWJadHcDu30R8TLTmUaOMASFczk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jelk38b0yBV0go3WPFkzawk8op1OSEkwntx2UM5sVsPj5hsAArv6VSV2CUmoRtZstHgGbt0zaCD/56M8XKMjaGV5AVeaOOvc9H/IrRPdc2agcm2EHP9r/6GhJVSNZkQ0GzNYTXFlxncjd7kL8PjRuHq+U/RC58m8lXQK7T5wyKU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pBPHvG+V; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PL2t1GMr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pBPHvG+V"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PL2t1GMr" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60JAJp3r1531330 for ; Mon, 19 Jan 2026 10:40:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GaQTe44hMaWFCObwIQnLwBlsgWnPwdcAGUke3wQLRtA=; b=pBPHvG+V+aldTdvm pilu6HfKXIj+geOWxbAR8Jg4hT2TC3v3SmvZh+4BnvnA+YlYsbTcXeoJMUC/xZtu FAlw8vIQHM6WbJQNSzV9TNb8LWZ1RMQ1bHkH3jeX/3GdI8Ssf3zwnzPnpP7LHef4 k6Ov1j3Z5dqpiHT++AQKVR/o+L9m8fl4fjDIsaExLmsCAFVZh4/XgVejbSw4FCpG 1p7xg1wWcDN3gOG4GrfRnttPczxBO/YEv/5kRF8dIyZr1UxuY5weLcDA8ZLsOVUl 4BaiQhLjFwKMBThwM19nnTDOKwNd3zMpE23Sp701ZScL46/4kysNPjVQ3ODM8esL ev1iDQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bsjrxr204-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 10:40:39 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c6a2ef071dso1250395185a.0 for ; Mon, 19 Jan 2026 02:40:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768819238; x=1769424038; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GaQTe44hMaWFCObwIQnLwBlsgWnPwdcAGUke3wQLRtA=; b=PL2t1GMrDLSGoc600GLpMehKqpjhhxj3Fks3iYmZHUQ33jwkYT0SaerVnyK7aQiCdN hV4rDVio8VW6m8Ci9MZvk1dyUwLGsSeXdevANPL8VxMRTiqFc98MdkwcqIWZ9AbNsynT DV7o6F/uMgV+gocrpEPH2A8DslKaadTQBEohnEMlNbTQBanHcdWh/Xl8TA8JjBRgJvtL 13YCo7bgg6Quy5Pg405TJ4gnfA3p3XhA7yItrSe/iYhCU17Y4b7kugE8kcrQESYmeUfd MLG7GcJW2dt6GYTak4hzF1NY5E+4HrcMLgT7qZ/CXfF8ya2rYpm+FzbSmvGD88SoMc+x vRFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768819238; x=1769424038; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GaQTe44hMaWFCObwIQnLwBlsgWnPwdcAGUke3wQLRtA=; b=dya6wmc1bdngxpkGNGVKssFxXvyN1h9kVqzOLOYla/rlWea2qOJWDjkBsTbYvmB/0i NBSM0Psfm45VgEwBiHSym1n59qtRkBKeo2OLe/FpuaAj2dID/ExL/8x5C9dUly77rLot kOtJ5muRHawl5E1yn1dh64iS3+E0Ou9fzZylcc76fSEx/wanTR7Xk4m7Xv2Dfw/tvPTW Fw2tcNaK1jBIXnY8HirwwKO2Si9o1pLb6DF+LNxA950W8vREL/3kSedNsJrs1JFo9KmF J+w4zp6eKzQUd68d38KEcJGO64nQgjdk8QR7iGSiEZ60iMhCBETV9whRJMSKfCg5oqJk xNIg== X-Forwarded-Encrypted: i=1; AJvYcCWmPHnDz8b6+UQ2acLKlio7laoBfKoBDziwNdius5wK6/Aa/ejNUrLjclEuvAzolCD6q3nRmjAsOkoB1qY=@vger.kernel.org X-Gm-Message-State: AOJu0YwLh1JwJt58pauc5EBbuH5LsNHDSHB59FoCDX0hjmngjie1yr6G /LtfsPjNq1nM8wQaPf3vcreLcLwAwWdIHbxFQP52o19GYTB96uLIJ3nXULob3qIVNtN3piybWwV IMXJiUUC0e3RQwHXTAa3swCSM8Vt2hMle1y7vPGQLG1l9l3/oPUWRoDwLujuYsZz9eYA= X-Gm-Gg: AY/fxX45YhQPDeCk9f1HD+RRzOKApHCara2c1wQzVwQ87YYVyZzMJP0XoyWWpkGpHLF SZthuVGoq1XSDzfoHctMDew9FLLJb4UJFACCPCPP/rsGQNGsxSFDS6rm30UM+G9YcixAVubL/Cm /v0JXxHdZkhT+PL1xut7LEPedk5tl+UEX55qFUKk9L5n5Mgx5pIx1TmVBlGbThR8urzp3OcCOgM dp/FS1/3n4g0ASEpVxUdNiWbP8zQqtctJdP++on3j6Mnvj1a6Pa30xldvugVTYo6QuqyecePdgm Ypba9KCY5KwRppo7okRfmfiXJz0iEyo0m3qxLeMs/doTOjpC/hJa6vyfCjHUZihBsRgY6j/f9yO XcG5N8Sy7fLxY/k77hw+hZmEk34L3LFIOKHFlVYac X-Received: by 2002:a05:620a:d89:b0:8c6:a034:9231 with SMTP id af79cd13be357-8c6a6909cc2mr1477511085a.32.1768819238230; Mon, 19 Jan 2026 02:40:38 -0800 (PST) X-Received: by 2002:a05:620a:d89:b0:8c6:a034:9231 with SMTP id af79cd13be357-8c6a6909cc2mr1477509285a.32.1768819237805; Mon, 19 Jan 2026 02:40:37 -0800 (PST) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:4f55:d102:7129:1a8f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801e8c9cbcsm185185245e9.12.2026.01.19.02.40.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 02:40:37 -0800 (PST) From: Bartosz Golaszewski Date: Mon, 19 Jan 2026 11:40:15 +0100 Subject: [PATCH 4/8] soc: fsl: guts: don't access of_root directly Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-soc-of-root-v1-4-32a0fa9a78b4@oss.qualcomm.com> References: <20260119-soc-of-root-v1-0-32a0fa9a78b4@oss.qualcomm.com> In-Reply-To: <20260119-soc-of-root-v1-0-32a0fa9a78b4@oss.qualcomm.com> To: Rob Herring , Saravana Kannan , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , "Christophe Leroy (CS GROUP)" , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Geert Uytterhoeven , Magnus Damm , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1696; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=w0g7AInxJuR27u9srWJadHcDu30R8TLTmUaOMASFczk=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBpbgoYwGcebs7TnQeHLScelsB33SEhUygDvo2R1 Rz0CVrKa/OJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaW4KGAAKCRAFnS7L/zaE w5J5D/9l3gjjfHn8oabJffDpUYkOaslm5iWFwsy3WllRD3GzaFol/CREVg/2njHPc8W6eROxsJT wxXIe8OowaGf9BENgeEaEfA8NUIlmtIFwmbtAqn1sxEgK9RG62GMxZGUDYZqiwiAQ1IhUCRBxIj YT88QAz10YAkhKSrY8oYfeZ9IU2FUWXWbZMGy6GURV2i4h8GRc5YDqiM+6STIp1RD4S4pRQGuMk LHP/fRSDznxefUp41kh61X5wU43AQ8FM1leLsCKG8y7WmQg8bhtr2DW+p4PtZjazDWXVf5GsAwb 1n+fE/v5NLvuGKRZuLkw3nDyesXIDKy6Kiy3iUaqz5dcnOYnfFFRNFvgbLzpIPI9aDgokuOOg4w AXXSky8r+SmkmL6is7QCrmrDXnUhHaMdn7/V4oudwwiVN0xvAENYX5tWKikeT/HNJ7f6Y5EsHEe 9KOKMdbzylzqjsas2M11HREQNgxrJXfnNDgqrKm0fUVmTgmYmlpC84SnHLwAFBzIZ9ZbA63CZTP GeMs85X3Gqv6T6o/VMovWvCYazRePcP9Hh6O+NEalOLNppUV68kCUS1lW6U6iC9uGII++8njXvo smph8uKv5reLDLaVa97fvnplAnD45eUsvXk1KmzUFINRupBTUl4tKJJRsz4mgQOE6nPFufkfwA2 yUh05MLZIZsj/bA== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDA4NiBTYWx0ZWRfX+oAyUHga7TPw OUF0nmbueGVnoE7D/iWeGrzm+ZylZCjCIb7CRuw3AxvAYKUEiVdtjjPCG86d2hQVGQ5jgH3zh5q 4Q8RXWclDJgCDbqW4Y5SF2vSV8Xi/vo9F9etHwR/H/+MdyOcHbb0i1EIngIW9XlHuFRRoqMai// LllElsiuQnEu6vojUVdyfSnDozRy2JH5ATag/mXAUFNdll1L8Rrbh6QiUICXANVsZW5uvMzGXFH 9w8a/ptVgrbS0jlNjXUrymSvfcdMPXpT/cDz+AUyRZ5uF5iE3njiqkMdu3pMzfVOnlU2RcrnwPS rKSGv4FPgxJ65dpsIvDo+3s4IE3OZ032EPfkQn35u5lmWFeTeAPlUj/AFiDgnit0LIiJomBQ6LR vGE2xpEWCAbUYq0BkY0xqtqRTRV4lwVLW0ysh/uvFAYK68FTGWhUDTyjz6Sv9vxUHVRk6KjAQGq jlfHfW9bx8DpFVNSx8g== X-Proofpoint-GUID: bJ_Dr5sdyzgHKkoizNfeIwP91neY7VHp X-Authority-Analysis: v=2.4 cv=PPUCOPqC c=1 sm=1 tr=0 ts=696e0a27 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=oxzWnGEk1v-FRkq7efsA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: bJ_Dr5sdyzgHKkoizNfeIwP91neY7VHp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_02,2026-01-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190086 Don't access of_root directly as it reduces the build test coverage for this driver with COMPILE_TEST=3Dy and OF=3Dn. Use existing helper functions to retrieve the relevant information. Suggested-by: Rob Herring Signed-off-by: Bartosz Golaszewski Acked-by: Christophe Leroy (CS GROUP) Reviewed-by: Christophe Leroy (CS GROUP) --- drivers/soc/fsl/guts.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c index 6bf3e6a980ffc67c21ed7b62b5b638e37f27454e..88ba32a40f6a27f8ffd13624e94= 0aa0edf48586f 100644 --- a/drivers/soc/fsl/guts.c +++ b/drivers/soc/fsl/guts.c @@ -186,7 +186,6 @@ static int __init fsl_guts_init(void) const struct fsl_soc_data *soc_data; const struct of_device_id *match; struct ccsr_guts __iomem *regs; - const char *machine =3D NULL; struct device_node *np; bool little_endian; u64 soc_uid =3D 0; @@ -217,13 +216,9 @@ static int __init fsl_guts_init(void) if (!soc_dev_attr) return -ENOMEM; =20 - if (of_property_read_string(of_root, "model", &machine)) - of_property_read_string_index(of_root, "compatible", 0, &machine); - if (machine) { - soc_dev_attr->machine =3D kstrdup(machine, GFP_KERNEL); - if (!soc_dev_attr->machine) - goto err_nomem; - } + ret =3D soc_device_get_machine(soc_dev_attr); + if (ret) + of_machine_get_compatible(&soc_dev_attr->machine); =20 soc_die =3D fsl_soc_die_match(svr, fsl_soc_die); if (soc_die) { @@ -267,7 +262,6 @@ static int __init fsl_guts_init(void) err_nomem: ret =3D -ENOMEM; err: - kfree(soc_dev_attr->machine); kfree(soc_dev_attr->family); kfree(soc_dev_attr->soc_id); kfree(soc_dev_attr->revision); --=20 2.47.3