From nobody Tue Feb 10 02:49:09 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A305A2C15A2 for ; Mon, 19 Jan 2026 17:42:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768844536; cv=none; b=FeoDQnhFsn/ee35sPJgraBRD+Bd8oFy0RebjZ97LTxYcwFIn0+BWB+qV4/HYogTA7vSnK9SYpxcCoS8gBAbblQfjeXkFqUdo5joWQrOce2T///bkYBinrDXv+zd9YhYggI/MlTINKQREWHByOys5/v0v0WlehF4qukj2DJyaZ+4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768844536; c=relaxed/simple; bh=6WzeFU1ZELy887TqCFg45XhUTORseWZMpoP7KRV7Sug=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=j4stONuHcxen/gTHpMmhDpHNPyOJgtFLDz/ecPlKVvg1LULOLGZ3JjJaDvNQUVbhMwfV8s96qTa/inLnRV4XSKVCc5bL/YbULQtHjFFdJSMkZIbfXKKGV/Wax55ytK8iuGkEWOKQoajJpX6GL0V8ba583M7qvIEsaACJSJFYPsk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=KZ4NGsnS; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="KZ4NGsnS" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-47eddddcdcfso21577205e9.1 for ; Mon, 19 Jan 2026 09:42:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1768844533; x=1769449333; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0G2jHMHIp3XuUuwkNNM9FSCxv1qZQblNwod1SKxM/vQ=; b=KZ4NGsnSY2kM1jg56huqbgoe6X0Na/p35fNhRFTcdqtUEgRlukvw3kX/6SdIVS4lIX DBlWtrtrox8Y0NC8H9jUPAlo/ei6g3xcN7JKByrI/Cp6izYtFnqfF89lSYBDY0upL9+c gM/vTTx1JcUepxNYV+S2nRqZilc2TfOIjZBv3eal0M1MEB0nSRCyQjxchO3vA5w/UuhG l4VeAazfhnk+1uhd4fAw3tAVThwlvIQ7YfpVBcKN5vXjVUHrGz9PKZH3WOiNUW/ksnAE zwQN9os1hBGltcHKPww7SPm5owyF5kf1yYiwF1Q0ePIyshXe4f5qRHk8/lJaejPyADkO QElg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768844533; x=1769449333; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0G2jHMHIp3XuUuwkNNM9FSCxv1qZQblNwod1SKxM/vQ=; b=Gg9MbrqaEKkoNedapupIigPcxjWOOE/OUNnE6FMDYKI5OC8q/uL9X9lqm/GToUu6kE 6RKoKzlHJKIuCJKFToJp3WSlcpe43HWcXDv2Rt8DJBoEvyfbz6yylinAWCZyzDifRytf vMYuoqknj7FRL2krOc4b95Mua9Hnk5YThpY0DyAOVcI0pBOV4Qg1a9d4zl3Wevk50UCB Xb/OwQ96DKXbfxYD2CweLz9O5NgedvGbjzuGYUi4E06Qa6Lkhq7Ge6fX8AupLxDHKXIH aEfPOjyjRFcuf5sBTqAnPzqWw6rbmjQofC3g8ajPtU4KYkbk32exP7lyMY0cJOGc7TjI PLuA== X-Gm-Message-State: AOJu0Yx8fW45SPTJkLKE3MDnXtV62uKLHwgnjv25eHgEZFO+xUleS1JT wsTpWKRCzQoQMVdYPHVk1Fb+m1xXQ3G2ErsU86B4saFx1TF+bvJnnVEEC/qLz2vnLIA= X-Gm-Gg: AY/fxX6VG4Am/4NMjMxEWUjGG/ulCxVyNoZp1jkHWOpC5hPPHcX9924JdcoQlvmx8Ap WAeLnyGL8U6iEknIUrM/+iDWPHorXcg2wY8Af0AZ+EFrSlIMDy4/9oTTK2KfUe+StJSg33R3q6b QcLTX8710fR44jt97eufst4eWYndyRv2uwEKDvNPBkTsJ3g6GzE37mQ2brAo2hz2pVA8Kp7OE0B s4W0hfD9+5FI6RNiX2JMaHspvahlCMW55qYG3Lop/nL1moWGnAk0DcZhFPkRjTQhLWjZrU8R/Cj cFymsdd/OtKLyvFIyQJrNrRTzI30X5vvjq9qQDxQTporYJ9bCVBFT28VCicsVk3R25NP4XkeSqF RB3MWeQbVwoQEHnDp966dJR68ORm6T/irHTpEYqZwGRcTF3s4ZRJH+7nixl2W25Bau7TiqcEb6F cfaOILG7+GReTxIKAD6YokhgGPcU+HAdQ= X-Received: by 2002:a05:600c:81c8:b0:47e:e807:a042 with SMTP id 5b1f17b1804b1-4801eac800amr141556645e9.15.1768844533128; Mon, 19 Jan 2026 09:42:13 -0800 (PST) Received: from blackdock.suse.cz (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801e86c1b2sm199658755e9.3.2026.01.19.09.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 09:42:12 -0800 (PST) From: =?utf-8?q?Michal_Koutn=C3=BD?= Date: Mon, 19 Jan 2026 18:41:19 +0100 Subject: [PATCH 1/3] sched/rt: Skip group schedulable check with rt_group_sched=0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-sched-rert_groups-v1-1-80c1e5269910@suse.com> References: <20260119-sched-rert_groups-v1-0-80c1e5269910@suse.com> In-Reply-To: <20260119-sched-rert_groups-v1-0-80c1e5269910@suse.com> To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider Cc: linux-kernel@vger.kernel.org, =?utf-8?q?Michal_Koutn=C3=BD?= X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1620; i=mkoutny@suse.com; h=from:subject:message-id; bh=6WzeFU1ZELy887TqCFg45XhUTORseWZMpoP7KRV7Sug=; b=owGbwMvMwCVWZ8v0fMrtHxyMp9WSGDLzct7YZm/a1rpOdNlO7c9rEk2Syw/d0G2xkhSJCWDYx H9d6Gdsx0QWBjEuBksxRRYn4TzW+R9k3CxPd32BmcPKBDJEWqSBAQhYGPhyE/NKjXSM9Ey1DfUM DXWATAYuTgGY6jfdDH94HzhxJ3Wp23AsYFKtZLyUPa/m7qnngSLx7hHft1ntFAtmZLj3q9jR1XJ 5kbvBi3OFDa8qNBqEJt/1e9Asatw8y+imFDcA X-Developer-Key: i=mkoutny@suse.com; a=openpgp; fpr=9F2AB6F1F2BBEE7621C1B620CFDED9A2FD1314F0 The warning from the commit 87f1fb77d87a6 ("sched: Add RT_GROUP WARN checks for non-root task_groups") is wrong -- it assumes that only task_groups with rt_rq are traversed, however, the schedulability check would iterate all task_groups even when rt_group_sched=3D0 is disabled at boot time but some non-root task_groups exist. The schedulability check is supposed to validate: a) that children don't overcommit its parent, b) no RT task group overcommits global RT limit. but with rt_group_sched=3D0 there is no (non-trivial) hierarchy of RT group= s, therefore skip the validation altogether. This fix is immaterial with CONFIG_RT_GROUP_SCHED=3Dn. Fixes: 87f1fb77d87a6 ("sched: Add RT_GROUP WARN checks for non-root task_gr= oups") Signed-off-by: Michal Koutn=C3=BD --- kernel/sched/rt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index f1867fe8e5c53..2dfdf2d9471be 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -2668,9 +2668,6 @@ static int tg_rt_schedulable(struct task_group *tg, v= oid *data) tg->rt_bandwidth.rt_runtime && tg_has_rt_tasks(tg)) return -EBUSY; =20 - if (WARN_ON(!rt_group_sched_enabled() && tg !=3D &root_task_group)) - return -EBUSY; - total =3D to_ratio(period, runtime); =20 /* @@ -2814,6 +2811,8 @@ long sched_group_rt_period(struct task_group *tg) static int sched_rt_global_constraints(void) { int ret =3D 0; + if (!rt_group_sched_enabled()) + return ret; =20 mutex_lock(&rt_constraints_mutex); ret =3D __rt_schedulable(NULL, 0, 0); --=20 2.52.0