From nobody Mon Feb 9 16:01:57 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 584FC23E358 for ; Mon, 19 Jan 2026 12:17:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768825042; cv=none; b=jnPHBVd4oRfMCityOoj/TLixu1dSA76bhAfABRTMiS+KFzy+1mTBFfX/BJXORDlAx1Esb9+ip1Vze955IAMs9se682Tb8Y2haq0a886gC3t8ITfHcsnMggYtDTC3D4IkvaM3nTCuSWMv037GPKj0gTG3fU3Oin8ElbPRt9rLUaI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768825042; c=relaxed/simple; bh=PZQ/HyJUBzLI4q25Cr4PA1zrRatPlEyyxDNqfDEZSTM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uSfCdD851nZy0VgzmqsxYgolzt5BH1qvJGKbJyR6dMMK6zlcOXpfuI9+iuQvdasHiXAD0Pa/tpKOVu3rNHXssNCrR1t9998MJV4Uwcc9cS8Fpi9fEZoo72fEPjaTyG4tyWl1vRLbt9FWk7yqQcGFc6v3E0W/HNJ0fVvsMT0BmqI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fe/Zr1x3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Lab8NwCW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fe/Zr1x3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Lab8NwCW" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J91GRB748360 for ; Mon, 19 Jan 2026 12:17:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6qC/9vKSzQzUUoZh2ZSv3mwkxmrw/IyTUO/hV1ChtFs=; b=fe/Zr1x3pNkHSHYw CLzWIFNmqZkyHn3sHTZV7hpcppDAM0emR/uMPBk256pr2HOWjLLn98BqQPwUaWb9 AdctIhHq1JAhtsecMqtxt1SpLUHBnJt7qF7nCPoWfrGQAZtH5wMaQbIxn/z/vjqv XLRKg3xkQaSBMwQQOrOBsUQIoqk6HhmPt2epxquU+N7xAxiJBfrG07ZkFVmdWXQR cWyhp/kqMrYFyyX00aXtq1J1/FtSI76vhOHRiYICwFOMC11lDopEBehcf6mvzdSW 6bZFaXxCbiIHTdn0bmDvMm6dEalE6DsvhrLcnXfvO27/pNMlsfxlXjIDdz6ZwqId y4q00g== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br2t74yxm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 12:17:20 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c52f89b415so1048147385a.0 for ; Mon, 19 Jan 2026 04:17:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768825040; x=1769429840; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6qC/9vKSzQzUUoZh2ZSv3mwkxmrw/IyTUO/hV1ChtFs=; b=Lab8NwCW5XeF2R5xT1bdGvTFgnlcD2Dpd5Zs1TyDeFmBuMZEw5usZ5zBqvMc9FLGAh DvFaPwcULpm7bOzi8q8mCBnQEsuUi/BXPEJpkE/4UtdaQl+7PQroj35W5gzLy681Mlmi IiSgrKU9b8L8s2F+oetrgZx24d8Ow8tKJiVbcb5r36W+HzDlkUVDO/rvpsqFoXYHTg3G Hye26eD6LyThvMkdbbjXLPBAVWNDdSLu4dz/SWC7twSntTXG+pIR+cUsHli5mCAfbCGR YyxOBxiNSOO91Cnahv3wRJblJEzdnzyXTaR8DsaBr8cEcS4K0/cd7R4Fp2csjYuSd16p BY6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768825040; x=1769429840; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6qC/9vKSzQzUUoZh2ZSv3mwkxmrw/IyTUO/hV1ChtFs=; b=S8XG8BbQXmgVgeex7Ay6Csu4m9a9dAmzI23Qql9i1QCy7YnwDI2QJdAYmkUq5sCecr B/kdBgzF+reH0FSnRXlde/47cl4BsBqWOdjdycocK3V3OmgiCteZ1vyFPkb1p3m4vt8s zS3sw9Ol6HVK8XCHc5Lq5VxMarVOiZbk8S6RmFK7jN9RkWcPzyGcHIIFLAGDshR0yLUL hMLwaaUZj34S715vy+93AzEPGSVCzY1WO4+Tvl4TeI8Smq/xmRAwoqlMGztb5rNMI6ZE no8c/TyEcgRqhVZ/LNZOyE0U+yOcIGnaoZcVdqoxbX9BIeP3OvVqU6uSXwb8ysWECPx+ M2Gg== X-Forwarded-Encrypted: i=1; AJvYcCVzW0+qi3m4XAEbcb79Tv9wj0sWLOGhfen/QzEN/bavIA8F7JeeUPge3Yq5LSw5TG3hZpHPvMsMWQGF4nc=@vger.kernel.org X-Gm-Message-State: AOJu0YwGAysZVNLMKbzJJFHDQYj1G1432jSQsux9fzvHIrNFlcC+OEgX 2n5z5Hcz2PKhCvQ7+e8UvFtmXU7NVYlN3hAMqVxketVEePwXvEpvpM8G7RlZrDR6a5P5LoTylGj WQpObR/12LQlZ4aDsrgvHpWNOuPJhbc4CqjPBQmQAiooHeJ7wNVgcFHyySjN8hfKcwd4= X-Gm-Gg: AY/fxX5FLE7ZCcg5ZlOIgBlrclWX8fGJitrhdZ41wU7KjcrsoRahx4pmN5t3/SpuHsO bBBiRNu0SzGDYst/9l8C89g9iMtkeX1CcC/Gaa13soj1bEEW5Hk6b9R26pp826j8CVdQlvPeUKf TSj34XUGZUW1HB6BHV/Rg+iniWKOEdq3KVQM8/Marb9D+1gPnfWyG4iIVtvUrwXrfSxg8eXzXx6 w8OCmoEbA5Y2vrr8lJhPzPO9l6dGEy0pJrd6w19EgAleSoxRrEn+JAJeywKRAMflyGqKrvqAD8f h+UHzDhs0gcrlK7a5VFjn2ZGOukDN3AU7fP4XztCTquiMrGAOGqucDHkxBqxnCeIuNHdXbhCp5H FX7YNKAvvQS/HUkrGzihTOFmze3ISq7Q8toVDCo6pLazbWjsMK4u4gmSoJUk5l4j3op1AJ2vSht IREiOtx8GcArkI4YOyg+qU8AA= X-Received: by 2002:a05:620a:258c:b0:8a0:fb41:7f3c with SMTP id af79cd13be357-8c6a66f8dd9mr1536272085a.27.1768825039603; Mon, 19 Jan 2026 04:17:19 -0800 (PST) X-Received: by 2002:a05:620a:258c:b0:8a0:fb41:7f3c with SMTP id af79cd13be357-8c6a66f8dd9mr1536268385a.27.1768825039101; Mon, 19 Jan 2026 04:17:19 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59baf3a17b9sm3274641e87.92.2026.01.19.04.17.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 04:17:18 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 19 Jan 2026 14:16:38 +0200 Subject: [PATCH v4 2/4] drm/msm/dpu: offset HBB values written to DPU by -13 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-msm-ubwc-fixes-v4-2-0987acc0427f@oss.qualcomm.com> References: <20260119-msm-ubwc-fixes-v4-0-0987acc0427f@oss.qualcomm.com> In-Reply-To: <20260119-msm-ubwc-fixes-v4-0-0987acc0427f@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Val Packett X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2116; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=PZQ/HyJUBzLI4q25Cr4PA1zrRatPlEyyxDNqfDEZSTM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpbiDLFZ6M1k9Dzt0HQxU81lGHZ4S1WCvcUQ6j1 i3M8BIIrfWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaW4gywAKCRCLPIo+Aiko 1cxpB/91qJ3F2Z6sVCwbnkATmecyx5/y180v0zAcduBX+E2Kd2Iox9l0bwlm7oingvUb/gMg6Vu i2Ft6jpcsEfxJP8LNm+ejWozDd2PUvErw06rAdh+MGdtindnXY8Bfhw9aI/ewgkNKFbK7daxaGu njAUPDg1TVFw4FTnWsZwd+DduBpK0ESNBKp/ER05/Lif+vyelQb/cS4XirEm2/zmnQslYYz9S0W M0kIi9vykXTmOvvFOY2t9NAbIpgBhKMXyyKWfkSLahLQqQkdH1b6DLZ/9luezikfV+Lbey88ugi zf3MqRbicIbWStMiKxerkCna3iTtmZforsH3q8yW9V/A+sPZ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=Fdc6BZ+6 c=1 sm=1 tr=0 ts=696e20d0 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=1unLKcHO38ebvhyrShMA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: xVwiUmNO8XndlbStC6oh1GEKtaEJ2eX2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDEwMiBTYWx0ZWRfX9HDaCrV3jSys mMtU8pTinsE1PtUo797rK5XfFi6TCbPVPsJb/bAl5o5MkcAZOEskQDbP86CBbM21XuJHV9dNN4Y DLPZ29j6yTDouUcNNPMpVDTOEi+bCawRmWMSqIsTzcfUauiPDS89MY6JtvfoFi9KcgUkyI2fSYa X/SGP45Vhe4vzstu3NJDEVf/ZPtKjgqW+0BGuXq01zbfLPbvWJEkbPgOwoYkvE1CUiOv0E1hS7I 5nO7OC4OUSqyF7b36z+KADOGf66tK67rC/Lb08hoBt8H90pznE/U3vVHPG7s6QIVIJRpXlD8HSk OHVPm0TBE7qZBGcOqvipRou2XyYL//wC5yjVNNNjtwAw6aSGL7QHskJt0XoNFlM9ibbhKuWhgSr dlnmwlCZMg2vZ1N6woEfwu7ZVA83eVeVE4dntltLXKO+SStKkC5/J8egCDUvwQINVmnwBGhAO2t z3q2PjBD+Ud01L5JrBw== X-Proofpoint-GUID: xVwiUmNO8XndlbStC6oh1GEKtaEJ2eX2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_02,2026-01-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190102 As in all other places, the Highest Bank Bit value should be programmed into the hardware with the offset of -13. Correct the value written into the register to prevent unpredictable results. Fixes: 227d4ce0b09e ("drm/msm: Offset MDSS HBB value by 13") Tested-by: Val Packett # x1e80100-dell-latitude-7455 Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index 6f1fc790ad6d..b66c4cb5760c 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -270,30 +270,32 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, ((fmt->bpp - 1) << 9); =20 if (fmt->fetch_mode !=3D MDP_FETCH_LINEAR) { + u32 hbb =3D ctx->ubwc->highest_bank_bit - 13; + if (MSM_FORMAT_IS_UBWC(fmt)) opmode |=3D MDSS_MDP_OP_BWC_EN; src_format |=3D (fmt->fetch_mode & 3) << 30; /*FRAME_FORMAT */ DPU_REG_WRITE(c, SSPP_FETCH_CONFIG, DPU_FETCH_CONFIG_RESET_VALUE | - ctx->ubwc->highest_bank_bit << 18); + hbb << 18); switch (ctx->ubwc->ubwc_enc_version) { case UBWC_1_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | BIT(8) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_2_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, fast_clear | (ctx->ubwc->ubwc_swizzle) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_3_0: DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, BIT(30) | (ctx->ubwc->ubwc_swizzle) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_4_0: DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, --=20 2.47.3