From nobody Sun Feb 8 22:01:05 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6955E25332E for ; Mon, 19 Jan 2026 12:17:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768825041; cv=none; b=QeOJR5kQ7uPK0fn4EOqTeuFlN+E9KIMqkogVMzZs2DV8HKkm0Uo24t7Ps16Wca0YxDvMcBuaXX/+Ry622Z/XJQX5QDwsS1VoHE56w75qFZY6m6PrbKQSMxRDa5U5vWt+L4JMDv7/sK7YMWo8ktGfLaC6XVoweZfOcHrdExJiYPU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768825041; c=relaxed/simple; bh=sKKQwB/Ww13iy8a902V0LopTAE5vZckjzbE46YxMyPE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=u89XrpJYmT3OA+YNAGIQrYDL/kUkgwnC8URxavU5k7YxlgAvKoI3RKnDYEPuGWm7HqslOB6vrDMi5z9f7MgBSLnF0ra/NBrrldh0qayoOVSKQ1ww6iwpQw3lLV16EsZLI7oOyJKmPDX5kJHXejtra+vLCFznwPSTKW5Qr3EdFqc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=obq7xxVR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XI7eqUBN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="obq7xxVR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XI7eqUBN" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J9nBxt2965782 for ; Mon, 19 Jan 2026 12:17:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= K2DDNEPkGNzO2qo7B7YRZVVJuY+Bv0xW+0S4R/akcpE=; b=obq7xxVRcZHxETmd VDdDOoGStwDh+fET4bxhqYkdON65QHKWHeWeTm4BB5W6EVTvS0EIih2cMEDyTLvV bsU6Eiz8nkfjsVUGymdOTGm1DlBSVPwO/aTSh7PWJE8aso06SnD4utZWVcVCryUP 8rKeysVHJOdVl51eEte5pALwYaSxrVxLkWw4nQuTQhb1P456qMX25yw7NRTyzxsv TCjaRHu36k+6fUCdN949TCXXYZenDWvDOWgF19DYHVe4RAQHpJFBHNDVWMFLsGhE lAV0PSHlcW2aaWizNbeI3h1oh1vwhQRV7dMDAvZs3SCGNkkCU0ewdueismQoaZkW 8QKXGQ== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bsjaa8e7g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 12:17:19 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8905883e793so125670566d6.2 for ; Mon, 19 Jan 2026 04:17:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768825038; x=1769429838; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=K2DDNEPkGNzO2qo7B7YRZVVJuY+Bv0xW+0S4R/akcpE=; b=XI7eqUBNZJRPomG0o6bvC+34aW/d5zMoxHdpSK3nnksfxbNUoxDzDl3h/d9NY7BOpi 63pYhHu6b84XzIQRIFE+nejjAafYuxvI7vm1VOZqwXwnQ3H0IhO+RjB0s74l2AUV1boE SG8YJUedooDFO562xXyFucpQdSgJXAlB1a7CsqUHMjVrgTKTy7qyv6KR1tBF+l73qLup SIhUjBKwc9we8jqqOrI1Nho7tDucKkiRHSUmiu3hs+VjnVvVEx++5Pjc9+BrAiRkGOrc IQMpNakfIe1o6oDqiK1SFHx6pHqT1Z+T7a1eJWtMdkqWBFsbJTMHRmAsEFP2RXynTx2W 7Wlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768825038; x=1769429838; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=K2DDNEPkGNzO2qo7B7YRZVVJuY+Bv0xW+0S4R/akcpE=; b=CLfEX1YrBD7f3cUr8nX1vrjtHksqA73kexWTmTHgRRD/JYC5VAXD+9NK3Wvm2Nn0Fw z8gxfJ0ph6HuyMh6c2pswvzaO1zw1tHXaHInt12TKx43ojViHBa5tbYFilRYUtkW4UyZ lKPCjE2+Brvdc99VhdVXV0qQdeRReCMadVOAS1voqG+36cAEM1C6nlX+15BYufnd/CDP 6pafF7nNX+QSQ0f0cuQ1JXQXEq3mKoJTDriXZwtPuQZ5xv5Y8ibaJYdrMw3qbTDijJKb mHd5kRjsy18p/pFCpLG6LJ7b11nnZDZttg5qe/fii+Q2J6aE09saENasWVa0dPodJPr3 7Rgg== X-Forwarded-Encrypted: i=1; AJvYcCXtgsJaOOtqpQM7SxuOPhDxDBY1sMm5TJpPpQGEHLQoLxoyGY6C5Z6F8JjuGXYXmDdXB63qoKc+GGfe8f8=@vger.kernel.org X-Gm-Message-State: AOJu0YzBv5u6AKYxSCUe6+jMyzKSf91Rq+P3Fd82aoiXUy/exHHnFQ/Z 9ohrRTYolyjzfmLYwQdjqLatPWhpacLQeRYmSVxw6421SiyYQ+c9ygrFzu+KRvKW2AXAFMuPeBy rEbP0XhKnYcyJK8n4RpVY/7tryCKYFvN2fef6BZZ7R/s2vBmABIb4GKxbAvmAnqgIz/0= X-Gm-Gg: AZuq6aI/wYxQKIbVwsCr2+2kQEBGHsPODCqPANBtiJHtkIgVoVwlpdOUVEyyGoGtxRv kBOtY/HZYE/fGmCHA/uCg662IeuVyzI5sXSZm7a2X+nJKRN8FNBhyQABxWWLxgBAgYi8JxMzx8y eCptBmye8pn2tQhap7hiAcLyBJcYef8250fcFANvdteU0tPppXDMKuzmdsnpRw0MtqL5cjGhcBP XUDpeePAXqYbQmubcQF3KnJzqZf+25Dp6s6kaeTw/tUr2mAKTLneBJJSOAa0wxIORG7hF3x8Hsb F/W/Wcqv7hxCHNY5TZFQRoWQKrW2R9snb0e9FP4zg+mg0heDuUXZC4lPdNYgcJd5/qJgHfvTS7c U7VGOUJ23kS0zWfZDDI7gPHsNp2atEGhEBhS/NHTMgOpvbeeDTHniy9Vxtm2gMin4SEJKQM7f1J xckGPJZdI/7sWZV1ZJQ2CHyuM= X-Received: by 2002:ad4:4ee1:0:b0:888:8804:50f4 with SMTP id 6a1803df08f44-8942dd2bbefmr164875966d6.20.1768825038368; Mon, 19 Jan 2026 04:17:18 -0800 (PST) X-Received: by 2002:ad4:4ee1:0:b0:888:8804:50f4 with SMTP id 6a1803df08f44-8942dd2bbefmr164875746d6.20.1768825037967; Mon, 19 Jan 2026 04:17:17 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59baf3a17b9sm3274641e87.92.2026.01.19.04.17.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 04:17:17 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 19 Jan 2026 14:16:37 +0200 Subject: [PATCH v4 1/4] drm/msm/mdss: correct HBB programmed on UBWC 5.x and 6.x devices Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-msm-ubwc-fixes-v4-1-0987acc0427f@oss.qualcomm.com> References: <20260119-msm-ubwc-fixes-v4-0-0987acc0427f@oss.qualcomm.com> In-Reply-To: <20260119-msm-ubwc-fixes-v4-0-0987acc0427f@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Val Packett X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1248; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=sKKQwB/Ww13iy8a902V0LopTAE5vZckjzbE46YxMyPE=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpbiDL4X+M6uTUV039bM0Krcqx4R4SL7dj+wjPm +9j3R+CGuCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaW4gywAKCRCLPIo+Aiko 1eUvB/wPKGLVePsM+jG46z8z8T+4NRTsQp6ZWb3KQgnHMdv7R2g9hGINKNTRd4SZmcpW+pnhiqr MHfy6JhzVE1CUOkt/zYlREuteQomH2O4/ZSIeuWDyQA0qbIy7QHGmll7eHGT53ryqMLQy0V5fKJ DiCAqYIrazrWIJ97wVg886OloVJaOV7FTc05DTSmP1Fe0AvA5QpUQH26XQaXQs2YxjhQomca2tl KF6/SzOGhUllXGYHzrgfdvmmlg47LTbtPTchGwFdFWPnc6bGOoeUH3uuIeE1OaJ1b1mY/UPd6vi 440j+aJWPsEEZ/NLAREbFswRkbbTTk/bNEDQWEXJ/5bFkFIg X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDEwMiBTYWx0ZWRfX1YzeQf8ztyGB Y6XlxONpC9qQQawt4lE2qMckavsqlYLsl48hAbXMH4uCBsLrcE1BC/W3TwccU8a9TCcrSUNFNSa bHlQ/2lgw69RCC26ZGzxLUVxi+zU3JzVWP7w52A7PLuPmJjN4HOXYIV21RSnNS/mzhZJH2OnB78 zrxlQXPZzX6LOpbL/2EsVbXCuP7esxzcdmhyIxWbPq3zLgW6wueT89LlZhTIocwL4jxwQCkkQf8 X0j331TW4hYgGvEgO7GrfI/ct1v9oOuSCr7OzeAsZCOQxa08uoTA6trj/L6mc42q7YpGY5UcVSl OlEgQD9zRIcJ9mbG09ZNCu57rxdGbWYAptTPr3ydDwJwm4QuUShK+P87er7FEm0at6JyDRYR7ZR AsG3d2CEEwOcQGCJFrlSIBCaM1X+KJ6IWih98oU2UWTg26vYnx5mX4qMuukZBohB55BJp6vhEjr vvwIAzb7RBqY7Uj26lg== X-Proofpoint-ORIG-GUID: d9M8gSerOkdcSuHf6lK3loUZPRjeUc2y X-Proofpoint-GUID: d9M8gSerOkdcSuHf6lK3loUZPRjeUc2y X-Authority-Analysis: v=2.4 cv=L8gQguT8 c=1 sm=1 tr=0 ts=696e20cf cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=VBuLEOLxEfejlaYavu0A:9 a=+jEqtf1s3R9VXZ0wqowq2kgwd+I=:19 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_02,2026-01-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 spamscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190102 As in the previous generations, on UBWC 5.x and 6.x devices the Highest Bank Bit value should be programmed into the hardware with the offset of -13. Correct the value written into the register to prevent unpredictable results. Fixes: 227d4ce0b09e ("drm/msm: Offset MDSS HBB value by 13") Tested-by: Val Packett # x1e80100-dell-latitude-7455 Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index bf9a33e925ac..910242f5a71f 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -229,7 +229,7 @@ static void msm_mdss_setup_ubwc_dec_50(struct msm_mdss = *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | - MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit); + MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; --=20 2.47.3 From nobody Sun Feb 8 22:01:05 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 584FC23E358 for ; Mon, 19 Jan 2026 12:17:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768825042; cv=none; b=jnPHBVd4oRfMCityOoj/TLixu1dSA76bhAfABRTMiS+KFzy+1mTBFfX/BJXORDlAx1Esb9+ip1Vze955IAMs9se682Tb8Y2haq0a886gC3t8ITfHcsnMggYtDTC3D4IkvaM3nTCuSWMv037GPKj0gTG3fU3Oin8ElbPRt9rLUaI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768825042; c=relaxed/simple; bh=PZQ/HyJUBzLI4q25Cr4PA1zrRatPlEyyxDNqfDEZSTM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uSfCdD851nZy0VgzmqsxYgolzt5BH1qvJGKbJyR6dMMK6zlcOXpfuI9+iuQvdasHiXAD0Pa/tpKOVu3rNHXssNCrR1t9998MJV4Uwcc9cS8Fpi9fEZoo72fEPjaTyG4tyWl1vRLbt9FWk7yqQcGFc6v3E0W/HNJ0fVvsMT0BmqI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fe/Zr1x3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Lab8NwCW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fe/Zr1x3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Lab8NwCW" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J91GRB748360 for ; Mon, 19 Jan 2026 12:17:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6qC/9vKSzQzUUoZh2ZSv3mwkxmrw/IyTUO/hV1ChtFs=; b=fe/Zr1x3pNkHSHYw CLzWIFNmqZkyHn3sHTZV7hpcppDAM0emR/uMPBk256pr2HOWjLLn98BqQPwUaWb9 AdctIhHq1JAhtsecMqtxt1SpLUHBnJt7qF7nCPoWfrGQAZtH5wMaQbIxn/z/vjqv XLRKg3xkQaSBMwQQOrOBsUQIoqk6HhmPt2epxquU+N7xAxiJBfrG07ZkFVmdWXQR cWyhp/kqMrYFyyX00aXtq1J1/FtSI76vhOHRiYICwFOMC11lDopEBehcf6mvzdSW 6bZFaXxCbiIHTdn0bmDvMm6dEalE6DsvhrLcnXfvO27/pNMlsfxlXjIDdz6ZwqId y4q00g== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br2t74yxm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 12:17:20 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c52f89b415so1048147385a.0 for ; Mon, 19 Jan 2026 04:17:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768825040; x=1769429840; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6qC/9vKSzQzUUoZh2ZSv3mwkxmrw/IyTUO/hV1ChtFs=; b=Lab8NwCW5XeF2R5xT1bdGvTFgnlcD2Dpd5Zs1TyDeFmBuMZEw5usZ5zBqvMc9FLGAh DvFaPwcULpm7bOzi8q8mCBnQEsuUi/BXPEJpkE/4UtdaQl+7PQroj35W5gzLy681Mlmi IiSgrKU9b8L8s2F+oetrgZx24d8Ow8tKJiVbcb5r36W+HzDlkUVDO/rvpsqFoXYHTg3G Hye26eD6LyThvMkdbbjXLPBAVWNDdSLu4dz/SWC7twSntTXG+pIR+cUsHli5mCAfbCGR YyxOBxiNSOO91Cnahv3wRJblJEzdnzyXTaR8DsaBr8cEcS4K0/cd7R4Fp2csjYuSd16p BY6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768825040; x=1769429840; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6qC/9vKSzQzUUoZh2ZSv3mwkxmrw/IyTUO/hV1ChtFs=; b=S8XG8BbQXmgVgeex7Ay6Csu4m9a9dAmzI23Qql9i1QCy7YnwDI2QJdAYmkUq5sCecr B/kdBgzF+reH0FSnRXlde/47cl4BsBqWOdjdycocK3V3OmgiCteZ1vyFPkb1p3m4vt8s zS3sw9Ol6HVK8XCHc5Lq5VxMarVOiZbk8S6RmFK7jN9RkWcPzyGcHIIFLAGDshR0yLUL hMLwaaUZj34S715vy+93AzEPGSVCzY1WO4+Tvl4TeI8Smq/xmRAwoqlMGztb5rNMI6ZE no8c/TyEcgRqhVZ/LNZOyE0U+yOcIGnaoZcVdqoxbX9BIeP3OvVqU6uSXwb8ysWECPx+ M2Gg== X-Forwarded-Encrypted: i=1; AJvYcCVzW0+qi3m4XAEbcb79Tv9wj0sWLOGhfen/QzEN/bavIA8F7JeeUPge3Yq5LSw5TG3hZpHPvMsMWQGF4nc=@vger.kernel.org X-Gm-Message-State: AOJu0YwGAysZVNLMKbzJJFHDQYj1G1432jSQsux9fzvHIrNFlcC+OEgX 2n5z5Hcz2PKhCvQ7+e8UvFtmXU7NVYlN3hAMqVxketVEePwXvEpvpM8G7RlZrDR6a5P5LoTylGj WQpObR/12LQlZ4aDsrgvHpWNOuPJhbc4CqjPBQmQAiooHeJ7wNVgcFHyySjN8hfKcwd4= X-Gm-Gg: AY/fxX5FLE7ZCcg5ZlOIgBlrclWX8fGJitrhdZ41wU7KjcrsoRahx4pmN5t3/SpuHsO bBBiRNu0SzGDYst/9l8C89g9iMtkeX1CcC/Gaa13soj1bEEW5Hk6b9R26pp826j8CVdQlvPeUKf TSj34XUGZUW1HB6BHV/Rg+iniWKOEdq3KVQM8/Marb9D+1gPnfWyG4iIVtvUrwXrfSxg8eXzXx6 w8OCmoEbA5Y2vrr8lJhPzPO9l6dGEy0pJrd6w19EgAleSoxRrEn+JAJeywKRAMflyGqKrvqAD8f h+UHzDhs0gcrlK7a5VFjn2ZGOukDN3AU7fP4XztCTquiMrGAOGqucDHkxBqxnCeIuNHdXbhCp5H FX7YNKAvvQS/HUkrGzihTOFmze3ISq7Q8toVDCo6pLazbWjsMK4u4gmSoJUk5l4j3op1AJ2vSht IREiOtx8GcArkI4YOyg+qU8AA= X-Received: by 2002:a05:620a:258c:b0:8a0:fb41:7f3c with SMTP id af79cd13be357-8c6a66f8dd9mr1536272085a.27.1768825039603; Mon, 19 Jan 2026 04:17:19 -0800 (PST) X-Received: by 2002:a05:620a:258c:b0:8a0:fb41:7f3c with SMTP id af79cd13be357-8c6a66f8dd9mr1536268385a.27.1768825039101; Mon, 19 Jan 2026 04:17:19 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59baf3a17b9sm3274641e87.92.2026.01.19.04.17.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 04:17:18 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 19 Jan 2026 14:16:38 +0200 Subject: [PATCH v4 2/4] drm/msm/dpu: offset HBB values written to DPU by -13 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-msm-ubwc-fixes-v4-2-0987acc0427f@oss.qualcomm.com> References: <20260119-msm-ubwc-fixes-v4-0-0987acc0427f@oss.qualcomm.com> In-Reply-To: <20260119-msm-ubwc-fixes-v4-0-0987acc0427f@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Val Packett X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2116; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=PZQ/HyJUBzLI4q25Cr4PA1zrRatPlEyyxDNqfDEZSTM=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpbiDLFZ6M1k9Dzt0HQxU81lGHZ4S1WCvcUQ6j1 i3M8BIIrfWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaW4gywAKCRCLPIo+Aiko 1cxpB/91qJ3F2Z6sVCwbnkATmecyx5/y180v0zAcduBX+E2Kd2Iox9l0bwlm7oingvUb/gMg6Vu i2Ft6jpcsEfxJP8LNm+ejWozDd2PUvErw06rAdh+MGdtindnXY8Bfhw9aI/ewgkNKFbK7daxaGu njAUPDg1TVFw4FTnWsZwd+DduBpK0ESNBKp/ER05/Lif+vyelQb/cS4XirEm2/zmnQslYYz9S0W M0kIi9vykXTmOvvFOY2t9NAbIpgBhKMXyyKWfkSLahLQqQkdH1b6DLZ/9luezikfV+Lbey88ugi zf3MqRbicIbWStMiKxerkCna3iTtmZforsH3q8yW9V/A+sPZ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=Fdc6BZ+6 c=1 sm=1 tr=0 ts=696e20d0 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=1unLKcHO38ebvhyrShMA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: xVwiUmNO8XndlbStC6oh1GEKtaEJ2eX2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDEwMiBTYWx0ZWRfX9HDaCrV3jSys mMtU8pTinsE1PtUo797rK5XfFi6TCbPVPsJb/bAl5o5MkcAZOEskQDbP86CBbM21XuJHV9dNN4Y DLPZ29j6yTDouUcNNPMpVDTOEi+bCawRmWMSqIsTzcfUauiPDS89MY6JtvfoFi9KcgUkyI2fSYa X/SGP45Vhe4vzstu3NJDEVf/ZPtKjgqW+0BGuXq01zbfLPbvWJEkbPgOwoYkvE1CUiOv0E1hS7I 5nO7OC4OUSqyF7b36z+KADOGf66tK67rC/Lb08hoBt8H90pznE/U3vVHPG7s6QIVIJRpXlD8HSk OHVPm0TBE7qZBGcOqvipRou2XyYL//wC5yjVNNNjtwAw6aSGL7QHskJt0XoNFlM9ibbhKuWhgSr dlnmwlCZMg2vZ1N6woEfwu7ZVA83eVeVE4dntltLXKO+SStKkC5/J8egCDUvwQINVmnwBGhAO2t z3q2PjBD+Ud01L5JrBw== X-Proofpoint-GUID: xVwiUmNO8XndlbStC6oh1GEKtaEJ2eX2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_02,2026-01-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190102 As in all other places, the Highest Bank Bit value should be programmed into the hardware with the offset of -13. Correct the value written into the register to prevent unpredictable results. Fixes: 227d4ce0b09e ("drm/msm: Offset MDSS HBB value by 13") Tested-by: Val Packett # x1e80100-dell-latitude-7455 Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index 6f1fc790ad6d..b66c4cb5760c 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -270,30 +270,32 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, ((fmt->bpp - 1) << 9); =20 if (fmt->fetch_mode !=3D MDP_FETCH_LINEAR) { + u32 hbb =3D ctx->ubwc->highest_bank_bit - 13; + if (MSM_FORMAT_IS_UBWC(fmt)) opmode |=3D MDSS_MDP_OP_BWC_EN; src_format |=3D (fmt->fetch_mode & 3) << 30; /*FRAME_FORMAT */ DPU_REG_WRITE(c, SSPP_FETCH_CONFIG, DPU_FETCH_CONFIG_RESET_VALUE | - ctx->ubwc->highest_bank_bit << 18); + hbb << 18); switch (ctx->ubwc->ubwc_enc_version) { case UBWC_1_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | BIT(8) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_2_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, fast_clear | (ctx->ubwc->ubwc_swizzle) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_3_0: DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, BIT(30) | (ctx->ubwc->ubwc_swizzle) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_4_0: DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, --=20 2.47.3 From nobody Sun Feb 8 22:01:05 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 643CB244660 for ; Mon, 19 Jan 2026 12:17:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768825046; cv=none; b=DvqQ38NL871FMxuQ1gth867B34OJpDSP19QJlMuMlfyDRpJqHS0ASakK9TWNUAfAbmhKluHYTWyS1KFr0JccIVjusCgzJbOrdmVSMyJpzlr1hUq9FVDquaIuwlkdAoe4wy35g+pZ8u0yzp3u/sfB2Xwa+DtzlwM8N85h/IVWrK0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768825046; c=relaxed/simple; bh=j7ALa2ZclhoGMQnJoj7aJ1Do0/fMTZqp4zi/tvC4Yrs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rAOPXgSkuwaVJ3LG5yU7LoGuiMmitHON4I6Ft89vQNmm2lhnxDlTWch7wGXoXkO8ajCl3d/Auuqbe3RfpwevOx8XN5AeJSbNgGM9DG/6ecpDQQH7S3mbtiU/TB0e3kvMb+nDpSm8wxK7+UQOkfM85txZ1yIiISestsq3JZhQxX8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IPZpVwLJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RRbMKvxJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IPZpVwLJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RRbMKvxJ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60JBDMCW1440838 for ; Mon, 19 Jan 2026 12:17:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ODvajz5k+1YRXA6Nwokuzw/VMyW4/mE+fTtWqbu7rKg=; b=IPZpVwLJPuvCjP68 EoXnbOX2bzoU+tuQhq/IuETuOxfpvrvxHmSzbWOd+1epPb4wsI9ioMpvcVHF+Gnc Y28i1c2a6s/MklK5LDwOThlPLmtp4ZB8S5C0NYqVb0IPq1OmEvnlI4dKgK9bCWaJ +wDybahgZcE4bCioOW5d8zAg88TuEQ7JCFj6L/uNEvNCYsdo59GVICPx9/FMnupk oeCmOU33uP2A37xAG8cyG+TZizK8MZpEyBrt3zcHmqxqEaeRuGPnCIkrjy0lJ1Ne NUDKH99bzopgButMyP8nllor5LJN4uNloTCHWKzDoWuivzUOwCAfkrjzbg2KY/6K Q+yGKA== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bskj3g5h2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 12:17:23 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-88a2d8b7ea5so47432996d6.0 for ; Mon, 19 Jan 2026 04:17:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768825043; x=1769429843; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ODvajz5k+1YRXA6Nwokuzw/VMyW4/mE+fTtWqbu7rKg=; b=RRbMKvxJMc5FLLOwDeDe//3MVExAp8xSYMI9xmEH8TAtjdSoctyRxnNGO9FlqzPKin oW1gA/WIKov9bTREPD4CoULwRToM1jMDZwV1NSK0XvcU2zWyVkDv+qiuPgMeopnWaePl S+T457YGVv22a9lFHEVhpto3j9ncbGVpLWtVHObLz2yZzgBGGV3LTyeESJMu96Xtk7YI EAgvneDdZ9BYNllsol5VpBkyTRp4xNSWGFcXPmZ3nAt7M4P9E1iU12zEI00RORTZazmJ novDUzSm/vBDbyZ6LKacUSolaAeap0XE5RahfjdMiAB5r0E1nGAkFtXgiExN3BCnNdMN BZvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768825043; x=1769429843; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ODvajz5k+1YRXA6Nwokuzw/VMyW4/mE+fTtWqbu7rKg=; b=p/bc0bbECqVaWRvxfAJ0L7v7QZB3hmZuv59NPC4doMgFPu0xlDTCEqlHKKgwW0ku6E 47evsAT28g+0mUsT8EzOyVUtDCQbhPzCmr7I0Q48Y0//Qw26pCTp+aNe1wUDQgBo00/+ QuYm46hQ/Bh/GSDaiI5mt1HYe5d5ofBAkagjJ6AftdLQGuzBCFwddtqKvvW5/ECHDKvO dDisR+0QUxm2eXwDqidPMXogh8tClMZ2L+BjtX5y+B6eU1e+61U71v7NdapdX3OdaR1U F1cokI3Gfekdd8iqzc0iIGorLf9fUFdroPicH2CkA+ByK0rPga2QemcZ4HG3QBm8620V VgZQ== X-Forwarded-Encrypted: i=1; AJvYcCW5wSnHK/VfDMpIy3+Z809DZPVIZuVXqtbhdVdX/ta2LYQoyMotE7ZpybZ8boeuF8lMBL+FyckLUB3zDuo=@vger.kernel.org X-Gm-Message-State: AOJu0Yyhr+BTKoWGVoUPv2AEoJuee9PZudL9HjdBvymmmQf4F3d/DmX8 dQgbN7pqw0ERUIh/IpVjVndsjRVAdHCv1sj4JZN84qYm7ItgPGe2/iMflwlTmdY/5NSgXK/xCfK 3pWQNxDQuL8u6DjGN4KTPAwkyg3LEmTV+/YYwfvh4Zcgim0KkErymtTM6/9ShUxljBGQ= X-Gm-Gg: AZuq6aJz02PFNbUtBDWFjECbNLljG5ax+xBhVPJB/rfoWoxUUQXK8enLbbl4RvFxIu4 SRuGEx4+skGvgVHITPMQMJtrzZBpAP9O3vvbdP+dVnH0ZYazPhRqEJllsPoT0kfJNsc13DIyWcq kQ6WD8SoIS4K0tuSjL1lscFTGnxavvkqo+HAjO5VwBRb54htmMZnJn3QNn+hriSiDrSrdSEZtOx l3F0XoekAgI4/mNpQyXWn5SviY0lHD35nGN60tbKKAmGKqMbAi1DJkF4XDEenFvTeUlh7/LKz7V DMvR1T+WusCP76PBY+D2ATm8qJ27Fs8VYhCKk7tx5GM5T2F1rgT/5lKD0PNZVTL4cO//kUmc8q3 t3KmFq2yUUUg7QZWjxiyxDJeNZeGhEJDaSiA31v7vuvqkNAzhBF9LYp7Rm7GvLdU5mKCeQ7KLoM k/AC2q5Fb8CxkPvN95Mr5mfW4= X-Received: by 2002:a05:6214:629:b0:88a:3113:3abf with SMTP id 6a1803df08f44-8942dd8e7c8mr153078956d6.52.1768825042395; Mon, 19 Jan 2026 04:17:22 -0800 (PST) X-Received: by 2002:a05:6214:629:b0:88a:3113:3abf with SMTP id 6a1803df08f44-8942dd8e7c8mr153078406d6.52.1768825041762; Mon, 19 Jan 2026 04:17:21 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59baf3a17b9sm3274641e87.92.2026.01.19.04.17.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 04:17:20 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 19 Jan 2026 14:16:39 +0200 Subject: [PATCH v4 3/4] drm/msm/dpu: program correct register for UBWC config on DPU 8.x+ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-msm-ubwc-fixes-v4-3-0987acc0427f@oss.qualcomm.com> References: <20260119-msm-ubwc-fixes-v4-0-0987acc0427f@oss.qualcomm.com> In-Reply-To: <20260119-msm-ubwc-fixes-v4-0-0987acc0427f@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Val Packett X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3623; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=j7ALa2ZclhoGMQnJoj7aJ1Do0/fMTZqp4zi/tvC4Yrs=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ2aewum/G+1ffRMqUL0xI39LiBqH4eGkfwYP4uNeMlc7/ S5hLmHoZDRmYWDkYpAVU2TxKWiZGrMpOezDjqn1MINYmUCmMHBxCsBEumvY//C9Wblebvp1pYT4 f/e736Zn70xWNo+XX//xTPn9j+902Riu1Sh1PjXZKhafFfiq66f3AgmX3aqLbfqv/90pNmnOgwL 3z9ZCoUJNqqF1LE38ebs6pBwnMTcfMJHWfuC/hWnJEr3sG5PNdXgcs8vdS7fE1cm2bKu2m744/X +HZMceuU7PNLV3U4JfTTRV4zSMOct1pOp148FjgR1Nqwtta7bsfd7CydyfOlt/26942WfT/jNmH +X1Wvbh8etzXPus1FwuTrV4N52DIXiexss3leUCOp/F9umznX9jWLw2uu9kdY7pgRnrjhg9j757 RuhPrV+hZL6qs9O7C/oBr5u5XvcfEFkc+db9o5SEfkU9AA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=ds7Wylg4 c=1 sm=1 tr=0 ts=696e20d3 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=BEO5sv_cWZf0Vc4k7EUA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDEwMiBTYWx0ZWRfX2GWzcpZT8N/R XhvC4qPbwurxu1kj9hMZ+rNbGijee8UEK0jIqpVoqYUvz4IuDuhb2agGzaraesz0sM4iQ1TZc2s E24sxCJORtlb+HtwZvqRckAIFtnEPq+SL/B4farbTmXzu5bWkw8+aqEUambAjKtg5meiLFV5BCc e6WfjsorsjWaB7FmvggFZgcLrC0uZxdjqaPu61XI9PY1BsvYl3QEKxdR2PiFbnqWKyOU9qRPQDf G6Ta7T4DCdqSfaDYkO7wFM10WsbL4Fm/3ikBtaQ+OFh6p97daux0biquApg01CEM+nRGsU/Vj6H EZahp0s8q385nUmP3PMYUoRHyRh7LhOgwfy9ahdbQPOT6N+UC8zU11PiXC80oeqlCjmyKHPQ6I3 C+MTll+9xpwSe+2nFjhj33T33FRoRajl7OCexLpxCVLGIpetf9OfcQpF0jU8yO0lUtDbtKGQ2jO sRnDl5uElpORh5WBj8w== X-Proofpoint-ORIG-GUID: oS7Q-4bV1pJMsCqZ_kHYPLe-Irv_N8dV X-Proofpoint-GUID: oS7Q-4bV1pJMsCqZ_kHYPLe-Irv_N8dV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_02,2026-01-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 phishscore=0 priorityscore=1501 spamscore=0 clxscore=1015 adultscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190102 Since DPU 8.0 there is a separate register for the second rectangle, which needs to be programmed with the UBWC config if multirect is being used. Write pipe's UBWC configuration to the correct register. Fixes: 100d7ef6995d ("drm/msm/dpu: add support for SM8450") Tested-by: Val Packett # x1e80100-dell-latitude-7455 Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index b66c4cb5760c..6ff4902fce08 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -72,6 +72,8 @@ #define SSPP_EXCL_REC_XY_REC1 0x188 #define SSPP_EXCL_REC_SIZE 0x1B4 #define SSPP_EXCL_REC_XY 0x1B8 +#define SSPP_UBWC_STATIC_CTRL_REC1 0x1c0 +#define SSPP_UBWC_ERROR_STATUS_REC1 0x1c8 #define SSPP_CLK_CTRL 0x330 =20 /* SSPP_SRC_OP_MODE & OP_MODE_REC1 */ @@ -215,7 +217,7 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pipe= *pipe, u32 chroma_samp, unpack, src_format; u32 opmode =3D 0; u32 fast_clear =3D 0; - u32 op_mode_off, unpack_pat_off, format_off; + u32 op_mode_off, unpack_pat_off, format_off, ubwc_ctrl_off, ubwc_error_of= f; =20 if (!ctx || !fmt) return; @@ -225,10 +227,21 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, op_mode_off =3D SSPP_SRC_OP_MODE; unpack_pat_off =3D SSPP_SRC_UNPACK_PATTERN; format_off =3D SSPP_SRC_FORMAT; + ubwc_ctrl_off =3D SSPP_UBWC_STATIC_CTRL; + ubwc_error_off =3D SSPP_UBWC_ERROR_STATUS; } else { op_mode_off =3D SSPP_SRC_OP_MODE_REC1; unpack_pat_off =3D SSPP_SRC_UNPACK_PATTERN_REC1; format_off =3D SSPP_SRC_FORMAT_REC1; + + /* reg wasn't present before DPU 8.0 */ + if (ctx->mdss_ver->core_major_ver >=3D 8) { + ubwc_ctrl_off =3D SSPP_UBWC_STATIC_CTRL_REC1; + ubwc_error_off =3D SSPP_UBWC_ERROR_STATUS_REC1; + } else { + ubwc_ctrl_off =3D SSPP_UBWC_STATIC_CTRL; + ubwc_error_off =3D SSPP_UBWC_ERROR_STATUS; + } } =20 c =3D &ctx->hw; @@ -281,24 +294,24 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, switch (ctx->ubwc->ubwc_enc_version) { case UBWC_1_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_ctrl_off, fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | BIT(8) | (hbb << 4)); break; case UBWC_2_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_ctrl_off, fast_clear | (ctx->ubwc->ubwc_swizzle) | (hbb << 4)); break; case UBWC_3_0: - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_ctrl_off, BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4)); break; case UBWC_4_0: - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_ctrl_off, MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30)); break; } @@ -327,7 +340,7 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pipe= *pipe, DPU_REG_WRITE(c, op_mode_off, opmode); =20 /* clear previous UBWC error */ - DPU_REG_WRITE(c, SSPP_UBWC_ERROR_STATUS, BIT(31)); + DPU_REG_WRITE(c, ubwc_error_off, BIT(31)); } =20 static void dpu_hw_sspp_setup_pe_config(struct dpu_hw_sspp *ctx, --=20 2.47.3 From nobody Sun Feb 8 22:01:05 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C0853254AC for ; Mon, 19 Jan 2026 12:17:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768825071; cv=none; b=Nk5ggzxsw3EIz89EEDWmUlT+JKXXVSGX/MWHOz50O3cfSFhnDf61NbJx3aRm3O7ktiBt7aNeASqZcuWGBmj4NPyRsNkilh3V9+sNlLnDO95bNa76XkZNRx6YJS6j1j2757cP3SkCi0gt/Ak1Q8CT0YCEZ44rc3xXqiygmuLVLV4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768825071; c=relaxed/simple; bh=hK4mO/cagHj3HVYjVR3i3QZO8ZbZgg9vO0ANe18SGRw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TZp1OmnpR1Pq7hfJimr+gTfPRN3GLETlKsozyXS/SdQX7tswEd0Tg+iAGyN9HrdrqoIa+c2DmbsveGGQdKnaoH0fTelXFrN/JbIcl8hP1wg5PfUj84P8kpN0QneP31lHG7PuBPRxs8FkGPdtGTAk3GEk7dvvXEwCiCECXR+bxg0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=C7zxh3D5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AwYe4Ns2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="C7zxh3D5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AwYe4Ns2" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J9143J903258 for ; Mon, 19 Jan 2026 12:17:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1+R1NURe0aOQBp8d0tJX9/rPnT/UJh1DxdGIX1sR33s=; b=C7zxh3D5av3+lFSy TDVSFodXBe0LK+CdMRyvl+zIIZSy79R6llY5l4BiNEFbe/bJnLOukNGaQxj130xt 9tymzsvPWCY+NVGZtW07cPhPfq+dklHbkGfKIWNjGDK7WkYvXD/+aE85/kKBXtmb hwtEkcyL1gaKRCH9KOV+64q5cl3sILjgGtV4+/a3Vxsjeyl1DGVHi5cZu6kaBEeb KfsucreD55oUBkp2U6T7kFQ0HQnipAdZaUTyJ7BVVR/73Lj5xnNDCuaxW/oFsd81 tB69RpSQiTWOi1MnUAGZBTuuaeQbEvMg7ptXR1tIv2ZHfv7JH998pzkmsusAD1tU 2z2kfg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bsb4ysspf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 12:17:25 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c6a2ef071dso1271378685a.0 for ; Mon, 19 Jan 2026 04:17:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768825045; x=1769429845; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1+R1NURe0aOQBp8d0tJX9/rPnT/UJh1DxdGIX1sR33s=; b=AwYe4Ns20XnFf4Is+2cKxrF3a1Eorm1VcfngrEfFH803AbQz9VIvwZs+Vcomvc7b0R xxqkFwYi2ua8ip9LRHvgK/rFCnfhWeEzCpYu+Jx1aT+WVRIHp1G8UVTHWsHRSDMmXUYx BN8AkOEB1H/sL3qN/Oq2AfyOGgF+Qjc/7H8IzkYQaueAPmagY++50BEeGoqERU95VLOQ VN0cprnaOEBYrSEPQk8rNGrq4NG+KUYC8dm16GwNuDkuE6XFf0zhXTzcgoDJ5stSLD1A o4HjhB4w2xX/GIfuMdnVnZFrRFjN4V6+1+qoevztM4WLX472lE8UfU1r5060NSzGJxSg D7BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768825045; x=1769429845; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1+R1NURe0aOQBp8d0tJX9/rPnT/UJh1DxdGIX1sR33s=; b=ckDXYP0SP1rtgMCmMCSD1xY1lbCTz4dN8+su0hUcVAWa0S951Mx4CuAgtXZxKJmz+B KIzx/cy9CmaKucWUwJMPKxIp7ZhOu1za+nksimdkEHsLwfb8lXhtXs9p8Y9ct6/HkM84 QZThOWiNZ1fBK+xWmkoE8K4xrlpGObJoSFUY3hKj19LbG1IxEebymARiUPEpkc3Q3nT5 957kg+1UXo3eHsJpTA7PsbZVbeOmltFBKEQkUpJoZvQBK4QMRmjh8+LvxSs4+5pObesI L6KhOEsr6Am+VC7QFCV/fNSwH+FKxyPb5ooMYYErl5N3GUGArtIDtXj8dOrVe5lXr4dI C/Dw== X-Forwarded-Encrypted: i=1; AJvYcCU8GaAQ6Hz9FV7ExMAeR7Z9Yb0y8zdX6B9gaCW2qHQqtTMIsBh2ODKZZCRncVMRYekueO64dvMZFC5a/S8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7QdsYmbhD9ZVZOG5hZEa4q4zFv66oJOcwvXaTeO6ONTah8uUa 8yspTDuxfWfIryvkEkmMu/om7jCeMWdI1rfKuCPqBx6dZAQWzU+zYr48ZxKe9PMey5QbCqSWaON mZmRP2J8bcBQ+RynfomqwXa4mv5m5FFF46AUZsvx17fYAdrSPpAKsVC0YWsDEG8r+Y28= X-Gm-Gg: AY/fxX5kW5acOemwrO+Ek/pF51x68ko3WX+STzFGYyidUqzmBG/AhXZBg9WCLaxD8ry iSGko7mROvcJGMvDfw4l2Z2RmfmiVr9tY3i3VQVW16WQKUkybNqMA64rjjo7BFxpZXp6YZAMjFT Q9f2ujyJMhmgnoCKKsE5uUEf/1hJYk33F6SquXPWg2UlkGivkz5BGD08OTOjYNMTem8i2eF8Fsg m4hTFz+fOa03Znv3j4clftmaOmW/vlwJUCM1A3t8WATH2U2lGvTW2dNkr6iE1IQo+voQJvJITJB Z/NbVmXV2X51pSTSBEHVpipDBCSNt8Hn0LRxAiFbSFqREWhbpsQCCY349kmMdTORc0aGrTLrETh xWI7FR+Wqu+1fYnhic8Zrew+OOZU+GQ9cIfL9s41IBkP1/T0rDPugo3OVyoveGlsSbzNCs768sw ptkuqGFG9PhdjsBvYbDrvFwaQ= X-Received: by 2002:a05:620a:3947:b0:8c5:3495:87df with SMTP id af79cd13be357-8c6a691f35emr1541594785a.38.1768825044752; Mon, 19 Jan 2026 04:17:24 -0800 (PST) X-Received: by 2002:a05:620a:3947:b0:8c5:3495:87df with SMTP id af79cd13be357-8c6a691f35emr1541590685a.38.1768825044215; Mon, 19 Jan 2026 04:17:24 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59baf3a17b9sm3274641e87.92.2026.01.19.04.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 04:17:22 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 19 Jan 2026 14:16:40 +0200 Subject: [PATCH v4 4/4] drm/msm/dpu: fix SSPP_UBWC_STATIC_CTRL programming on UBWC 5.x+ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-msm-ubwc-fixes-v4-4-0987acc0427f@oss.qualcomm.com> References: <20260119-msm-ubwc-fixes-v4-0-0987acc0427f@oss.qualcomm.com> In-Reply-To: <20260119-msm-ubwc-fixes-v4-0-0987acc0427f@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Val Packett X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2999; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=hK4mO/cagHj3HVYjVR3i3QZO8ZbZgg9vO0ANe18SGRw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpbiDLpqeQzOXgyf3tXynVkxvGog9EgSHQgbY48 /KeMdsJMhKJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaW4gywAKCRCLPIo+Aiko 1e/2CACcDaJ6s6kfm+vHnD/D6JZRlYJKgJpb6vVJ+CubGxlksC2JZK/iBXaKvdU435oeEqvlR+A Yt+GmgPjHbmDSGXVLx8gj8/vu6AtqxKz3yRy/WpPcEgOI9N2Yap9grQHG4IC1C4UPJwFHtUELzK CLmBgwHX8VLI/U9iqp34YeYlZLjAvpNqya8tAxv5zaoHoR+3mx7N0i1XzUmgK5OgtWFa9LYwFea XZLzz6LRRZH74S26+h7Ue79tjdrJ58maQ1Ic/d1syDvrKPI2ksCHPBPrPaIEoo6MhwayjVDqXhd gkNlqZWnjhlKc8SR1SOCwK/TmDh9XJ4m2GldNLuMdoY8AQW+ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=SNhPlevH c=1 sm=1 tr=0 ts=696e20d5 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=7FpWx5GjbivZIX0HvvoA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDEwMiBTYWx0ZWRfX/NNV+DibNTow dluZiI8S1gC9VaE2E+xBRNn10PHXaQjKmgJ/HRSUz2AfLtFilQzENm9buP3eCFwlC/mkhrQdwrI 4L/FkUS2kYrlaA3QIy4McoFAq3Q07oJe8awAfNJqYW5YwluweohevWBM1fX2G54FHoOFtazGK0M ZtOmOrtwr+ini7foD1BDiF1nnyzbMte3kFN0GnGE3HSTr8tsovimRj4vYmTWTXER4xeEeFXMfhM KWnWW2Pz19FoUnufm9k6tFxl4XA34quPOOtQGdhLfr88Wan61+DeN/GQ5pxaA29Wsc+DJ9yzLf5 j8Q2LKPxHRyF0bIGCk1UbZuc4m8X6h6rApBY7887MVII7c7SP2WNzIiSSjv9S8VFMv3ProVpi5i IsXTXRap6r3LbE/gGKlOp7nBXl9SSdtQcoqjZDnLvpClpMJeQbGJpTHzP5kWufg0zGCtQgPPMYs QsEAmcc9JCX5yf+bKjg== X-Proofpoint-ORIG-GUID: fmglKQhhDAlkiwQkGY_GZNTZiU02RnA8 X-Proofpoint-GUID: fmglKQhhDAlkiwQkGY_GZNTZiU02RnA8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_02,2026-01-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190102 Code in dpu_hw_sspp_setup_format() doesn't handle UBWC versions bigger than 4.0. Replace switch-case with if-else checks, making sure that the register is initialized on UBWC 5.x (and later) hosts. Fixes: c2577fc1740d ("drm/msm/dpu: Add support for SM8750") Tested-by: Val Packett # x1e80100-dell-latitude-7455 Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 45 +++++++++++++++----------= ---- 1 file changed, 24 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index 6ff4902fce08..f275b14da4ff 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -284,6 +284,7 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pipe= *pipe, =20 if (fmt->fetch_mode !=3D MDP_FETCH_LINEAR) { u32 hbb =3D ctx->ubwc->highest_bank_bit - 13; + u32 ctrl_val; =20 if (MSM_FORMAT_IS_UBWC(fmt)) opmode |=3D MDSS_MDP_OP_BWC_EN; @@ -291,30 +292,32 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, DPU_REG_WRITE(c, SSPP_FETCH_CONFIG, DPU_FETCH_CONFIG_RESET_VALUE | hbb << 18); - switch (ctx->ubwc->ubwc_enc_version) { - case UBWC_1_0: + + if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_1_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, ubwc_ctrl_off, - fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | - BIT(8) | - (hbb << 4)); - break; - case UBWC_2_0: + ctrl_val =3D fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | + BIT(8) | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_2_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, ubwc_ctrl_off, - fast_clear | (ctx->ubwc->ubwc_swizzle) | - (hbb << 4)); - break; - case UBWC_3_0: - DPU_REG_WRITE(c, ubwc_ctrl_off, - BIT(30) | (ctx->ubwc->ubwc_swizzle) | - (hbb << 4)); - break; - case UBWC_4_0: - DPU_REG_WRITE(c, ubwc_ctrl_off, - MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30)); - break; + ctrl_val =3D fast_clear | ctx->ubwc->ubwc_swizzle | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_3_0) { + ctrl_val =3D BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_4_0) { + ctrl_val =3D MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30); + } else if (ctx->ubwc->ubwc_enc_version <=3D UBWC_6_0) { + if (MSM_FORMAT_IS_YUV(fmt)) + ctrl_val =3D 0; + else if (MSM_FORMAT_IS_DX(fmt)) /* or FP16, but it's unsupported */ + ctrl_val =3D BIT(30); + else + ctrl_val =3D BIT(30) | BIT(31); + /* SDE also sets bits for lossy formats, but we don't support them yet = */ + } else { + DRM_WARN_ONCE("Unsupported UBWC version %x\n", ctx->ubwc->ubwc_enc_vers= ion); + ctrl_val =3D 0; } + + DPU_REG_WRITE(c, ubwc_ctrl_off, ctrl_val); } =20 opmode |=3D MDSS_MDP_OP_PE_OVERRIDE; --=20 2.47.3