From nobody Mon Feb 9 21:20:00 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41CB333CE8D for ; Mon, 19 Jan 2026 08:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810646; cv=none; b=XZOKgwxbjLEkmXH9mVXkklddhgkQYCQ5fCds7f+s8L4ARb3tLsoyDsSexeaW0rpDjbDmi7fOGBTi70IIHmmEaIwVK3PkOG3ndpLg5rDpuMeg2OiupjfhgbDyneQ+BqlRd8hIs+yHdvg4lpT5HfMSzI4Z8+35prv9cQqYxnXIu/c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810646; c=relaxed/simple; bh=9rYsLNuEACuzhywI0tRJ339OJWdDN6xkayUa/9Ma/Po=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mHE3fRWMtZs0F1MLh2FAvrcJPqNnJaRMAsPp1qFcY/RCWtpBIUg3WvBStRj/AU22lg6WF/Med2yZ/e52ePmTALAOpd2CEAwVgCcsZgYWQNorYKZl6Z1e+xic7C78MDt7ADiayAVWrvINKCb20IBb0S+ohZih/L5QLADY5O9Ki4E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f5nFLgAY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NG48zTqV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f5nFLgAY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NG48zTqV" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J7hYLF039971 for ; Mon, 19 Jan 2026 08:17:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 87X96O69HjPFMulPg1QR+SL19iQWTFSZSdfYbuNZu7Y=; b=f5nFLgAY1HDPwSHD z9EAo74k2884XGgOpgA4Ti84KPi8+DgA+VPSkYhElavI7IETWl7mWZ+uG7tY83lG 3qgnB1M5m9Yxa5FYrUsNFwzymaWMyqgpuXrzxDwDo+/Hn9GIB8Gwz0GDTYXZ4/Nv C6KofOe1SxF/nSKY5VkWKZZg9GrJjhCl8R7uLzGjJ+/QauDAbBB2ErEinopnhqnM c+pic2gOvwWBuj5eBs71QbxsGojWfS0ulG0kT9PJ6dGTlji3tMVt86PUIJ6Tq1tv pc2OljToIW50KavPmsd8HHuZZkGyybAxlzR8wlsCdv6DCS5wi+ORnluXPWiK00/k 6R/dxA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bsgfr84k8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 08:17:23 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c5329ed28bso1051994085a.2 for ; Mon, 19 Jan 2026 00:17:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768810643; x=1769415443; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=87X96O69HjPFMulPg1QR+SL19iQWTFSZSdfYbuNZu7Y=; b=NG48zTqVeNhXdFfRsClLExfKqZ4ajQOQrC07JfpBZ7/MJsL5i5BN0UaaF1AXhuW56S nQwoxX3SLz/k+GCmM+e6S6drKSC0lKR5rlLCNwr9qr7MP6H/ZbyRtc/PA2Nf767JL/h9 fS9kCr4Ja9kF+0wjK504i6J5IR/Vz5+cz9qO7JuyeduCY7IegbeYdufWxr55/Xmr+LeR zReJOZ17+UEK1DtVQP7uZKIgz3rJ3NYuL3bd40lG/6tHxcyJmmScnRFgFcVmI4oFyGRB ++V0KDsB0QsWO+hbvT1iLxQ5DcHXyUhXyK6J03f+J9sfjrA6r3FDlo1oRARQH6AURGae iBCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768810643; x=1769415443; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=87X96O69HjPFMulPg1QR+SL19iQWTFSZSdfYbuNZu7Y=; b=KbVfzVZHx6sqQB8X69oYm8Q4Pvap0HuKztUyGJ2Hyye2qq0rBpWranxz4R7biayEfB NQjZNXVZvsgMeDesccSJko4cOJEvogqyfJQ9B49BNEbzD0tFZse98U73fZo/CdF6Ppz1 /Hb2qrUa8pD4Bo6Ur3kNHB2x1x51canzDMynkjBWHofwXeOYAbtR++oDc3pio/Z/58bp D8pcwE/lX0VcPPj+OZtRZnX2BmE0sWwB2RZE4Mq6ecGEyEQF1ZA19X9BZZld4N3tW04N ni6M7xFUYKi0Jc7mvmwUsUyO3BtHIWdDzOyWXJBOchCWOTjAp5lxkDa8EvsUq/+4b2Vl kf5Q== X-Forwarded-Encrypted: i=1; AJvYcCX0S/Xxo0hjrtQD+R1ARA1iJHedix+sjJftKMFUVbP6dHdsq62A2nLR33xs86qSPurgb/zXGAvRWcL4g4o=@vger.kernel.org X-Gm-Message-State: AOJu0Yxwky6m/pzC/TOtei7aQqJBi42zEbKF7YEVF+xpeGbz3WLRCO7i LrqSNE7qhkHBL4uypoqjXJP8pJMQdlDJQQovpSiDS5MLgvMUBtVIe0ru6wWORvVW4JES6isY8HW Oi52SMLTl2exjZ9B2V0i3BzM+bBoRo7DSA+gBTx5Y/WbHWaX4EClInmA2EsnE0xXT3To= X-Gm-Gg: AY/fxX5QW0k5cOeQnRERy1eLgN4BFm8TBCkcE3svkpPuKKmtmFCzXTGW48i7j/d7CTO budNxHPYm1topBRjPspBWmEykVKaiYoYRNJhLrybJZM7bVwj6hZa3FrA+BNRvRq0Wh/7OASbnRp 4QUDVL+42n6b1VvWC1pSSamGYB2eo1EJIJUICUO1PqIaIkd4AsmD6pcC/vt+PKM3Vj1K+NyTQKE 75ks25+Oh0Od/EjehMxRNbJ6ALnPywQ7c7hKbaaSv2vk8F2/Td4Budr4aFc6OsbzdwIM3AJ6iL6 fYiUyKrMMuUnyQvSkxoNtUDlQDFX2KfQ5WW5QKCCkm0i1sp0nQw6RVFP8EyOmnzUZIrgmYEjDwg 4j6kJxRLyuocsb/FZj+AuFFY5J5/Ho/IihgtcL5THBdiMnXPXkOem0lqSRSTsKWHIpzozha8kYY eH5buJIe7fJdv7PBx5QopLErk= X-Received: by 2002:a05:620a:4049:b0:8b2:ec1e:fe30 with SMTP id af79cd13be357-8c6a6768664mr1454264085a.57.1768810643258; Mon, 19 Jan 2026 00:17:23 -0800 (PST) X-Received: by 2002:a05:620a:4049:b0:8b2:ec1e:fe30 with SMTP id af79cd13be357-8c6a6768664mr1454261285a.57.1768810642692; Mon, 19 Jan 2026 00:17:22 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38384dbec4dsm29636391fa.20.2026.01.19.00.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 00:17:22 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 19 Jan 2026 10:17:17 +0200 Subject: [PATCH v3 4/4] drm/msm/dpu: fix SSPP_UBWC_STATIC_CTRL programming on UBWC 5.x+ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-msm-ubwc-fixes-v3-4-34aaa672c829@oss.qualcomm.com> References: <20260119-msm-ubwc-fixes-v3-0-34aaa672c829@oss.qualcomm.com> In-Reply-To: <20260119-msm-ubwc-fixes-v3-0-34aaa672c829@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Val Packett X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2955; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=9rYsLNuEACuzhywI0tRJ339OJWdDN6xkayUa/9Ma/Po=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpbeiLLojkLl0l+zM1+h0l2qpcUidmSQV1rw+h9 D+WwgtfE22JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaW3oiwAKCRCLPIo+Aiko 1cGZCAC0A7tmbVhi9GlkQf5dplKw2Mi34dw/Bqiahw6XorhTYT5UCjmIMBhkwgtvJT7mPbwp875 gcQKMZmC5tXIHeSNPStlBtQzk9Q2Ty1NkjB+cLjU37G4qdcdVxr6ppbhywf5bQHsDqPdcTicSEY uerl5IVtPd0pqryeyTuOTUvqQYo+pllR3oNpC47OayU2ZwtENSE1HVKR5qFAdKn4SzcWy9ty7DZ /ksQKWtv6pOGTrE3efVoZfpR6wU2ZbJ9QBO0p2tp4LDJwnVbby7HNZu5gWawdBYHCLR+1xS6UK9 XPTC1wSjeiO0mIsiV1e4WZvuGqkiCLW3PWl7x9lEIvEXQzxx X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: YsnrjCUnFebakZcn28Wd6C3peiZ83Xwu X-Proofpoint-GUID: YsnrjCUnFebakZcn28Wd6C3peiZ83Xwu X-Authority-Analysis: v=2.4 cv=c4OmgB9l c=1 sm=1 tr=0 ts=696de893 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=7FpWx5GjbivZIX0HvvoA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDA2NyBTYWx0ZWRfX89NqxeEr85pR GgQD3o0c8H1inkFKQ+N6vx0wvdFZWb+J2lKrsgdy/9LMq981YghuGF7nWS9RfWYYyFLIPuBH5OX 2vw4fHWCKojjrcm5K1pded2bC1+E4iY0KCPJ6RHZUaf6HPTRTeboN5xvSepSY7Fddk4K6Y2T27E eF3BdAKt7V0ji9YDFXdjorVi5tgtVSp/rIW9ozPDh95NKMyGGft6SLJfzG/Z7ryV6RV6F2fUdSV +oMnZwBmbRA6QsJC/CjxToVAqohHwtZQcJT+JzzJGSPQTsIdjKnjykL8Ctyhf67+VTO3bDl/tR7 C58o8Hjj6F/IGEDptKJiGanljLLU2KZ751fdnk1i4TwF4P2mlaoSRvM/3JdlzGmzn1RtF+ZUnt3 5mJ2YjsN/Hc9eM3JQ6hpsJIXGBumr/xxxQ5EuPQa+qP3+CY8d329EytZ1tOtsoymNymG/KyT0qp +Co3zAb3Vogv0buktew== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_01,2026-01-19_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 spamscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190067 Code in dpu_hw_sspp_setup_format() doesn't handle UBWC versions bigger than 4.0. Replace switch-case with if-else checks, making sure that the register is initialized on UBWC 5.x (and later) hosts. Fixes: c2577fc1740d ("drm/msm/dpu: Add support for SM8750") Tested-by: Val Packett # x1e80100-dell-latitude-7455 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 44 +++++++++++++++----------= ---- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index a99e33230514..80a9fb76b139 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -279,6 +279,7 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pipe= *pipe, =20 if (fmt->fetch_mode !=3D MDP_FETCH_LINEAR) { u32 hbb =3D ctx->ubwc->highest_bank_bit - 13; + u32 ctrl_val; =20 if (MSM_FORMAT_IS_UBWC(fmt)) opmode |=3D MDSS_MDP_OP_BWC_EN; @@ -286,30 +287,31 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, DPU_REG_WRITE(c, SSPP_FETCH_CONFIG, DPU_FETCH_CONFIG_RESET_VALUE | hbb << 18); - switch (ctx->ubwc->ubwc_enc_version) { - case UBWC_1_0: + + if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_1_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | - BIT(8) | - (hbb << 4)); - break; - case UBWC_2_0: + ctrl_val =3D fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | + BIT(8) | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_2_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - fast_clear | (ctx->ubwc->ubwc_swizzle) | - (hbb << 4)); - break; - case UBWC_3_0: - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - BIT(30) | (ctx->ubwc->ubwc_swizzle) | - (hbb << 4)); - break; - case UBWC_4_0: - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30)); - break; + ctrl_val =3D fast_clear | ctx->ubwc->ubwc_swizzle | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_3_0) { + ctrl_val =3D BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_4_0) { + ctrl_val =3D MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30); + } else if (ctx->ubwc->ubwc_enc_version <=3D UBWC_6_0) { + if (MSM_FORMAT_IS_YUV(fmt)) + ctrl_val =3D 0; + else if (MSM_FORMAT_IS_DX(fmt)) /* or FP16, but it's unsupported */ + ctrl_val =3D BIT(30); + else + ctrl_val =3D BIT(30) | BIT(31); + } else { + DRM_WARN_ONCE("Unsupported UBWC version %x\n", ctx->ubwc->ubwc_enc_vers= ion); + ctrl_val =3D 0; } + + DPU_REG_WRITE(c, ubwc_static_ctrl_off, ctrl_val); } =20 opmode |=3D MDSS_MDP_OP_PE_OVERRIDE; --=20 2.47.3