From nobody Mon Feb 9 13:57:25 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9F2D30274D for ; Mon, 19 Jan 2026 08:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810646; cv=none; b=IXLeLW/VBsDSsT41CmHFriExiqwgu/+2G4UIbRDdgYNzrQG3tJo7qT0GBNVlbDS2DbegpIIka2PPDwYu5FUG/d9jS+L//EV4tMNdZlmQjSVA6nJESTUKYbIZXxL8ia7Ygz9mybSUZ3X3RN9NJRe7d4HIxJD2c4tQuU9DbzHZ2wQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810646; c=relaxed/simple; bh=HWBT7H+ACSNaTYDAPUtOQBPmeUobbB01ZGnKJJ3+Wc8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WL1UpTkXRjqRncofJWNXXVG4flWaOpi81/1X+CpnOC5DIt/fz89zgxU4Foh5l3nPzzJADrVp+6Biqts9OjuHd5BmHKU2ROUD0krhKyOPkQWPmjjEfM5AAYxLvmEbf2J9E8DwOgNNK/APHehJ7Ac0VBRcMdNIttmFbXUbo5B4fNI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A42zWdUY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Gc2xA/Gf; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A42zWdUY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Gc2xA/Gf" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J86gMc3524621 for ; Mon, 19 Jan 2026 08:17:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xMzeLdH4gkDYQXE3MEX/WwUYO0IiYwGQ9/Yw/tKZcNI=; b=A42zWdUYIYOrD0G+ /o+bZvDph2WavJ8bAhIZL6ZX1FVFRPS0a3jaHqzOQfe4pUsOoawGVTqkQsk9w/60 ExxdQNpkttSKJnFn/3vRFnCy12LbkPEvR3+GNITGU72xPwBi6UGtCG8/3bllcCgw mVcpF4pzQFGSpmSs8oroY/HmM2eoSzQG5w3GRNBvGT9Y08YKI527qj/8QLI2qK0I A+2316rAmX2mCAENp4x+TWitxl0y7j8p/f7xagPzhTVrsv2xuxrHZZTBMm18pAEv 3YzeRG14qpS9E24mxZ90tea4/ahE+1VTpaLfL6Hvb7eRUqAMBAXcVQYWL6aSrVXY JqO/FA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bs7881ab2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 08:17:21 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c6a341ac9fso698868285a.3 for ; Mon, 19 Jan 2026 00:17:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768810641; x=1769415441; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xMzeLdH4gkDYQXE3MEX/WwUYO0IiYwGQ9/Yw/tKZcNI=; b=Gc2xA/GfWOyzDRI7AaP6FtVIErud6G3KvuGTIKASouSx5kazRRquJfrImOof99yu58 1O/ArFeX/q3SI2H+bKSLlPekX9nRoXPxz3ll7a07daExU+To5KBy1sU3H8Mj5AZ5t8Qq eq74BX5picPejylFPkc7ukxC+Xi+aHfJROGtc+7GYynrX/LYTK4yC5DChSzdv1frD53j aeqf7UW93ypoCwYrtmnldC3mgf/Om7RiIQlXPhCEprWn4aiA7c1cj6OcjS1mtdNmKdAD vCrPWmGAvJGx0AwLkpApuHHiEWBBghVWNCgZSCZHlqUQxcHiqfwxCWhawzAj6JSd9w+u JbXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768810641; x=1769415441; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xMzeLdH4gkDYQXE3MEX/WwUYO0IiYwGQ9/Yw/tKZcNI=; b=d2/ypLxj8prENrIjf9FB2xuP8OR4cb2IxMGnvzRQBBedJ36eZcmTubEUkJXjMIQCdy j8XQZ05KESmVIHglAQS/VJvzobStE0U9oLMVaxAERaOfioF+szkI9wuoJPO9ujsB+O5A Jwn/OHVHBrWZEeTxcsUrchC0/xcbq15eGgeCvc0dfEa1GegqfTYAPldtLdRVZSKsvHr1 4i79WfrlAxnx1GSK/zB9ys6HR9e3saLlG34oFf9qxVy7UbiPiEwFyz56UlQLSUUOWgeJ tmNz0xdjtwcG4VX+nTekQPXOnO1K4nT2g+bp4VjvormEo41JYUYAOqrZ6dHKz6qyWgWM eHDw== X-Forwarded-Encrypted: i=1; AJvYcCVC0fFDZ2sk9AQLXJPhGiDFBDxHHnyGPCynmrkdi0HZrJAjTn+20W+6Ay1+FPaBSwhtWCqFMjlLeEqmEx8=@vger.kernel.org X-Gm-Message-State: AOJu0YxxR2LeRj721K/Ov0tUHdc7UBgjY84kX86KU0yvGkiHGr4aDfAe ySeOyhproVYmbPYv+DJke4rAcGujeKN2xTtDqiG+oWMpisywJAekMz6bpB9nK/UJByHBmdPP7w/ mIedrbIPJR78hMROifWI+duQ2KMdBtynJzCCrR6okXw793WuctsULPrqF18ViYrR12SI= X-Gm-Gg: AY/fxX6komgLPXtJTR1vVCu2hUCYJKxA9Jr1/EW5bpJmQwMbUN0WGFoW5vj4OTbodI0 hFDixGtw8GBEH84q2cIEvlAu+ERfAIn2r6Lv9ugpMXoXEkuuaBftVV18dlW+hVgFJA7mhAXQyAN uKVAK87xf/bKJa0PnsTQGGvuhMreYksZkxPodJ/p1heflWRTtFSo0tiFInKDNco+WnQGyaOCQG2 WRO7HxgpzpAPEWBuCLopGddd0LBRFN8kpc4Dg32tdayOGld8fS6dvcNp/4++7EphmNi3G8jBU5k 5CoPujvOOCFm3FqX4nHMbIB8QOh/+01nRrsEZ1aJyR/6MsOhjvZe97aMAEBXI8SfF/ydVlJg9u9 DRsakjNvhnoH1KnPqn5M10SEpzFci7w1CbT/9vyFjLCcspVLF5d2eE9zxMxNzD9nxhgxWHR7nZE YPrSWlrBLyY/GhqWMj+vVLEv8= X-Received: by 2002:a05:620a:4043:b0:8c6:b14e:655d with SMTP id af79cd13be357-8c6b14e660fmr970511585a.74.1768810640923; Mon, 19 Jan 2026 00:17:20 -0800 (PST) X-Received: by 2002:a05:620a:4043:b0:8c6:b14e:655d with SMTP id af79cd13be357-8c6b14e660fmr970508285a.74.1768810640371; Mon, 19 Jan 2026 00:17:20 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38384dbec4dsm29636391fa.20.2026.01.19.00.17.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 00:17:19 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 19 Jan 2026 10:17:15 +0200 Subject: [PATCH v3 2/4] drm/msm/dpu: offset HBB values written to DPU by -13 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-msm-ubwc-fixes-v3-2-34aaa672c829@oss.qualcomm.com> References: <20260119-msm-ubwc-fixes-v3-0-34aaa672c829@oss.qualcomm.com> In-Reply-To: <20260119-msm-ubwc-fixes-v3-0-34aaa672c829@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Val Packett X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2055; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=HWBT7H+ACSNaTYDAPUtOQBPmeUobbB01ZGnKJJ3+Wc8=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpbeiL3Nd+yf7puUGMY7KuxkWqmbU6DWV2RZ773 F67oFji852JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaW3oiwAKCRCLPIo+Aiko 1SRyB/wKRd14DtwJro7LaLDkuj2jMns/ytO0vlhsDsFlv+Q/Fqae9x88klP0cZGKJ8lo8VuVhBx 1aZbO/P1jnM15YO1zOpdxhPSIFdSvm2jNocHZw/cD9jQNX7j8TboVeyikDRGRlHz6kyrVLAG94j JT97VDxWjGhJXEsMb9VX71mmJ/wKPSwEhLcwvt0UYOXxk5b+OdzCN1Wzgt3xtjc01CDv4uH2spX ZnDAX2JIrywtMjgNJBgDKIMWEp5asWACxVF2TAClZJ+jM6z55sC+as3fARVyYl7H7UnGuV0BE4J jsEAzASMscpw0+tuedB8HbdmUQYyhY/6oJfB2BqY3YTTPrTW X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=KLVXzVFo c=1 sm=1 tr=0 ts=696de891 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=VBuLEOLxEfejlaYavu0A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDA2NyBTYWx0ZWRfX8gvGyxzk+xDK vhYUUwl2EY9DCg2Ev7enE2yS7P78nloYTJK+/crFJfj2hz6ewnvTk/ksuZJcRZBXsv+iAGxPlP2 nJd1mhU3Z4OM0VRnwtLsHQha441FmoJeRHKUW50F3VIDAVIYt8FDVLqIeuyQ8wRjninI++DbTlH ZJHpDC51qJsX+3dNSH0Hmu24S122iIhHSQrHmwMQWXXssb3rhVJnOG5BDd9LTME8j0CrmCE/QN0 BrTlDCW1FCKLDSnE3vCq0pLk7uzOydzXE5G0AaC05Tlcr9jqoDwTQpEfsF/eLb7Q7gRc+uMTw/g iFq4SIlKIbbRLzvNrOU+GjsivDS4UFDOqH8kugEwXycCbwAKYE2PkMdrEugBHcVQiPxla92B4AR qw3oGJjH2/u3MEaeZjFzwnBk5oYid7gsOEGtTI6idKxPr3qaBEd//QMaAZJpUA+UnQIjvLK9c6c +V+XAcGk57JrkKacLmQ== X-Proofpoint-GUID: bRmPkB2w3Z-3WA9W2upJVb1FyVS33h_v X-Proofpoint-ORIG-GUID: bRmPkB2w3Z-3WA9W2upJVb1FyVS33h_v X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_01,2026-01-19_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 impostorscore=0 malwarescore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190067 As in all other places, the Highest Bank Bit value should be programmed into the hardware with the offset of -13. Correct the value written into the register to prevent unpredictable results. Fixes: 227d4ce0b09e ("drm/msm: Offset MDSS HBB value by 13") Tested-by: Val Packett # x1e80100-dell-latitude-7455 Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index 6f1fc790ad6d..b66c4cb5760c 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -270,30 +270,32 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, ((fmt->bpp - 1) << 9); =20 if (fmt->fetch_mode !=3D MDP_FETCH_LINEAR) { + u32 hbb =3D ctx->ubwc->highest_bank_bit - 13; + if (MSM_FORMAT_IS_UBWC(fmt)) opmode |=3D MDSS_MDP_OP_BWC_EN; src_format |=3D (fmt->fetch_mode & 3) << 30; /*FRAME_FORMAT */ DPU_REG_WRITE(c, SSPP_FETCH_CONFIG, DPU_FETCH_CONFIG_RESET_VALUE | - ctx->ubwc->highest_bank_bit << 18); + hbb << 18); switch (ctx->ubwc->ubwc_enc_version) { case UBWC_1_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | BIT(8) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_2_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, fast_clear | (ctx->ubwc->ubwc_swizzle) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_3_0: DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, BIT(30) | (ctx->ubwc->ubwc_swizzle) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_4_0: DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, --=20 2.47.3