From nobody Sun Feb 8 08:36:50 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72CEF33CE9B for ; Mon, 19 Jan 2026 08:17:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810643; cv=none; b=lgoNGlJrnS/XUDIxvVcwArl33iqcBjL1SIMLgYVaWTRGvTbfh18yScrPalzYnqZAK7vzAq/Vr78biW1b7v2VLQ0jKAgxpUq4dDUtuBjC5d5WGO0+CS/qT9wVY4jLCvee+9OESljaBHBQH9cnJzTep8tMdRRPlAlWqFuKOdHfUOE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810643; c=relaxed/simple; bh=rvlLamNB1d8AxWI8yQdhDfj/WRXPqvKE6wjpg+ZGkfw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=t7zBVa0YcuqsTHfu/jj/jKt8hmf+QvCPefPK65kXely4aPr+DIbhKNQo93i3GvDzB0veaaiP13kvP4gbEi05i+dZ71MzWOo/H8vrCeU/EESwnVLuRn+c29wYiqNFUCLR1CNf3jyYO0RDxi4tJIWNk/LOuddBgSGWVYxI/0TVv8E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UkInDYfe; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DBGd9+z7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UkInDYfe"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DBGd9+z7" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J867SQ121490 for ; Mon, 19 Jan 2026 08:17:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 76Smpb7OAuPrJPWLjQuPjMFitzxPMEeAECFWrSbRqDA=; b=UkInDYfeu5xWblOq DAVT1XskVc27rpyqoqeSm7p50dCup0/1+iOBuoJxFJWu3V3I0kMagqUm/Jn6aYRr EktTEbiVW53DV70B1kx2Auxlr8GFnL0mcWb1ugpy6a7nBHZijAT24gowk1CxwNgE 2T58ALEVucJ3HZ5QgnNWAo28Hos0n4+yMBrBf6wZLiG/bB4mcavaeLVVhOakuH3G DTnazyxp2CO2tFhEvZX4C2KNGghUL/RxasNhWBLZ4Mq0ecMD2XSr0Ln8iwXnMFGk A8E6sQ1gbVOnfOO/wxdc2xY+2g2tHzqSLXgSzqZRztwWNM4vhbWLS758k26HMWfk R0GQyw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br2gumbr8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 08:17:20 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c6a5bc8c43so859349985a.2 for ; Mon, 19 Jan 2026 00:17:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768810640; x=1769415440; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=76Smpb7OAuPrJPWLjQuPjMFitzxPMEeAECFWrSbRqDA=; b=DBGd9+z7OCf9kVQK5qLmB3Jw1zGzSpCxvpq+rAm9G2kVlMfCdFYJom6Ib3p8GZ84zX Ftflc/FcuPbubR86ai9GmVWITZSfZ5muK5oOFRzAyRzKwJeV4mCmxbRycoifUTo3wqDg meH2ZPMoip4YxhzF95HvpP5Jew1+sdV/18d3OgyhM6zkSQWh6HL1LeCMJK/hZ4sj050L JpfV2uHP/2zbErvjt90YONuBvANAXMcbAFS6zTdQVU2NAQyqIfSzlwRFfQ5j95VFTEuW MWjO2jcEq7wdW0fSDUnv/fjLmeKp+T2j9eWsWVrwD1Kb1UKmKWT90WwIMS2ezZL66qPk 5Axw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768810640; x=1769415440; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=76Smpb7OAuPrJPWLjQuPjMFitzxPMEeAECFWrSbRqDA=; b=qkv12WWgU7sYcO20fz2oPz6vFBa9aE2FUPn59xCHMn4PyfQzXTZdNl5mr02Ib288f6 9rQPm3K13LmBXa8Jm5Iuxt2rmH3CxkUZJA1/FuVUewT5jvy5NmEy6OZayQv3Vqm7YHyv KzKlEWrmCpKbxWF3XKaWXfDkIDMcU5KBiSE9EitcL4pINnIJQ3BYcfic6x5OCJGWTScj +KRImdpn21ZymzO6WNJI9I4txz3TJoIVFhTTT9RAI2VEFXn7BtPaY3McBnsRIwt+FR1F oHFg0UZeG94w5B8/vNZwkCvR/9o5PWzhwEint3QS1xMPgAvFc2lCxU4POXlXBY10SvxY bxbQ== X-Forwarded-Encrypted: i=1; AJvYcCU2Cb+0rgpweoNAkdqvsOtVmlpY2zPnmQeRiR4cIfGLlP3obCEGUhrA/n7W1d1f0nHh7kbUM0mMV3G7pV8=@vger.kernel.org X-Gm-Message-State: AOJu0YzpyXtPQJfEYglUQvuqx2QYM2sSPS7LVTimwhZAIyB2A1idc+KF B3nhu+LJp26qIUk+ZJ4PmPl1RKPZS5lTihIR/Ypkz6C9HWMLvjfUVt8VlUoQDT1RzqDwXssTnqU c6WhcLd5LReDVAVs8JMy+RN4XcBqHz5zL+hJz7n4YkG9OKkwb2KPesxrnUNkee0AI1CM= X-Gm-Gg: AY/fxX5bEzj/5e/QWko5X+rsfoV0Nu7uUwkiVSXFJXoLXoW+2Zfnxd02Y/uf1fiNrMh +l+lvAv92pcgLCyAIOFMWaaksLH5O6w8tY+UqCE2sq6yTVNVYj2IXvnoncR7tbwLm/lPCvm6CcI NoBrn7m4vQg0xqSbdZSZTXfH0djYucFlxMDz4DPGrtXbFTHkEeMsgg6qFIc0J6fX/yzz92acgrs easu+F42LzqsdisBgFdvPVenconcGMfDqPihVtPokmUBAhTIqfnLntKxVf0P1EGA2Qfj7IHzQiC dzAkFhbo9HI9Fie0uQLsxLEESVB6d+1MClDDu/Ml3T8yQCsbx+Ja/iCcn2cvosgjq6NA9hJtaOm Ykdee1pHO3II34xVipBAyWwQJ6sa33VzJnglcfYMFCFF9F7FAMkg5jiEx89WUA++xvYS6bMmRY7 6Vc9anrIyhXBvRWXXnl4nPULA= X-Received: by 2002:a05:620a:bc2:b0:8c5:310d:3b1e with SMTP id af79cd13be357-8c6a66f6bb5mr1518899785a.33.1768810639774; Mon, 19 Jan 2026 00:17:19 -0800 (PST) X-Received: by 2002:a05:620a:bc2:b0:8c5:310d:3b1e with SMTP id af79cd13be357-8c6a66f6bb5mr1518896885a.33.1768810639275; Mon, 19 Jan 2026 00:17:19 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38384dbec4dsm29636391fa.20.2026.01.19.00.17.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 00:17:17 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 19 Jan 2026 10:17:14 +0200 Subject: [PATCH v3 1/4] drm/msm/mdss: correct HBB programmed on UBWC 5.x and 6.x devices Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-msm-ubwc-fixes-v3-1-34aaa672c829@oss.qualcomm.com> References: <20260119-msm-ubwc-fixes-v3-0-34aaa672c829@oss.qualcomm.com> In-Reply-To: <20260119-msm-ubwc-fixes-v3-0-34aaa672c829@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Val Packett X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1187; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=rvlLamNB1d8AxWI8yQdhDfj/WRXPqvKE6wjpg+ZGkfw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpbeiLRc6MfZfjLwLgU9ZLO+AmHQLpKNEG53lTe uFIrNKomZ6JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaW3oiwAKCRCLPIo+Aiko 1ZiYCACKIFBdBuVY28Simiz9YBlSWLg7vfCkIdbVslZHYkeWy+BmVuv0O1Ne8FFUiw3KIWTX1C+ Blz4BoZakElqDCeCKgu/N63/gkM5NPFytkeUQ4cHgHtcceXl4bG47umALc9V1NJAfM1tDOb5/0c VX7JYAynZSWnkpn//AVfb4bweJ/n71hPBkUZWjtO8+BI6A4c5FCLxyw+hfAhkEyFzj99A6JIX52 mNtQgQuTjMgV9j9EekWH2LxvKeWItXo9Kr/LhQQZjCPCye24ph6NJAQZmEk83C5w7/e2f88sbUO TP0dvVar7Di6T9yZf38+ThRugmLsSv25DeTeKGA8k15VJmcQ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDA2NyBTYWx0ZWRfX1D1h7KQbvIy8 cps48qDtIfjxc/iKjcDmSa2j6qZJQ9Ak4WGiDGA62870wqpTHetTLVvNyvu5NEWpV/WzdQAPdDf kDztiSG5PziF9fMZN5jEMRvEB/c2jHgp7M66Dd8FYFyBu5jY2+fJCPerHjaL6tDr+qyhueRhklb zo9IHBbWAe+rkrMYz/CnNC0EcYjxsY9H9zJ6RCmcOWItvP8Uj6CvFbGlX/FUqrach2t/I89DVdq CMPCmmLFdg9bXGZ9N5rWttY5NLaH9PzNNdEnC7Z29FJETC9WCXGDccG8OrmMvrtaDQU8gjhTPyr fdA8537ebFzlaLKbFCbvtpYse8/i7vkQsKp9Ajv5AYbsCpsbpK6mffF/+9voQ1G4RSkXf/Zf+Sd r2q7qViUYciHSEgJT8Tp+/RF9w74umzY6pk/8peVfAYkSjSgtGJpeJqzGYgcMJYKMJGK+Gvqsrh AMwpMry7698lOjChafw== X-Authority-Analysis: v=2.4 cv=Sev6t/Ru c=1 sm=1 tr=0 ts=696de890 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=VBuLEOLxEfejlaYavu0A:9 a=+jEqtf1s3R9VXZ0wqowq2kgwd+I=:19 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: OyazbIyVNTzUiIiT-bCI-jLMlZuPKZod X-Proofpoint-ORIG-GUID: OyazbIyVNTzUiIiT-bCI-jLMlZuPKZod X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_01,2026-01-19_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190067 As in the previous generations, on UBWC 5.x and 6.x devices the Highest Bank Bit value should be programmed into the hardware with the offset of -13. Correct the value written into the register to prevent unpredictable results. Fixes: 227d4ce0b09e ("drm/msm: Offset MDSS HBB value by 13") Tested-by: Val Packett # x1e80100-dell-latitude-7455 Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_mdss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index bf9a33e925ac..910242f5a71f 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -229,7 +229,7 @@ static void msm_mdss_setup_ubwc_dec_50(struct msm_mdss = *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | - MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit); + MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; --=20 2.47.3 From nobody Sun Feb 8 08:36:50 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9F2D30274D for ; Mon, 19 Jan 2026 08:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810646; cv=none; b=IXLeLW/VBsDSsT41CmHFriExiqwgu/+2G4UIbRDdgYNzrQG3tJo7qT0GBNVlbDS2DbegpIIka2PPDwYu5FUG/d9jS+L//EV4tMNdZlmQjSVA6nJESTUKYbIZXxL8ia7Ygz9mybSUZ3X3RN9NJRe7d4HIxJD2c4tQuU9DbzHZ2wQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810646; c=relaxed/simple; bh=HWBT7H+ACSNaTYDAPUtOQBPmeUobbB01ZGnKJJ3+Wc8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WL1UpTkXRjqRncofJWNXXVG4flWaOpi81/1X+CpnOC5DIt/fz89zgxU4Foh5l3nPzzJADrVp+6Biqts9OjuHd5BmHKU2ROUD0krhKyOPkQWPmjjEfM5AAYxLvmEbf2J9E8DwOgNNK/APHehJ7Ac0VBRcMdNIttmFbXUbo5B4fNI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A42zWdUY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Gc2xA/Gf; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A42zWdUY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Gc2xA/Gf" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J86gMc3524621 for ; Mon, 19 Jan 2026 08:17:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xMzeLdH4gkDYQXE3MEX/WwUYO0IiYwGQ9/Yw/tKZcNI=; b=A42zWdUYIYOrD0G+ /o+bZvDph2WavJ8bAhIZL6ZX1FVFRPS0a3jaHqzOQfe4pUsOoawGVTqkQsk9w/60 ExxdQNpkttSKJnFn/3vRFnCy12LbkPEvR3+GNITGU72xPwBi6UGtCG8/3bllcCgw mVcpF4pzQFGSpmSs8oroY/HmM2eoSzQG5w3GRNBvGT9Y08YKI527qj/8QLI2qK0I A+2316rAmX2mCAENp4x+TWitxl0y7j8p/f7xagPzhTVrsv2xuxrHZZTBMm18pAEv 3YzeRG14qpS9E24mxZ90tea4/ahE+1VTpaLfL6Hvb7eRUqAMBAXcVQYWL6aSrVXY JqO/FA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bs7881ab2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 08:17:21 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c6a341ac9fso698868285a.3 for ; Mon, 19 Jan 2026 00:17:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768810641; x=1769415441; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xMzeLdH4gkDYQXE3MEX/WwUYO0IiYwGQ9/Yw/tKZcNI=; b=Gc2xA/GfWOyzDRI7AaP6FtVIErud6G3KvuGTIKASouSx5kazRRquJfrImOof99yu58 1O/ArFeX/q3SI2H+bKSLlPekX9nRoXPxz3ll7a07daExU+To5KBy1sU3H8Mj5AZ5t8Qq eq74BX5picPejylFPkc7ukxC+Xi+aHfJROGtc+7GYynrX/LYTK4yC5DChSzdv1frD53j aeqf7UW93ypoCwYrtmnldC3mgf/Om7RiIQlXPhCEprWn4aiA7c1cj6OcjS1mtdNmKdAD vCrPWmGAvJGx0AwLkpApuHHiEWBBghVWNCgZSCZHlqUQxcHiqfwxCWhawzAj6JSd9w+u JbXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768810641; x=1769415441; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xMzeLdH4gkDYQXE3MEX/WwUYO0IiYwGQ9/Yw/tKZcNI=; b=d2/ypLxj8prENrIjf9FB2xuP8OR4cb2IxMGnvzRQBBedJ36eZcmTubEUkJXjMIQCdy j8XQZ05KESmVIHglAQS/VJvzobStE0U9oLMVaxAERaOfioF+szkI9wuoJPO9ujsB+O5A Jwn/OHVHBrWZEeTxcsUrchC0/xcbq15eGgeCvc0dfEa1GegqfTYAPldtLdRVZSKsvHr1 4i79WfrlAxnx1GSK/zB9ys6HR9e3saLlG34oFf9qxVy7UbiPiEwFyz56UlQLSUUOWgeJ tmNz0xdjtwcG4VX+nTekQPXOnO1K4nT2g+bp4VjvormEo41JYUYAOqrZ6dHKz6qyWgWM eHDw== X-Forwarded-Encrypted: i=1; AJvYcCVC0fFDZ2sk9AQLXJPhGiDFBDxHHnyGPCynmrkdi0HZrJAjTn+20W+6Ay1+FPaBSwhtWCqFMjlLeEqmEx8=@vger.kernel.org X-Gm-Message-State: AOJu0YxxR2LeRj721K/Ov0tUHdc7UBgjY84kX86KU0yvGkiHGr4aDfAe ySeOyhproVYmbPYv+DJke4rAcGujeKN2xTtDqiG+oWMpisywJAekMz6bpB9nK/UJByHBmdPP7w/ mIedrbIPJR78hMROifWI+duQ2KMdBtynJzCCrR6okXw793WuctsULPrqF18ViYrR12SI= X-Gm-Gg: AY/fxX6komgLPXtJTR1vVCu2hUCYJKxA9Jr1/EW5bpJmQwMbUN0WGFoW5vj4OTbodI0 hFDixGtw8GBEH84q2cIEvlAu+ERfAIn2r6Lv9ugpMXoXEkuuaBftVV18dlW+hVgFJA7mhAXQyAN uKVAK87xf/bKJa0PnsTQGGvuhMreYksZkxPodJ/p1heflWRTtFSo0tiFInKDNco+WnQGyaOCQG2 WRO7HxgpzpAPEWBuCLopGddd0LBRFN8kpc4Dg32tdayOGld8fS6dvcNp/4++7EphmNi3G8jBU5k 5CoPujvOOCFm3FqX4nHMbIB8QOh/+01nRrsEZ1aJyR/6MsOhjvZe97aMAEBXI8SfF/ydVlJg9u9 DRsakjNvhnoH1KnPqn5M10SEpzFci7w1CbT/9vyFjLCcspVLF5d2eE9zxMxNzD9nxhgxWHR7nZE YPrSWlrBLyY/GhqWMj+vVLEv8= X-Received: by 2002:a05:620a:4043:b0:8c6:b14e:655d with SMTP id af79cd13be357-8c6b14e660fmr970511585a.74.1768810640923; Mon, 19 Jan 2026 00:17:20 -0800 (PST) X-Received: by 2002:a05:620a:4043:b0:8c6:b14e:655d with SMTP id af79cd13be357-8c6b14e660fmr970508285a.74.1768810640371; Mon, 19 Jan 2026 00:17:20 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38384dbec4dsm29636391fa.20.2026.01.19.00.17.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 00:17:19 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 19 Jan 2026 10:17:15 +0200 Subject: [PATCH v3 2/4] drm/msm/dpu: offset HBB values written to DPU by -13 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-msm-ubwc-fixes-v3-2-34aaa672c829@oss.qualcomm.com> References: <20260119-msm-ubwc-fixes-v3-0-34aaa672c829@oss.qualcomm.com> In-Reply-To: <20260119-msm-ubwc-fixes-v3-0-34aaa672c829@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Val Packett X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2055; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=HWBT7H+ACSNaTYDAPUtOQBPmeUobbB01ZGnKJJ3+Wc8=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpbeiL3Nd+yf7puUGMY7KuxkWqmbU6DWV2RZ773 F67oFji852JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaW3oiwAKCRCLPIo+Aiko 1SRyB/wKRd14DtwJro7LaLDkuj2jMns/ytO0vlhsDsFlv+Q/Fqae9x88klP0cZGKJ8lo8VuVhBx 1aZbO/P1jnM15YO1zOpdxhPSIFdSvm2jNocHZw/cD9jQNX7j8TboVeyikDRGRlHz6kyrVLAG94j JT97VDxWjGhJXEsMb9VX71mmJ/wKPSwEhLcwvt0UYOXxk5b+OdzCN1Wzgt3xtjc01CDv4uH2spX ZnDAX2JIrywtMjgNJBgDKIMWEp5asWACxVF2TAClZJ+jM6z55sC+as3fARVyYl7H7UnGuV0BE4J jsEAzASMscpw0+tuedB8HbdmUQYyhY/6oJfB2BqY3YTTPrTW X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=KLVXzVFo c=1 sm=1 tr=0 ts=696de891 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=VBuLEOLxEfejlaYavu0A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDA2NyBTYWx0ZWRfX8gvGyxzk+xDK vhYUUwl2EY9DCg2Ev7enE2yS7P78nloYTJK+/crFJfj2hz6ewnvTk/ksuZJcRZBXsv+iAGxPlP2 nJd1mhU3Z4OM0VRnwtLsHQha441FmoJeRHKUW50F3VIDAVIYt8FDVLqIeuyQ8wRjninI++DbTlH ZJHpDC51qJsX+3dNSH0Hmu24S122iIhHSQrHmwMQWXXssb3rhVJnOG5BDd9LTME8j0CrmCE/QN0 BrTlDCW1FCKLDSnE3vCq0pLk7uzOydzXE5G0AaC05Tlcr9jqoDwTQpEfsF/eLb7Q7gRc+uMTw/g iFq4SIlKIbbRLzvNrOU+GjsivDS4UFDOqH8kugEwXycCbwAKYE2PkMdrEugBHcVQiPxla92B4AR qw3oGJjH2/u3MEaeZjFzwnBk5oYid7gsOEGtTI6idKxPr3qaBEd//QMaAZJpUA+UnQIjvLK9c6c +V+XAcGk57JrkKacLmQ== X-Proofpoint-GUID: bRmPkB2w3Z-3WA9W2upJVb1FyVS33h_v X-Proofpoint-ORIG-GUID: bRmPkB2w3Z-3WA9W2upJVb1FyVS33h_v X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_01,2026-01-19_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 impostorscore=0 malwarescore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190067 As in all other places, the Highest Bank Bit value should be programmed into the hardware with the offset of -13. Correct the value written into the register to prevent unpredictable results. Fixes: 227d4ce0b09e ("drm/msm: Offset MDSS HBB value by 13") Tested-by: Val Packett # x1e80100-dell-latitude-7455 Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index 6f1fc790ad6d..b66c4cb5760c 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -270,30 +270,32 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, ((fmt->bpp - 1) << 9); =20 if (fmt->fetch_mode !=3D MDP_FETCH_LINEAR) { + u32 hbb =3D ctx->ubwc->highest_bank_bit - 13; + if (MSM_FORMAT_IS_UBWC(fmt)) opmode |=3D MDSS_MDP_OP_BWC_EN; src_format |=3D (fmt->fetch_mode & 3) << 30; /*FRAME_FORMAT */ DPU_REG_WRITE(c, SSPP_FETCH_CONFIG, DPU_FETCH_CONFIG_RESET_VALUE | - ctx->ubwc->highest_bank_bit << 18); + hbb << 18); switch (ctx->ubwc->ubwc_enc_version) { case UBWC_1_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | BIT(8) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_2_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, fast_clear | (ctx->ubwc->ubwc_swizzle) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_3_0: DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, BIT(30) | (ctx->ubwc->ubwc_swizzle) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_4_0: DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, --=20 2.47.3 From nobody Sun Feb 8 08:36:50 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E446D33CEA8 for ; Mon, 19 Jan 2026 08:17:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810646; cv=none; b=LGNsdPqWHSFn/qf8ij1Ja729nxFs/UieD6hKmaqUB5xiww0Su7SrHHWm7FSDHYjNJvrd8+UDyNTnch95192KEowC4oh698oDcgVWPrNxNQN52SrlgJ5RwO2WdyQKf8+7vLDR0LIUtR+j2mWf0Nek80d6IVVh7+DsXxrOQrXY4PM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810646; c=relaxed/simple; bh=lo3imQhUcYZeiROXs6LS6r/XOzlEgkEUmatFOrZKrog=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I3QMUUlJgeNazJ1kG+N/wGsm7LQfjOzAL33IcLhLdVVV1Z8jeD+e6g+OYku+R98CLSYuxbuIx6sqiBqG/eO4ydPDfZ44M1/2yL6W9W2JtJIKCroo7Ljo1v64kMjoS+Sbckn0dO4l7E90n3pnaq15IwerX2x8uWveJy3I8P0rN5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Wi7Wu3Ls; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=h/jZPEXD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Wi7Wu3Ls"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="h/jZPEXD" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J85oHv3691326 for ; Mon, 19 Jan 2026 08:17:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ySBe32B9dFLBxykveI4xu5ZLa7Kh8Fdd134UNyMzTpw=; b=Wi7Wu3LswO6H6Rk5 nxBvkHFRXwtsp7kyLPXPOWzAHWb+zqVDX7ATsczThru5sIFe/QTRPlUhujMS9lYq BbXDSmOP/zHQbPyDXBunAUecMYqGoc5Q12Zjw9t5SqqljDjxXJK1Kxj0FstDGKwj EH2u1h174oQmcYsXBN6haacMucXF7stD4SYKfON+wdrALlLbcUeHy/1Q+9DOMOaw WVbhzCuOn+U4Lddq+HXPZAZ5lR3cWlep1MnVcISBILaOB/w7DJosl+6nwAf/zhz4 bSiOB3yA4qzPfxD/KTjNE1w5u8BVPnkgp4+2NFm6KxfwDD8I0cRO8XoXhFhivQ0P zaaqdw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br2t74893-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 08:17:22 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8bc4493d315so1167915285a.1 for ; Mon, 19 Jan 2026 00:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768810642; x=1769415442; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ySBe32B9dFLBxykveI4xu5ZLa7Kh8Fdd134UNyMzTpw=; b=h/jZPEXD4BQET3eB5TKjw6U0+BvMnULp0ZJ1lZtuTUbZTvQfk7PI8OXSnh9cg4yWCC PpiYfM2XmxzUMoA1A2MVQ4jqhBU9NUiaN+iv/uRhyVe0s0hQn1pSpDlqNyX6muh3kbr6 tKNi4xYSbE4yInUGARpW0jlvys/evF7zdmut2B3WGHwPl9ui0A4xgO90qR40lM+a00b+ AWtCzzHuWJjf9FTmw0vs0vMKTytz4ckdHxDNqWYEhryhpZgPA0UzCy7BiHxvtBiUX+kG ahMqZlcbzK8NTB14Wp13s21Lyq1OPmE8a6+U4UfN6GnFemE3D0PvvrFhW1j4qy5zljt8 lGHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768810642; x=1769415442; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ySBe32B9dFLBxykveI4xu5ZLa7Kh8Fdd134UNyMzTpw=; b=hONDjJgiwaeYaSh1ZxVRiVuWqHrinpY1BgfQtvUNGRZr9es5YdhKPdX5SIauGnMa2C 986895qvIPURapMz17vmJLALTNnUMnB+atB7aVTlGGd80IToN7KtX/EO39v32F4Enq0Y E4p29+O6C33/vo+wzb8P9Oj2wLsri+ZM86PyScmYQF7+TlpAjafM5EKHdtjljNbRj11f jN1irqV6VJI2CRhwOgbI8X00dV4KtEkK69f2qK5uvyrqdltu0N7Kw2ObxnpzQLbHxrqR hZ7WklfGb4bIcgQ9yCh+au0R1jWV3HfNuADhS3VmqCu7lRUnzhPog2Wq/P7fG+LjnDjL O70A== X-Forwarded-Encrypted: i=1; AJvYcCW1/xhewuG8IR/ovtSY1GfCmk2TRzfpB5uSHhJXcEWzzHKL3pCfID8YRnKfpQIKG/rh9yj3WI16NV8J88g=@vger.kernel.org X-Gm-Message-State: AOJu0YwjwFSdKTyCrn1m7qGbakmqKAwgtYJNMH994a3DFj5pfkEV2X+t TL8rTgJdv/t+hA8p0Xa7n5XS/GZyWjmtYPQazEdXGR04tW24/jOqClEFuUoLuOXNKdQq65eMX6m YXhOrR/sq4H+hOZHX3MINbUFO4c4T1f3Bhc1hNZU8v19mc0/GXBE1J/LI+6JpOrdwU8c= X-Gm-Gg: AY/fxX5/czZREWTG8hCNTwzIShJTBE6b1pXdVu4QRJrITzsoxDWdx4mwDZwXStvs3Dn bEX5Y6SZxUlzeip5UxHdtbk2Zub4VeFav31eatZWc9Wf2CRJTU1VDcbBkqXAEhw+veTHe4gt3o/ GY0ZEwFQTju0UXDUU+Rf52I9dxAJrjrMbj6q6g8pONXm2uzMRAsl3DHKRGZmvHNCutzmxGvrhDY WDdY9PC1r6GnMhXMLCmTnmexjwGj5Gi6odMabmasQtBaUdwInTj+JLk2TR7K7Y589jM/rLCv2Gy CaOWpx8WUVQB2FYZndZaxLVVS/WPu3KXnSD7XxNE03zuKIAOlZyIgzuVs+ySDS9ILVUuKI8rlIt bnj/P2mXGVvn+m7cbXcDLgbuuBwKqdxWkEH5HjsihCjKB/zrl1Puzc7rZZr7Jan3SyJgszHr63s 03Cot3w9F/rYRcyxvUui4hW7w= X-Received: by 2002:a05:620a:2982:b0:8c5:2ef1:7d4e with SMTP id af79cd13be357-8c6a6948240mr1557610585a.73.1768810642023; Mon, 19 Jan 2026 00:17:22 -0800 (PST) X-Received: by 2002:a05:620a:2982:b0:8c5:2ef1:7d4e with SMTP id af79cd13be357-8c6a6948240mr1557608685a.73.1768810641589; Mon, 19 Jan 2026 00:17:21 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38384dbec4dsm29636391fa.20.2026.01.19.00.17.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 00:17:20 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 19 Jan 2026 10:17:16 +0200 Subject: [PATCH v3 3/4] drm/msm/dpu: program correct register for UBWC config on DPU 8.x+ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-msm-ubwc-fixes-v3-3-34aaa672c829@oss.qualcomm.com> References: <20260119-msm-ubwc-fixes-v3-0-34aaa672c829@oss.qualcomm.com> In-Reply-To: <20260119-msm-ubwc-fixes-v3-0-34aaa672c829@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Val Packett X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3052; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=lo3imQhUcYZeiROXs6LS6r/XOzlEgkEUmatFOrZKrog=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpbeiL/WY6dQq1hsAiruVmlJNpw57IWcvKI0mt4 N7D1QNofs2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaW3oiwAKCRCLPIo+Aiko 1UOrB/9IB96KEZsLVA0GwmxwgpsTgczf0JVTDWkX8qtyDLCq0z/ZfbuEcCSmPHBhsKwFIVJ5yuA kN7oHWAkFgGWtbC2eu4yoTaTyAHwKgjYE65CzizRgOGqUxF8EO+Ap/2WUsuBWvM7+F49uDQkelh 6Ei4TGLrMuMnkQwBWpn6TrsLHI7LC81RbZTnqRDpg7ARWgP40sF1JjnKrnokaOYXLXOeachxtKA V73mG2sOraF9fHqtEMvyJTkwQJLT0Jaj9/iF/C7fVlcUjcSIB2oRleJZaurod5mC7vKxwvm0zr9 3GqjoaiCca4Idd2hujFK0ERRWqepS1ZchB9uT5loLrVXi/NT X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=Fdc6BZ+6 c=1 sm=1 tr=0 ts=696de892 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=7tap2HhiP8zdS8EL3YEA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: wTiu4biTm6Ra8LRN2d-dnRLI5wl3xNt0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDA2NyBTYWx0ZWRfX1WGBzy+TtnEh T5pw7QOKRTVuIO5R6b5qfus600SOTpNkiWb4Lu7JCRq09SG9LVLLsZC3EwcCkqRd78jqc8L9uVD vQ8AyeDDuhMykP5cDHeQ3jWMmSwD7JnuWWQdt3bGGwVUK3772uaQpf0ydH15kVomlWK3hhR25/0 ZhNSppqA/2hrqC8JAED55WLxLfbLYrWg8eE/gFTl7/bn4CYhkQ0iwO4CjcUPagLy1ZjAFvO2n1z zkH4sB9gn7C5tKGkuic8QV4x9+M2WXN1Tpdj6deH9ofqfasH2cC6cGq5fCbWe5sbZzOAARqFHhv YXjbkwyQltHTuYWH1VyZgnCURErUORZSrFBLYpEAMDai92Bqg8/Dvfhdv30zeYOkbObeUKINLgx iAoPHY4Jum6mprFnXHH7CdyFJkuQ3Rgud1eIzMwxEZkJY+B7oZGJVD/X78KXZWO1Yj1FXTvsf86 +1rv5HzvJAm5nXPNI7A== X-Proofpoint-GUID: wTiu4biTm6Ra8LRN2d-dnRLI5wl3xNt0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_01,2026-01-19_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190067 Since DPU 8.0 there is a separate register for the second rectangle, which needs to be programmed with the UBWC config if multirect is being used. Write pipe's UBWC configuration to the correct register. Fixes: 100d7ef6995d ("drm/msm/dpu: add support for SM8450") Tested-by: Val Packett # x1e80100-dell-latitude-7455 Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index b66c4cb5760c..a99e33230514 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -72,6 +72,7 @@ #define SSPP_EXCL_REC_XY_REC1 0x188 #define SSPP_EXCL_REC_SIZE 0x1B4 #define SSPP_EXCL_REC_XY 0x1B8 +#define SSPP_UBWC_STATIC_CTRL_REC1 0x1c0 #define SSPP_CLK_CTRL 0x330 =20 /* SSPP_SRC_OP_MODE & OP_MODE_REC1 */ @@ -215,7 +216,7 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pipe= *pipe, u32 chroma_samp, unpack, src_format; u32 opmode =3D 0; u32 fast_clear =3D 0; - u32 op_mode_off, unpack_pat_off, format_off; + u32 op_mode_off, unpack_pat_off, format_off, ubwc_static_ctrl_off; =20 if (!ctx || !fmt) return; @@ -225,10 +226,17 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, op_mode_off =3D SSPP_SRC_OP_MODE; unpack_pat_off =3D SSPP_SRC_UNPACK_PATTERN; format_off =3D SSPP_SRC_FORMAT; + ubwc_static_ctrl_off =3D SSPP_UBWC_STATIC_CTRL; } else { op_mode_off =3D SSPP_SRC_OP_MODE_REC1; unpack_pat_off =3D SSPP_SRC_UNPACK_PATTERN_REC1; format_off =3D SSPP_SRC_FORMAT_REC1; + + /* reg wasn't present before DPU 8.0 */ + if (ctx->mdss_ver->core_major_ver >=3D 8) + ubwc_static_ctrl_off =3D SSPP_UBWC_STATIC_CTRL_REC1; + else + ubwc_static_ctrl_off =3D SSPP_UBWC_STATIC_CTRL; } =20 c =3D &ctx->hw; @@ -281,24 +289,24 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, switch (ctx->ubwc->ubwc_enc_version) { case UBWC_1_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_static_ctrl_off, fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | BIT(8) | (hbb << 4)); break; case UBWC_2_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_static_ctrl_off, fast_clear | (ctx->ubwc->ubwc_swizzle) | (hbb << 4)); break; case UBWC_3_0: - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_static_ctrl_off, BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4)); break; case UBWC_4_0: - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_static_ctrl_off, MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30)); break; } --=20 2.47.3 From nobody Sun Feb 8 08:36:50 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41CB333CE8D for ; Mon, 19 Jan 2026 08:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810646; cv=none; b=XZOKgwxbjLEkmXH9mVXkklddhgkQYCQ5fCds7f+s8L4ARb3tLsoyDsSexeaW0rpDjbDmi7fOGBTi70IIHmmEaIwVK3PkOG3ndpLg5rDpuMeg2OiupjfhgbDyneQ+BqlRd8hIs+yHdvg4lpT5HfMSzI4Z8+35prv9cQqYxnXIu/c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810646; c=relaxed/simple; bh=9rYsLNuEACuzhywI0tRJ339OJWdDN6xkayUa/9Ma/Po=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mHE3fRWMtZs0F1MLh2FAvrcJPqNnJaRMAsPp1qFcY/RCWtpBIUg3WvBStRj/AU22lg6WF/Med2yZ/e52ePmTALAOpd2CEAwVgCcsZgYWQNorYKZl6Z1e+xic7C78MDt7ADiayAVWrvINKCb20IBb0S+ohZih/L5QLADY5O9Ki4E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f5nFLgAY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NG48zTqV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f5nFLgAY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NG48zTqV" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J7hYLF039971 for ; Mon, 19 Jan 2026 08:17:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 87X96O69HjPFMulPg1QR+SL19iQWTFSZSdfYbuNZu7Y=; b=f5nFLgAY1HDPwSHD z9EAo74k2884XGgOpgA4Ti84KPi8+DgA+VPSkYhElavI7IETWl7mWZ+uG7tY83lG 3qgnB1M5m9Yxa5FYrUsNFwzymaWMyqgpuXrzxDwDo+/Hn9GIB8Gwz0GDTYXZ4/Nv C6KofOe1SxF/nSKY5VkWKZZg9GrJjhCl8R7uLzGjJ+/QauDAbBB2ErEinopnhqnM c+pic2gOvwWBuj5eBs71QbxsGojWfS0ulG0kT9PJ6dGTlji3tMVt86PUIJ6Tq1tv pc2OljToIW50KavPmsd8HHuZZkGyybAxlzR8wlsCdv6DCS5wi+ORnluXPWiK00/k 6R/dxA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bsgfr84k8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 08:17:23 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c5329ed28bso1051994085a.2 for ; Mon, 19 Jan 2026 00:17:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768810643; x=1769415443; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=87X96O69HjPFMulPg1QR+SL19iQWTFSZSdfYbuNZu7Y=; b=NG48zTqVeNhXdFfRsClLExfKqZ4ajQOQrC07JfpBZ7/MJsL5i5BN0UaaF1AXhuW56S nQwoxX3SLz/k+GCmM+e6S6drKSC0lKR5rlLCNwr9qr7MP6H/ZbyRtc/PA2Nf767JL/h9 fS9kCr4Ja9kF+0wjK504i6J5IR/Vz5+cz9qO7JuyeduCY7IegbeYdufWxr55/Xmr+LeR zReJOZ17+UEK1DtVQP7uZKIgz3rJ3NYuL3bd40lG/6tHxcyJmmScnRFgFcVmI4oFyGRB ++V0KDsB0QsWO+hbvT1iLxQ5DcHXyUhXyK6J03f+J9sfjrA6r3FDlo1oRARQH6AURGae iBCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768810643; x=1769415443; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=87X96O69HjPFMulPg1QR+SL19iQWTFSZSdfYbuNZu7Y=; b=KbVfzVZHx6sqQB8X69oYm8Q4Pvap0HuKztUyGJ2Hyye2qq0rBpWranxz4R7biayEfB NQjZNXVZvsgMeDesccSJko4cOJEvogqyfJQ9B49BNEbzD0tFZse98U73fZo/CdF6Ppz1 /Hb2qrUa8pD4Bo6Ur3kNHB2x1x51canzDMynkjBWHofwXeOYAbtR++oDc3pio/Z/58bp D8pcwE/lX0VcPPj+OZtRZnX2BmE0sWwB2RZE4Mq6ecGEyEQF1ZA19X9BZZld4N3tW04N ni6M7xFUYKi0Jc7mvmwUsUyO3BtHIWdDzOyWXJBOchCWOTjAp5lxkDa8EvsUq/+4b2Vl kf5Q== X-Forwarded-Encrypted: i=1; AJvYcCX0S/Xxo0hjrtQD+R1ARA1iJHedix+sjJftKMFUVbP6dHdsq62A2nLR33xs86qSPurgb/zXGAvRWcL4g4o=@vger.kernel.org X-Gm-Message-State: AOJu0Yxwky6m/pzC/TOtei7aQqJBi42zEbKF7YEVF+xpeGbz3WLRCO7i LrqSNE7qhkHBL4uypoqjXJP8pJMQdlDJQQovpSiDS5MLgvMUBtVIe0ru6wWORvVW4JES6isY8HW Oi52SMLTl2exjZ9B2V0i3BzM+bBoRo7DSA+gBTx5Y/WbHWaX4EClInmA2EsnE0xXT3To= X-Gm-Gg: AY/fxX5QW0k5cOeQnRERy1eLgN4BFm8TBCkcE3svkpPuKKmtmFCzXTGW48i7j/d7CTO budNxHPYm1topBRjPspBWmEykVKaiYoYRNJhLrybJZM7bVwj6hZa3FrA+BNRvRq0Wh/7OASbnRp 4QUDVL+42n6b1VvWC1pSSamGYB2eo1EJIJUICUO1PqIaIkd4AsmD6pcC/vt+PKM3Vj1K+NyTQKE 75ks25+Oh0Od/EjehMxRNbJ6ALnPywQ7c7hKbaaSv2vk8F2/Td4Budr4aFc6OsbzdwIM3AJ6iL6 fYiUyKrMMuUnyQvSkxoNtUDlQDFX2KfQ5WW5QKCCkm0i1sp0nQw6RVFP8EyOmnzUZIrgmYEjDwg 4j6kJxRLyuocsb/FZj+AuFFY5J5/Ho/IihgtcL5THBdiMnXPXkOem0lqSRSTsKWHIpzozha8kYY eH5buJIe7fJdv7PBx5QopLErk= X-Received: by 2002:a05:620a:4049:b0:8b2:ec1e:fe30 with SMTP id af79cd13be357-8c6a6768664mr1454264085a.57.1768810643258; Mon, 19 Jan 2026 00:17:23 -0800 (PST) X-Received: by 2002:a05:620a:4049:b0:8b2:ec1e:fe30 with SMTP id af79cd13be357-8c6a6768664mr1454261285a.57.1768810642692; Mon, 19 Jan 2026 00:17:22 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38384dbec4dsm29636391fa.20.2026.01.19.00.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 00:17:22 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 19 Jan 2026 10:17:17 +0200 Subject: [PATCH v3 4/4] drm/msm/dpu: fix SSPP_UBWC_STATIC_CTRL programming on UBWC 5.x+ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-msm-ubwc-fixes-v3-4-34aaa672c829@oss.qualcomm.com> References: <20260119-msm-ubwc-fixes-v3-0-34aaa672c829@oss.qualcomm.com> In-Reply-To: <20260119-msm-ubwc-fixes-v3-0-34aaa672c829@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Val Packett X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2955; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=9rYsLNuEACuzhywI0tRJ339OJWdDN6xkayUa/9Ma/Po=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpbeiLLojkLl0l+zM1+h0l2qpcUidmSQV1rw+h9 D+WwgtfE22JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaW3oiwAKCRCLPIo+Aiko 1cGZCAC0A7tmbVhi9GlkQf5dplKw2Mi34dw/Bqiahw6XorhTYT5UCjmIMBhkwgtvJT7mPbwp875 gcQKMZmC5tXIHeSNPStlBtQzk9Q2Ty1NkjB+cLjU37G4qdcdVxr6ppbhywf5bQHsDqPdcTicSEY uerl5IVtPd0pqryeyTuOTUvqQYo+pllR3oNpC47OayU2ZwtENSE1HVKR5qFAdKn4SzcWy9ty7DZ /ksQKWtv6pOGTrE3efVoZfpR6wU2ZbJ9QBO0p2tp4LDJwnVbby7HNZu5gWawdBYHCLR+1xS6UK9 XPTC1wSjeiO0mIsiV1e4WZvuGqkiCLW3PWl7x9lEIvEXQzxx X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: YsnrjCUnFebakZcn28Wd6C3peiZ83Xwu X-Proofpoint-GUID: YsnrjCUnFebakZcn28Wd6C3peiZ83Xwu X-Authority-Analysis: v=2.4 cv=c4OmgB9l c=1 sm=1 tr=0 ts=696de893 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=7FpWx5GjbivZIX0HvvoA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDA2NyBTYWx0ZWRfX89NqxeEr85pR GgQD3o0c8H1inkFKQ+N6vx0wvdFZWb+J2lKrsgdy/9LMq981YghuGF7nWS9RfWYYyFLIPuBH5OX 2vw4fHWCKojjrcm5K1pded2bC1+E4iY0KCPJ6RHZUaf6HPTRTeboN5xvSepSY7Fddk4K6Y2T27E eF3BdAKt7V0ji9YDFXdjorVi5tgtVSp/rIW9ozPDh95NKMyGGft6SLJfzG/Z7ryV6RV6F2fUdSV +oMnZwBmbRA6QsJC/CjxToVAqohHwtZQcJT+JzzJGSPQTsIdjKnjykL8Ctyhf67+VTO3bDl/tR7 C58o8Hjj6F/IGEDptKJiGanljLLU2KZ751fdnk1i4TwF4P2mlaoSRvM/3JdlzGmzn1RtF+ZUnt3 5mJ2YjsN/Hc9eM3JQ6hpsJIXGBumr/xxxQ5EuPQa+qP3+CY8d329EytZ1tOtsoymNymG/KyT0qp +Co3zAb3Vogv0buktew== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_01,2026-01-19_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 spamscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190067 Code in dpu_hw_sspp_setup_format() doesn't handle UBWC versions bigger than 4.0. Replace switch-case with if-else checks, making sure that the register is initialized on UBWC 5.x (and later) hosts. Fixes: c2577fc1740d ("drm/msm/dpu: Add support for SM8750") Tested-by: Val Packett # x1e80100-dell-latitude-7455 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 44 +++++++++++++++----------= ---- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index a99e33230514..80a9fb76b139 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -279,6 +279,7 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pipe= *pipe, =20 if (fmt->fetch_mode !=3D MDP_FETCH_LINEAR) { u32 hbb =3D ctx->ubwc->highest_bank_bit - 13; + u32 ctrl_val; =20 if (MSM_FORMAT_IS_UBWC(fmt)) opmode |=3D MDSS_MDP_OP_BWC_EN; @@ -286,30 +287,31 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, DPU_REG_WRITE(c, SSPP_FETCH_CONFIG, DPU_FETCH_CONFIG_RESET_VALUE | hbb << 18); - switch (ctx->ubwc->ubwc_enc_version) { - case UBWC_1_0: + + if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_1_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | - BIT(8) | - (hbb << 4)); - break; - case UBWC_2_0: + ctrl_val =3D fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | + BIT(8) | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_2_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - fast_clear | (ctx->ubwc->ubwc_swizzle) | - (hbb << 4)); - break; - case UBWC_3_0: - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - BIT(30) | (ctx->ubwc->ubwc_swizzle) | - (hbb << 4)); - break; - case UBWC_4_0: - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30)); - break; + ctrl_val =3D fast_clear | ctx->ubwc->ubwc_swizzle | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_3_0) { + ctrl_val =3D BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_4_0) { + ctrl_val =3D MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30); + } else if (ctx->ubwc->ubwc_enc_version <=3D UBWC_6_0) { + if (MSM_FORMAT_IS_YUV(fmt)) + ctrl_val =3D 0; + else if (MSM_FORMAT_IS_DX(fmt)) /* or FP16, but it's unsupported */ + ctrl_val =3D BIT(30); + else + ctrl_val =3D BIT(30) | BIT(31); + } else { + DRM_WARN_ONCE("Unsupported UBWC version %x\n", ctx->ubwc->ubwc_enc_vers= ion); + ctrl_val =3D 0; } + + DPU_REG_WRITE(c, ubwc_static_ctrl_off, ctrl_val); } =20 opmode |=3D MDSS_MDP_OP_PE_OVERRIDE; --=20 2.47.3