From nobody Mon Feb 9 01:16:30 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E442633B958 for ; Mon, 19 Jan 2026 08:14:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810487; cv=none; b=lPS6dd+0OqYb/eh2yhNJQwVDX2av299zaEyCqjDCyFJ9KEs566ln95yz66XghDAfsCtlldCpgVtqgGuIGLnwnmGPgdCO0GnGiCwxpg139jwLkwL62ZiNQWlHPAtvIwQRa9+UrFikERj5pCMtR7NDLYsXxfdcvN+7P1Av8fLCwEU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810487; c=relaxed/simple; bh=pAwvHUCEcXNpm+LDy8SETL5I47IZwg6IMDS0FVV1308=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=g4hLfJ5kS+Id53IDhYg52PiI2MAd8Pn4r5q5LAoS8yl2SZlJuW+FOt2Lrm8h8k12BAzKPKg22wkubjcV7mY5T/D5vxwCtOpwShXnWLsvtYRpkzWu5dLEmbXvjBQ8bqqtoAUXrdd5oprtNbwirLHm/oloh9Nt4N44yYkoc9Bhvso= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f/8ul0m/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KpXdETO+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f/8ul0m/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KpXdETO+" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J86FE7276675 for ; Mon, 19 Jan 2026 08:14:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Q2s2/Y+rMi8EkXfWOzNwWPKg5Sl+rEgH1nG07NabTws=; b=f/8ul0m/k9Mtusu0 O4fVRPgrk/fKyS0leQJqStHmbFxAVcFnRKSejveBzuAEhqyMDNKSvywms5UkpQ4x /+NWDGCkne5xd4gHH/fljmnmh0P6tIJhvk4r+UQ+rK6hB+ldU175HNUQGbsdDKgj 50AA01vjl8UagFhuip9oLiQojsQfzt8An4iJA/Fgi/pR2qqx1R9A/pWcKKARKuDs OTaDHaRPd0yBfzpizFt/gal+HiY1F9zDOngL+IW2rzB9DteDl7n7gc7PpzTLYlEy /ku1xqkG+G/KYlmgPqqf/N9my6CPm1kewV/RUY8Sg+1UO3h6R0WZUzKyALYBTsYH 4d7e2Q== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br36dc8vu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 08:14:45 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c6a69b7813so737510085a.0 for ; Mon, 19 Jan 2026 00:14:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768810484; x=1769415284; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Q2s2/Y+rMi8EkXfWOzNwWPKg5Sl+rEgH1nG07NabTws=; b=KpXdETO+KFXkyuV68skJ4La/IsDVo8t938LPrsNlI4rTS55BbWU1+UqU2UibYY1JJf m8nS10bt1lvP2VrTb+p26fQNV2Jtl3al6K/mEjnify+xtjx8cVdMCE909jTXQGuGiulS uvnrqXco4pzgvjZ8+hzQf+GHOP9wVeOL9N7WyZmlPiqZqPEU3GtlffDPcm52WlxDXkyz /eXmCJoVlySbHJb9wN+HcNcZ8x9K6jVKbWTOf1umrYXwn/WKpMjuKsJ+G+GrIF+nPZii rJRrtsl+1flhAGEt/QGI/jfFka/dypyzFwbeF/7DzbxSpeV4yydTUx/WX+eQxowkn/tl ovsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768810484; x=1769415284; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Q2s2/Y+rMi8EkXfWOzNwWPKg5Sl+rEgH1nG07NabTws=; b=iGMlV/R1V6WrDwgyTMaIYpz0a0S+O6jRvgaRFvDpY/JBhWAvYiPZjms3XPjn2e0/Ed hkb9Sa4Crl5U+K6TSFuDvw4YCFB/3EAX+4YN2k8NVL/V/aoBeMq5La5TNhnXd0QEPzgl 3rXA3M+ZQ+RindfWVDG26E5MZ7wePQzcxfhVfUXogqsQfhPlMGEaWJx0kV70LDv5qMH9 gUrSwKf9sg1uHB+Qsa69TbjUkzGyE2lDh60NmV5v/inewcbCYjMZBC8IUg9lrlUpvf9g j/bGXrMNLBW2maQyyqSxRQvwPKlhsldVAYQNjZUMJtgzo2+SNoi+PlUDzGsEnyhn72ez uFFw== X-Forwarded-Encrypted: i=1; AJvYcCUu5aoWwkKHZP1ApvOPZu+J9RkmEBgSzSfPZ3Js+fuxlP9Y6Jou32y9Fo8XlBFXIyoqzTuWMoM3IzhJP1E=@vger.kernel.org X-Gm-Message-State: AOJu0YzPCQqvNvIdv42ig5BXOEHZW8JA9BvP+y9ke5KxegSXta+jQLLT 5dpj6D7FkDln8s6CkWS902wqKEdIIVP5Fvf/8ZuuDvXRTmFsmhu0CUMzvV2jDfAo0IOqmY3lSEj 86dAuVSHYBZtTvPT9orNfxVxwHZGGdczAfhdQFSidPGPOkUovGTi6/M4q5zI3Bqot+jQ= X-Gm-Gg: AY/fxX5lKkaMUrbJxCi5uy58zZTNxJ+NzxSKdj2gUfjw55LrIWTYRu0+Aw4DmT2OV6a USggFumvu4VNaRKUL9i+kX2VpeGH+Qu8bz0ysmtp/e5+se0Yz1T9kc6GnZ8/iK8vcAVO7FI4HNh LhtiUFPdI9oh8WnT/d+EifWtiFRcwd8w8QtsvepzEKNtRg5bgBPYgITEV/yk/hHyhOyB0IQutwB 9gRWArQj71zDlausQX788J4Kfexw+34YZcYnE4Ieu4bX0HIWW9h/CNHkPZYHcCIy6juckY3g04A Jw42I+ty+M0g0I5xQlBC69hN9ZZ8UJdtHYPT2V09c7Q4tHSP8AFlN5G00iJtbkR3y71Z69LOTJO /UZRo9aLl690rm+hnkKgkwkRmnehzRqTtGzIgETYoFlOTUFFuN5M1Vi27kx/BtJlmZKFz3tdAXy /IIdrzlL/fZbJ9qI9JodaJAyA= X-Received: by 2002:a05:620a:8186:b0:8c5:4e48:c908 with SMTP id af79cd13be357-8c6a68d9cf6mr1151899985a.27.1768810484205; Mon, 19 Jan 2026 00:14:44 -0800 (PST) X-Received: by 2002:a05:620a:8186:b0:8c5:4e48:c908 with SMTP id af79cd13be357-8c6a68d9cf6mr1151898085a.27.1768810483806; Mon, 19 Jan 2026 00:14:43 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59baf34d572sm3063845e87.24.2026.01.19.00.14.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 00:14:43 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 19 Jan 2026 10:14:38 +0200 Subject: [PATCH v2 2/4] drm/msm/dpu: offset HBB values written to DPU by -13 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-msm-ubwc-fixes-v2-2-e0c8c630fdd3@oss.qualcomm.com> References: <20260119-msm-ubwc-fixes-v2-0-e0c8c630fdd3@oss.qualcomm.com> In-Reply-To: <20260119-msm-ubwc-fixes-v2-0-e0c8c630fdd3@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1982; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=pAwvHUCEcXNpm+LDy8SETL5I47IZwg6IMDS0FVV1308=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpbefulaU81WiHXID2ucRCwgIoY/i44V65kXGZq PlYEDN++fWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaW3n7gAKCRCLPIo+Aiko 1RgJB/9wF+X3VBdjncUszdIcvNEvKE56cWE58F1+MNVBscWHvaZpjbqub1DQ93KaB24e/cKF3MP ow8jjcMzlCQQDgVQ6wJrrDZrNQ+pquybiDnRhZznfMMZggxJkULXNIer+RVanIPnaNOyz7ZZRIN 4au+ggELHPCNXRMTHUIiwzRSl1pkh4C594S4fTiGuZvx0QECDApHBWAhWG8qkGzOy1Zco1r0qaj 8BBFBAuzQO9JJ9x3W/0GVZkAepKsvt6MytM74UPJQrfYa1DW0DuAQKbMbZLZlYylPoIRdTZSTDR Vzkjtq8W/gxNR7sKhhrY5E+y9ENQNAZwEOyIMlXfzDv9BIzX X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDA2NiBTYWx0ZWRfX+uykRLSfhaZR 4crEn602700y+Co9gGJu19iW3RcJvPTa+90pqJizM2dg653nPubXjrbsqisUEgX+EapU4zPsGUQ QYSmoi1BhWwRpkelhjlB8OP+v1chbLtZXfIlhwKCGjMArQ5gGZD0FBnDGt7XsPxXP7RjU4ZDds0 YchQhqGwOMoJrCLJr2Ddb2bfvyGvKoO6V7R6AdKsxPfCZnhKH9cXSmZFL/609K0/XDib2zC/GDJ MiH5xSQE0cejRfoAaRCS3QjtR5FasnimSy/ZgdDMHBRr5Xw7OTxrh1V3s3NmzoXzFAH0+z0YEhe zPL655bK6EHxgegc6fHZ+rz+u6bDcrgEh1GTqZubO1btpG89ivO6Hz74JjVqkAf9BkbuUM4n50i fnAAbsCeJHfHW3Tqrl/9eyZPA1+u96NoZqakFB4f2SH6vL+23f1TXJiaKXgKY3nu79lLU0Q/ugB f457v+gxXp3kuzAug8Q== X-Proofpoint-GUID: 0c7GEZjNYCWq0TcKJfB-IUMgWgXjaU7k X-Authority-Analysis: v=2.4 cv=GJ0F0+NK c=1 sm=1 tr=0 ts=696de7f5 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=iGWu5DhtBPyiFZBs7r8A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: 0c7GEZjNYCWq0TcKJfB-IUMgWgXjaU7k X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_01,2026-01-19_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190066 As in all other places, the Highest Bank Bit value should be programmed into the hardware with the offset of -13. Correct the value written into the register to prevent unpredictable results. Fixes: 227d4ce0b09e ("drm/msm: Offset MDSS HBB value by 13") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index 6f1fc790ad6d..b66c4cb5760c 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -270,30 +270,32 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, ((fmt->bpp - 1) << 9); =20 if (fmt->fetch_mode !=3D MDP_FETCH_LINEAR) { + u32 hbb =3D ctx->ubwc->highest_bank_bit - 13; + if (MSM_FORMAT_IS_UBWC(fmt)) opmode |=3D MDSS_MDP_OP_BWC_EN; src_format |=3D (fmt->fetch_mode & 3) << 30; /*FRAME_FORMAT */ DPU_REG_WRITE(c, SSPP_FETCH_CONFIG, DPU_FETCH_CONFIG_RESET_VALUE | - ctx->ubwc->highest_bank_bit << 18); + hbb << 18); switch (ctx->ubwc->ubwc_enc_version) { case UBWC_1_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | BIT(8) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_2_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, fast_clear | (ctx->ubwc->ubwc_swizzle) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_3_0: DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, BIT(30) | (ctx->ubwc->ubwc_swizzle) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_4_0: DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, --=20 2.47.3