From nobody Sun Feb 8 16:05:27 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B821633B6E3 for ; Mon, 19 Jan 2026 08:14:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810486; cv=none; b=jlhEAY8oakxNnCrj4J4/BwXBvdSTmnixYmZApKITtAxtEF7ZjLFp19GJF1PBzdg3+HLO5xK3h5Qa+ibqiy+jrPo7x7CuJRGwQmEa8Tx3Xs2b5Fvh3kR54mm0VZtJ7bLHNqhEY0Aglk5wlonmG5rhZFFbM7MAy1V8bTzsNm4BJsM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810486; c=relaxed/simple; bh=Rj8iAyMfVncSKRo62kAtziE4yMoYdmQABsHSh5kDWEY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cRqUsIeqQzzX8u06xqZvQAoV8ab1LM4U6Jv3L1WB7Y+KkgqEVX1MrXD0chOXH4EDFm1L6MTM4ibZSh9lQfFIUm79oaGRluIx+oF7+DVNXoSTaT2zUo9pcON+NzGb3RwGik+7hJwQf0q90XPWACuxkc9t6kHgtKmQuqCU6u9Q+Ds= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=b8Ckh+nQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ob1nhnrD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="b8Ckh+nQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ob1nhnrD" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J840tc351898 for ; Mon, 19 Jan 2026 08:14:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2tTHPmj2NBaJb//qs7JmAmt97xPSCIRHJxgVnBNp34c=; b=b8Ckh+nQruCBx6g3 Yv5/PMCoCm3zn5m4yKZVY8bQmfKpDg/eL0MlBGND1hmbffxHP7cPhbS4fEgNpxH5 V4UUpIZxikIvZIYP0FF/q4TEq4Nu6uLoSyE2YMYishwGk8V3+5DIG7bB8ZpA6nNE K3CtVz/Y/EW5Ch3dDiDCSK/pU8uyj2RwPuuTdeBBFRnEncUUWbBsmNBc5NYOgcCF 9NTb+4b2YxOaF5cIuS4UrzaRmitT0bmABZSFz0cTs6J4TVFrJA6HfIUowSgBZKVd jaTv4EEQ1VmpBS7j4QFC9SLMn7vlgAJGsRLi8xrVxrcwwdKARG0tg8WDxD/E+1tY ktrqfg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br36dc8vs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 08:14:44 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8c5311864d9so878014885a.2 for ; Mon, 19 Jan 2026 00:14:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768810483; x=1769415283; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2tTHPmj2NBaJb//qs7JmAmt97xPSCIRHJxgVnBNp34c=; b=Ob1nhnrDZV4cVz+aYpjByOJs7cz1nkwbWG7CWr+AepdzB0q5Q5OlXDh2/mH9iFjZRx Q60g+W8RxmrzIArD9PUUcv0co2MJH4BLb5WhpAiaDo9GtwcaDt5CpZTkbqSw3XNzdI6m DMebWoj3e2EGVgeLEZ9fpVYVXhe5ZzYaL/22nvqZVsGlQNLGQo57Cu3wSuseDI9PjdEi nLvMX9QCr+G3XTElaD5J4Nylb7zQTnaM+OBvUJMqt4gAp6FE99+eeQtAQdye/yQaZctH zMSP4O6WwsfdICk/gnlFKqQ+Ah3pyKny5RV31purQetqqkwv6IsbAuylwtJ7dGkzlzVi ZNkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768810483; x=1769415283; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2tTHPmj2NBaJb//qs7JmAmt97xPSCIRHJxgVnBNp34c=; b=c8AQVX6+LTRLAdbHkp4vVu7iI7+aeox/278vGp+tHzjrtL0BAEE9fnFXEFpq8ShW0v 9OJhiDGUR1HA0UDeUbd1ou1ibHtteEkyXT+x1juYO+otkFKwJOH9cAmXubzTNXACIGyr fkuZK4pY5gfCG/kwyVlaEkUdaOzyZLOM8WufiWYhCErpaI9eaX9jj67dQSbMsVU54N4z fUvI8iKatbLD8wsOAHgrW5pa9LVuQDQCJqynhNYIlQx2kGKQGJvOADqkSpcw+yl9oO41 RPvSCWP0H0Xh8VUNuXtmwNOisAku8ZcXhIL1acuiV40uNnPAssaX/x0qNGYP8BgTblWw CqYg== X-Forwarded-Encrypted: i=1; AJvYcCXPbU9fRQfw1TOFof1MqBezD4AYwnM+wTAHk4/Pa9af7x7QYfmRHlB2PlwCICN63bMdJkuqX/l1ghh6jkE=@vger.kernel.org X-Gm-Message-State: AOJu0YzvHrEssWJaREt45Ly+F1B+dHme5+XYSww0+ObMtk09S1AfWsyS O8A8BR4o6WMi5ZQbxxa1DB69LEag5jfLPaWoIUblRqvYDb1YAR9OVsOMGDA3GV4dqWCPP3zy4tv IWWtV/0M02qLm+cAPG60+FNYP9tKglzLTUIyq4P/MvLGRHuZKrNAxqjIcaRy8JhOgLuU= X-Gm-Gg: AY/fxX61jrQQYSkDDwaVmPPWumjKF02238hP4IacL1hvPC4U9dUXfO5TjkgDG7KceOp g7g4cjkzmB6vfkJxHlh8CzxZI11zv1rZatk6IxaHtGb8j5BZG4Cm71yYeBc+A8l1f+R2txbJNVn 731mEm7LwmPPZfMULpjt7Q6K8jMy5sRey8z360yCz3MuJZiAU41N8kZkrCLKtdIRMrs5mYfbFVa 73V0L93tE4OuNysLuUfNQeKt2rwA9LDYXH85i2BjHP6dxrvxOEGM4qr8kigZC6eK3akwO2Qrlk8 MJ4UOFNJyS2BuhetI77ULtrpDvsS0PSjsbxY+9ZU0SbaZnJ16oeVaXyf9JQWvW1mII07R5zfoYp QvOA3znBNAttr+tP4REIGQazAca32QhQ51+EbGBiWZst7YyQ3ryY6LW4HZr9J9+ogVPHtEuPYZ4 v/UZV0X4j91IAD6JbfaPfuxN0= X-Received: by 2002:a05:620a:3712:b0:8be:88f2:5b15 with SMTP id af79cd13be357-8c6a670f6e8mr1458674785a.38.1768810483134; Mon, 19 Jan 2026 00:14:43 -0800 (PST) X-Received: by 2002:a05:620a:3712:b0:8be:88f2:5b15 with SMTP id af79cd13be357-8c6a670f6e8mr1458671285a.38.1768810482685; Mon, 19 Jan 2026 00:14:42 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59baf34d572sm3063845e87.24.2026.01.19.00.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 00:14:42 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 19 Jan 2026 10:14:37 +0200 Subject: [PATCH v2 1/4] drm/msm/mdss: correct HBB programmed on UBWC 5.x and 6.x devices Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-msm-ubwc-fixes-v2-1-e0c8c630fdd3@oss.qualcomm.com> References: <20260119-msm-ubwc-fixes-v2-0-e0c8c630fdd3@oss.qualcomm.com> In-Reply-To: <20260119-msm-ubwc-fixes-v2-0-e0c8c630fdd3@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1114; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Rj8iAyMfVncSKRo62kAtziE4yMoYdmQABsHSh5kDWEY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpbefuQyz/KDw5+L2NGZr/8tgfTvkCZZ6LwB57K VEiKShTdROJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaW3n7gAKCRCLPIo+Aiko 1dL+B/47onnFk9FOGKSyu2tzszeBJMJknaST8XNmfVXnyT8fSrNmF7Tcug9qjZ+iy/tW8/viW8n kcj8bw+OmmOeCpqvAxBfzRbuTJBuI6EAZt60h9SqdwdyJ4lTE8uGF4Z1TRvSD+psuBqrNBYCmYo 0Em1AMukV4Xw8gYOnQmrW64huNldZEFeeDGulwGIJOVqNDj4cPMn+UZPVFu2mlkdndXp6FhxuiA 8zuGRmL5u8zO1/BCirhUE5Y66fxqpYt/x2Dukek7vZ/znMnhqHY2kRClGWeA8Ez3RwLC1a+HQ2n 4MA591fvbGA8hFNktnhBKeLPYe0FhbMsAqQxsdqTG7I+XEnl X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDA2NiBTYWx0ZWRfX0+2R9E5/I5nq gyFGmV1+ZPPHTlcN1trJ2v/4HpSgenlpXtUadzwi0zuW1WOCaIQVBrwIuGkpv1e3N7IrLMjbgCk FDODoYIagl/JOndJZdb8UTGpcFp5TCpEUOiQKjsv2l7XGrLrLCYP/kRS3l6plnTkcKtiyNTbuWl EbwvYS9m9QiIzJIo4Cuag29dNs9y/6K8zYmmWXKUjdSV6HDN+2+WLaDiGPzLolAbjzaCtJ0lD2n cELIHmNyZwKhZwwNbWsHTt5cp7KD6k30ZynuMkeBU5bEJBmxe9k4sSfnnwKEUjlcS/rfprbwso2 Zy3ZH4+RqdyqRdJPFC/yVeG7L8nwUk/S2e3vwBUn/OC5t0lZtR95DM67GqZaPxFS3Y4i5nJQvg6 DGvo7vcnce9mkssrvTS2VxCQFsKOO48aeN7XSn/DkyhE0WFYJR0JdV3+L+WBnh3iCA9vGXl3iLN KCoW8vw7za8SXDMv0WA== X-Proofpoint-GUID: 2AN4lij_zmFEuzeQnMnLCgbaOs6PYkVI X-Authority-Analysis: v=2.4 cv=GJ0F0+NK c=1 sm=1 tr=0 ts=696de7f4 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=iGWu5DhtBPyiFZBs7r8A:9 a=+jEqtf1s3R9VXZ0wqowq2kgwd+I=:19 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: 2AN4lij_zmFEuzeQnMnLCgbaOs6PYkVI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_01,2026-01-19_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190066 As in the previous generations, on UBWC 5.x and 6.x devices the Highest Bank Bit value should be programmed into the hardware with the offset of -13. Correct the value written into the register to prevent unpredictable results. Fixes: 227d4ce0b09e ("drm/msm: Offset MDSS HBB value by 13") Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_mdss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index bf9a33e925ac..910242f5a71f 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -229,7 +229,7 @@ static void msm_mdss_setup_ubwc_dec_50(struct msm_mdss = *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | - MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit); + MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; --=20 2.47.3 From nobody Sun Feb 8 16:05:27 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E442633B958 for ; Mon, 19 Jan 2026 08:14:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810487; cv=none; b=lPS6dd+0OqYb/eh2yhNJQwVDX2av299zaEyCqjDCyFJ9KEs566ln95yz66XghDAfsCtlldCpgVtqgGuIGLnwnmGPgdCO0GnGiCwxpg139jwLkwL62ZiNQWlHPAtvIwQRa9+UrFikERj5pCMtR7NDLYsXxfdcvN+7P1Av8fLCwEU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810487; c=relaxed/simple; bh=pAwvHUCEcXNpm+LDy8SETL5I47IZwg6IMDS0FVV1308=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=g4hLfJ5kS+Id53IDhYg52PiI2MAd8Pn4r5q5LAoS8yl2SZlJuW+FOt2Lrm8h8k12BAzKPKg22wkubjcV7mY5T/D5vxwCtOpwShXnWLsvtYRpkzWu5dLEmbXvjBQ8bqqtoAUXrdd5oprtNbwirLHm/oloh9Nt4N44yYkoc9Bhvso= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f/8ul0m/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KpXdETO+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f/8ul0m/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KpXdETO+" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J86FE7276675 for ; Mon, 19 Jan 2026 08:14:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Q2s2/Y+rMi8EkXfWOzNwWPKg5Sl+rEgH1nG07NabTws=; b=f/8ul0m/k9Mtusu0 O4fVRPgrk/fKyS0leQJqStHmbFxAVcFnRKSejveBzuAEhqyMDNKSvywms5UkpQ4x /+NWDGCkne5xd4gHH/fljmnmh0P6tIJhvk4r+UQ+rK6hB+ldU175HNUQGbsdDKgj 50AA01vjl8UagFhuip9oLiQojsQfzt8An4iJA/Fgi/pR2qqx1R9A/pWcKKARKuDs OTaDHaRPd0yBfzpizFt/gal+HiY1F9zDOngL+IW2rzB9DteDl7n7gc7PpzTLYlEy /ku1xqkG+G/KYlmgPqqf/N9my6CPm1kewV/RUY8Sg+1UO3h6R0WZUzKyALYBTsYH 4d7e2Q== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br36dc8vu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 08:14:45 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c6a69b7813so737510085a.0 for ; Mon, 19 Jan 2026 00:14:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768810484; x=1769415284; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Q2s2/Y+rMi8EkXfWOzNwWPKg5Sl+rEgH1nG07NabTws=; b=KpXdETO+KFXkyuV68skJ4La/IsDVo8t938LPrsNlI4rTS55BbWU1+UqU2UibYY1JJf m8nS10bt1lvP2VrTb+p26fQNV2Jtl3al6K/mEjnify+xtjx8cVdMCE909jTXQGuGiulS uvnrqXco4pzgvjZ8+hzQf+GHOP9wVeOL9N7WyZmlPiqZqPEU3GtlffDPcm52WlxDXkyz /eXmCJoVlySbHJb9wN+HcNcZ8x9K6jVKbWTOf1umrYXwn/WKpMjuKsJ+G+GrIF+nPZii rJRrtsl+1flhAGEt/QGI/jfFka/dypyzFwbeF/7DzbxSpeV4yydTUx/WX+eQxowkn/tl ovsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768810484; x=1769415284; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Q2s2/Y+rMi8EkXfWOzNwWPKg5Sl+rEgH1nG07NabTws=; b=iGMlV/R1V6WrDwgyTMaIYpz0a0S+O6jRvgaRFvDpY/JBhWAvYiPZjms3XPjn2e0/Ed hkb9Sa4Crl5U+K6TSFuDvw4YCFB/3EAX+4YN2k8NVL/V/aoBeMq5La5TNhnXd0QEPzgl 3rXA3M+ZQ+RindfWVDG26E5MZ7wePQzcxfhVfUXogqsQfhPlMGEaWJx0kV70LDv5qMH9 gUrSwKf9sg1uHB+Qsa69TbjUkzGyE2lDh60NmV5v/inewcbCYjMZBC8IUg9lrlUpvf9g j/bGXrMNLBW2maQyyqSxRQvwPKlhsldVAYQNjZUMJtgzo2+SNoi+PlUDzGsEnyhn72ez uFFw== X-Forwarded-Encrypted: i=1; AJvYcCUu5aoWwkKHZP1ApvOPZu+J9RkmEBgSzSfPZ3Js+fuxlP9Y6Jou32y9Fo8XlBFXIyoqzTuWMoM3IzhJP1E=@vger.kernel.org X-Gm-Message-State: AOJu0YzPCQqvNvIdv42ig5BXOEHZW8JA9BvP+y9ke5KxegSXta+jQLLT 5dpj6D7FkDln8s6CkWS902wqKEdIIVP5Fvf/8ZuuDvXRTmFsmhu0CUMzvV2jDfAo0IOqmY3lSEj 86dAuVSHYBZtTvPT9orNfxVxwHZGGdczAfhdQFSidPGPOkUovGTi6/M4q5zI3Bqot+jQ= X-Gm-Gg: AY/fxX5lKkaMUrbJxCi5uy58zZTNxJ+NzxSKdj2gUfjw55LrIWTYRu0+Aw4DmT2OV6a USggFumvu4VNaRKUL9i+kX2VpeGH+Qu8bz0ysmtp/e5+se0Yz1T9kc6GnZ8/iK8vcAVO7FI4HNh LhtiUFPdI9oh8WnT/d+EifWtiFRcwd8w8QtsvepzEKNtRg5bgBPYgITEV/yk/hHyhOyB0IQutwB 9gRWArQj71zDlausQX788J4Kfexw+34YZcYnE4Ieu4bX0HIWW9h/CNHkPZYHcCIy6juckY3g04A Jw42I+ty+M0g0I5xQlBC69hN9ZZ8UJdtHYPT2V09c7Q4tHSP8AFlN5G00iJtbkR3y71Z69LOTJO /UZRo9aLl690rm+hnkKgkwkRmnehzRqTtGzIgETYoFlOTUFFuN5M1Vi27kx/BtJlmZKFz3tdAXy /IIdrzlL/fZbJ9qI9JodaJAyA= X-Received: by 2002:a05:620a:8186:b0:8c5:4e48:c908 with SMTP id af79cd13be357-8c6a68d9cf6mr1151899985a.27.1768810484205; Mon, 19 Jan 2026 00:14:44 -0800 (PST) X-Received: by 2002:a05:620a:8186:b0:8c5:4e48:c908 with SMTP id af79cd13be357-8c6a68d9cf6mr1151898085a.27.1768810483806; Mon, 19 Jan 2026 00:14:43 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59baf34d572sm3063845e87.24.2026.01.19.00.14.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 00:14:43 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 19 Jan 2026 10:14:38 +0200 Subject: [PATCH v2 2/4] drm/msm/dpu: offset HBB values written to DPU by -13 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-msm-ubwc-fixes-v2-2-e0c8c630fdd3@oss.qualcomm.com> References: <20260119-msm-ubwc-fixes-v2-0-e0c8c630fdd3@oss.qualcomm.com> In-Reply-To: <20260119-msm-ubwc-fixes-v2-0-e0c8c630fdd3@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1982; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=pAwvHUCEcXNpm+LDy8SETL5I47IZwg6IMDS0FVV1308=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpbefulaU81WiHXID2ucRCwgIoY/i44V65kXGZq PlYEDN++fWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaW3n7gAKCRCLPIo+Aiko 1RgJB/9wF+X3VBdjncUszdIcvNEvKE56cWE58F1+MNVBscWHvaZpjbqub1DQ93KaB24e/cKF3MP ow8jjcMzlCQQDgVQ6wJrrDZrNQ+pquybiDnRhZznfMMZggxJkULXNIer+RVanIPnaNOyz7ZZRIN 4au+ggELHPCNXRMTHUIiwzRSl1pkh4C594S4fTiGuZvx0QECDApHBWAhWG8qkGzOy1Zco1r0qaj 8BBFBAuzQO9JJ9x3W/0GVZkAepKsvt6MytM74UPJQrfYa1DW0DuAQKbMbZLZlYylPoIRdTZSTDR Vzkjtq8W/gxNR7sKhhrY5E+y9ENQNAZwEOyIMlXfzDv9BIzX X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDA2NiBTYWx0ZWRfX+uykRLSfhaZR 4crEn602700y+Co9gGJu19iW3RcJvPTa+90pqJizM2dg653nPubXjrbsqisUEgX+EapU4zPsGUQ QYSmoi1BhWwRpkelhjlB8OP+v1chbLtZXfIlhwKCGjMArQ5gGZD0FBnDGt7XsPxXP7RjU4ZDds0 YchQhqGwOMoJrCLJr2Ddb2bfvyGvKoO6V7R6AdKsxPfCZnhKH9cXSmZFL/609K0/XDib2zC/GDJ MiH5xSQE0cejRfoAaRCS3QjtR5FasnimSy/ZgdDMHBRr5Xw7OTxrh1V3s3NmzoXzFAH0+z0YEhe zPL655bK6EHxgegc6fHZ+rz+u6bDcrgEh1GTqZubO1btpG89ivO6Hz74JjVqkAf9BkbuUM4n50i fnAAbsCeJHfHW3Tqrl/9eyZPA1+u96NoZqakFB4f2SH6vL+23f1TXJiaKXgKY3nu79lLU0Q/ugB f457v+gxXp3kuzAug8Q== X-Proofpoint-GUID: 0c7GEZjNYCWq0TcKJfB-IUMgWgXjaU7k X-Authority-Analysis: v=2.4 cv=GJ0F0+NK c=1 sm=1 tr=0 ts=696de7f5 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=iGWu5DhtBPyiFZBs7r8A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: 0c7GEZjNYCWq0TcKJfB-IUMgWgXjaU7k X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_01,2026-01-19_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190066 As in all other places, the Highest Bank Bit value should be programmed into the hardware with the offset of -13. Correct the value written into the register to prevent unpredictable results. Fixes: 227d4ce0b09e ("drm/msm: Offset MDSS HBB value by 13") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index 6f1fc790ad6d..b66c4cb5760c 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -270,30 +270,32 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, ((fmt->bpp - 1) << 9); =20 if (fmt->fetch_mode !=3D MDP_FETCH_LINEAR) { + u32 hbb =3D ctx->ubwc->highest_bank_bit - 13; + if (MSM_FORMAT_IS_UBWC(fmt)) opmode |=3D MDSS_MDP_OP_BWC_EN; src_format |=3D (fmt->fetch_mode & 3) << 30; /*FRAME_FORMAT */ DPU_REG_WRITE(c, SSPP_FETCH_CONFIG, DPU_FETCH_CONFIG_RESET_VALUE | - ctx->ubwc->highest_bank_bit << 18); + hbb << 18); switch (ctx->ubwc->ubwc_enc_version) { case UBWC_1_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | BIT(8) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_2_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, fast_clear | (ctx->ubwc->ubwc_swizzle) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_3_0: DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, BIT(30) | (ctx->ubwc->ubwc_swizzle) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_4_0: DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, --=20 2.47.3 From nobody Sun Feb 8 16:05:27 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CD5833B6F1 for ; Mon, 19 Jan 2026 08:14:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810489; cv=none; b=sLkG0MKfmW41quwWuSnBY9YY70JMRupJxCdDZiLztRBJwsLPsOE3xOdy8VZk6UiBZBvtPOvugSG3ehoxZ8+dUWCeXPs/QZesWOK0mKTDBZ1bXAYJn1NOMYz5MdVslp7di3xl4YNYO8LdvsdmmJrZUa3tqLWcZxvHMMDEbYAhlu4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810489; c=relaxed/simple; bh=nlqM4pS5tehTmTBqQ+prrjj8JpfEcAuwIhsTGK973JQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E5zPQcj2U1U/Dski1K2ED1WO3JH+MnscPST6G7Zd90klMwnZKQq8a1lWu65G4uM6YvLOHmZKyiN8ewRLgdJWt6C7vcP3jtjeUd1ctS9TvPdAUs+XzfY0xJo3EU+cmY5J9ALupoXE9UVgiCS/5KvuGPtUh4wnvyqaYzvp1w5QkY8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jYOUEt0B; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=h5e++9j6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jYOUEt0B"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="h5e++9j6" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J1jVOS505462 for ; Mon, 19 Jan 2026 08:14:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /NThq6KSUJeukEL9pMouMMZw++r4/wpGPMWQ27LsLSs=; b=jYOUEt0BYWuVrhzB fHkc6UXZhpeuA8O4ZWwd+20yM34hs5Fkdm4bMxJ2yEYjxSBz3YnlXAne8dUIvXqw yfwT5NW79P0QJMmUv4NMzYJdVEvJSVZauBX3QhP3a0fkKO95Gla6t7v1D3rijGrq UkULtt66gjyfu2Yt1/3uG2RyVPoe0/adIDZ1RDQHQL9YFmkDlonEwxqzt6iaB8ZA NM7JZvid1SCVP/BIazkURbpdNAai35ofENsedKhOSP97U2CQy/djp2N6x7vQ/ZSH VbS+ZiZTmck25sjJW+U2/8mclwZ556KuEZmJfJKRsGgHkK0cNLP6e3Hr885b1t2D vxwXKQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br3q9c4sq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 08:14:46 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c6ad709d8fso482540185a.1 for ; Mon, 19 Jan 2026 00:14:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768810485; x=1769415285; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/NThq6KSUJeukEL9pMouMMZw++r4/wpGPMWQ27LsLSs=; b=h5e++9j6dqlfTwCTsGGdZGAEjKq6YpHeoGS56X0/y7ca0uEcONFvWB7iBKaRHGmfKh IPo8zyeB4ACrHPQHl+cYyJ340KBCWBV/EAMRMi/Ibu5uD5NRlD4rSa7rkYDzu3gcicXI CXjv1AoR3yVpFeoRZTInI9CE6101mSU3s8zsITw0rcOw7gH8sXdKbULviENwA9sTjAA1 hjlEPQW8s4cCiXh3mFwvD7gs/PIPhLzo3/f5jIvA+ZyMHKZDcE6cfYHKoZOf9xvlgLzI XpG2pgIHnxV6S97jdeL/LhaFplkNV+vxonBZsUteHkmExDnf2jMLolYdK619BOggbwc1 UqwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768810485; x=1769415285; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/NThq6KSUJeukEL9pMouMMZw++r4/wpGPMWQ27LsLSs=; b=jTz4fXQBwSj6s4Nc6scrfFaCuGfYrr/TvLmdJflkkKeh4zCaJxh1zFx1Rouu1r4c3h 8f3lHTw2vOG3zMnYIgYNzMdPLIcEJpIIdRoT9LAmBmeoEjBJjkgcn+dsR+QZZkNFAf9t 1Abj7MaQxOVHDO7v/iyIaxBuaUxcLGZQq24DDSb8/sJAWpxJwHOnaY8AB3IUcLON4Mu/ VE6qYx7sVcDpZlAfVhP+eUonVR6EUx/nqf9DMvp5p5BsS7B2oZu2QbEnR/8lssPz+MnK 9iZ0+2pxMJVBtqjThDHZDWtlM2j4m8vGGLvVBJzNgQTbLLI0WdKsdBEdB27122iBQ26g tCoA== X-Forwarded-Encrypted: i=1; AJvYcCVqchBvenLABjNbsuQKpRmbOiR8ge70Zr7snF13v6y8JxagdovlabDtmyn2AT2CRVpNOXnziVoP1ptrxfI=@vger.kernel.org X-Gm-Message-State: AOJu0YxMBb8HbHgUycY+aGc48L0m+bToxciIXqGYwlV+1u5ELVolTA1S 2cPNw7RTB2NR6rf7g2jvzQz61pG4p+jiiHRRw2aX2bVgucXCfA11xzeS6IVEdLn1nSX+rkmdo77 AfkTRo0v1jt5ZNt1eoMle7XRXF1lAWrOPtRtkEC+banx7SAjDlH2HQAudWLz7pZt7fy8= X-Gm-Gg: AY/fxX4lEpThAQbzJlYByGu03qfUWMg39G6GfK/l9fSex2z8ZfA5e52oLCE9joHiTjE cIBnW/XdRPtW82nmxM/H7Ma2FkQ0aitavm2H1Nf+9/P/1jG3K7Y3EtZwOL2Sp0w+aiZMqZWHwKX I+uwhEDiPP0yITaYe/qgZ0Uq2Ks4M1pjCZS2lQ2QdC1SfCB0nfdhy2wjk15/GYQ89pziwux8Lm0 aWda4zXKJjEP/f6c5DboDPBwHJcqdGFphmWuvXthH4JYO6U7IiD/pnfhZMotNCzNp4CkxQOmcNq ncUXLfSCjYiElBs0uMIpBcftgCQpfvtMTs2pJhj9O2Dt2YxzQcw4NHPkQhCeKwb08V0CIjk+EbY bp/1ls5XtSqPpZuEx9TNdKoWtX3HPnUdLxyZo2Adw5EqT0ie9RAetnVxHB3yo1IF34dB5Kav5wy hiNkS+oRUTHGa2zk29O7cOXTI= X-Received: by 2002:a05:620a:450b:b0:8c6:a587:377f with SMTP id af79cd13be357-8c6a58737e7mr1730834585a.36.1768810485419; Mon, 19 Jan 2026 00:14:45 -0800 (PST) X-Received: by 2002:a05:620a:450b:b0:8c6:a587:377f with SMTP id af79cd13be357-8c6a58737e7mr1730831685a.36.1768810484957; Mon, 19 Jan 2026 00:14:44 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59baf34d572sm3063845e87.24.2026.01.19.00.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 00:14:44 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 19 Jan 2026 10:14:39 +0200 Subject: [PATCH v2 3/4] drm/msm/dpu: program correct register for UBWC config on DPU 8.x+ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-msm-ubwc-fixes-v2-3-e0c8c630fdd3@oss.qualcomm.com> References: <20260119-msm-ubwc-fixes-v2-0-e0c8c630fdd3@oss.qualcomm.com> In-Reply-To: <20260119-msm-ubwc-fixes-v2-0-e0c8c630fdd3@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2979; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=nlqM4pS5tehTmTBqQ+prrjj8JpfEcAuwIhsTGK973JQ=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpbefvWPciqvjeXggjI9TRGgYthCdanfv4U7egB 9Iij4swhm+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaW3n7wAKCRCLPIo+Aiko 1VJ1B/9YNyZABfqXcN2Uyf9qCt6ZDrbYTxPKKdlQWj1xVwUsjAVwyWSRdpOT+5ryjmRjqlf/kKt AG4lFvLBZALJSOitDQIAFXj3TjTKi26Mebk4IkVjAiYUYTxhwWwR0qWp/RxVgyP9V1A2luxImxr FUb1yNcGq22/w6TcmEFHp7bamENlqzo9jI7kzrPBoisVdY3a0bb6lL1bAT5MigvnAFck3ebnOpk SrG+az6YJ4ea9ovVfwpkWtT6Hdlnhqn9RTC9ahEuDEd65xTb6EY1ISBtle674JDXzQX8p93PCTB CTcqBHmL0nrmvIPtAwWDji43ZMCzExr1u1uzpwVbuKihq+dr X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDA2NiBTYWx0ZWRfX5iFL7FP0HgIe XR6lpwiNo6fOG8yeh3TnGpIIgZMBIMCaYhurDsf8aJUcFhONQLOpsio9wSym53POo183vI8ii4u e3LuJF51EXgpjLzfKHTY69dKDK6WauT1MT+XR09ACui6zYLVO4WOLKj1PbKKi74IOj2YfaAiGV7 E0zQfcupe1y9rEVCUMFWdRvBtaKbbDI6J403fQ90tCXZK6GcjJNtX6tKAM3Wwv2K5h+0OkRSEyT f238Kn+pUTKTSwa+QvZx3ykaaxnyF7CN9zqAgv5G30dQQyPpKaVJoUaifYg0bLXac57Rn/ThJUO YTbhVSv4WrFqCXKSL1YTs+6/Bi70MFiucEn+4qRmrEsVMrgmWtyCTJ1Sr6v96GNsLlfmevatJKD jsnfCZi9k9BYuv3AVzIHn2960uWJvf+BmLcX9z6UIvtJ6y+a6OGKyjFAKzrs6wH+kFxyXTNyHxP zCG0Z0pmotqFeo8xawg== X-Proofpoint-ORIG-GUID: gKDVlwHZIAiALU_vGcpC4rOsN0FZZjEa X-Proofpoint-GUID: gKDVlwHZIAiALU_vGcpC4rOsN0FZZjEa X-Authority-Analysis: v=2.4 cv=dPurWeZb c=1 sm=1 tr=0 ts=696de7f6 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=7tap2HhiP8zdS8EL3YEA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_01,2026-01-19_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 spamscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190066 Since DPU 8.0 there is a separate register for the second rectangle, which needs to be programmed with the UBWC config if multirect is being used. Write pipe's UBWC configuration to the correct register. Fixes: 100d7ef6995d ("drm/msm/dpu: add support for SM8450") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index b66c4cb5760c..a99e33230514 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -72,6 +72,7 @@ #define SSPP_EXCL_REC_XY_REC1 0x188 #define SSPP_EXCL_REC_SIZE 0x1B4 #define SSPP_EXCL_REC_XY 0x1B8 +#define SSPP_UBWC_STATIC_CTRL_REC1 0x1c0 #define SSPP_CLK_CTRL 0x330 =20 /* SSPP_SRC_OP_MODE & OP_MODE_REC1 */ @@ -215,7 +216,7 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pipe= *pipe, u32 chroma_samp, unpack, src_format; u32 opmode =3D 0; u32 fast_clear =3D 0; - u32 op_mode_off, unpack_pat_off, format_off; + u32 op_mode_off, unpack_pat_off, format_off, ubwc_static_ctrl_off; =20 if (!ctx || !fmt) return; @@ -225,10 +226,17 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, op_mode_off =3D SSPP_SRC_OP_MODE; unpack_pat_off =3D SSPP_SRC_UNPACK_PATTERN; format_off =3D SSPP_SRC_FORMAT; + ubwc_static_ctrl_off =3D SSPP_UBWC_STATIC_CTRL; } else { op_mode_off =3D SSPP_SRC_OP_MODE_REC1; unpack_pat_off =3D SSPP_SRC_UNPACK_PATTERN_REC1; format_off =3D SSPP_SRC_FORMAT_REC1; + + /* reg wasn't present before DPU 8.0 */ + if (ctx->mdss_ver->core_major_ver >=3D 8) + ubwc_static_ctrl_off =3D SSPP_UBWC_STATIC_CTRL_REC1; + else + ubwc_static_ctrl_off =3D SSPP_UBWC_STATIC_CTRL; } =20 c =3D &ctx->hw; @@ -281,24 +289,24 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, switch (ctx->ubwc->ubwc_enc_version) { case UBWC_1_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_static_ctrl_off, fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | BIT(8) | (hbb << 4)); break; case UBWC_2_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_static_ctrl_off, fast_clear | (ctx->ubwc->ubwc_swizzle) | (hbb << 4)); break; case UBWC_3_0: - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_static_ctrl_off, BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4)); break; case UBWC_4_0: - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_static_ctrl_off, MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30)); break; } --=20 2.47.3 From nobody Sun Feb 8 16:05:27 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34B4933BBA3 for ; Mon, 19 Jan 2026 08:14:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810489; cv=none; b=ZaD0pW+UADEbzQKYq47HbMH0WvCyhubLSH6UiHk9/1jq1kxMOWYA0e3EHlRid1/BdOC0HYJJQ/XP2zbGQcMH95VkCMhoP6xsHz1QYd6o7nXUdxRfEnQVxUnnMFQHg5UMLSPlmBVCYnZradcoQTuVP2ahoKabZI4eCfcgh/AYZVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768810489; c=relaxed/simple; bh=Irf6GJDAnKdRVE5ZDTRsZj60m1BLdF1o4/Z3RDY3HSM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rGVKrC1T0dCa4Kq/nLckj5oIFM0QEfgpjVCKUNdW668sp3dyKNNDlL/3xmUduNvQceRFthMznkNVLsMx+yajw7a+Nm1pjAM4kJAlFibh+x9jRZSFy4VP9PHqe5DKwOF0678UA7+T8AXD7n/GaWlarREvbwVURGuKuF3si01nV7E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QHnZHS7y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IQlpK8Ca; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QHnZHS7y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IQlpK8Ca" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60J7jfo93329642 for ; Mon, 19 Jan 2026 08:14:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yEA5A7r2kJllLC6PuaIA9vsYW7wCDvkUCbOlZOzUws4=; b=QHnZHS7ylljx+36j RJu3Ldx9sPlBb00YKfVCuwk0OLv7nFQSx+8oAz0LZZNjIUM2pALQzUwpaJkhyZx4 IIiTMA2Ly1FA7Lmy+ktuGahnFRJhNYfGctlZ+1hCLDj7mrowv6e3ZUNWRuGmgfn3 ETN8P00zeej8sXnabb3Q2N69w+11YhQJX2b8Zg+eFPClfI6ioLfwKb6Kyj3s64Yh +bC6vcGqhB67b2ZDBujLw0s7C3qxlL9bk/JM/ahahYsFiD/WrqcTZOhlaLNWohkM tQJx6QuE3e5tTRgXf0Dxk/e9Em757gUpqc8dGs6HM5rPERa2nGexvS6VjIvj5y0b lUMgCQ== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bs78819x1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 08:14:47 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-88a316ede50so91374356d6.0 for ; Mon, 19 Jan 2026 00:14:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768810486; x=1769415286; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yEA5A7r2kJllLC6PuaIA9vsYW7wCDvkUCbOlZOzUws4=; b=IQlpK8Ca7LR2bCsgdJtckBSD0BP/zhB80zhy9Eg561AA54L6/CDF+FOvTmwIu8H4n1 gxlBSy0kfhS0SuqZWNccg+1WMqlHuHTzwz5li7pSm3vBXpfYOKpCnfKKiKPDSyMNg/EQ g0Y0BgjhtVnWCwOVmTxOUGOHI3PMRNr5gIxWx4O0jXSq4WjanpwD/02jl//UlU95Sp7Q c2ONsdU7bvXsguSewBpCpB43KcesUODyg/ns4bg3MRCNOcTf5M8BGiFxO4slZZ+614tX N3ZXkx1mjk/V8X/3T/dtuNyq6z2mjkPsCPmTXCRU89m8FDMbNVSuyqLwCr10IDpP/YFz ADoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768810486; x=1769415286; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yEA5A7r2kJllLC6PuaIA9vsYW7wCDvkUCbOlZOzUws4=; b=m18G39TZXYn6J0assGIVNs+F9tjr0FQW9tl74dp8uYo7/hKkb5ioJ6LpB9/Sm50fOM feok0HcVQoeq9/0I1HgCKQVgdfMj7cvCGzwIPTP6FihvMgp3wg8p4Z36UROUFdQTmS3C /aXO0WXvYnOxUMGPzsCTxxXnajDiGZpiG3nFdDWQus+jCw3wZGcd+cO2b0u0kjtEFbjt HsZ+PYa+oYP3+fmfdCPJRv7cqZdg/yVYOhn/kD0qZg/JHXyZvksEFvt4madtH07tukdV Yi51eBgUQTcvh75TvMtDo5Yltg+g4p4hro1WKT8l6E1bzJdgnSABYbFPFyO3hcu1Abi/ RSgA== X-Forwarded-Encrypted: i=1; AJvYcCXXWHHwF2MP5jG3Pc0t9QapPgnENA6TPAmk40dV9Ww1aQ+iyYWS3m6sQn3cx58Y7MzbF92Xu1H00NZxc70=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6z9XuWrUYNb2zIJKEtLb03FJsJGh6fjWqFyUm9WIkq07x/Cfy pAhtXPhDjnwpw8W/yCa1viu2QBQcVmfNN0SabjpvJ9jDF6QT1ZThiBfjdlBF8VpaCmhkCWU7FAd 1mP/z/Gwf4ayYfGcRGsslPUuO/DBXfJBFWoaBjXYB3Ik3lEg1fCRCAJW0UnEBHad0hLk= X-Gm-Gg: AY/fxX6IcqesspCRATfo+WJxXnO+k8XPLJ4JRhJVMi1nSRkGUi9uvM0Sav73EobEoBh lLxe02+N1eRsQ/yNDypFfznJ0QYNBBPaIa6HnGWFOawsUxDydDZuPpvZsoeCzxfACObRYQUomKl 0t8Nifs04dEqgR7yD2VPZwhZP5qC3Wz0UJ8780SJcLlfer5tJCD2ZUtAvtYxo+IUtX8soNazNWz YxyDZ4Pwi1zcACZ8C5OXWfR1s2TydZfU4Q/1+6/yQjCnj5G4bNr3JMmjxgyB33NhOcW9FHCw/j4 8PTqBjuibbAr1cGnHT17W1X5Mfg9Toy40+Ne2p7LkF7ena2DwaiqoEJgKTYRroWk/WwJG/w1kbR Un9UNFfRJj0EydoR+UOPzKuy3j0NUnVFHmS00L2mEXD0887g0hzzUD7XNquGX7eLJ4bCCCa3WLe ZBFfsDJMiNOVahNwdtCI1GVy8= X-Received: by 2002:ad4:574e:0:b0:892:7075:5743 with SMTP id 6a1803df08f44-8942ddbbaa2mr140094996d6.45.1768810486580; Mon, 19 Jan 2026 00:14:46 -0800 (PST) X-Received: by 2002:ad4:574e:0:b0:892:7075:5743 with SMTP id 6a1803df08f44-8942ddbbaa2mr140094746d6.45.1768810486138; Mon, 19 Jan 2026 00:14:46 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59baf34d572sm3063845e87.24.2026.01.19.00.14.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 00:14:45 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 19 Jan 2026 10:14:40 +0200 Subject: [PATCH v2 4/4] drm/msm/dpu: fix SSPP_UBWC_STATIC_CTRL programming on UBWC 5.x+ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-msm-ubwc-fixes-v2-4-e0c8c630fdd3@oss.qualcomm.com> References: <20260119-msm-ubwc-fixes-v2-0-e0c8c630fdd3@oss.qualcomm.com> In-Reply-To: <20260119-msm-ubwc-fixes-v2-0-e0c8c630fdd3@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2821; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Irf6GJDAnKdRVE5ZDTRsZj60m1BLdF1o4/Z3RDY3HSM=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ2bu8/ca+i8f2sd4NaovzTpgGcpeVn9k/lIfT1v9BG3N4 C+31Z06GY1ZGBi5GGTFFFl8ClqmxmxKDvuwY2o9zCBWJpApDFycAjCRJWLsfwU7eqScwlR21Xbr vmDR+l0tuTa063IDw+2v2U26IRMnCe7cNm1646kbt+JOLdTdHDv/5pvdt6o9puw9vi64jP/2r5d lZttfTWaWlPiy5qCkzxVH2Z2MTTEOE58WCLrWXk8Oi2kOOSllo7Pj9+RbHImGC/Ijmm24WTSdtl zwCd+4nk1IKnO689On/FnG3VtY5tckHpTp1eFeUrY6U+5yjbPuXsO8A+/zXD/dm7RKsPaij9eCp zKtEodVU2p2LpwTefa5H+e2wzZrb+0u41nZePj15Abdv967PliqG6kdC0pzU3vFU/JwsZWT04/D z+dOVvhwPilRQNisy7ROIZDHJlDD65doXaawRfKtTcfLAQ== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=KLVXzVFo c=1 sm=1 tr=0 ts=696de7f7 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=7FpWx5GjbivZIX0HvvoA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDA2NiBTYWx0ZWRfXy71vshSsxpol hBQi+Z6pLeDJrxsYeBGi/Qyw4p8ihBUJgyQnZvxsiNqqvyp5z90X07GImrbNnz90En6Qp0FFVSt AJCjzgxM8HSozIb8tZtydV/79wqLztiskZt2YanpCcihowcBXG5WPe06Ufc06AKy/yJMHnDKLIQ y/C2B01QIQrGVEsaZlTh99mMme5hGhnZ/w4ykXma3IKx90nWUEWQyl5ljSyJWX+tXGIP+ZF0eZI GRGmQYzw5+L9F/A4XEUtTBXlrpT5NS31Z00kqOkKGYb+fGGsd2HHny1yoNcnSmuPvfQaOZLfb33 aPAi9LkaX8cMuaTUfVvTgaiZvZHgWTwN32A2dzPc91OjRnPi8j+XVsuoSyx/AHH9uPUr1tl4A3s zjha/b5v2xxx4ASEpjmcXDu0Rw1ZCH6dsKwK1p6HfnesLzgeNcOaG9eH4u6mXMaMLeuyxVLZzh5 vW5XlIT/WLWVOYIdstg== X-Proofpoint-GUID: wH9pqgg8TpmBfLJymp-fJl0SPQ_pq5Qg X-Proofpoint-ORIG-GUID: wH9pqgg8TpmBfLJymp-fJl0SPQ_pq5Qg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_01,2026-01-19_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 impostorscore=0 malwarescore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190066 Code in dpu_hw_sspp_setup_format() doesn't handle UBWC versions bigger than 4.0. Replace switch-case with if-else checks, making sure that the register is initialized on UBWC 5.x (and later) hosts. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 44 +++++++++++++++----------= ---- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index a99e33230514..80a9fb76b139 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -279,6 +279,7 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pipe= *pipe, =20 if (fmt->fetch_mode !=3D MDP_FETCH_LINEAR) { u32 hbb =3D ctx->ubwc->highest_bank_bit - 13; + u32 ctrl_val; =20 if (MSM_FORMAT_IS_UBWC(fmt)) opmode |=3D MDSS_MDP_OP_BWC_EN; @@ -286,30 +287,31 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, DPU_REG_WRITE(c, SSPP_FETCH_CONFIG, DPU_FETCH_CONFIG_RESET_VALUE | hbb << 18); - switch (ctx->ubwc->ubwc_enc_version) { - case UBWC_1_0: + + if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_1_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | - BIT(8) | - (hbb << 4)); - break; - case UBWC_2_0: + ctrl_val =3D fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | + BIT(8) | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_2_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - fast_clear | (ctx->ubwc->ubwc_swizzle) | - (hbb << 4)); - break; - case UBWC_3_0: - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - BIT(30) | (ctx->ubwc->ubwc_swizzle) | - (hbb << 4)); - break; - case UBWC_4_0: - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30)); - break; + ctrl_val =3D fast_clear | ctx->ubwc->ubwc_swizzle | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_3_0) { + ctrl_val =3D BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_4_0) { + ctrl_val =3D MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30); + } else if (ctx->ubwc->ubwc_enc_version <=3D UBWC_6_0) { + if (MSM_FORMAT_IS_YUV(fmt)) + ctrl_val =3D 0; + else if (MSM_FORMAT_IS_DX(fmt)) /* or FP16, but it's unsupported */ + ctrl_val =3D BIT(30); + else + ctrl_val =3D BIT(30) | BIT(31); + } else { + DRM_WARN_ONCE("Unsupported UBWC version %x\n", ctx->ubwc->ubwc_enc_vers= ion); + ctrl_val =3D 0; } + + DPU_REG_WRITE(c, ubwc_static_ctrl_off, ctrl_val); } =20 opmode |=3D MDSS_MDP_OP_PE_OVERRIDE; --=20 2.47.3