From nobody Mon Feb 9 17:57:39 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87ED637F0E4; Mon, 19 Jan 2026 14:37:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768833450; cv=none; b=TDsO8iaVE2vON7TbYF6ZalWx01fGa7WUj1IrEmkcQfurCiCngZY0u8aehEcDhXA7ojSgKuJs4bfpYR3Xr9D/24gSuT5Ah7z1ackKG63N4mcw+1kRk6gpq2QPRVlpr1LPJIvYxl5R3XtfyxuHLGkxeoMneS7pIM4OwjewcHjvGFw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768833450; c=relaxed/simple; bh=HcN7gZXwRIuh+bGj1eRaqviXm4njZCLh8953XUGFkX8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ioiEs9OPSVvTZASj9oznrvtOrox/vclC0jbjSPvwI8NTsn/hlt7+VG56SmGS39b2ef2irViiVnQApzhrqduXC+8yEalq3HaRO5tTrb5qHABUVgW8uIAiblB4beiCqTOVK85WCJHdYlVWh8WlJ8KWMaoVSkP/CXqyjbeMoqGWSw0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lSv55gNY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lSv55gNY" Received: by smtp.kernel.org (Postfix) with ESMTPS id 58C93C2BCB5; Mon, 19 Jan 2026 14:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768833450; bh=HcN7gZXwRIuh+bGj1eRaqviXm4njZCLh8953XUGFkX8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=lSv55gNYrLoQa1gcWrYZQP4DkyWfjpFZEr9jy31a0iNr//831mi4PqzzeW6ZpzEeW qRLmrLwLl1uc4dv5ea44yWM+/97L4RjDBKJG6/oxwJAkBj2gD86g1lJKuTcEuECUJb 7tdbdwYsvLPdLKCGWas0OZT1bNj8fIIdB8P5RaVF8dyiz6H9Fr5d4NqfQeK5w7bS9x J7YMIlvDGI5P1HKUgUYk1PLiTHuVuqG3t4BjN1XQ9bZwphoaIoP7fucXUaUxEStKRn dflB63jALEXUrXsr/tn9fTBtUpZ9HlZESekYivcLXsGVEQaKzYuxP9uchxeG+zfL/g xdzIrZu3QR3XQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FEAFD29C35; Mon, 19 Jan 2026 14:37:30 +0000 (UTC) From: Rodrigo Alencar via B4 Relay Date: Mon, 19 Jan 2026 14:37:01 +0000 Subject: [PATCH 7/7] iio: amplifiers: ad8366: add device tree support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260119-iio-ad8366-update-v1-7-8044e23e964a@analog.com> References: <20260119-iio-ad8366-update-v1-0-8044e23e964a@analog.com> In-Reply-To: <20260119-iio-ad8366-update-v1-0-8044e23e964a@analog.com> To: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org Cc: Michael Hennerich , Lars-Peter Clausen , Jonathan Cameron , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rodrigo Alencar X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1768833448; l=12768; i=rodrigo.alencar@analog.com; s=default; h=from:subject:message-id; bh=67Y4OSTw7ChBFBUHIGLRt2epU3S1rrY4JV+HtSrHjes=; b=ZqhL2dzr6U3CVOo5V95jN2ttiEnrPnbSIEvCppMlRB6EALHfUoTZmzRnB4HAxrirWfAB7fMbd Ty9AUNhE+XkDM4vflyQkc2xeeYYofSPNSppuNeE3Fk6+2+qxwzh0rvw X-Developer-Key: i=rodrigo.alencar@analog.com; a=ed25519; pk=ULeHbgU/OYh/PG/4anHDfLgldFItQHAhOktYRVLMFRo= X-Endpoint-Received: by B4 Relay for rodrigo.alencar@analog.com/default with auth_id=561 X-Original-From: Rodrigo Alencar Reply-To: rodrigo.alencar@analog.com From: Rodrigo Alencar Device-tree support achieved dropping the enum ID in favor of an extended chip info table: - gain step and number of channels moved to chip info - pack_code function added to describe how SPI buffer is populated With this, switch cases on the device type were dropped: - simplified read_raw and write_raw callbacks - number of channels retrieved from chip info in probe function Signed-off-by: Rodrigo Alencar --- drivers/iio/amplifiers/ad8366.c | 303 +++++++++++++++++-------------------= ---- 1 file changed, 129 insertions(+), 174 deletions(-) diff --git a/drivers/iio/amplifiers/ad8366.c b/drivers/iio/amplifiers/ad836= 6.c index d3fd8d44eae7..484ab2b6196c 100644 --- a/drivers/iio/amplifiers/ad8366.c +++ b/drivers/iio/amplifiers/ad8366.c @@ -27,6 +27,7 @@ #include #include #include +#include #include =20 #include @@ -46,9 +47,14 @@ enum ad8366_type { ID_HMC1119, }; =20 +struct ad8366_state; + struct ad8366_info { int gain_min; int gain_max; + int gain_step; + int num_channels; + size_t (*pack_code)(struct ad8366_state *st); }; =20 struct ad8366_state { @@ -66,153 +72,142 @@ struct ad8366_state { unsigned char data[2] __aligned(IIO_DMA_MINALIGN); }; =20 +static int ad8366_write_code(struct ad8366_state *st) +{ + const struct ad8366_info *inf =3D st->info; + + return spi_write(st->spi, st->data, inf->pack_code(st)); +} + +static size_t ad8366_pack_code(struct ad8366_state *st) +{ + u8 ch_a =3D bitrev8(st->ch[0] & 0x3F); + u8 ch_b =3D bitrev8(st->ch[1] & 0x3F); + + st->data[0] =3D ch_b >> 4; + st->data[1] =3D (ch_b << 4) | (ch_a >> 2); + return 2; +} + +static size_t simple_pack_code(struct ad8366_state *st) +{ + st->data[0] =3D st->ch[0]; + return 1; +} + +static size_t adrf5731_pack_code(struct ad8366_state *st) +{ + st->data[0] =3D st->ch[0] << 2; + return 1; +} + +static size_t hmc271_pack_code(struct ad8366_state *st) +{ + st->data[0] =3D bitrev8(st->ch[0] & 0x1F) >> 3; + return 1; +} + static const struct ad8366_info ad8366_infos[] =3D { [ID_AD8366] =3D { .gain_min =3D 4500, .gain_max =3D 20500, + .gain_step =3D 253, + .num_channels =3D 2, + .pack_code =3D ad8366_pack_code, }, [ID_ADA4961] =3D { .gain_min =3D -6000, .gain_max =3D 15000, + .gain_step =3D -1000, + .num_channels =3D 1, + .pack_code =3D simple_pack_code, }, [ID_ADL5240] =3D { .gain_min =3D -11500, .gain_max =3D 20000, + .gain_step =3D 500, + .num_channels =3D 1, + .pack_code =3D simple_pack_code, }, [ID_ADRF5720] =3D { .gain_min =3D -31500, .gain_max =3D 0, + .gain_step =3D -500, + .num_channels =3D 1, + .pack_code =3D simple_pack_code, }, [ID_ADRF5730] =3D { .gain_min =3D -31500, .gain_max =3D 0, + .gain_step =3D -500, + .num_channels =3D 1, + .pack_code =3D simple_pack_code, }, [ID_ADRF5731] =3D { .gain_min =3D -30000, .gain_max =3D 0, + .gain_step =3D -2000, + .num_channels =3D 1, + .pack_code =3D adrf5731_pack_code, }, [ID_HMC271] =3D { .gain_min =3D -31000, .gain_max =3D 0, + .gain_step =3D 1000, + .num_channels =3D 1, + .pack_code =3D hmc271_pack_code, }, [ID_HMC792] =3D { .gain_min =3D -15750, .gain_max =3D 0, + .gain_step =3D 250, + .num_channels =3D 1, + .pack_code =3D simple_pack_code, }, [ID_HMC1018] =3D { .gain_min =3D -31000, .gain_max =3D 0, + .gain_step =3D 1000, + .num_channels =3D 1, + .pack_code =3D simple_pack_code, }, [ID_HMC1019] =3D { .gain_min =3D -15500, .gain_max =3D 0, + .gain_step =3D 500, + .num_channels =3D 1, + .pack_code =3D simple_pack_code, }, [ID_HMC1119] =3D { .gain_min =3D -31750, .gain_max =3D 0, + .gain_step =3D -250, + .num_channels =3D 1, + .pack_code =3D simple_pack_code, }, }; =20 -static int ad8366_write(struct iio_dev *indio_dev, - unsigned char ch_a, unsigned char ch_b) -{ - struct ad8366_state *st =3D iio_priv(indio_dev); - int ret; - - switch (st->type) { - case ID_AD8366: - ch_a =3D bitrev8(ch_a & 0x3F); - ch_b =3D bitrev8(ch_b & 0x3F); - - st->data[0] =3D ch_b >> 4; - st->data[1] =3D (ch_b << 4) | (ch_a >> 2); - break; - case ID_ADA4961: - st->data[0] =3D ch_a & 0x1F; - break; - case ID_ADL5240: - case ID_ADRF5720: - case ID_ADRF5730: - case ID_ADRF5731: - st->data[0] =3D (ch_a & 0x3F); - break; - case ID_HMC271: - st->data[0] =3D bitrev8(ch_a & 0x1F) >> 3; - break; - case ID_HMC792: - case ID_HMC1018: - case ID_HMC1019: - case ID_HMC1119: - st->data[0] =3D ch_a; - break; - } - - ret =3D spi_write(st->spi, st->data, indio_dev->num_channels); - if (ret < 0) - dev_err(&indio_dev->dev, "write failed (%d)", ret); - - return ret; -} - static int ad8366_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, int *val, int *val2, - long m) + long mask) { struct ad8366_state *st =3D iio_priv(indio_dev); - int ret; - int code, gain =3D 0; + const struct ad8366_info *inf =3D st->info; + int gain =3D inf->gain_step > 0 ? inf->gain_min : inf->gain_max; =20 guard(mutex)(&st->lock); =20 - switch (m) { + switch (mask) { case IIO_CHAN_INFO_HARDWAREGAIN: - code =3D st->ch[chan->channel]; - - switch (st->type) { - case ID_AD8366: - gain =3D code * 253 + 4500; - break; - case ID_ADA4961: - gain =3D 15000 - code * 1000; - break; - case ID_ADL5240: - gain =3D 20000 - 31500 + code * 500; - break; - case ID_ADRF5720: - case ID_ADRF5730: - gain =3D -1 * code * 500; - break; - case ID_ADRF5731: - gain =3D -1 * code * 500; - break; - case ID_HMC792: - gain =3D -1 * code * 500; - break; - case ID_HMC271: - case ID_HMC1018: - gain =3D -31000 + code * 1000; - break; - case ID_HMC1019: - gain =3D -15500 + code * 500; - break; - case ID_HMC1119: - gain =3D -1 * code * 250; - break; - } - - /* Values in dB */ + gain +=3D inf->gain_step * st->ch[chan->channel]; *val =3D gain / 1000; *val2 =3D (gain % 1000) * 1000; - - ret =3D IIO_VAL_INT_PLUS_MICRO_DB; - break; + return IIO_VAL_INT_PLUS_MICRO_DB; default: - ret =3D -EINVAL; + return -EINVAL; } - - return ret; }; =20 static int ad8366_write_raw(struct iio_dev *indio_dev, @@ -223,10 +218,8 @@ static int ad8366_write_raw(struct iio_dev *indio_dev, { struct ad8366_state *st =3D iio_priv(indio_dev); const struct ad8366_info *inf =3D st->info; - int code =3D 0, gain; - int ret; + int code, gain, gain_base; =20 - /* Values in dB */ if (val < 0) gain =3D (val * 1000) - (val2 / 1000); else @@ -235,50 +228,18 @@ static int ad8366_write_raw(struct iio_dev *indio_dev, if (gain > inf->gain_max || gain < inf->gain_min) return -EINVAL; =20 - switch (st->type) { - case ID_AD8366: - code =3D (gain - 4500) / 253; - break; - case ID_ADA4961: - code =3D (15000 - gain) / 1000; - break; - case ID_ADL5240: - code =3D ((gain - 500 - 20000) / 500) & 0x3F; - break; - case ID_ADRF5720: - case ID_ADRF5730: - code =3D (abs(gain) / 500) & 0x3F; - break; - case ID_ADRF5731: - code =3D (abs(gain) / 500) & 0x3C; - break; - case ID_HMC792: - code =3D (abs(gain) / 500) & 0x3F; - break; - case ID_HMC271: - case ID_HMC1018: - code =3D ((gain - 1000) / 1000) & 0x1F; - break; - case ID_HMC1019: - code =3D ((gain - 500) / 500) & 0x1F; - break; - case ID_HMC1119: - code =3D (abs(gain) / 250) & 0x7F; - break; - } + gain_base =3D inf->gain_step > 0 ? inf->gain_min : inf->gain_max; + code =3D DIV_ROUND_CLOSEST(gain - gain_base, inf->gain_step); =20 guard(mutex)(&st->lock); =20 switch (mask) { case IIO_CHAN_INFO_HARDWAREGAIN: st->ch[chan->channel] =3D code; - ret =3D ad8366_write(indio_dev, st->ch[0], st->ch[1]); - break; + return ad8366_write_code(st); default: - ret =3D -EINVAL; + return -EINVAL; } - - return ret; } =20 static int ad8366_write_raw_get_fmt(struct iio_dev *indio_dev, @@ -312,10 +273,6 @@ static const struct iio_chan_spec ad8366_channels[] = =3D { AD8366_CHAN(1), }; =20 -static const struct iio_chan_spec ada4961_channels[] =3D { - AD8366_CHAN(0), -}; - static int ad8366_probe(struct spi_device *spi) { struct iio_dev *indio_dev; @@ -329,7 +286,9 @@ static int ad8366_probe(struct spi_device *spi) =20 st =3D iio_priv(indio_dev); st->spi =3D spi; - st->type =3D spi_get_device_id(spi)->driver_data; + st->info =3D spi_get_device_match_data(spi); + if (!st->info) + return -EINVAL; =20 ret =3D devm_regulator_get_enable(dev, "vcc"); if (ret) @@ -339,44 +298,23 @@ static int ad8366_probe(struct spi_device *spi) if (ret) return ret; =20 - switch (st->type) { - case ID_AD8366: - indio_dev->channels =3D ad8366_channels; - indio_dev->num_channels =3D ARRAY_SIZE(ad8366_channels); - break; - case ID_ADA4961: - case ID_ADL5240: - case ID_HMC271: - case ID_HMC792: - case ID_HMC1119: - case ID_ADRF5720: - case ID_ADRF5730: - case ID_ADRF5731: - case ID_HMC1018: - case ID_HMC1019: - st->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); - if (IS_ERR(st->reset_gpio)) - return dev_err_probe(dev, PTR_ERR(st->reset_gpio), - "Failed to get reset GPIO\n"); + st->reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); + if (IS_ERR(st->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(st->reset_gpio), + "Failed to get reset GPIO\n"); =20 - st->enable_gpio =3D devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_HIG= H); - if (IS_ERR(st->enable_gpio)) - return dev_err_probe(dev, PTR_ERR(st->enable_gpio), - "Failed to get enable GPIO\n"); + st->enable_gpio =3D devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_HIGH= ); + if (IS_ERR(st->enable_gpio)) + return dev_err_probe(dev, PTR_ERR(st->enable_gpio), + "Failed to get enable GPIO\n"); =20 - indio_dev->channels =3D ada4961_channels; - indio_dev->num_channels =3D ARRAY_SIZE(ada4961_channels); - break; - default: - return dev_err_probe(dev, -EINVAL, "Invalid device ID\n"); - } - - st->info =3D &ad8366_infos[st->type]; indio_dev->name =3D spi_get_device_id(spi)->name; indio_dev->info =3D &ad8366_info; + indio_dev->channels =3D ad8366_channels; + indio_dev->num_channels =3D st->info->num_channels; indio_dev->modes =3D INDIO_DIRECT_MODE; =20 - ret =3D ad8366_write(indio_dev, 0, 0); + ret =3D ad8366_write_code(st); if (ret < 0) return dev_err_probe(dev, ret, "failed to write initial gain\n"); =20 @@ -384,24 +322,41 @@ static int ad8366_probe(struct spi_device *spi) } =20 static const struct spi_device_id ad8366_id[] =3D { - {"ad8366", ID_AD8366}, - {"ada4961", ID_ADA4961}, - {"adrf5720", ID_ADRF5720}, - {"adrf5730", ID_ADRF5730}, - {"adrf5731", ID_ADRF5731}, - {"adl5240", ID_ADL5240}, - {"hmc271a", ID_HMC271}, - {"hmc792a", ID_HMC792}, - {"hmc1018a", ID_HMC1018}, - {"hmc1019a", ID_HMC1019}, - {"hmc1119", ID_HMC1119}, + {"ad8366", (kernel_ulong_t)&ad8366_infos[ID_AD8366]}, + {"ada4961", (kernel_ulong_t)&ad8366_infos[ID_ADA4961]}, + {"adrf5720", (kernel_ulong_t)&ad8366_infos[ID_ADRF5720]}, + {"adrf5730", (kernel_ulong_t)&ad8366_infos[ID_ADRF5730]}, + {"adrf5731", (kernel_ulong_t)&ad8366_infos[ID_ADRF5731]}, + {"adl5240", (kernel_ulong_t)&ad8366_infos[ID_ADL5240]}, + {"hmc271a", (kernel_ulong_t)&ad8366_infos[ID_HMC271]}, + {"hmc792a", (kernel_ulong_t)&ad8366_infos[ID_HMC792]}, + {"hmc1018a", (kernel_ulong_t)&ad8366_infos[ID_HMC1018]}, + {"hmc1019a", (kernel_ulong_t)&ad8366_infos[ID_HMC1019]}, + {"hmc1119", (kernel_ulong_t)&ad8366_infos[ID_HMC1119]}, { } }; MODULE_DEVICE_TABLE(spi, ad8366_id); =20 +static const struct of_device_id ad8366_of_match[] =3D { + { .compatible =3D "adi,ad8366", .data =3D &ad8366_infos[ID_AD8366] }, + { .compatible =3D "adi,ada4961", .data =3D &ad8366_infos[ID_ADA4961] }, + { .compatible =3D "adi,adrf5720", .data =3D &ad8366_infos[ID_ADRF5720] }, + { .compatible =3D "adi,adrf5730", .data =3D &ad8366_infos[ID_ADRF5730] }, + { .compatible =3D "adi,adrf5731", .data =3D &ad8366_infos[ID_ADRF5731] }, + { .compatible =3D "adi,adl5240", .data =3D &ad8366_infos[ID_ADL5240] }, + { .compatible =3D "adi,hmc271a", .data =3D &ad8366_infos[ID_HMC271] }, + { .compatible =3D "adi,hmc792a", .data =3D &ad8366_infos[ID_HMC792] }, + { .compatible =3D "adi,hmc1018a", .data =3D &ad8366_infos[ID_HMC1018] }, + { .compatible =3D "adi,hmc1019a", .data =3D &ad8366_infos[ID_HMC1019] }, + { .compatible =3D "adi,hmc1119", .data =3D &ad8366_infos[ID_HMC1119] }, + { } +}; +MODULE_DEVICE_TABLE(of, ad8366_of_match); + static struct spi_driver ad8366_driver =3D { .driver =3D { - .name =3D KBUILD_MODNAME, + .name =3D KBUILD_MODNAME, + .of_match_table =3D ad8366_of_match, }, .probe =3D ad8366_probe, .id_table =3D ad8366_id, --=20 2.43.0