From nobody Sun Feb 8 14:10:29 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010020.outbound.protection.outlook.com [52.101.61.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 218071D5160 for ; Sun, 18 Jan 2026 19:26:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.20 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768764395; cv=fail; b=Hok5vPOJElKkqBI2Z2HGYMMxVqcjIFHAqD2cxAEQbuDgW2D4d/IosKfK31+CzTMqoRfJXaGqcaJ+kfYFZGuMJ42TsYZm65sVuXu0V3dLK80XsSz4ld+T+dR2l5gKHlZH/cQFcW0MU4Si2c1TrDAdScskS+LVsz04eYETHKlEf+I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768764395; c=relaxed/simple; bh=bHJzWBjMP45DMPXTvzY9nA8Lv3slbbXZn/NYDVXGO90=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RrwSJWoO/QBIXc9JrWtQc+eMwOy8EUOjg2CSDDM2px1hC6IpFxrljnaQbiXaxOs8Bau8LloX6amsILTJCx3fWe1nvfCMfC7t7lQ7paIuy1wVhOvc1boOfFe5K+Oszg6MFQvnKwJ1OO1f07I9svFlQmtrJyThxr6nkgC7Hh/6+0w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=qUGv/T9p; arc=fail smtp.client-ip=52.101.61.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="qUGv/T9p" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CrywA6xRltQ2iQcRgMwAwIDY5qmRTK6P39zR648EB9bB+VIFPxNypbhgvxJKCDKialE73425lbgweD/E7Pxfr7Bhfk4tlsRp2YNDmL/bytr+OFsl34S3LydGfSOmZ8I2Qq45dpGklKjQBQGjyG7oaaMEDFHSfjb4rL2YrJW90tgWCmesHT78L020bUHdCLaQcD+sbAi15l8CNtMEISRqKjRkN+1vSTnlfZQ06yy0aKagpz4fVSlURgGFXRsLu1dQ78wnnPrmUsmEqsYRp9gGOEGNLUNiwUUnt8LCi45t1/bFyhpG4gp7bnuWary3yC2JuB8tyD2EfOdmvMSAgBqmtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fCKc2c/qjEjSDRw/8Qyb1Lt+GR46T99lw7jy2DPXaRk=; b=IFxMqPBfik6VZZd9J+3qR+7JC5bnl6taGVL4F2tgq/r50SF6qd3IVdgwFdBdDi1BevtwAXNv+ATPD4Oo/TdJLsz9NoKuTTIWSglqtAYMcpGApBfOOs9a2KKmbEflJ8hoDa8XSvResXkofySyKJhzRG4R950Yit5D08NY49ZN6Eri8OiKyDFulMGBS7X81o+NFVf8ckqbajhcsGqSFlmlro7oBg6nFCSCEbAmu5FF6Y/EYk1w2humCorW7oYIoal++54QtIJdj7evXz/34TApVWQPQzWkHbWeybWVrU16XjwrznEduEgD3Kq2rGyOFRF97ElKrh1KidMqxMWvDDQk6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux-foundation.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fCKc2c/qjEjSDRw/8Qyb1Lt+GR46T99lw7jy2DPXaRk=; b=qUGv/T9pFhL2Kgv4aAwmgbICIx3V3FW6q40tWqbu9ahIcuXdSYJqZhzGES/vGMxz3I8+U0xnbemZVmfIf7wtCXabk8nsYbQ0TpLxN7LKlGVENcRoqeUXG6MoeT/SB1yCDrHiBkfRk7ja1ebY71g+2V+G/InmVwJPoJ9FlC+9Wwg= Received: from SJ0PR05CA0058.namprd05.prod.outlook.com (2603:10b6:a03:33f::33) by SA3PR12MB8762.namprd12.prod.outlook.com (2603:10b6:806:31f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.10; Sun, 18 Jan 2026 19:26:30 +0000 Received: from SJ5PEPF000001F6.namprd05.prod.outlook.com (2603:10b6:a03:33f:cafe::19) by SJ0PR05CA0058.outlook.office365.com (2603:10b6:a03:33f::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9520.2 via Frontend Transport; Sun, 18 Jan 2026 19:26:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ5PEPF000001F6.mail.protection.outlook.com (10.167.242.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.4 via Frontend Transport; Sun, 18 Jan 2026 19:26:30 +0000 Received: from kaveri.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Sun, 18 Jan 2026 13:26:25 -0600 From: Shivank Garg To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes CC: Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , , , Subject: [PATCH V3 1/5] mm/khugepaged: remove unnecessary goto 'skip' label Date: Sun, 18 Jan 2026 19:22:53 +0000 Message-ID: <20260118192253.9263-6-shivankg@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260118192253.9263-4-shivankg@amd.com> References: <20260118192253.9263-4-shivankg@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F6:EE_|SA3PR12MB8762:EE_ X-MS-Office365-Filtering-Correlation-Id: 9f78faa2-d775-4dab-3129-08de56c77b8e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|7416014|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?60LifQSJr8AzxseqngO8CodpavTI8L0On3/apMyzwslpRCP22mgK1+5NC9nx?= =?us-ascii?Q?iqaF+cyYqyyn8mglHtlxfB6Bu/RawpUqcXsQZBzL59sbfqXbOroGbIoXRW9a?= =?us-ascii?Q?1GJZVIFhGpZMNvV2q3DpKK0tH7h3hLf8zBIKmnbdeiPpEu8Jnh5+wBAmVzSJ?= =?us-ascii?Q?qRKrxzkq6WV3qOmYEZByhWf+3v+wXkNz0XDqtCT1IR+L2nWKJ6ZpOJv5pTBu?= =?us-ascii?Q?WFLdoXt3Fsj6Q5WiSS6ZPFvGzK1vvHKdFGy4eHf4RWAdRxdf3Tczv8JfGsqR?= =?us-ascii?Q?52F9LyGl0hiYxFg7Hgfnhelfy/c/yDfLCKm14JMPlWML7l5lNLS9WhpDUuDS?= =?us-ascii?Q?vjpYDyxM6oA955pIRzJ2m5Rl0sZC2Qi1vK9cW1wqIBBpfvJBKpzd08kcjrd6?= =?us-ascii?Q?OKAS21SpKwhX2kaNBlEFOsPa3z3ZEXa1Ud92vhFX2SFS3wC7yiMhUexyFvNu?= =?us-ascii?Q?nnVGeHFaXUldII1dMpFO0uPjN1RZJiE2veo4WgJB/t7fQxT7uXfDXIh7asmV?= =?us-ascii?Q?JzB7x/gvruScRxtZF9j495+lBXDBU7EnZC6fIlFkv2vD3JoDEcWgbgnMzBRF?= =?us-ascii?Q?sd2j+lKSBZ+5sFdoURKMuxy7dnSbP022We11SYjE4XuqcRLxuL3jGDNFs6p8?= =?us-ascii?Q?NuzqZSnqpLdlFFaZ46LQHRzbvYUOzA1sumt8zH/BzJavhZ56a3njOVpPlLIy?= =?us-ascii?Q?0PJrYcfTvMKUOtox0NIcAjR0vqEPaeQEPy8JVnijquHCumsgy942hgPQsEk3?= =?us-ascii?Q?hM2OzmdHfUlecmZfQSQwE7HOj8ltw3oityKlfQxUzX/jIQV5Wlc56BcQfuwS?= =?us-ascii?Q?seTzEpmHVzgEW2OsIi0RpCMd7bO2gRoKduamWkznmF2qfPW2iZdHZEX1xcnX?= =?us-ascii?Q?MSnb6lrp9OjECbMl1lX5QcoPwPpbi4hUOC8wmYrfWmP5n7FWATYUJ+TUkhh0?= =?us-ascii?Q?AsLzZ+aKfgER1j5yOeiAbhDdultqvdsh69uUuiXZvQvpzdnTly0rCSZOnvGt?= =?us-ascii?Q?NnwuAZmKESOXb/tn8nUpj5tcOnVTXmAPrp1FcT2xrT5uc94g8zAccigi/+4u?= =?us-ascii?Q?gBP1Cp3s9L7zUQZVbT9SLO4BwirT5xdLb63sCiqujyHmFNBolNSjmkRh8W95?= =?us-ascii?Q?7kFFus+fNAs9ZA79BJE8UiJOGxlfaIzidsAnAligAR/0FwUw12tA3BvC/V2s?= =?us-ascii?Q?R1UDh08L2rMCV/h3XknUJ76W7U5fc9Anef+awSCX6/DFm5VDN+x9kEzzGTLe?= =?us-ascii?Q?OQ7DNaGs2l5nhBoyCY/WWvn4lKjDq4/7BHsFZfywyeGM/W2Xe4ygmUBWtCf0?= =?us-ascii?Q?cDmi2MBt8XKreMvPqJ93cCedLXnMr3vPVQlRuXFrCy6U9Gk+w2Ud0f8Bq6Sd?= =?us-ascii?Q?XxYwAIFGdSOnhhqtAr0y4bkMWnbsMrrOpOCX4cxeCDttz4wkdqQBas98tkYR?= =?us-ascii?Q?7OWvMU6vy6b7f8V6ZB+Xte8zfxldd5loZz5JB2lwUuBRsxdwiUqb41Ou7fxX?= =?us-ascii?Q?NVkqYCD2zswSlYjjJ5UyVb4b8ZRYGEnu/PVIN9gStKZO8HI6fdEZh9QUg76Q?= =?us-ascii?Q?jVQaerZR2z06QivMn22UNq195yileG4k98UKF6lxKwwsp2NoUYYvWSNQ58KI?= =?us-ascii?Q?v2tmwLX0UjqTWUQRpNmQf4lDVBf0slqx9MpTp23tnmJCyq0UHpwxkhRD/rMu?= =?us-ascii?Q?K1cnbQ=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(7416014)(376014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2026 19:26:30.3175 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9f78faa2-d775-4dab-3129-08de56c77b8e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F6.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB8762 Content-Type: text/plain; charset="utf-8" Replace goto skip with actual logic for better code readability. No functional change. Reviewed-by: Liam R. Howlett Reviewed-by: Zi Yan Acked-by: David Hildenbrand (Red Hat) Reviewed-by: Lance Yang Signed-off-by: Shivank Garg Reviewed-by: Dev Jain Reviewed-by: Nico Pache Tested-by: Nico Pache --- mm/khugepaged.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 16582bdcb6ff..984294a16861 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -2442,14 +2442,15 @@ static unsigned int khugepaged_scan_mm_slot(unsigne= d int pages, int *result, break; } if (!thp_vma_allowable_order(vma, vma->vm_flags, TVA_KHUGEPAGED, PMD_ORD= ER)) { -skip: progress++; continue; } hstart =3D round_up(vma->vm_start, HPAGE_PMD_SIZE); hend =3D round_down(vma->vm_end, HPAGE_PMD_SIZE); - if (khugepaged_scan.address > hend) - goto skip; + if (khugepaged_scan.address > hend) { + progress++; + continue; + } if (khugepaged_scan.address < hstart) khugepaged_scan.address =3D hstart; VM_BUG_ON(khugepaged_scan.address & ~HPAGE_PMD_MASK); --=20 2.43.0