From nobody Sun Feb 8 02:41:28 2026 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0316A50095A for ; Sun, 18 Jan 2026 18:57:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768762662; cv=none; b=NUavICafvJ5MqWr4kTMgXDjAAJsOhJe/TUYCn8eDSCGNKvJCIl6Rvm0jsKEvZoQ5jSP4tj6YAEe4NyWhK4ZWFlSw2KA+t9/36XL7GmrXGReS9VHTM7tVP3OeeqR55zfRYoApX4LfbsiJCNSAGHEe/shANPQSH5kvDREiEhPVU7g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768762662; c=relaxed/simple; bh=uEH6tkrhwnjKM1uvdiIJIJXExMuu7hcx+AmXyWxFOOA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lmzAxrU9a1hVc5EF5dOzUHiiIrb+3nmoScMdSHZpwhd0+uFvBSI/DyfNgJU8i6yVQKfMwT618+u3Hhpcz/m01ZzoLX99aNZ36xQXxRKckr+XrQcMmwQ0wmF1Ybd4QCTqEMKi1EpHwuHAz2xvlT6VauUuU4i9/iUIqNps4g1orRE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kKAXgJ2d; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kKAXgJ2d" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-7cfd6e0173cso1956643a34.3 for ; Sun, 18 Jan 2026 10:57:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768762660; x=1769367460; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sIn7kPGIfDc+QhgxXADc8Eo2fOwVdn5dCfxtYkZG0x8=; b=kKAXgJ2d7wLGFb0j/dkkCRwufxMtPBJCUaQN6ThbCOQ6tp2Wj8fSjdAPrXIGCAPqoG FafTl+jcrnm4vcEO/cgcXXsBKZQCFJtRg+zjz/3GgpGqHoMUmjqw2Ng8UyE8+Wui8UgX 44Mqik+9op7pPFEf4Mv/EjVxKX2BCMBVdVBWzSdiboGcHN+eCvk/XaASp3k8A64S/dob 7qeAfHCiXLFNcz4kAIduE9FMDe0jdE6QHx0q2Effy4gbW+u4acpQB4GijkaygAZyCn9O KHJwI60ZSiSF+6kpvOsbs6Pl5X8ZAxseYzXNqINVRsyS/eJ6oU8LXytKRgrRW2mizEMp PFRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768762660; x=1769367460; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sIn7kPGIfDc+QhgxXADc8Eo2fOwVdn5dCfxtYkZG0x8=; b=S9Z0N05h2ZsrEFoHiZjcSqwwnhX/ruk7U420HqxABfkJWrwqoB4HLUh+URrzXWZ8+Q pebZwm3c5//bIw2tD3ndxLraSn53rB9w0Bnmbv6iavRuP2QymjKqszU91XQTXnk6g/Cx DOFP7ibOVW/tHHA8ZZdYDw9dAauvXrnZiXEPnsjqUlqzT6eeTdSWEp0q7MywGXpC9ix9 ndnz+cd1ejt/3N6hfcWg28H7b1292aC8gDc8S3Ukm9gyQJw8RDWlr0jqZXPz2GQ26wy0 Sml5KJHeOa4XEwyZjrU3KBgSbyFJl+dYg4TvKm4JiqBEddAUqHOybsK2ykRokkRlkF0U UGYQ== X-Forwarded-Encrypted: i=1; AJvYcCWn9gcleEorRjgd2z9LSC7juXBmkKlPqtw0Z2zCqYqXv2WYQ9DAJRxTiioDYjZ0mXKfNWadcdDmg23rR5Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yyo5gwLdrr6xkFpo5aTi3PqD4D5rXzcm0lJqH89Od7qFBtsZ4pM tF7R0nIwAdZQETTqCH5fdOXlzult4nxjxN9LobJUQmJJk8vnPaPWlJojbuSf+A== X-Gm-Gg: AY/fxX5y41GAitIIWfHieZg/uMf3qKvXuHzspWGAaojOjahHxcXLznOsPyn9F6kTg8X q1MNbbaT9c7QNXbH9X8JFIolsqKIw/Q1Nor1lsQqoYwncfam9Peg5be6QY2RlAEY6c3U6ap5r8Y lCcBORw3Z5i+A63VRCvoXi1nV7cu/DgzIt2hu8kXgO997t0D4+ML4J/dcf5Yxs3jQauKNPzY2nS dcNHB4KIIWzwWgkh/5jBDd44c8kcmASPMOfbuU62OpTKPK/eI+dHGUHnhDCNJecaRDADFGka2Be 2muM6l6+uHEU0kgOV4jsqlMFaa2pLSzTJm/GDdXASo/RVJogOLDUt95GRcl/6AE/Cil3A58ATUr 9nkp7T3Q+L3XePCJifykQ70X5EvIxwOUZzcxa99lc08SjXp+fXmfS6Nji8PHvwxWnuVWJJoApct WiBqBl9eMolyku3FYs2nqktKArWrUv/TeZNYF13ujrWjo= X-Received: by 2002:a05:6820:490c:b0:660:fd8d:954e with SMTP id 006d021491bc7-661179cc735mr3331882eaf.42.1768762659937; Sun, 18 Jan 2026 10:57:39 -0800 (PST) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-661187820a5sm3867685eaf.10.2026.01.18.10.57.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 10:57:39 -0800 (PST) From: Jiasheng Jiang To: markus.elfring@web.de Cc: almaz.alexandrovich@paragon-software.com, jiashengjiangcool@gmail.com, linux-kernel@vger.kernel.org, ntfs3@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH v2] fs/ntfs3: Fix memory and resource leak in indx_find_sort Date: Sun, 18 Jan 2026 18:57:36 +0000 Message-Id: <20260118185736.41529-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <17914287-640d-4500-b519-5f3d3aed2878@web.de> References: <17914287-640d-4500-b519-5f3d3aed2878@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function indx_find_sort() incorrectly uses kfree(n) to cleanup the 'struct indx_node' instance in error paths. The 'struct indx_node' is a container that manages internal allocations (n->index) and holds a reference to a buffer head (n->nb). Using kfree() directly on the node pointer only frees the container itself, resulting in a memory leak of the index buffer and a resource leak of the buffer head reference. This patch replaces the incorrect kfree(n) calls with the specialized helper put_indx_node(n), which correctly releases the internal resources and the buffer head, consistent with other functions like indx_find_raw(). Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block") Signed-off-by: Jiasheng Jiang --- Changelog: v1 -> v2: 1. Add a Fixes tag. --- fs/ntfs3/index.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c index 7157cfd70fdc..c598b4b2f454 100644 --- a/fs/ntfs3/index.c +++ b/fs/ntfs3/index.c @@ -1248,7 +1248,7 @@ int indx_find_sort(struct ntfs_index *indx, struct nt= fs_inode *ni, sizeof(struct NTFS_DE) + sizeof(u64)) { if (n) { fnd_pop(fnd); - kfree(n); + put_indx_node(n); } return -EINVAL; } @@ -1261,7 +1261,7 @@ int indx_find_sort(struct ntfs_index *indx, struct nt= fs_inode *ni, /* Try next level. */ e =3D hdr_first_de(&n->index->ihdr); if (!e) { - kfree(n); + put_indx_node(n); return -EINVAL; } =20 @@ -1281,7 +1281,7 @@ int indx_find_sort(struct ntfs_index *indx, struct nt= fs_inode *ni, /* Pop one level. */ if (n) { fnd_pop(fnd); - kfree(n); + put_indx_node(n); } =20 level =3D fnd->level; --=20 2.25.1