From nobody Mon Feb 9 19:04:51 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FDB3246782 for ; Sun, 18 Jan 2026 18:14:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768760058; cv=none; b=I3MVVy6EULKueDdofgTTresg8e4ycaI+kp5m8GffuUuPy7qrQAhA2LlvHov41/GdFGRTbCa+jflWcV+vicuJBfnM+UbBG7OIXWR2aXjC76pz2fgvw0dNUnGREmiI1S9mYBebflHQM8lV15/Py34jkeUZh7N316TpHaMPgJDG9OU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768760058; c=relaxed/simple; bh=vkcDznwWj/qjFMBulKmjQOCoF8Ar2DR3hx4Aku8xDU0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Dk1IeDkrLVs6igkXgjXxpchRRMRj+uby6tqN0tLZ6+PZdJltf5NxsqwXPPuCxoK1HhsNvr1EjffHVmFOnQdlJsF43gqFR29856+yvkw0sjBFWUWyF96HtkSeUyiHJiZJamvLSuAbbVQkjH7D4ao33KPDQh9cyyy++bhivT1eRAk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EzN+2k4N; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DLbf2Pms; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EzN+2k4N"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DLbf2Pms" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60IHNstQ2915997 for ; Sun, 18 Jan 2026 18:14:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=67t6RAhLzyt rgRuVauxjrKxLIpAZrpKmZdGn8t+btIA=; b=EzN+2k4NrM7LuXrWo7G1bUIbumD OTNAK1l+TrY4gyVn7XnIgQyU6eyUGdOGjlFjAIfHm6sBAITz/2HEUTI99W8gWt/r B8ZmG4egbpUH/U7hy5A6xnxplPWDsLrfJVnZ8C5utr+ktLXkrtfIZN55IqC5vg5n JY0pWIUNo23UDKTY5IY6A2kEAx71yWE7ZI5stIsu1FUTEdSFBn77123+rZnbRrBu ueX7ztwOcBiuiO/dzRGkqOofKnm+Id2r4CgAE8HN4NJ19vHlx5hoDB1FbpNMAqVU gSlWjTLdG55FQBiXMu7HWOrYANMCnS1qb9l/GkHQdHaBUJKdripqciSWV1w== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br3q9an3m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 18 Jan 2026 18:14:16 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-81f2481ab87so2341580b3a.0 for ; Sun, 18 Jan 2026 10:14:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768760056; x=1769364856; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=67t6RAhLzytrgRuVauxjrKxLIpAZrpKmZdGn8t+btIA=; b=DLbf2PmsCbMDaYG5Cu79N3Uybj+o+8mjgheKZ+szVELuu9z+snCY6r8s0q/N90dH2b ul9jIn1Nqjb/m3seMtKB7BBp31y5B37F2Xx1Zjn61QILqsScYJaG1UQP/A59ZnX6w+dH ARbgtLMushjLx+iJqoC/3fU3vwpsYCGDiXafYzRWY8Lzi3k7ODn4nXrFcjwND9Xxma5A 1/bo8sSSBw7i1JUP/2YpwQGele6dXwnW+8dKo4BcSbhWyCXSfP7E8abmhd1q9ydC7ru2 TGe2NrNjbPJvB4YxNxo6WkPu7nIIcRvZKrFGZtWG6mZ4KWFHErrdNfZ/fp3gJjZFA8++ wsAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768760056; x=1769364856; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=67t6RAhLzytrgRuVauxjrKxLIpAZrpKmZdGn8t+btIA=; b=b8eEJLjZ7UNL3+lo/szJcfkFzwqO2bTjKsve1p5IyI17YKw2WgFhcuX5jwdzCc1vUB kY1pDEU7glM3J1a2wmdrdW8t28PVMXDz7MFGoaAQjTOhQlK2yeLk1cqJlADI643/LR9j AargLPLvcjy1XKl9JqGJJordieu70Stmv5Edb+n1vUykOeFP7bMW7x+Gi1v9PFE4LXmM 0ZP+WyZFjbfV+7+7RjI9lZUqSNzVYhadZoRO8vRwOc8MBJoUzNpwcieSaeLmXCv+1aSS mlGg4vCNOS/9t34wZhLDhrc/Fyv3Axh8W/xOcafVsf3Nxd6FyfK6KYkxTwqUj52IXKrn lxQw== X-Forwarded-Encrypted: i=1; AJvYcCXsoLX7RdjPTTQG7klu2o0FwWe9bN0naW5Nh0TIAQjSI+Ox1o6zfK2vFKO5zgMxsnXRqIeC4XBJC62agcU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyg+gczDX86auB0GEbSgCkwJg8npa60pPfsW7jA8HdLn6V6FW6V IEUbdVZcWm9HAEKbjNn5IqL7fnRiKnsfBdGm18zIW/PS58QOKYixcepl+gPlsEyLv+gjPHrSoks 9wh8AUDiq8yoOOykWzpks6v4xw7r/ColgTOQJbD+mvD8mBqwH31plJo0NuaYoM4ymeFU= X-Gm-Gg: AY/fxX74+7Ob83h1nJP5E1CpWDSWJI8DWZ/d5aCs5kCKWGkq1faK/qpMhIZ4MKJJlhI I1uNP0j6Tf63nWVDRQ9eMELZxb/bQbOMMBK16CXJcc0zy6sBunOypM06yJJlf4+VxbRn6uUF7Ie MNlFYum621KF26YSKTZmGxF4P1z1r0vx8/Epkys/foozEUhQDGbZUJh0vm5by3TS2mKgJTjWFLF SZOzfhqiBsMb5iJ1US8oniSW2m+aXKInmGtqEueeVbVUNQQy2gQDSQ7l3jxg22Q+yRnBnfddVzn 7GkXh1yjpMsEbDMKSOQIqJxEN50Hk6uOpgNePpiRS/lyuEQUKFkgUMpcvLuIrJGOGnUmFP55l8k LUK2jo7BZrulMxoLJVMUVdxEOU6t4V/f5JTbuUmx40zRr X-Received: by 2002:a05:6a00:600b:b0:7e8:4587:e8c5 with SMTP id d2e1a72fcca58-81fa030fc84mr7460181b3a.56.1768760055711; Sun, 18 Jan 2026 10:14:15 -0800 (PST) X-Received: by 2002:a05:6a00:600b:b0:7e8:4587:e8c5 with SMTP id d2e1a72fcca58-81fa030fc84mr7460170b3a.56.1768760055199; Sun, 18 Jan 2026 10:14:15 -0800 (PST) Received: from hu-vjitta-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81fa1277a15sm7070759b3a.42.2026.01.18.10.14.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 10:14:14 -0800 (PST) From: Vijayanand Jitta To: robin.murphy@arm.com, will@kernel.org, joro@8bytes.org, robh@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, bjorn.andersson@oss.qualcomm.com, bod@kernel.org, conor+dt@kernel.org, krzk+dt@kernel.org, prakash.gupta@oss.qualcomm.com, vikash.garodia@oss.qualcomm.com Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, vijayanand.jitta@oss.qualcomm.com, Frank Li Subject: [PATCH v5 1/3] of: Add convenience wrappers for of_map_id() Date: Sun, 18 Jan 2026 23:41:23 +0530 Message-Id: <20260118181125.1436036-2-vijayanand.jitta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260118181125.1436036-1-vijayanand.jitta@oss.qualcomm.com> References: <20260118181125.1436036-1-vijayanand.jitta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE4MDE2MCBTYWx0ZWRfXxkbN4FY2Jvym J7CF2bsEVD+GNceHqbyimwEDhCgnkrumEnsd1xJRtQQxGaD5xgOz0tyt+fXK2kq6XwhikRm+Flv JpcQtZFNtQNXc7Cm8QCLWr8+kRYlxuasLeblYLIbi4jQyLbtf03oKXeY4W3nxuHvDH7EcVcuESU bBzFonHrXGb9w7v2/KCZ2ymud4VReixK53AaPAdsVVu0uL/KOfV7FKP7Hym9v9/KRBUVN3ZeBll jX7eGrfFoZtLQDAwR09sM8uxmY1oqlcMD7A0bC4OW1ad0chwXUzJMVOzG7uhiwduJKYQ2oOoVM7 Tdmo7gedEvLQtgFFPIwvMfrSGofnIm++fCU0e4yeQyoz12mJLoU8ifTJ6301W7l29v5YVJp92y7 g5xIgFXi+uzLuuVTLbMCP/XrNsXFPkTQzTPcSoRoFtBsiC4PXb0pEDNOdvF6YUV1XK/fWzQ6u4v btqoNN1qHrqYs37JoJg== X-Proofpoint-ORIG-GUID: FRMtdAIkzaj1vdAiMaPT_GNj7X4v9nub X-Proofpoint-GUID: FRMtdAIkzaj1vdAiMaPT_GNj7X4v9nub X-Authority-Analysis: v=2.4 cv=dPurWeZb c=1 sm=1 tr=0 ts=696d22f8 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=7CQSdrXTAAAA:8 a=VwQbUJbxAAAA:8 a=8AirrxEcAAAA:8 a=EUspDBNiAAAA:8 a=wrOk0Nx1w3hKWqktZycA:9 a=OpyuDcXvxspvyRM73sMx:22 a=a-qgeE7W1pNrGK8U0ZQC:22 a=ST-jHhOKWsTCqRlWije3:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-17_03,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 spamscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601180160 Content-Type: text/plain; charset="utf-8" From: Robin Murphy Since we now have quite a few users parsing "iommu-map" and "msi-map" properties, give them some wrappers to conveniently encapsulate the appropriate sets of property names. This will also make it easier to then change of_map_id() to correctly account for specifier cells. Reviewed-by: Rob Herring (Arm) Reviewed-by: Frank Li Signed-off-by: Robin Murphy Signed-off-by: Vijayanand Jitta --- drivers/cdx/cdx_msi.c | 3 +-- drivers/iommu/of_iommu.c | 4 +--- drivers/irqchip/irq-gic-its-msi-parent.c | 2 +- drivers/of/irq.c | 3 +-- drivers/pci/controller/dwc/pci-imx6.c | 6 ++---- drivers/pci/controller/pcie-apple.c | 3 +-- drivers/xen/grant-dma-ops.c | 3 +-- include/linux/of.h | 14 ++++++++++++++ 8 files changed, 22 insertions(+), 16 deletions(-) diff --git a/drivers/cdx/cdx_msi.c b/drivers/cdx/cdx_msi.c index 91b95422b263..63b3544ec997 100644 --- a/drivers/cdx/cdx_msi.c +++ b/drivers/cdx/cdx_msi.c @@ -128,8 +128,7 @@ static int cdx_msi_prepare(struct irq_domain *msi_domai= n, int ret; =20 /* Retrieve device ID from requestor ID using parent device */ - ret =3D of_map_id(parent->of_node, cdx_dev->msi_dev_id, "msi-map", "msi-m= ap-mask", - NULL, &dev_id); + ret =3D of_map_msi_id(parent->of_node, cdx_dev->msi_dev_id, NULL, &dev_id= ); if (ret) { dev_err(dev, "of_map_id failed for MSI: %d\n", ret); return ret; diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index 6b989a62def2..a511ecf21fcd 100644 --- a/drivers/iommu/of_iommu.c +++ b/drivers/iommu/of_iommu.c @@ -48,9 +48,7 @@ static int of_iommu_configure_dev_id(struct device_node *= master_np, struct of_phandle_args iommu_spec =3D { .args_count =3D 1 }; int err; =20 - err =3D of_map_id(master_np, *id, "iommu-map", - "iommu-map-mask", &iommu_spec.np, - iommu_spec.args); + err =3D of_map_iommu_id(master_np, *id, &iommu_spec.np, iommu_spec.args); if (err) return err; =20 diff --git a/drivers/irqchip/irq-gic-its-msi-parent.c b/drivers/irqchip/irq= -gic-its-msi-parent.c index 12f45228c867..d5d8fa65c24d 100644 --- a/drivers/irqchip/irq-gic-its-msi-parent.c +++ b/drivers/irqchip/irq-gic-its-msi-parent.c @@ -173,7 +173,7 @@ static int of_pmsi_get_msi_info(struct irq_domain *doma= in, struct device *dev, u =20 struct device_node *msi_ctrl __free(device_node) =3D NULL; =20 - return of_map_id(dev->of_node, dev->id, "msi-map", "msi-map-mask", &msi_c= trl, dev_id); + return of_map_msi_id(dev->of_node, dev->id, &msi_ctrl, dev_id); } =20 int __weak iort_pmsi_get_dev_id(struct device *dev, u32 *dev_id) diff --git a/drivers/of/irq.c b/drivers/of/irq.c index e3816819dbfe..fb50ccb50cfd 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -747,8 +747,7 @@ u32 of_msi_xlate(struct device *dev, struct device_node= **msi_np, u32 id_in) * "msi-map" or an "msi-parent" property. */ for (parent_dev =3D dev; parent_dev; parent_dev =3D parent_dev->parent) { - if (!of_map_id(parent_dev->of_node, id_in, "msi-map", - "msi-map-mask", msi_np, &id_out)) + if (!of_map_msi_id(parent_dev->of_node, id_in, msi_np, &id_out)) break; if (!of_check_msi_parent(parent_dev->of_node, msi_np)) break; diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller= /dwc/pci-imx6.c index 1d8677d7de04..c3e5cb3cb846 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1143,8 +1143,7 @@ static int imx_pcie_add_lut_by_rid(struct imx_pcie *i= mx_pcie, u32 rid) u32 sid =3D 0; =20 target =3D NULL; - err_i =3D of_map_id(dev->of_node, rid, "iommu-map", "iommu-map-mask", - &target, &sid_i); + err_i =3D of_map_iommu_id(dev->of_node, rid, &target, &sid_i); if (target) { of_node_put(target); } else { @@ -1157,8 +1156,7 @@ static int imx_pcie_add_lut_by_rid(struct imx_pcie *i= mx_pcie, u32 rid) } =20 target =3D NULL; - err_m =3D of_map_id(dev->of_node, rid, "msi-map", "msi-map-mask", - &target, &sid_m); + err_m =3D of_map_msi_id(dev->of_node, rid, &target, &sid_m); =20 /* * err_m target diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/p= cie-apple.c index 2d92fc79f6dd..a0937b7b3c4d 100644 --- a/drivers/pci/controller/pcie-apple.c +++ b/drivers/pci/controller/pcie-apple.c @@ -764,8 +764,7 @@ static int apple_pcie_enable_device(struct pci_host_bri= dge *bridge, struct pci_d dev_dbg(&pdev->dev, "added to bus %s, index %d\n", pci_name(pdev->bus->self), port->idx); =20 - err =3D of_map_id(port->pcie->dev->of_node, rid, "iommu-map", - "iommu-map-mask", NULL, &sid); + err =3D of_map_iommu_id(port->pcie->dev->of_node, rid, NULL, &sid); if (err) return err; =20 diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c index c2603e700178..1b7696b2d762 100644 --- a/drivers/xen/grant-dma-ops.c +++ b/drivers/xen/grant-dma-ops.c @@ -325,8 +325,7 @@ static int xen_dt_grant_init_backend_domid(struct devic= e *dev, struct pci_dev *pdev =3D to_pci_dev(dev); u32 rid =3D PCI_DEVID(pdev->bus->number, pdev->devfn); =20 - if (of_map_id(np, rid, "iommu-map", "iommu-map-mask", &iommu_spec.np, - iommu_spec.args)) { + if (of_map_iommu_id(np, rid, &iommu_spec.np, iommu_spec.args)) { dev_dbg(dev, "Cannot translate ID\n"); return -ESRCH; } diff --git a/include/linux/of.h b/include/linux/of.h index 9bbdcf25a2b4..309c5681744b 100644 --- a/include/linux/of.h +++ b/include/linux/of.h @@ -1457,6 +1457,20 @@ static inline int of_property_read_s32(const struct = device_node *np, return of_property_read_u32(np, propname, (u32*) out_value); } =20 +static inline int of_map_iommu_id(const struct device_node *np, u32 id, + struct device_node **target, u32 *id_out) +{ + return of_map_id(np, id, "iommu-map", "iommu-map-mask", + target, id_out); +} + +static inline int of_map_msi_id(const struct device_node *np, u32 id, + struct device_node **target, u32 *id_out) +{ + return of_map_id(np, id, "msi-map", "msi-map-mask", + target, id_out); +} + #define of_for_each_phandle(it, err, np, ln, cn, cc) \ for (of_phandle_iterator_init((it), (np), (ln), (cn), (cc)), \ err =3D of_phandle_iterator_next(it); \ --=20 2.34.1