From nobody Mon Feb 9 12:08:05 2026 Received: from mail-pj1-f97.google.com (mail-pj1-f97.google.com [209.85.216.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D97932EB86C for ; Sun, 18 Jan 2026 12:40:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.97 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768740052; cv=none; b=asCO95lzG6I6AMJ0KxW+MIs7jS3Ee6/oLHSEQJbmh8m0BTm0T+KeNaoYpxN5TrvOvPCd8lwvLkkiyChpMGm+yCytqfWj+pTfuzwAlKqiza1N+ejnc/Kg+IYB1ic5Z5R76JvBHOQLChrnVC8CaAj3FR8r53EhvhPuKFkJkjbGxEo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768740052; c=relaxed/simple; bh=QHymrLP79c+XQE/8LFPXoEJnFY+e4wkVSqfgxyXv1tA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZEpYquQnUzHzRUKP5Tpuws21zrQa7rupaQLA2sPn813QbSRhDJlnt9Y3CihGB8EBeRNEGv+92HQtbhGfIUDys0shC1w3/lVtiL9aYaEcGzXvqwPS9Cj3pCN72RaoIvq4WdE9NETbPUnFo61e2MWq6IxL8n9L4vnHLM8rWRucl/0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=ErORafVy; arc=none smtp.client-ip=209.85.216.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ErORafVy" Received: by mail-pj1-f97.google.com with SMTP id 98e67ed59e1d1-34c84ec3b6eso3116148a91.3 for ; Sun, 18 Jan 2026 04:40:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768740050; x=1769344850; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8uwW5kTFniNzAK7B8ZBRrzacCwm+22XYIhP9CIuYilg=; b=C9FcqLGNs5BKsk578hfYAVREBTkKFGGVLgFXjMj8JnyoB6rZzdDWX038d3N59C69ps S5GkZX8LXJ2e8PRxR6g9V8bC4UZghDAFOCQcEib1dyx+b1ttTO4J4+C5+lgr8AGPmBSI 4ZeKautelvyELtgYKuGDpjbd6Mxa275O24VBG+v3JhCkgbLNMFp8lPP1X25NudhGR+6K nzwTm+RRvONtBkXONlHZUlWKoYiqS+YaYUGui742bwfS96uGbiWQ4Sy3O4RcQLs7HQL8 Lcqsh4QehWwmuqV+JhjvLzElEga4qfmHZxCH9stYq/UGCMExnsiAhOXZX/azyXaUDJVi AWOA== X-Gm-Message-State: AOJu0YwlkJQUgKicX7+dPmclJY4RmPYaEcSUXXthDPEGcGxBuFfJI3hE lvMuQWLJZHZJsxI8Fn1jmqSXNcpsq+DoepJkK+ZrVfcIdNT8f49KLjFByRh92anStBRPoHVNR3O pLITA+s858bEEtvQLm1v/XcWaqi7LiaROc5g6I0btKUnzXLIqUVhCvImRxsYlDONUuN1IlRuVug f+PwKBN5lOC+V5B5tTWYB83p1yKksWlBgJwXrDnSZmO2TNk6AVBtORyOsZzXFqWNR6YL7HTB4e5 PotvD/UwQNWBr1J4N0= X-Gm-Gg: AY/fxX7YJRU+nvsNKJkNMHMR6Deeug0CvY6IY2sXJgnLjEKKBVhTqb3E8UD/IEDqTEx TWqWOzuAcR+qZE6xwPYX95R8mMqkDZy6lp9+g9OPepHxValHdPqImNGyg7ahfkpvqVgPHcl/k2J rKDR+dnEVXltlJLIErr6hVjVSwddDfn7Vd5qBok+ez3SsJP4DxZ6vdWqtjv2NpVUDBrOZJhVj1S Y/7coouxNIFE28qvWUxGSwDiRO0pVWDlkUlkaloRkiJttCK8Am3NHXyz41TOV7iFnNjbuxP5E27 l1L1tYJPLYj8anjV/wmi7lDt0TORYN12bkgR4D5c5ama4hSacFWdPPkmh9gPxiLlKPJPreBbLGW D02nFq+WbmQF7OK+BnwDuitnRm3b2++xpCtMsjmU/MFk6mfGLrP4S4KQXynqRBzNgNTyB2v439W SrpqC5OIbOZuAbkvhBv46U6gkbfAyAJ3FY5xZvWMwK1Q== X-Received: by 2002:a17:90b:3906:b0:340:c179:3657 with SMTP id 98e67ed59e1d1-35272fbf5e1mr7086847a91.33.1768740050124; Sun, 18 Jan 2026 04:40:50 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-2.dlp.protect.broadcom.com. [144.49.247.2]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-3527313ffcdsm1031180a91.8.2026.01.18.04.40.49 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Jan 2026 04:40:50 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-34abd303b4aso6953770a91.1 for ; Sun, 18 Jan 2026 04:40:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1768740048; x=1769344848; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8uwW5kTFniNzAK7B8ZBRrzacCwm+22XYIhP9CIuYilg=; b=ErORafVyVXoy/ZRzs8vvxGIIUnXN4IGnhMBNp9NGguRghgz0jHMjFMs+THIO7B+U6q 6NfEAo/Y7gO/ndzzqJVZiz8h94d/50NnmOPYf/DnKNJzySXT5SsMoVZOoHw0bor1aT/l nkYClBJllOJyDuBuNN0N8esRGWXinW6bfSPVM= X-Received: by 2002:a17:90b:2ec4:b0:34c:fe57:2793 with SMTP id 98e67ed59e1d1-35272f87fc2mr6957107a91.20.1768740048230; Sun, 18 Jan 2026 04:40:48 -0800 (PST) X-Received: by 2002:a17:90b:2ec4:b0:34c:fe57:2793 with SMTP id 98e67ed59e1d1-35272f87fc2mr6957098a91.20.1768740047871; Sun, 18 Jan 2026 04:40:47 -0800 (PST) Received: from PC-MID-R740.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c5edf249c24sm6761246a12.11.2026.01.18.04.40.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 04:40:47 -0800 (PST) From: Pavan Chebbi To: jgg@ziepe.ca, michael.chan@broadcom.com Cc: linux-kernel@vger.kernel.org, dave.jiang@intel.com, saeedm@nvidia.com, Jonathan.Cameron@huawei.com, gospo@broadcom.com, selvin.xavier@broadcom.com, leon@kernel.org, kalesh-anakkur.purayil@broadcom.com, Pavan Chebbi Subject: [PATCH fwctl 3/5] fwctl/bnxt_en: Create an aux device for fwctl Date: Sun, 18 Jan 2026 04:33:59 -0800 Message-Id: <20260118123401.3188438-4-pavan.chebbi@broadcom.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20260118123401.3188438-1-pavan.chebbi@broadcom.com> References: <20260118123401.3188438-1-pavan.chebbi@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Create an additional auxiliary device to support fwctl. The next patch will create bnxt_fwctl and bind to this device. Reviewed-by: Andy Gospodarek Signed-off-by: Pavan Chebbi --- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 14 ++++++++++++-- include/linux/bnxt/ulp.h | 1 + 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c b/drivers/net/et= hernet/broadcom/bnxt/bnxt_ulp.c index 1378b58da018..44cf0dfb9556 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c @@ -49,6 +49,10 @@ static struct bnxt_aux_device bnxt_aux_devices[__BNXT_AU= XDEV_MAX] =3D {{ .name =3D "rdma", .is_init =3D &bnxt_auxdev_is_init, .is_active =3D &bnxt_auxdev_is_active, +}, { + .name =3D "fwctl", + .is_init =3D &bnxt_auxdev_is_init, + .is_active =3D &bnxt_auxdev_is_active, }}; =20 static void bnxt_fill_msix_vecs(struct bnxt *bp, struct bnxt_msix_entry *e= nt) @@ -276,6 +280,11 @@ void bnxt_ulp_stop(struct bnxt *bp) aux_priv =3D bp->aux_priv[i]; edev =3D bp->edev[i]; mutex_lock(&edev->en_dev_lock); + if (i =3D=3D BNXT_AUXDEV_FWCTL) { + edev->flags |=3D BNXT_EN_FLAG_ULP_STOPPED; + mutex_unlock(&edev->en_dev_lock); + continue; + } if (!bnxt_ulp_registered(edev) || (edev->flags & BNXT_EN_FLAG_ULP_STOPPED)) { mutex_unlock(&edev->en_dev_lock); @@ -312,7 +321,7 @@ void bnxt_ulp_start(struct bnxt *bp, int err) aux_priv =3D bp->aux_priv[i]; edev =3D bp->edev[i]; mutex_lock(&edev->en_dev_lock); - if (!bnxt_ulp_registered(edev) || + if (i =3D=3D BNXT_AUXDEV_FWCTL || !bnxt_ulp_registered(edev) || !(edev->flags & BNXT_EN_FLAG_ULP_STOPPED)) { goto clear_flag_continue; } @@ -512,7 +521,8 @@ void bnxt_aux_devices_add(struct bnxt *bp) aux_dev =3D &bp->aux_priv[idx]->aux_dev; rc =3D auxiliary_device_add(aux_dev); if (rc) { - netdev_warn(bp->dev, "Failed to add auxiliary device for ROCE\n"); + netdev_warn(bp->dev, "Failed to add auxiliary device for auxdev type %= d\n", + idx); auxiliary_device_uninit(aux_dev); if (idx =3D=3D BNXT_AUXDEV_RDMA) bp->flags &=3D ~BNXT_FLAG_ROCE_CAP; diff --git a/include/linux/bnxt/ulp.h b/include/linux/bnxt/ulp.h index 72d6941fd57b..c668f3e67fef 100644 --- a/include/linux/bnxt/ulp.h +++ b/include/linux/bnxt/ulp.h @@ -24,6 +24,7 @@ struct bnxt; =20 enum bnxt_auxdev_type { BNXT_AUXDEV_RDMA =3D 0, + BNXT_AUXDEV_FWCTL, __BNXT_AUXDEV_MAX }; =20 --=20 2.39.1