From nobody Sat Feb 7 05:01:20 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4957CB67E for ; Sun, 18 Jan 2026 07:03:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768719794; cv=none; b=M+IV5UHVjC8e/B8Qnn3VYtTuyJeBRwdG0zNBPcYiJ/hwFt9We4lZiBGnlSZ7Kz2K10/tNyu/aAPcSmXynBHnSOWvfUxAk/Ovq2kMKbxkgcDnfHJBKTEtCXjMEU6ztIfCU8vqilmlltMv3q3qgWKITMFN2hknHqxMiuP2J0UAsOY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768719794; c=relaxed/simple; bh=CJ20BdSc3shk+8PeBJbNxX2xUlMTHoO04lnwXOyirwg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=rApmserRmHfNOkZgLOMHPpua9bDXG9HkMf93o0R5iiM7XgDEr15bjblFgkjyJALIyqo7CXWizcCyVemWmVL/t6tkgZcrkOPvYyBFM1t/dOct9l/Kow8KKwQmrJGmqRyh9WirI59r3udJsI/oMTztawKJECLmqva29U8/nXSohMM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U0r8H+b3; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U0r8H+b3" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-47ee57c478eso1554325e9.1 for ; Sat, 17 Jan 2026 23:03:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768719792; x=1769324592; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3hBz9XaEMOL/y+MvlCbl4u+hBnfx10ydis7U4oQtDmY=; b=U0r8H+b3YtUDda+mZyAyY7p1GEPOfcrd15fZ83fXvTcymRX8I4x6+8193HVGXwrKiX pgXSRMW3TnD7snrTLTKXwiT/cWvrCA5cvN6yxFRoP2wa5zWEtgcX3DnL+9T7PX8RMW1F +iX/wKjPdlS+6+B4OYqpuSURR6q+KqSU/svC42UEQxwOFfvD2baIfe0yJhFi4yz1ZV6e XpfIDWTJO27ZytyqzK1XpC9fpIXfqW6rPMimA7OCfSMHFK6E6Ak6EWfVU4DxyMvL+a2y rQ2MlfZ3AMwrB4WNZmYxTJn4mviJ/ZvfaapQLPJmNBltqjjZ+ZsPmTcK+zBaaV9nkFrq rSxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768719792; x=1769324592; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3hBz9XaEMOL/y+MvlCbl4u+hBnfx10ydis7U4oQtDmY=; b=IeF7MpQe/yQuMkkS9/GN/L05T5AKSYRy97PBC0ry7vapRVy12VmP3P5eOBwdhl1EoJ zwaWdSHpuKL++h2aP6JRabf/IxbxcoJ4bZpbXXG+5uioeXyufK1A5tIRB/QKFnOoPCKf GSnO02puK9j+FOWLtZV8nuBZjgIm5jIXpkCmIOBJ3d6/1+xjswVLTo1c55d91WfHNwIR Q0gEIb3C0ZrW4FU99pgha1oEPxdhjG1KHsfwwFg1VWqyob3M2aS/ji9yUo11hM57tN+H 8WWLUqIu/sp1AT7om+M+qC1+7gUys6pFCOjfbqdYdxj4fHULnHT9XhYzkS4p+QA2eX11 A/jw== X-Forwarded-Encrypted: i=1; AJvYcCX+kPnkSN161593cN/7NzDNM6t1l7u9C8Hk2V3frv2oFyw+CcRHUVVXrJX905OPkHHYhihdduTFHiiEh7U=@vger.kernel.org X-Gm-Message-State: AOJu0Ywip/xj+e+SlLGk3P9tRuxVpNZa4woQU0Pt3Sma0w+sbTzRO9gk OMLiUA4+sTpbUn8Z9LigtzocUSXW9XF3ShTGNlsHuZyKm5aX4Zszv+J7ibqaLw== X-Gm-Gg: AY/fxX5ZP/Tr1iqo3Rhigm/BwHzREJwhOZ6FIuRHtzTg/Si190jGfx8I8qXb5QyJ8/7 o6UBA1ugwXzhIL4KKcDHwUkR43OiZAKFswPvwhpcw9p0t4Hr28Mf7rBCoD0qoIGuZb0MEDSoERQ 6Ss4+T/EM82hT64zw33ihdPeGdHXeVvL1iyMASihGm27vcrUdKn5x86ezXeqQbNQXb1p0cNGHGF JrqCEtnHarHZO0oy0PucxmEjAT8uobL0W/D0saH+zjwOWWdOsE7WggjvpbZKeBHIXGpJkto/hIV lr01z+7EnYL8+pz/2KNRclffwo7Y9V+TNcI2mFjT+u8MRWXZbW0dvz/ZdpqOFZwuiYOo3oXnmgi Tzu54MJuM05QleyyGCgnaAV3qDcU3jKCdtzyDMdMbk3EC3ej/VUQLG8KTxW/8M7m4oMr8W6uPlp 7A85g11rESWySsUHX2HEfrVFIRCaSMcPOZER8vRAAbhfktm2RdBhDayaSPEx4= X-Received: by 2002:a05:600c:3594:b0:47e:e20e:bbbc with SMTP id 5b1f17b1804b1-4801e2f2845mr68388275e9.1.1768719791404; Sat, 17 Jan 2026 23:03:11 -0800 (PST) Received: from 3ce1e5d2d1b2.cse.ust.hk (191host009.mobilenet.cse.ust.hk. [143.89.191.9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4802dc90068sm44687605e9.7.2026.01.17.23.03.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Jan 2026 23:03:10 -0800 (PST) From: Chengfeng Ye To: sathya.prakash@broadcom.com, sreekanth.reddy@broadcom.com, suganath-prabu.subramani@broadcom.com Cc: James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Chengfeng Ye Subject: [PATCH v2] scsi: mpt3sas: Fix use-after-free race in event log access Date: Sun, 18 Jan 2026 07:02:56 +0000 Message-Id: <20260118070256.321184-1-dg573847474@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A use-after-free race exists between ioctl operations accessing the event log and device removal freeing it. The race occurs because ioc->remove_host flag is set without synchronization, creating a window where an ioctl can pass the removal check but still access freed memory. Race scenario: CPU0 (ioctl) CPU1 (device removal) ---------------- --------------------- _ctl_ioctl_main() mutex_lock(&pci_access_mutex) if (!ioc->remove_host) [check passes] scsih_remove() ioc->remove_host =3D 1 mpt3sas_ctl_release() kfree(ioc->event_log) _ctl_eventreport() copy_to_user(..., ioc->event_log, ...) <- use-after-free mutex_unlock(&pci_access_mutex) Fix by setting ioc->remove_host while holding pci_access_mutex. This ensures the ioctl path either completes before removal starts, or sees the flag and returns -EAGAIN. Fixes: 6a965ee1892a ("scsi: mpt3sas: Suppress a warning in debug kernel") Signed-off-by: Chengfeng Ye --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mp= t3sas_scsih.c index 7092d0debef3..973893528747 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -11264,7 +11264,10 @@ static void scsih_remove(struct pci_dev *pdev) if (_scsih_get_shost_and_ioc(pdev, &shost, &ioc)) return; =20 - ioc->remove_host =3D 1; + /* Set remove_host flag under pci_access_mutex to synchronize with ioctl = path */ + scoped_guard(mutex, &ioc->pci_access_mutex) { + ioc->remove_host =3D 1; + } =20 if (!pci_device_is_present(pdev)) { mpt3sas_base_pause_mq_polling(ioc); --=20 2.25.1