From nobody Sat Feb 7 05:01:26 2026 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2654F500962 for ; Sun, 18 Jan 2026 05:31:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768714279; cv=none; b=ovv2zGbJhf4L3R27x3IGJg1gx9dEMQyjyEceeE8RxoM7aC6zi3qAJ0THzhrkkuNPOcfDpgA5YIEdfk/4WipDemv1HF7mTjNn0WBJxMKkng/dLdT7jB5lM0WcR798M1jl3X6cjHSA6mnglAn+eOxrTqqQMbpeYOzsb1HIZNVZQnQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768714279; c=relaxed/simple; bh=fkhXpp5OCKlj1yuiIdnEYADmB1Ali1BEyuc42nHc1s4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=rCR9B9rXUIdc52QzyvVYvH8xkCuB1w9Fwlkvxeqfyw/LO/eZYL5GrQYkcLbaZxdPzQZPoXYsOFOu18gp9aQOHlAB+SvKX66uvBmoYce0r9vl0rUWAwOp83h/8rpJe2LHLr6GnIknB+njyPW+5WQKJHJO7PepEFbXr0JekuAoBpM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HJhKUetv; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HJhKUetv" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-431037f7c0bso326524f8f.3 for ; Sat, 17 Jan 2026 21:31:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768714276; x=1769319076; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BOpOj9KW01OdX7LlAL2wctL3KjfB8CTK3nQNmhrSkw0=; b=HJhKUetvIwxOhrqDx9jhyUqxtSLkQyjSfHd/0b/8B+YkCeUymBLgD6UIeml2iZ5MIK 04dCjtZCGv2hkVEK7d4YFnBCd1LcWyaBTpijEqc98/cuvzNUVb2OZYNiscqqZ+Ft9ng+ tvthF6VvdOPa0XWRQ+2F20yHigqsqNO54VTn18J4v7ubweAJOHAWxmckMXoeec7V++Ha +dJxoKXrY+H2WThuVCS7qBSwbPmzQ3ClK2q1Jkher4K6sMdZlWQZdIrU+ClzhX8ESZlu NB2k9XeHYmcldfPZmGIL1W7ojeJJbHEhDTTEWZcN6u2ko1Yb4RTXJAgj7ur69lHI3Kww 6+Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768714276; x=1769319076; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BOpOj9KW01OdX7LlAL2wctL3KjfB8CTK3nQNmhrSkw0=; b=gxXJj9L2FJxhKxmxsSCRS5VN2PMVvIz7wmMYT90ExMZTcUs9U3GyQps9kO4J4MPOjr tub+E8qk53l8UB3JQQfAKL4ci1QBNQGZp4+Ic+xd/hTVSW0O27qNeJTnDZ/YgNNY5WIf TD2PaCILPIQ89j877ug67YwZQp3xtdw88lB83oDnoU/aOaZONwMogNTOmg4o08P3EPbZ JbKLGZA5LuXu+zSABZRihdfBzIKHAjgGTkYcU59jirkDkDkoobx+Ie7jUwCTEtHF4lOH BsOQ826AhDCYHRr5D20RdSBhiXmFYBIsddWj0zbd5DHy/bW0TxRExa9uYNq9E91LYFDV mHEQ== X-Forwarded-Encrypted: i=1; AJvYcCXYHmT2O0ksqEPALJ82cCq6Uz0Lay1H6Bvfj36ystjOrC6AyV5uYkhW39WYHM1tGDjOB2I2ut+g4mriuvw=@vger.kernel.org X-Gm-Message-State: AOJu0YyZv4O8dMUTsI66Vb72bsDTmiUN3CpFIi5NokKDx9juymZdRqas GEOPoWnHuZl9SkzjZaSZt3y1CPBcP5oayFvMDjgSDA2pstd9opd5byQ0 X-Gm-Gg: AY/fxX4j3xiLZVY3QnaLHna3+hFDg8EPcCAyQxVfLfpMv4mioJ5FC2tbXUnIUg62SZU LtFjSnOcIwLlSTCj5ckjhNp8OXAug4Iy21GABao5YW4zmuGCWGtRcEkJQ4DcsDFIH38WVzpKUoH V2sF39FlQeKtYdBcmPDXpXmZzbC3kf/h32DpzM7+1cnXIEGr+v+fOI6fHutnTYA19ih3PLwmSk8 Yu9J1HTNk6N4G4WQ9/+BT/rkM/DAA9vKuPeTBfQVMpxPqpy4f22rPUGMSuf7dTtz+mraZfRAGPy AxhtqmzSi32c9X+17JaLfC0/38MG18k+vY4gd5mkzAoqoh3Xi77Ey0quodBW7DlOjifI5wvVgkd DcnJhUSgIQpHKHb8zf7rkpzMsVtNPucudsM8hDX7838V3TkBqyrQjjpsdrLVLcgd4DYaPFUjvsc 2VeesSTTLBbCZadu90IpvRHxl+jyge8nWabC7C98lMv3yWNLljrc1Uglt4r8M= X-Received: by 2002:a5d:5f83:0:b0:431:32f:3153 with SMTP id ffacd0b85a97d-43569bdb2d5mr5478370f8f.7.1768714276213; Sat, 17 Jan 2026 21:31:16 -0800 (PST) Received: from 3ce1e5d2d1b2.cse.ust.hk (191host009.mobilenet.cse.ust.hk. [143.89.191.9]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356999824csm14904136f8f.39.2026.01.17.21.31.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Jan 2026 21:31:15 -0800 (PST) From: Chengfeng Ye To: sathya.prakash@broadcom.com, sreekanth.reddy@broadcom.com, suganath-prabu.subramani@broadcom.com Cc: James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Chengfeng Ye Subject: [PATCH] scsi: mpt3sas: Fix use-after-free race in event log access Date: Sun, 18 Jan 2026 05:30:50 +0000 Message-Id: <20260118053050.313222-1-dg573847474@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A use-after-free race exists between ioctl operations accessing the event log and device removal freeing it. The race occurs because ioc->remove_host flag is set without synchronization, creating a window where an ioctl can pass the removal check but still access freed memory. Race scenario: CPU0 (ioctl) CPU1 (device removal) ---------------- --------------------- _ctl_ioctl_main() mutex_lock(&pci_access_mutex) if (!ioc->remove_host) [check passes] scsih_remove() ioc->remove_host =3D 1 mpt3sas_ctl_release() kfree(ioc->event_log) _ctl_eventreport() copy_to_user(..., ioc->event_log, ...) <- use-after-free mutex_unlock(&pci_access_mutex) Fix by setting ioc->remove_host while holding pci_access_mutex. This ensures the ioctl path either completes before removal starts, or sees the flag and returns -EAGAIN. Signed-off-by: Chengfeng Ye --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mp= t3sas_scsih.c index 7092d0debef3..3086e27a6293 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -11264,7 +11264,10 @@ static void scsih_remove(struct pci_dev *pdev) if (_scsih_get_shost_and_ioc(pdev, &shost, &ioc)) return; =20 + /* Set remove_host flag under pci_access_mutex to synchronize with ioctl = path */ + mutex_lock(&ioc->pci_access_mutex); ioc->remove_host =3D 1; + mutex_unlock(&ioc->pci_access_mutex); =20 if (!pci_device_is_present(pdev)) { mpt3sas_base_pause_mq_polling(ioc); --=20 2.25.1