From nobody Tue Feb 10 03:44:58 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E599E30275E for ; Sun, 18 Jan 2026 18:10:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759819; cv=none; b=WoitrfMnW4Ngsesy7kzT2DA0P5Qg/i/JykzGiEk2VCLLpz220SbOc1f1Ilhj1GSkVhe/1ZJmk2tpAlVEYQRJDixeoxkvxfC8O6gdwm2tVqCR5BePU8wmxIhDw0wEVukAYhP9X2mofdv7nE9Vb0I2+56muOBbHq94TbzQ9nJCdDI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759819; c=relaxed/simple; bh=7TcfQldnwsgDeNj9THUL7ZJpvo8wBH6EB0ftex+EuCs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JuzqFc1X0WTX1208MtxMfURwpacUHbNepzeLuj1duoArw46UlRm6dDCmzcRDebW1ERrtxdJLURwF6/o7VnGRgRs7S46XWYfBDFadanNb2alB0KgWg1TkbkIpz0nod3/c3pPWX1YPlbYrIiNtti8uagkXgtFNwL4yfjGQh2UCUpc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=japKNcnf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cfPXpjpG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="japKNcnf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cfPXpjpG" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60IBH9cP2445449 for ; Sun, 18 Jan 2026 18:10:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= N8rDVtwaqFFOKGAdA8c98jUQvXsuqYrjM/OKm05D9ak=; b=japKNcnfAcEprVtV 0bUawGTTXZfbthfW6B3TsG8SOrANCsLkg7+/n7DXtuSnDQSKAnz3usFRiyGjxOj2 +tPoYHPy0SDVDav2D8OMjbHMnyAIRUOJCc6YT7Ti8/Jsu0oJRI9rek6MgZf2St3c heEzwj4GUyubAeqSY6lo5q+3kGDRU7stWSWOAZ2olHVwkhtTkyTRJpQ1rr+wzOHB +wVhVSdyTbXGW4rCcE6MUCDGhhR16OCgC2i5uhHVrodFaAum1yFa5gvt3ks8eXrZ m2q+iBAO2sdTs4NNckCqDI+IQx8+BEUWCDxfo5lF8Ut1fbWYDdG0O/PFOwgxIs4y 0wCOwg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br2ke2rb7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 18 Jan 2026 18:10:16 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c6a5bc8c43so755695085a.2 for ; Sun, 18 Jan 2026 10:10:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768759816; x=1769364616; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=N8rDVtwaqFFOKGAdA8c98jUQvXsuqYrjM/OKm05D9ak=; b=cfPXpjpGOhSdEeMu4Wu/2L3sNveiCmvBuEO7ved61PodNu2FcL6QHq8sgC59SlEjFA vfClxH3Fo/dmvwDH7+WBpk05iVMxj80Qg8TXQPohjgRhSgTO2/4X1OpuU07Tv2DOlmpv xlruC0PsDc6bz31pM8KoO0lTTEfJW8DKlkPUTPp4HNT63UUoPl0WUizPRJDzvNF43nuL jiEBUNLRGFCZIROnsyXFVz08YhZblk3Ny3oGnKa/PZTs21oGNBcGDxnRLq2EI78egbXV K3o7N1tsIkh5CHx3HSpiJzCx1IekLQZtdqoi7Alnn0FPtWlqs9PZLAQtWwx77pV4bv3d 6KVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768759816; x=1769364616; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=N8rDVtwaqFFOKGAdA8c98jUQvXsuqYrjM/OKm05D9ak=; b=tTT8eV0pE/+hIeN8QiAJ5lDGU+nV3P7sec2F+CGpCNvuXU8rzHRDkNf4vh570+xXHT riSZ8naSXmByRd/HEFSB3ip1UtDXLJGweTGgy4ewiD7f515rzBXXx3x2fH8+G0T98MZJ tBodvYh3GeQPASLadVyuuyOEwEYSK/5XQEM1S4jiMMvpKRVA9cBkGNcnlZSw5HKazGM2 VjjCKffFPDAC3b6MCSOiGTxZh2Mp+eA0r0p2zZ6GzsUojzmAVI5RCElXZ19YljRmtZvB u1Po20DA8ZCNU0UUBUUVH1DH/0otbxfDtXVVUyG4/5QFRSRZWEhiR9iWnUKoYEA9iZxy T4ug== X-Forwarded-Encrypted: i=1; AJvYcCVOkTRSFp/s9jGg8jIvkgfzcXH1LdQePsseZDrA+4OvtirQQb9Qnxkz2+MEigXx9Ralgjrcqvv4bBkzOTI=@vger.kernel.org X-Gm-Message-State: AOJu0YxBKj62R/AmiQ0x2aFxq9M6LcJlfttckr/1nOVleAtR8BzU2k/0 VahQ6ATM+S8VujosK7el+V7ngbtqxNVfaAcIlQQ0A28W0wWe9ZKvU2QBYxR+KtVFcFtPF47dEIz Lali91Z1bodxI5xSxFQvqt09FsxZgFdLkqSA287z74gphMqRVJUB8y/Xt9fIZGjsChhg= X-Gm-Gg: AY/fxX7tPuJ79pPstafZpjW0Po0ntizR3TIHf4HWWPE4/AvRTEib3lH8WSeNPVdZj22 V/qui0AcsHkM+/+AtxxZRmr49U4+eKhxLqLmYIdbYAUmrebSmvwJPorfryokBfJgL4nx+YYm/IC yZfjMULCv9+chXdktMwkrQo6/YLNF2ZMgxqKK0JEFhaqfCDITvfiagzs9eX5QI6yw/Z0rEfOo/I hPp8f7F1ZtLUS8mogfgk6eG940oUUSORXQRM1IybQE3M8N6RSZxvO3GTxjfVbQlWeReuzmTq+1Y 65Nsg32xbG742vuIUzYxPvMENvmDKiJ4PhLu49HkYvs8XyERKfIkOmG44R86Z8Yx4HqmA7Tt/lB 4Aq1RVGJtBk4lFomIs5ciD74HbnyBeG0b5w== X-Received: by 2002:a05:620a:3942:b0:8b2:dafb:9089 with SMTP id af79cd13be357-8c6a67899b0mr1275483785a.67.1768759816083; Sun, 18 Jan 2026 10:10:16 -0800 (PST) X-Received: by 2002:a05:620a:3942:b0:8b2:dafb:9089 with SMTP id af79cd13be357-8c6a67899b0mr1275472285a.67.1768759814840; Sun, 18 Jan 2026 10:10:14 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801fe44b37sm62162085e9.12.2026.01.18.10.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 10:10:14 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 18 Jan 2026 19:09:29 +0100 Subject: [PATCH v2 06/11] pinctrl: microchip-sgpio: Simplify locking with guard() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260118-pinctrl-cleanup-guard-v2-6-bd36f681bdc0@oss.qualcomm.com> References: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> In-Reply-To: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1197; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=7TcfQldnwsgDeNj9THUL7ZJpvo8wBH6EB0ftex+EuCs=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpbSHzNyyJB2/5YcDkWVD78wo4fivaLa92BnhNE zEyQbnq1T+JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaW0h8wAKCRDBN2bmhouD 1/+ZD/9dLR0GeZEUoMpu1fyeS7gbRrh/E1fAhv5P7K1Wy6+T4QuZh0GJyRvYYNMop2bEXE+o/zg m0aJF5TNvzHCDEzDGh3hTWMW6zhEfdRW1x+41NwBiV+jUGVIHWeFXu64AMbTDIAep3SiKsUu5ur USeXISCYy7enjRAKdOU7c0fmdDnDnSSlMVF202nX4sHTfroJF4BlimVIpWz9/ILOSA18ewjMxl0 PaymU0l2amlmpZmIpE3edSB7zCVqvIGVyl1rD1g1v3Slmt66Wa0oJub3si4o9gWtDj/1mE2HGW+ YwsGcKQ0cx3eU9jda6IccRxjIrd1gwgf91zoZT6MdePaW7LZKOUWQ3TuPyA9SppV+7mNXJ6g7fg 5iv4i/aSKv878Z/9BjfRec+iDlhMHFlE1U/0TNLeQEiSePRFjzQkBZW/VD8h12mdLZyJ25RIeIq zcvbjxNdMPYNXX6zyo9KpdnIGRzqPn2eow9j7Ty/MvWaRS2UaQldkFjErgbKNlYyLyF4xueV36m JPYBzgnsAenS6V9TUf7bUvkG/jLLhifIhTXucaqJudGLGgqioXPok09zN5scbaryZOnU3poSZa3 r/njGSPDgsJ/i0ZuO82abROFWzVcuRbleDiqZ1V1y6SeGIH2EV1SlND3ueBORj8RHgxVja6hguI G262GYY0ih+1KCQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE4MDE1OSBTYWx0ZWRfX5SDFcMm27LiT m8kPNjqG59qYxcnrhlPHcQjMiidcgrJA4UzNhLSagdb1gpzYJNWGD5pRr4wi8TksRdysrwugc18 2XIvVs/N+qzqyZsglVxLtn6ujaDpj4QPSWtk3DolxMbyw4w7sS6eVhxlt3is7KqV+AX06YKj02S 2zri1Vdygkg7DKbIYiWetTsx5Kn+69ayFHvDMuV1WoL4cugol64i8/caatPk5f91sY/rQL/v+hu Qegkp90zwCiW9RStLNHIpsF5KFQ2nBCXOnzN0dqBhjWSU02ojABMtndgp10fBQpI/0MURDF5rZu j1Z5KG9QuGJYLyTPj9ZSC8k6dBOcwl7Akj5Invno2Ynt4tabkDNx3CXCTf1MkPHpGU0ig3l1onk QcAGDRFqRQ11hLJUA+PcffNJHwaP/YX3FpNyVwOe0Vky+ltQ4jPdLx2U3U6cN3OghQuIbv/GeqO iefQIR7ylhl89J4aJsw== X-Proofpoint-GUID: 40icBxLmZDcqXJqOsxRCnAnE-I3sbne_ X-Authority-Analysis: v=2.4 cv=EJgLElZC c=1 sm=1 tr=0 ts=696d2208 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=6VTnscBjb5kX48BWP-sA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: 40icBxLmZDcqXJqOsxRCnAnE-I3sbne_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-17_03,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 priorityscore=1501 malwarescore=0 spamscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601180159 Simplify error handling (less gotos) over locks with guard(). Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/pinctrl-microchip-sgpio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pi= nctrl-microchip-sgpio.c index b6363f3cdce9..7a6cb5f502b0 100644 --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c @@ -264,19 +264,17 @@ static int sgpio_single_shot(struct sgpio_priv *priv) * setting. * After the manual burst, reenable the auto repeat mode again. */ - mutex_lock(&priv->poll_lock); + guard(mutex)(&priv->poll_lock); ret =3D regmap_update_bits(priv->regs, addr, single_shot | auto_repeat, single_shot); if (ret) - goto out; + return ret; =20 ret =3D regmap_read_poll_timeout(priv->regs, addr, ctrl, !(ctrl & single_shot), 100, 60000); =20 /* reenable auto repeat mode even if there was an error */ ret2 =3D regmap_update_bits(priv->regs, addr, auto_repeat, auto_repeat); -out: - mutex_unlock(&priv->poll_lock); =20 return ret ?: ret2; } --=20 2.51.0