From nobody Mon Feb 9 23:42:30 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 726D8301472 for ; Sun, 18 Jan 2026 18:10:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759835; cv=none; b=uzr9/ed2I/7PnWiFfCi+2jZNQ/5xXlbQnVcohcV2DgT+BrL49p/UVGh6MP55P5I/PMpySbXST4T9PJi3cKF+sbMGcD2JaX3OhTHWjW4eHR1CzHhRUufq6aJTM/uuTxisrIUnKcyP2YPkqQGgcN370IajxZn3AaC9lkXAwnhN4tg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759835; c=relaxed/simple; bh=k1GvsBNYWO8pFPyazMMNabsh3Vpjdc1LSTY4GGhIuOk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q7BxQQrELL7ZpMo7UT17dOs9CKkjwBheXPl/JzAFa//kQJisOnWFitOT3nS0Law8QRmy8QA528wrAqpHSK9H8slBucD2cSb+iOWNlCWJxWa0k71OnXmki+UqNIAv4Lh6LiOBpTmIj6LLzmBhxTUXGdgLh/SwbobGfP8cj6n3MGA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CAJnBbDn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XPnOztoB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CAJnBbDn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XPnOztoB" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60IHuZ743785578 for ; Sun, 18 Jan 2026 18:10:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= N48lIvtnLb2IcsLS8pOSE3K1e123fF19xLaS4IvtzNQ=; b=CAJnBbDnA61W8ImL SnAgPRZ26uidWw6/crkIz13LXLfpToynIHrH8fGSxXxetED4wm5RJiZrZDg3rIfp I+yQhrd1CBcJ2Ad1lFGyf0FsGqwUca3zvkkfCL3ZCW32iOW4+BU+zFImpamvkP5L 3osMGujdYac1/k+nkBafEmhc9umBL/i3W2CHMm3rb7+w1xHJXWCVXvQUKh2K6id9 bp6GniMk26pToQycFEVVN2Av0pqMYej4EFc/gwjGx53qUMEe/dVECDdxjQSVVBKJ QGMQkydLLEne96NU+CuKEKwSYdrZH2VFYby+MaKWI8kzKlyfM27gyaBY1pIwxY0N TkbXFg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br2guju2t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 18 Jan 2026 18:10:29 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c52c921886so479326685a.2 for ; Sun, 18 Jan 2026 10:10:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768759828; x=1769364628; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=N48lIvtnLb2IcsLS8pOSE3K1e123fF19xLaS4IvtzNQ=; b=XPnOztoBqEthESAP1tnOH7Vi2lPZxfS83fCS14tTgZslzmzbvl9fEHOYjOZ+c7pkLS pL5LWEiNwPs+dms0fff8PPImuubS/FNe3hZ2awXh8wK10047p7128+k0lIVwWzh5xZVw vHfMdcSLCb4PVMvudxUOU1mraQmgpd3wHGARbOG9+C8E/F018AFoY2MJbUpgrjSZ8dmT RQZXadhgWlpuLjwYj6glAn9vrxM3V7ah/7TJh0qjukDZLv/qIaNYSbwepggHfRzN9w1x 64+99b+kMMsWuBkNNemFC+OlwYVOkU/JQz/HoTzPbVrRSEjD9yKCgnIXy2NKPnr/NbtM 35uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768759828; x=1769364628; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=N48lIvtnLb2IcsLS8pOSE3K1e123fF19xLaS4IvtzNQ=; b=V6nsu7O2wRjKTa1EYykR4VWNvlPa234MTEJ0gWCDkWU+aKR2+BiR/SE6dZb7TbZQhT W2al1e+supk9o8bNi4gXANpa4BBCIJlMY0C0pT9yYYdISac/BxT/y6DgBqEIzMep4TPq csn5aJNnJKTutbGCA6XGTaV92kyN3T9ZgxgixAWq/ywUEUchxB6loxyNFSlSHL05Sg7O BQ3tyeKaSyi0lJynE4tXjtlBDXubcUmzGfHTZra7CoE2mTSFUpa5vgIdzVluPzDEktsG drDAOdmkCLr0SuOXfCKTHH3cUkchOo3u1cbC4LWQ9frQorIM2mVGrDWaABhPf4k6B0hu 0rBw== X-Forwarded-Encrypted: i=1; AJvYcCVRJSpBmT2ZOD/swnDmD5jAIzIChO5M15EHvD4O0365tBlyIyHuOiIThbv2lgdp2enMb4+Y1aE1SdIBUz4=@vger.kernel.org X-Gm-Message-State: AOJu0YzMQhxM7gGFO4hsWahDh/iDqBQWvTzR2Owxk+yzdG9/WH1nXeEc eGsvSeA7p5CZ22SsRf8oFa62FR9pAQobml+EhXgLHHc71ZPVBfcLd68EDcumJ58QBfiCzFvZrKL 3zdlNlMgiNL5vwHLvN19ncFm07JW0mCGDLCYkXTx5M+nIErphEgk06UygrkncJjTphCo= X-Gm-Gg: AY/fxX6Hq+rt1f1iMudJK3U5AD/6zwF2tI7EnNNlWnrnzYMnsZUuqrAUubqUgjwqOJf l2OeXeDpyWdUwaJBO14n50k7+2UHDI3UQJJbAUiiWPGGc3FsVasTCliP4zMgLFH6XHdb7h8FdhB aOKv0NytwOO+Vl8/bW9iJvw990dfRT28VlP1hHGsEHhsVIw3x6IDFYBth3/T0ZUiFDjkLT4BCG/ Nsn+k5gqlW04oMrwqSIrSl1p+8b4eKIeLDcOQv9n+uSd5nyaAyxK+yvo/lP5eYq8xvqftC5RXlu V6erg4iOzMead49/u8mp2vP/g4ZASUsEFayeZJvhDJH7zzVTfryC51bSa20Fw0s/JhI+U2mFNpB MUSpP8/It/odhy7k3xpR1k3tvOIXYqhoW2g== X-Received: by 2002:a05:620a:2808:b0:8c1:ab1c:f2da with SMTP id af79cd13be357-8c6a67b79c5mr1285495285a.70.1768759828488; Sun, 18 Jan 2026 10:10:28 -0800 (PST) X-Received: by 2002:a05:620a:2808:b0:8c1:ab1c:f2da with SMTP id af79cd13be357-8c6a67b79c5mr1285491785a.70.1768759828043; Sun, 18 Jan 2026 10:10:28 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801fe44b37sm62162085e9.12.2026.01.18.10.10.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 10:10:27 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 18 Jan 2026 19:09:34 +0100 Subject: [PATCH v2 11/11] pinctrl: st: Annotate st_pinconf_dbg_show() as holding mutex Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260118-pinctrl-cleanup-guard-v2-11-bd36f681bdc0@oss.qualcomm.com> References: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> In-Reply-To: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1221; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=k1GvsBNYWO8pFPyazMMNabsh3Vpjdc1LSTY4GGhIuOk=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpbSH3xTqF1UPuWpw21q5i4y/0ItOY7uFl5LJRk I/zBJTe0SiJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaW0h9wAKCRDBN2bmhouD 14rID/9CmPz1fyhRfWxv8BXOtmT8JzPxM3Qn1vrvoEw3Redb2US4V07grJBDpsNMH2yrzXble41 qSybWyUX5o3mUWc71wO3IsMFu4uIK1mOxv3WeIRfETEaVH6Sn7DYx472fLtIqS9oZ+qA+sCBJja VZqb59C2Wu6FxIQy5jRXgkXFhzpMZX0nRzYzDwyQb/gPSnWoiBOSRkxbAxvnAWqmPNWAHehSuS+ S3lTrzXTkY98p1nxFqfdeU8afywPvhvwDpfmevQNjxy7iF3EVPf2z4pyHTOQREBUBBmC1perTa0 ANxtLXo2E8BaPttpb8EoZLHxfX7PIAA3ibfLPS0dPI9Yhlhkq9HgRSbSvTKCGxLSk4sxrjTofoP 8reJpHpMVSLdOfwPApz5sWcX+oq/L74sPON1vtXunQcS1QSf50DL+Abn0WjuoQWPqg6LsySITQc oE9X/C6PfDtxOP7YFCEU74SomVt5ZtAwYGK9tgAjJIhKXro4U0APc9TE5T0ekdeapQyKRAkQIlh 2oeg70iEhT2N/f16R6mk9EaIeneSiNYN/wqgMiPo418GRPwnMZVANUWr/har+gk+z3ScAHAYU4w LCmu/3TUFx8+BZXGjyqMjtcINUApT5RxEOVxvgAkv9Z4jn0eIIZd+UQuZn5nKG9jKV3FlgN0K7J BiN1rYOCb1j6Hng== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE4MDE1OSBTYWx0ZWRfXyfsXLGk71isF mGNQjjcpPTStKgIJs5HxjYHJIgDYgObVvBycyCeoVSwcNswaDUvoJzl0JsFmwqMurC8EtvIRAnd 3NS/1QBTjUPYXuGFyG72TBAhDlD9AvU5+IPEVExdVrpKskbPZppBPSb6B0CEVnvAZuMxdHcl+ar /XNc7i8Lwi4g4qwopWNjP3emwLuzqpucvj2mqqtS/TQDFEWTTGzwvRb8bkN4LguhmxBIeevmv49 dsTXak/6JO+rsMZ+Cm9ofTdQtTm9OvuBWwQ6fjsfucEeCGMwNiRFdS4NnerpVStErFfS58virOd QlekdSp4xW0ty1JSvQn5Bl/Ad5PevYH3cLqYuFt8U4NeAFhmWB1r+eB58sk3FI+2zBSXh+Sjeib w7p+zknZ/z3Iabrkw+qLjItSaPHB9FRKHEIXQ3FqTQpLZXSJX6zCcxnmgawKkmnrjDACE2+Sidd pRSOYeL82MPnvUDN2PA== X-Authority-Analysis: v=2.4 cv=Sev6t/Ru c=1 sm=1 tr=0 ts=696d2215 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=EUspDBNiAAAA:8 a=RIxbnQC35JVfspY8PfAA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-GUID: 0MNSYceYmMvdfefDc7Uh80GTKSfg8ApA X-Proofpoint-ORIG-GUID: 0MNSYceYmMvdfefDc7Uh80GTKSfg8ApA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-17_03,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601180159 st_pinconf_dbg_show() unlocks and locks the pinctrl_dev mutex, so it must be called by the pinctrl core with the mutex hold. Annotate the function with sparse __must_hold, so any changes in pinctrl locking will be statically detected. Reviewed-by: Patrice Chotard Signed-off-by: Krzysztof Kozlowski --- I think this is still useful, although maybe a bit pointless if core explicitly always locks every pin_config_dbg_show() call? Anyway, pattern of unlock+lock feels to me like something worth annotating. I left the patch at the end of the set so it can be nicely discarded. --- drivers/pinctrl/pinctrl-st.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index d3cea3437d7f..8ce88e591f47 100644 --- a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c @@ -987,6 +987,7 @@ static int st_pinconf_get(struct pinctrl_dev *pctldev, =20 static void st_pinconf_dbg_show(struct pinctrl_dev *pctldev, struct seq_file *s, unsigned pin_id) + __must_hold(&pctldev->mutex) { struct st_pio_control *pc; unsigned long config; --=20 2.51.0