From nobody Sun Feb 8 15:30:32 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CDEC2FE581 for ; Sun, 18 Jan 2026 18:10:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759808; cv=none; b=ClW1j41Fl4PsBU40KITGKcHbnyyZEWs6W7B27znLSHcHVEAkQJu0I1eIN2Qze4UtDvuttdDtAfewTRpMegEGKK4uU1l8cyOtiqALvUheoRYjTwYDJ6TOvzpvIDJXwoSWuBXkvWT+nwZfOLIvrx8trhLh91HSFyO6qHGNXOelxfA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759808; c=relaxed/simple; bh=baKkcqSJ65hc0ts9jVcHMZU7FH4i9Uox6/iD2KuATX8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ru+RcxrVJhnGg9UpAN0DiJbAD4ppphxhe9Br5MRn6YnT4vtGr75Tt0Z0eEONOOBvC7+hotr81przNZUmd1r4XHDXXJ5l24BH+oTx7mprYhtZhNO1tST9Fvk+O12FJod7DwOqydChevdG4XnLnf5SV25gXks8gumz9eXwSOaLx+w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K4oQQsBN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=b7KSc/Dj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K4oQQsBN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="b7KSc/Dj" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60I6t7gn2064618 for ; Sun, 18 Jan 2026 18:10:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cvBXEQRwk0vB9MxtistlWfSV6Vaus6aoeJvtQZzjTG8=; b=K4oQQsBNqYVZw4QH PjC93dzL+Hz3LWNfTQn9Viz2RAWjfWaMdQn+XQT1jUJQ1eVTll4XbPiZYIT+fVmi x3jDEAb3C1dOVGQjURrLEAeFU8nBZnO9SpeOqanXZAbvzSZge+gZufuN9ZeyAeUt VTjwhd8Lcu6dok0QAc6B8iEhMhncREgFSCjkTR1s5IkSFJpOF19qirc4gu2x20/U O2ZBSKiSBzFkmb0qaoaO299bc02LShw2HQovLbVbnGpCKtuxd2fbUYTRAF2El+rS Ox8De3k7GnXYCb/Sv2uTpimVD4QuaJ32BAyW4oXQvIexvZJU1c/dARph3HFIPOb0 risUjA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br2n2tufb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 18 Jan 2026 18:10:06 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c5311864d9so795876285a.2 for ; Sun, 18 Jan 2026 10:10:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768759805; x=1769364605; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cvBXEQRwk0vB9MxtistlWfSV6Vaus6aoeJvtQZzjTG8=; b=b7KSc/DjKkPaRcLEsFnGPIQwEB92twoGd6dgxOR12Rv2mR9u8X+NTY8V5pdzwyh7Z1 2yfqZdqUAa9Y5JpgWXLCCfr05dzXS0eEV6BB0e5D7O1U8x+YEFcV8cfznccU4VURuEtu ecWckcVSl5vpCwzwFslHb+bfzV9dRhL1+7oz+w6GH9hDkIf/XvlmXgMrQyN6T0ocy3TR 5t94A+78+DAnEj7jkEMWUtgsp60E3LvcbD+AthUc8ORc9yITqqLRuoXW+KASJ8gt4LfH XahuequuhOsUpLdPv8uNM628USWB0u0ECyatqVdC8T8GSuZogO90PUwMVL58Kz7cQ32g Qxzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768759805; x=1769364605; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=cvBXEQRwk0vB9MxtistlWfSV6Vaus6aoeJvtQZzjTG8=; b=pig2H25iWFpFwvaj1V7qhn/zElwhAUXWUgjppOq7UmgM+Qz1MZczk5ugQcnGTG0H2E aLvWbV/M3Izj5ZoKgjHuRDSB97ZdItXsq/FN+D2g0wv5jkrDw5TuzulJeFqV49OvV2P4 yuJy+zfnzU9pCgE+iEL2kF8XVSIVmsWAhTADW1ZgU1CL1BcsalnP+5bjTGFkhwTn8oHd jvttYY44wvPiHr4H37/iNtLrUXxoC8SgVI7SiNzCZgSf7U1ifwoF8yVzPOuinADgfcdi DcNi36HX9m3SfwoSDi5TCBMLN2EyPqUlWL61aza65rcikJ8rhPOiYg24gkWZAPzLJEvH ib6A== X-Forwarded-Encrypted: i=1; AJvYcCX4GZ/3m+DIxkxgXgq0xv4t4NXecPfy9hzIPUWNWD+iRN9zHHzFB5gHf3BbDraOORSkiv2TNBrWcqJ7gmM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0SdVFaG0uFlGCCjTsvoMd2EpMpBGpW/yoRXNW6n7gM8E9yizS 2L44yheb/I4N/nfKZaTJ1cVEJsJKBjsDRO9DBK9a9j66ExwVKpknPwj+Kq67Ol+a0JAzSbuZTrg btInqQovZq6aNVWFqizvJJ8FuWyTXWsrXrWvBAkJufCYwzk0Ks5pb4AR4dtRqEiPAcxA= X-Gm-Gg: AY/fxX58vePUSJmuVcvLJpS4xUUe6ArXOJz7e9Aooj5F8vn2RMIaYz/Y/cr02BEwPUF 9P97ITkLYO0kXvaT2hBsouMP5SAZnbfrXjDak5DA934WYbO2xH1yWq1y9W8lpB1xDxAP2ogIeXu 6fLeRTll0ZxTUY5M0amseKz3QcLLKCedP5Eg03sNPvxC/syHxAiSQ6jPnnbA3XXMeB8f0G/ZGOH tUFJDDMH7IGRoPPf/stM/3gREpA6ZVpyOQSFWXtJg2dlwsaWQ2HMza/3oJ48zG4BkJxJ8uHHATk FMhXyV+fFzeCpIPYUzn1+zDQ4EoRPRxPMpZQ44Tu+15gdMs7413H0X/9/dZOb7uhW9uC8Qfekh/ 7i+yT+Ooza6mqUJAY/jASx3A9q/cDO2M9FQ== X-Received: by 2002:a05:620a:2592:b0:8c3:7016:1d8c with SMTP id af79cd13be357-8c6a67bf39bmr1240338785a.88.1768759805364; Sun, 18 Jan 2026 10:10:05 -0800 (PST) X-Received: by 2002:a05:620a:2592:b0:8c3:7016:1d8c with SMTP id af79cd13be357-8c6a67bf39bmr1240334885a.88.1768759804930; Sun, 18 Jan 2026 10:10:04 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801fe44b37sm62162085e9.12.2026.01.18.10.10.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 10:10:04 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 18 Jan 2026 19:09:24 +0100 Subject: [PATCH v2 01/11] pinctrl: aspeed: Cleanup header includes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260118-pinctrl-cleanup-guard-v2-1-bd36f681bdc0@oss.qualcomm.com> References: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> In-Reply-To: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2575; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=baKkcqSJ65hc0ts9jVcHMZU7FH4i9Uox6/iD2KuATX8=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpbSHuEhmtjxve35yyh5CVKYE/OjzBr9jYAtTm2 cuacE/vqP6JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaW0h7gAKCRDBN2bmhouD 1+Z+D/9vnrXlH3u/GiXeOxQWIyZXbZQDkyEdActKpj2rvX7bL507HlztUm4KVnLg35wNcK5pjlI AB27rCgLeJSaUUY/Z1tYqFhPj5AMpwXMcHuMxxSsOZw4TZaGs8C74Tux+ZKoLxIjPHKBuGxhVTG xRvrIRns0lwCv3l1Vt61RY2eQWZ3cRzuTG70D1VNUCafSZyqBMfrseeOIJTQUka5DMx6p0OSCNh Pbide0KGADmwPF108KMVzyfXXSC7q3IhmoeLbX7y7tiru/iIGv623GQl0c3JCGE7E8wjQ+M8lDB CvSyDGn7tL9cDEbOm+G0FPZ9RXouXBE6EckA0eRvoQJGjFjdDAIc1Qai40rB+bydAmeDpHes8FD b9gsxIQnnhRFlHMwVSUB4QQ6Ue+xko4RD9aEy62jqjnnGbobSLUbADUwz+9ljllkjUsJo3MAwG6 fwyIWtfhX9Hm0aMzMd3+d52ZQvzknxii2yMiTgrMsN/mDi0PAy647DljHlE2xCa85qCqU47Tff4 V7uA0WcXPa4O0fVCDzDd4Eq5NRHKTtMDSMyx95WwGIp3uxnub4mphQkFe+0KnI/aXUX4PRJXLz3 RiAGGtePI2G/UzMvmMhFoRFIFDBUBZVOoiZB1ZQ+re/oz01WEe6LXPUmCBORP+EAN2EtF3Ah6kL TBkAdeCK1+yugAg== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=TvvrRTXh c=1 sm=1 tr=0 ts=696d21fe cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=7KBfExy5AAAA:8 a=EUspDBNiAAAA:8 a=GlqkQvVaQCEososwM9MA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=eL7OMsOqQ-6kYQPn45L1:22 X-Proofpoint-ORIG-GUID: NsndvFwTTWr7Gffi1SlJLbVKjiWkf278 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE4MDE1OSBTYWx0ZWRfX9IviZZOxZn/g j36eog/y2S5hpWhMIdQUjWIgV+QoxaLm88B6DP+cX/0A+NsHgcm1P42+DlYtA6f7DZDaXt0scsl hso6ylsOhj/PELfiPuAroDRvYKcdQ5I3OrJBnfDBYc+wniT9D7r0PqcLTUkPwSde8YEAMY+FP1p X1haLGlfeP/CqE1nCs3JKNj1mFVyLbl9oJrEkToD6EV6o4x1IXz0+yZ/iuZpUwitsOINx2/ys8+ KJAMtp3q/FKW75VFL27sDWdURUVzHlKieh3YM8H2M8/Ql5dkHptgOP1mYRXto+W+7T4PwgU7vUZ +O6nHN+qDTVp0VOQbv1b/LdfK6G6Svpp4oz4Fzz33oAhZeJScEKL+fnXic69AX1S/nyeufviF98 lc6HT4Qj3Akg2apXk4V/0swesMtOX48tfZHwunzzzUpt4QbQRkC97TLsydxOl0kYEtUuVE11OdY rD3F3oyO7K/CqzKLUtg== X-Proofpoint-GUID: NsndvFwTTWr7Gffi1SlJLbVKjiWkf278 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-17_03,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601180159 Remove unused includes (no mutexes, string functions, no OF functions) and bring directly used mod_devicetable.h (previously pulled via of.h). Reviewed-by: Andrew Jeffery Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/aspeed/pinctrl-aspeed-g4.c | 4 +--- drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c | 3 +-- drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c | 5 +---- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g4.c b/drivers/pinctrl/a= speed/pinctrl-aspeed-g4.c index cb295856dda1..f9d8fb1ab1ec 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g4.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g4.c @@ -6,14 +6,12 @@ #include #include #include -#include -#include +#include #include #include #include #include #include -#include #include =20 #include "../core.h" diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c b/drivers/pinctrl/a= speed/pinctrl-aspeed-g5.c index 792089628362..9934ef6205d6 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c @@ -7,14 +7,13 @@ #include #include #include -#include +#include #include #include #include #include #include #include -#include #include =20 #include "../core.h" diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c b/drivers/pinctrl/a= speed/pinctrl-aspeed-g6.c index b0c7e4f6df9c..8cf61aab81b1 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c @@ -4,13 +4,10 @@ #include #include #include -#include -#include -#include +#include #include #include #include -#include #include =20 #include "../core.h" --=20 2.51.0 From nobody Sun Feb 8 15:30:32 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9AD82FFDE6 for ; Sun, 18 Jan 2026 18:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759810; cv=none; b=VFiBs4Y1NNsy6eCU/f7bhZ61xTIKMnaNGdwWY/Jh+aYy0n0L68YqXmkmxDUQmaPEfHND6neW8wvUOTvMJVoW4AGcv5WwvUYYb5YPsSNzC3dYEKKIa2j59fdqVIQ4B5x52bXpaMFwWwEeEKyZVUAow5kxdKLwiGVBJKXoMUCxPSg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759810; c=relaxed/simple; bh=7QVsX3meH/ya2n+MBwkYR1pzRXVW1X0rbx6284HAjYo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rszqEzUGJ/9w1fmfA22IfNvsOB3huABuT4KlhLVxtJIluN/N/KwTKyKCK2gBd37/Mq+tIdOIVkUy4kB9an7s1VwjzzUAk21YgGeh536a3fIyF4/P1YdbaAj1La9EwPx0mcPSYFwdIH4oWMGTRIJNVuy2F0gbDxHgrr08d6MdRfk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eL0a1Qb7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GZyLaTjx; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eL0a1Qb7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GZyLaTjx" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60IAT3Dq2999637 for ; Sun, 18 Jan 2026 18:10:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xF+EKsCw3DAcisLqyjUVzy9KuncQFl/L6/ZeXlOHhAo=; b=eL0a1Qb7gDs4Ddve 0NXzoUo9WM/0fPiz+owufJ/TN7UB1YorGCL5iME/3xC20RYpToTyzU9rMAl69/cX p0se3f7oX63VGOYHAj579mzRleSJhJKqA1K2iejV6rNmmjQiZuwrXiluUYJeYd43 p05ezSi73YZu3gmMpnkbK/NT/g02StJ2p+xr68eOs+RhPvxe+nqM/+kqh171eNhf e1I7pgMXFtt3HuLgyHGwJnoLoHWAQ8vKfYIWwT6yLRTTp7thQtJU6gCSi8EfTM55 bOH6F+Br1a/t/yoE7EIMymmpb2Q/8yYy+chJp1osPlgMqMctqVegdOP9YCBrenu9 NTwUXA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br36darrh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 18 Jan 2026 18:10:08 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c6a2ef071dso1092430985a.0 for ; Sun, 18 Jan 2026 10:10:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768759807; x=1769364607; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xF+EKsCw3DAcisLqyjUVzy9KuncQFl/L6/ZeXlOHhAo=; b=GZyLaTjxGwiQgDRbu3sL/e4A9c1cd2ag/n3tCUItndGWxgVlEbRHWEvzdgEkjWwUHC RSaCn8pGvF3evR3IJmm197i7F4VUSCAPYJEcjIJBJPlOQeDn5gB8vbwna7aqqzmPE4Iv ya5K/evDv9sXUCxfTdVmwXQccOwGzi4EQqKXVYmbypwsQhc/W30heopHNTdoVJz2tOv+ VJeIiCV3OKLoUdPPwFZrnURG9Rra07ZUr5aueZAhTwRoatyruP687trtIkWsJlOPTEq/ QbaARyT4SxweVda/mapTBlMBVCF87cSI8TxzRkG4LlIOFxKCmjkTErZ1kW8xJ5xTly// oW8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768759807; x=1769364607; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xF+EKsCw3DAcisLqyjUVzy9KuncQFl/L6/ZeXlOHhAo=; b=qJq7MwQmPRKk/v0V1gNfAJQxKPeCo5ZLJaHctPn+nyeHbjCTTzhPgxdaOwYKae2x33 PY5dDcNYpyBvheqeJ84ng0c1j0XxWO4JEdkRnspD9sHSX2wQ2pkuQcJpG2BCjmocE5NC 8QmPsTxuxrWLKMFdNgb3qdJlJ5yafdpXXrR9OOcn4/5GxkeZ9MBsLaPE32rGdEwegcdU CNZQSQgZKsAN0bczSHSI3Do9pTGBAnk6/AfnLL+CjSV2jjuiutsfVWkHYmxz+YnarQ5j HWsNX128+cE2Wdw6mZ2jFoiuvormHzrVKhFqYyu8xWes+3BcghOIDIGbkzCzXxPZNh+o l7zg== X-Forwarded-Encrypted: i=1; AJvYcCVXwgArxf3oNDMOz8G0h07GEhZyIvKmJCwI+m7Yn3sxBux4SfWHzVwdizxiL8kOc4WS1mEfuhvDkZTrcgM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywi6VqDTzQsHAfwNml1c8duQ9V3rkpe4Jn938oRLsis1MhYIopn zYtBGwFX00HZgM7sF6U8VxrX4UtoSBFOA2wSKQKFVENBj+vHnfN5caMS6u3mfV7C1vdf9dNW3Qa Qy+APGnFnwRY6YPEIxmIXkwdVgVT96WBTocnXSA/Petl9MsE1M1FiGu1GT7KUdKBA4o0= X-Gm-Gg: AY/fxX7R5GRwpc8XJYqZuaCX0DH5A5xZykxTSSbmwNUvEPaIscXvcFgml0tpiJkPTc1 jesePjntOPOkrUUNwd6KNSZnJnJ9CE6+7/zrpKu5Dw2qyLcZxcSZoezX4qE5rkaNSbGV3CQheyW 7lbomeIVcc7u5gcMpgxMIv84HcOgo7MP78gV4gMw9Jm2nsKluTxch/mtwkRMm+qkJj9AHgyc6KG aTqIPhIyH9D7OPI9441jSXgpjamxet+sa/h4BT8gwaHrTPs/mpZsD+Nos2azF67aehhPuJAUx9M 7v0v9dYeGvc5xgEoQ/V9G7OIYqKBn5+k4pBesBDaQpfUoN5rk+N5osJSY1gKgDLV7W6lipzid1f QeFO3r65fdUFWwS/KmbaMj3An414Qwy4IVg== X-Received: by 2002:a05:620a:319d:b0:8a1:762a:ab13 with SMTP id af79cd13be357-8c6a68ed101mr1320494085a.10.1768759807229; Sun, 18 Jan 2026 10:10:07 -0800 (PST) X-Received: by 2002:a05:620a:319d:b0:8a1:762a:ab13 with SMTP id af79cd13be357-8c6a68ed101mr1320490285a.10.1768759806815; Sun, 18 Jan 2026 10:10:06 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801fe44b37sm62162085e9.12.2026.01.18.10.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 10:10:06 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 18 Jan 2026 19:09:25 +0100 Subject: [PATCH v2 02/11] pinctrl: starfive: jh7110-sys: Cleanup header includes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260118-pinctrl-cleanup-guard-v2-2-bd36f681bdc0@oss.qualcomm.com> References: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> In-Reply-To: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=957; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=7QVsX3meH/ya2n+MBwkYR1pzRXVW1X0rbx6284HAjYo=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpbSHvR6NL3AOW754D5v84SJb7LIyFBtY8KP66G rat0rpoDimJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaW0h7wAKCRDBN2bmhouD 140hD/oDwb35yyHvtbjc/M0Lb0PMZ0C388lWdCmXu5PHWfBfqbi0pqIpiLHa/I8lydecaQng+2T 6pXYaLCQXfyx6d6HjJ55DKT0y0CB6wGv6jNrkEel9RIEZtNF98EnmNQ16fH/1rSb9mkMC7i2p7p uDQZ4QUXT4LLz83NgAx9pJhb0KnfOtuSCj7ilWSVwBJAtUtjFo5I5GRJSTTEh56yE2ZABLc4cPM v3zF59Hm8PbD3E9MuXG9dkZ3zcW4LPXVh80oYbkUYomCkspDgpq1XUWslyrduP8BRg61ub43bFN D7b2pKxQcp9n4qRPG87arVBUJzO5bUdZriEhcvIwRA8g7Ty4t1XjUE2dBdcmlu1jHGR4yu0AvNS J7gZipSXXYh7pfrpXX5hfVYQaU0Rx5NjFvVJYlHsg3MPu58t0NRwsCZyu5njKqBnL97H23DcTnb OGU6INWVFiyd26HXHhgTxNPu8HbyBRFE4CXAtbLk+R38puFmLXoAIe93PD83NKVNNA5JuQ1qMDT 03Mtb/klRnsQT786huPeUBAPeMhGoyfg8zbw5gZNhOsb7qtBjGABqQ2+kFMbdfME3WC2aEWdkol fQpOxqisp1hpLzun3NpNsowLGMaZelCuMxI2s0Eqx5whKM1Oq8cNrvIZKO9NQDkY4SqD/TZ+3rw 05cWuH/pid0x7LQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE4MDE1OSBTYWx0ZWRfX1WvVsDdUtltG FPdKB4BUnXIg3u2FtCsAyh3AADIG+gk9uuTCmrPakRPina0G6Fpr3GGYo3yJSPYqd26WsOZIOj5 0fQ7srPB+pePpxck5jl55mDJs+BCUaOJJ4S6BukY0oF3tQt2PZEs9zgLAW6euXDwjjTPZa5rmz2 YOjY/iSGGLMrsDtJo8ihoY5KiS8bI9+9qTAtNaNI2xXvJuajD6svSoWI4xzom6aAG1q3l3tpEai HWmbUCjzk8k0NVM/nSCtcZwPqnd3LwbUxQnY1TRYW8goW3YcK7N0EudB5tTSSzQbGHkS2mvFK9V NelGr8ZicF7JK9MTQ28DNqFx62dJEwU5CrtjlFDQFmfnD+ojSsYykYZ30477mTSNHx5+9bukR2n 90smbXWt6RpbkOvwsTNHGTArocRxE0AlgPN11mTQKQLqjqLFnS7Myl0SJQi38I/0ZVGkczfRCLz 24mTZVJNbS7NFn+mnJw== X-Proofpoint-GUID: P10mYagb45WaDTesNp4t3ll5rDqqtFA2 X-Authority-Analysis: v=2.4 cv=GJ0F0+NK c=1 sm=1 tr=0 ts=696d2200 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Bq6zwJu1AAAA:8 a=EUspDBNiAAAA:8 a=2Nzugx-BcEq53SDkSVIA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=KQ6X2bKhxX7Fj2iT9C4S:22 X-Proofpoint-ORIG-GUID: P10mYagb45WaDTesNp4t3ll5rDqqtFA2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-17_03,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601180159 Remove unused includes: no clocks, mutexes and resets. Reviewed-by: Hal Feng Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c b/drive= rs/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c index 9b67063a0b0b..44f84e4c29bf 100644 --- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c @@ -7,14 +7,11 @@ */ =20 #include -#include #include #include #include #include -#include #include -#include #include =20 #include --=20 2.51.0 From nobody Sun Feb 8 15:30:32 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C2222FFFA5 for ; Sun, 18 Jan 2026 18:10:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759813; cv=none; b=c/+gjUaRkPNc4CBHvRN2kS2NRl1cqJQY+/cQDhdfvAf3zJMvj1Fh0Cacv3Fwlfvr5SljOCzX+dvoqAitwAnh6oPNsRW4wVOY2aUFdKc7n4/kDO8TuB3xBBD/7Rkp6UGilpaYEuNDP6ZM37vpycwWkycGc4ALYpws/+NR7Jv8HwM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759813; c=relaxed/simple; bh=K3uQDGZFV9ixSLMAp+XTCn6w6PMJReQbBttCFQN0F/U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UnLkjHsa9nHxR5Mg8luYiJckSmg2wbgVqoweiYudbFFflqzcs4fflWwji4ufOsfd3npHESOs5B1FTLPTkeCG8X9qU5NGYj+JKQhUPU35be4GIm5q51zmN1zrcvkwgULPjNZcHuW7HX+ZvbYIfTQfYjEXjE8zPHcUUyhk6oZCDXU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XM0kU0IO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Z6jKdIww; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XM0kU0IO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Z6jKdIww" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60HMZ4KF1957734 for ; Sun, 18 Jan 2026 18:10:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Nw/X4tXH2dJCM6CqOW5hG9dFyviCyY63+ly6mDS998w=; b=XM0kU0IOuobH+dzF 6qVL0KuB91DXq8pk+r1qmhwUkydjBo9HyCAY1LKdpuGih0pp9iKU6HVfW9HWLFxz R3IvKRlSB4lkLTBq6Pbr+wtIL33Q2GypI40wf1+SQn+5VlMc+q/3g2J/WUeCGB97 1dnPHYWjD5O3T1uXciWGtbVV3Wo7snw+1aYn8bU56XpkaX0IxdQtyK/Gfzq2EqHd 49dgs7MxLA2i7SGKCaYTRZEYUpviIKBf427BxsincA+Rj5kL4djRYs1NICEOqLuo Xf2CJ7rrUcH9mKV8D8qc8HG7eIjsQBCiUZGE8GGMvx+q81KgwIcWKIef2/ofx/2C kdePBw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br1e5jygj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 18 Jan 2026 18:10:09 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c52fd4cca2so937701485a.3 for ; Sun, 18 Jan 2026 10:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768759809; x=1769364609; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Nw/X4tXH2dJCM6CqOW5hG9dFyviCyY63+ly6mDS998w=; b=Z6jKdIwwZNqUcNHj7LtvEF5afSbpN4IKlMLhUbOc5X5QQri4FiuaMHjm5BaXHZOV2B pHfLDdg3FT/Jtl367u1GxZ/S+6KwxX2d7l0uXi6sf+IlAPFTsa4tH+c45BAQV6gAyVwb 9OUo7YUtx/VTmowY4w/nzq8cc2xKobiT1Dj/Rw+wzQF27NK97Ajw54H+nkr9t+5MokRb sVFIK610NHfZ5vDYdr05e9UimopJu9Dq9JMBN5AgbgpMqtYqIyCpJ9VuGixUPqieLvwB jXqYSpYwjkrlELCw7i/IjTNtZGssKKuM8AwJbz5plBVKDnWjK8A75KARlxeDABFrYXyY 8FOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768759809; x=1769364609; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Nw/X4tXH2dJCM6CqOW5hG9dFyviCyY63+ly6mDS998w=; b=a3N3GnM7yD9JDQ/VXSiy7oAObRW1TIQfhIBTEER0s2GzPCEJ0IILiyTWgyJxuzA1zZ w+DaFD2tRY2HhdbrqdTdzWDE5wO3UGAaS3ZgKqj0ttTVd6gCFbzdepNVca7MEb68LUpf etKG8oyLyAXuQckxyGKdWSJHA8HkvYANZ9ZbR6VyK3ZrJv686KcDlq13v8IYpSXXt8WC cfIsI+gfq/7S2QkCtHG8utUcgWOm+ZAUrijl9nsRuxx+kiNuaRDl3pGbbDZCIPG/nMrD zHIiTXVXKr9YY0gxqfYDpj72t1eovjKYMUyl5aUuCrkoqIG5t4gLKft0k8Nk7LS2o9qF 3tXA== X-Forwarded-Encrypted: i=1; AJvYcCWk+y9c+9L0hKz1huuDgZW8dvhnwV9bJWKInEg0VUqZJMD779GcT4bXRj+jM79n6HK2faiEaMIYTurxh6E=@vger.kernel.org X-Gm-Message-State: AOJu0Yza3v5vP+xEZRsdDEHW5YL0ppVh08lBq1eIUhp/cRSbYzEfC7dg KTj6wthrhIuLoyreItf6e1TbNnQQ4Z4dCOe8B7gKvNs3vfn0BT1flGDmTEko5oqUcUgiNo1gsZR 1PWPaHbVQ0cM0pMh7mRn2QJlXAP5Z3u2T35Mj18EONHBjY2UfPtZWeyF2zbkFXZs9uFM= X-Gm-Gg: AY/fxX4nG2DtFRGa2hLRIkcmZ2JpMyXXP0LoNT5yrIIxZgTB8TQscwDs6vwK8zDUm3b DMipqaw5OCXMU48QnVNQ6e7gLXMmp7BFwmz6JcKoa5HxsDZyzUrktLf7IBQ2FeKIARJ0GNw/BUa L4GvZzP4uR6yRdkJn3CPRHOZ5iEwM3C9I7/46uZRPLkkb3WviJKTt1QsDQt2IoeEH0j6T+y4NGb chDDqK5q2bXcRLOP96gjM4OI272j9EfQAZUWCWvWOGhQTe2m97kbpsaYB+tOs29XsINUygRkLLN OaY2BWF2CyZONphM8F1busWJRgMJFPgNHe3FtGMfEZr+NYwCKROA2p1/g1bJPkJsiqxc7O/8OY5 ihXqNLcfhA5JgTATrQiArkgA0WdmoTE0tIg== X-Received: by 2002:a05:620a:2550:b0:8b2:f1cc:a14b with SMTP id af79cd13be357-8c6a67cc5c8mr1321765885a.87.1768759809379; Sun, 18 Jan 2026 10:10:09 -0800 (PST) X-Received: by 2002:a05:620a:2550:b0:8b2:f1cc:a14b with SMTP id af79cd13be357-8c6a67cc5c8mr1321761985a.87.1768759808928; Sun, 18 Jan 2026 10:10:08 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801fe44b37sm62162085e9.12.2026.01.18.10.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 10:10:08 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 18 Jan 2026 19:09:26 +0100 Subject: [PATCH v2 03/11] pinctrl: sophgo: Cleanup header includes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260118-pinctrl-cleanup-guard-v2-3-bd36f681bdc0@oss.qualcomm.com> References: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> In-Reply-To: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1647; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=K3uQDGZFV9ixSLMAp+XTCn6w6PMJReQbBttCFQN0F/U=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpbSHwFh1ny8ZUBi7E3yd3ZVK3fp/JTPumZY3DF DMrk8Bsjp+JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaW0h8AAKCRDBN2bmhouD 1xP9D/wKpjBpf0B5lT15hZHuDhBlqt/XMr+dL2IoW+gDe82hyBNbi9Mssn20GVc1WxaEnqmnq4V p4+swUeTdryZjhbgxuKOPrnBZ5Vk+8vlzjCsvDVQ2ReBaqMpORafXuxkCKFgclmPhchYQRR6b/9 /6l9s0yU2jXLJ/19u2o6w1PYH9z2E0bXHvYkcbKNeJFQHEKOlKZO49UNYTddgFA6Glzh2kmdWa4 iVPwqzZEAbi33uzkLpefoBgD2iQyRwmyLJSxN0ZlVWdPPd6cxYvfPMWlr/a4ZUDTTfEYRZzlkEz nxG+54c1yU+jxM5okvGMdms9h6U5n3xWwKQoHYLNd8q0xZXrjBesvQB1Z49IkKfDBFLbkNGgWTN tlOUZlfxVOe5kEK6DwJlPpG7xVCf1ey6yUYxBCnqM+1HYMFULN3Q1/C+0jxj9XJZ4mKG4AC63n9 dYUqyGyPrLP8dKvvV619YhkgqwYnCKINxgT5jTECPev4nLqZjQxG2jWTZtVcGitKwo6aaZAPm4N nxmYst0BFODDdlwnUAIbEeTzcSbEfm1xCuURbI7/ir0a83enDBdVx7FY/SLEB55rhRpN63dJLgx Vciq6wWoExc3WoBaH3dwBm0ST1MNbLbF6lHxQqvEKQELGhE9JzTjOytPYUjW7UbvNKOMmRQ5Grw 4tuQ43AnItwMaTA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE4MDE1OSBTYWx0ZWRfX0HPw1X4U9h4I FiZov8b8N6AKCrgGzVLSEOxLztOCt4Gr2Pk/zubvLp3rO5/LVgHW4aoNQjobJY8mWYvHuayAP4Q k26VfkvwFzjQzsOCCOv0CnyjEu5sJkH8iz63c9wOAVgUsyXVvd1phe7wm7wpVuhYJJx0I5ovzVq CHyFIcbuiUHLdcpCAkL2FSYA/Ikm3C8xZXRtnK47TlL/IceI/PSmNmBKIRYfDG5kfFN/XCGpWG+ PJkoAQnuHp0u3pZPzeSjIRE70HHs95q5LHS5PBT1i+ZOoq+2r254ZUl/kHAVGp5Ol7gpvgchB3M bwANFWb79FSq4fsugGZAKCQBA4KVBI07f9dCNYhmdn6Dqqbj6BClO2qTIwDCfhw6fUUMCXY9Q2J jaOf6JFhAnf+yWLRB0Xbe+ALsxLzUnVE5ugNI8hElCvbyoITB/OpLAItlv87PMT9ZPj6OD2z+uE nM4XeNTLUvpbVM0bseg== X-Proofpoint-GUID: ACOJ8F1b3uv-zObLOHvGimLEOVUqE4Ip X-Authority-Analysis: v=2.4 cv=U5yfzOru c=1 sm=1 tr=0 ts=696d2201 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=XMepgddcWT0EFqeyVMQA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: ACOJ8F1b3uv-zObLOHvGimLEOVUqE4Ip X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-17_03,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 spamscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601180159 Remove unused includes from internal headers, because they do not have following: bit manipulations, mutexes, spinlocks and struct devices. These headers are included by actual C files, which seem to have all necessary includes. Reviewed-by: Inochi Amaoto Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/sophgo/pinctrl-cv18xx.h | 4 ---- drivers/pinctrl/sophgo/pinctrl-sg2042.h | 6 ------ 2 files changed, 10 deletions(-) diff --git a/drivers/pinctrl/sophgo/pinctrl-cv18xx.h b/drivers/pinctrl/soph= go/pinctrl-cv18xx.h index 759c0e604acf..973ab9a38fcf 100644 --- a/drivers/pinctrl/sophgo/pinctrl-cv18xx.h +++ b/drivers/pinctrl/sophgo/pinctrl-cv18xx.h @@ -6,11 +6,7 @@ #ifndef _PINCTRL_SOPHGO_CV18XX_H #define _PINCTRL_SOPHGO_CV18XX_H =20 -#include #include -#include -#include -#include #include #include =20 diff --git a/drivers/pinctrl/sophgo/pinctrl-sg2042.h b/drivers/pinctrl/soph= go/pinctrl-sg2042.h index d481973fcf97..1a2b00dde1fa 100644 --- a/drivers/pinctrl/sophgo/pinctrl-sg2042.h +++ b/drivers/pinctrl/sophgo/pinctrl-sg2042.h @@ -6,12 +6,6 @@ #ifndef _PINCTRL_SOPHGO_SG2042_H #define _PINCTRL_SOPHGO_SG2042_H =20 -#include -#include -#include -#include -#include -#include #include #include =20 --=20 2.51.0 From nobody Sun Feb 8 15:30:32 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2B823009C8 for ; Sun, 18 Jan 2026 18:10:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759814; cv=none; b=dO31IDpP3uhAWgGcweLAi31KSZKOj+pzB/ezyrqMy7wWDQ+HSxA7wFa763tP/buNUeX1LfSJnd3lmWEnH8Sou1d+n3oKeAefZ9wU198I/8doWhF1oW1HRAdBdLv2FQEMZwZk1AtEKNtG0MeBpOQqHBfCQN3frJ7utbQrCuBYpdo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759814; c=relaxed/simple; bh=KS2A41254/IzptP8+yKUiwH8wnfKT/gY+cirH/V2Wao=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=a6++tdWuKrBMRrws1sK8OE4+jAm1Hslp6vktTv0+RsH+pU7lG4v6GfLtZnrje/qQ0+glZ6wbVk1L3TkCCsc6/BcxrBpSP8vlZaGnUErN/uItF2zoylCKbuF5n6epEK6ygQ3whHJofVDucL8uTPhJI/7gAuqbgvaJ6KiPMrujjAA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EKd0XTCH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RG4z8RuU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EKd0XTCH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RG4z8RuU" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60IAko3R1699121 for ; Sun, 18 Jan 2026 18:10:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Mv0nQD2Fz+xmN887PWY6S7g+L/xnSZWABnal0geai9Y=; b=EKd0XTCH2anl67j7 +xoS3zAwyuw5gexTX4UDZDbMLnC5kc49ZKBvo/PRSfX8H9/mojr8PFpvgc3ME88b 6axcSF5oETo3Ez0pN8KFbvoEFyhPrF7c+uSatRaUEvMLzXAK644V1AGsZn56bvQS bCZLsjvXGEqpYS3LnoXqvUCuqUI7H7Y11WJLUaxSPHHwguRGZ4Q7IimJmipOt+50 Q6aw2Gwamt/7NCO5mbtrghH/O7wwME0l9ThG+ASTltN1oWwT7WSEvV1+2j1EvAR2 nzqjOBiZ1kktZ82XgQPuWYmITvwpCe163Q9AwYzYfAfXeJQ2iw890FeCl+fRz5AT mTlM1w== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br20x2vfx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 18 Jan 2026 18:10:11 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c6a291e7faso309783185a.3 for ; Sun, 18 Jan 2026 10:10:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768759811; x=1769364611; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Mv0nQD2Fz+xmN887PWY6S7g+L/xnSZWABnal0geai9Y=; b=RG4z8RuU5TN71yOmLLOTXsJ8ckqp6YQaHQCzDcKF9XoU+dWlVDRWQ7I+jdMUSMFosG hDWsSjJPT5LZ8cjfIWRf0mtT2R25mM3sl0qHuUNEJ3SuSLQfpgWwzxr40WrWia5YDQaf Gp95zPas7X017rLQFDYg4uXeUZyOvJMTUWryjLZPlW5rG5Y5X+XjPDkw4QWJFADfy7ZD JfreOTXnc7n9Z03lY8GdPpjuHXzApK9kWY0v1IIqheqVd4H0+WQ+lxnX2snkErKhuxhm 22R4IjM5CtU98x7eJasvjQ8C77tZVGuAWPSnYlLPnvKDb0RueL/7jVzu1djijkw+7/Pw p8Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768759811; x=1769364611; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Mv0nQD2Fz+xmN887PWY6S7g+L/xnSZWABnal0geai9Y=; b=UvFahrXZYg8JFOEgZ+Z3eB4DlA8WZXcepY3x9bbikHf6mVP24fPd0+s9DY5SRTsuaq VCD05iCS8WD8IRmI1mkm3USspTj4oUp00RMqDQtd2FCTCnShYIiRxxSLq8mOMyfBcQas wK6dyT2yN8L5LFjt194zLOG+1t0Yeaon+yBFlQYsox6t1YGbyHKYTj7tqEQZoZ53JJ9e ePR/q7IFlImsIGryQeaul3XQ6W3pmSj8cQXHFaa9EJNJFclgnbNq6ZM6fRT1LtQZVtTv EJdOjN4Jqk9pNWz+oePhITV55qk5obXXmNfr3HZCCYC3JYWJ0uzPpsk65TICZHreCcSA 8nPw== X-Forwarded-Encrypted: i=1; AJvYcCV00itdWiRe2S4zfEP00dxRTnh+wk41IGBys2ESz5T7fCR5vvwmOYCqA4cWahNhoZi0jWEDbDvl2GZV0aA=@vger.kernel.org X-Gm-Message-State: AOJu0YwJtbu5VS2PD7tcjrI7sr3H0NYpxYVakLIU9NiRc7WWMNXpiryR 68VTjhm3Hih7jLhwhuHxnq5JoZI2d8nIeNkzbSaGPaaOXfPWIRQGDzlR0Z46gjzJ8dcWAAg3wMy t5J7E5FGK6D8T02LbLlHtKbpUE2qq8TWuEbgDlEt9miqjQr45S2E894wX4p4+Rtn30/w= X-Gm-Gg: AY/fxX6v+IuXO+1RXeC190tKJ98u+ocw6DgiKGto92tEsnQ3yoZJNi+HUJkz/VEWCsj M057gdap9hAsFBHbeDjSudEBcb/1/pgZB4a23eI+ynmC6uQhOVnOvq4qiNCvzU8LgD4ndOGArMA 6smh5yhpvMgMpTVWNYEeSRUbYZxRcqCyGJWE+54v343l/RHZ3PxdTgL5Jo0CDFF+zNNMpskMtaN yDg8AkbAJQozTBRtERaDFLm/TqYk2tbaPf+lKZioaVcTzAmzbfP8HxDi+sv4JP+fszVZWx0J92p q2mww5gquEoYr8zzxNDixmyFIseDj+xlFA796qhRZi3a27NxO/sh8PQyXG70O/HKd1XzT17YgvU ei0SeZieSMIFHAfIRmClOe3ofGdVaeLK83w== X-Received: by 2002:a05:620a:1924:b0:8b2:f269:f899 with SMTP id af79cd13be357-8c6a6956472mr1391331385a.56.1768759811391; Sun, 18 Jan 2026 10:10:11 -0800 (PST) X-Received: by 2002:a05:620a:1924:b0:8b2:f269:f899 with SMTP id af79cd13be357-8c6a6956472mr1391327885a.56.1768759810821; Sun, 18 Jan 2026 10:10:10 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801fe44b37sm62162085e9.12.2026.01.18.10.10.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 10:10:10 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 18 Jan 2026 19:09:27 +0100 Subject: [PATCH v2 04/11] pinctrl: amd: Cleanup header includes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260118-pinctrl-cleanup-guard-v2-4-bd36f681bdc0@oss.qualcomm.com> References: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> In-Reply-To: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=775; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=KS2A41254/IzptP8+yKUiwH8wnfKT/gY+cirH/V2Wao=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpbSHxcMweZ49Q5Nba1wrVt3CAmG8iWHmyaxcHb TNtiusHLMCJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaW0h8QAKCRDBN2bmhouD 10MfD/9Y8BgVbkm6bl+36BXzMgv1xbm7JsRk164MPz0v27NRR9/A7MTJxMXT6LNgShVq1djSxge 6g8uCxUY/9zNFfEZbrbUevJi5cHtHc5/YUTCSNnot/lyVENX5O2KSCx3dYOpUdjrHDF8VX8ybHW wzM/tjZOoVQ7+gYxMukxqt3s8XLQOVct9PlD6qtPZmiFE1vab6GQQgLNVgM1lOYylEfR2ldNJXs jXDMtydYwc+g2dbP9e5rnGzbL2XkzK9qGia8zw1O8+ri8yvQ/U9eaHS+WXwTO7Vlr1QAxEc4oUC zKbv4wtZ1zeayUoWUv1YYDBGknxgFxwVQ+bjAyyLW+9wq3v6aKLX2CCdb7vhkv9IIbgJ0ieuMw0 xixdCHOWfKQ+OYzmelQ7pXLN7RTHkKO8loGnPsXOAVHqo6wdt1FOQH1bb4xGl9Pd1K011ZOn4sP piveUlRUfW37nPiHBDROLc5yASzQBPjKA06V8RpaHwfC7I/9bVbiBuGyvVHdGhk6LBSFFKEjrBX UljGUMx3HN/A8uksjr0su24ucX5chRlqNVyncRJqPaYjbJAJ0zFKM64X1r9AnLRwEVfas7sruYn VGBFODgVsHuDAOcu5XDZBnuzDmqv88C04tW2Pve5Yakzf9c11d3W7hQUeI1nroie7c8OQHhI2ca a6OcgYeqNAjKKjQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE4MDE1OSBTYWx0ZWRfX+IFEOwA7hdC3 Qk0bIm7gh4FBn3afaRsPXgIbU96AS6gvdVsiPrxvzWGKHHsokjHSoJUjMqIYjmGgg4lKY+EUcuL iPVPkT8PeeIAyAJc2A3mz+DByjAI9jKFALAnqRpB0osXQHq/UClCwSF1Cb5VM/vcbksr4Wytl+C AxzsLXAwMM+TtzxaHP5dqtBc9GlHF9mnAuV4kUEPw9TF3TW78EuTylIB7IjNhHe3913qCQvA1+i 14/8+u3CZQ7rjIfd27UzCquiCan073EyY44wl8YSYFSfov5PSIgYt67KEdt21YYT1iLH3Q5Wiz9 TWZRoPhOQGJrIJDG4U4wcIWIY791oJ217qcX7GN9Ev3KBgtY8JodprlR8uY4QKLW+IQFTaKW1Mu Z4l86hwdppL/tgIRnvK1QI/TChd6zmofWbKsuO/zYISV37Malq44dpgfymtXP6j0P8/OhZTeAXQ 9tj1fReD9ywf34Yf4UQ== X-Proofpoint-ORIG-GUID: TUPGDC9zfoE0myQMwQUnQ1gmsT-0dapl X-Proofpoint-GUID: TUPGDC9zfoE0myQMwQUnQ1gmsT-0dapl X-Authority-Analysis: v=2.4 cv=abRsXBot c=1 sm=1 tr=0 ts=696d2203 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=tMXyHTyi87mTYQFNLaMA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-17_03,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601180159 Remove unused includes: no lists and mutexes. Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/pinctrl-amd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c index 2dac5c71eb00..2af94ef56434 100644 --- a/drivers/pinctrl/pinctrl-amd.c +++ b/drivers/pinctrl/pinctrl-amd.c @@ -21,11 +21,9 @@ #include #include #include -#include #include #include #include -#include #include #include #include --=20 2.51.0 From nobody Sun Feb 8 15:30:32 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07B1C30148B for ; Sun, 18 Jan 2026 18:10:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759816; cv=none; b=tw7PGkuUn3jxYZAMZmXODUWrA9Ejhyl37U/hTV4k1aN9BK6126sHrCAhwiFj1ZEbI1NJaKi5g3mbJ+v8DOY3cuG4p5IKxv59wvE2nw8wjfzbmI4d08andOT0YFXBLGImI/8sQHQOSQX0IWy4PQ/3287hsWpHHV4wfRtzbnwtGa0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759816; c=relaxed/simple; bh=Y+FQmd4rABqYPyTPKLcnkK9CTadziXSgsQ+69hWhimA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=scMO6rWkRka19wb604GrJ/kNgB4i4vToRY+1SSnu+HTQ6Ba5b0zZ/exKVJVkXh8eSzirYJVBwvcZJVVA6m/QOGHhyFIJjc56A3vl8k4tqz6gkdHIcte9qpmD6Ru4M1OtKYRg+sYKFG9YRG6VfaSevub0NealF8agg9NsDzun7do= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KXHpX1m8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=J/g0n5jd; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KXHpX1m8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="J/g0n5jd" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60IDQ9cV456045 for ; Sun, 18 Jan 2026 18:10:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LXncEA4jW+AgdDM8Dn/nTshgL+Kv2q2dFOJVpt182v4=; b=KXHpX1m8m3rn36Jg XAOXwYt+u9K3TjPostd/Ga+OJGx79TdYs516hJ7Uuj1DP0pic1AGnEgszDSbZwne PlDfhwKpRxALzLVi9/aOTpk6UditMnDm/26xLFGDtbrHEDQ8D8GdH0lLQR4Svsqo pnP7iEh9mMwx8zLBM9tlTFKD5OpkE0j97kbRdyVpYBq944m/m/NN6wbfgx+b0Do/ 6FHtL3IJp+oK9lZqxZHck0q7vU3B3O9QpoRqSvP9CfcaD0RXSV07ytsg3tCUjcGe ow5J9jBBcx1u5RbtkPZs81+1yN/7xDoG6TjVaRHXngafujCzRFemL8NSl76wwWQ1 /MK8Jw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br3kh2mcj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 18 Jan 2026 18:10:14 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c5297cfe68so689258185a.0 for ; Sun, 18 Jan 2026 10:10:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768759813; x=1769364613; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LXncEA4jW+AgdDM8Dn/nTshgL+Kv2q2dFOJVpt182v4=; b=J/g0n5jdcQUE+owZWh8f0ixZsjjcFKEsrEthDALT4qXVuN3bincC2HIMpfkrZMTh4E F6ZYpHGe8gTtE/Cz+ruiDswdlq+5LK3WnfP+hzz7bRWsorLUt5BT3iQCyXJ46zkhv9xR 44DcoFGfia5Gbof1i9J+JR/iTxyV2InAXy+73yzc86wjbRK5R41uIJctk4qPjWs22G3Q Udn+GfIxXvN173Dphws/rnHA/rRqw0T6IpPSVMHKMrTXKvf1bi7QWfnHP7neIp2spl4E QQt446WxZ6eANJt4nSwfHqX+Bi6axkGjvO9yYm7zMat3mJT4McKQOCnzrVbXA8cfJBT5 E5XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768759813; x=1769364613; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LXncEA4jW+AgdDM8Dn/nTshgL+Kv2q2dFOJVpt182v4=; b=FIRWVhGtipS2AG6zQEsR4dKAbMCgOyxc730mnbx9ce+AWJVolGAHZ5o7LhfPkpz99d xvcEDZnrg962m8vmYkUVqi0bm3OtHWnwgZTzopFRntoj8fXf4n4YnTsNW/rh67ttLmuc h0ziexdgG0M1Mwj3Ap4RZUqS1B8kt3dFu+tQWXAXvnXy9MyL+ss6XWfz6BKnHi4RzY9n 5iFp5JxYL/0ywZO2SUhsq25omXjXusYm7UqdcvzSIlXdLRpgkKG0JwH55Kz7QIKOQrKp JtLVr92cRuM8al/j8rXeurLKHwyeDo41gJ/4AO9ITGJlsBQXnhlBSNj0qeiJdyLDbV75 qq/w== X-Forwarded-Encrypted: i=1; AJvYcCVnK4WZ0Pe/rJ6qiEoRTWo2cLDW6BF+BEYrnevPtd3y97YuO3sWZp4AtYOiQy4EjSiEjYqDSPp6E1D7Koc=@vger.kernel.org X-Gm-Message-State: AOJu0YyIvy2RnG/pY4BRpaQwRfq9wpNIEJ6hTif5VA1ML+cV+fUYDfCI iqI6lk32cf7ekjd115XC8/5fq0WYn9GZ9um43fS4mIHce/oUoE1IgHhI7EdYT5jGS6YsHqZXseL bGHmK5eiUsePGBcB63s/jJ7XebeJNmBhCxmrNXQYst88RTHfsNr1Y7O97nJJqVDEysbs= X-Gm-Gg: AY/fxX4lA+SSStvCouQ0gCyNNrm8eCHIqd8u5Fb9j1bBA49hAGbq1OL9zQqaCjK+S7Y 1/6qUYEUyqlbpKivAPGamldYfbj4Uj1WB/xiuNrz2Aj+WqN/k2Tl+DnmKkxCHqEJcQ/A5fnjLAH Uy+0ba5b/S7a4Fir432hDItMp8hEMNkPsGRymJDIgdonso+kHWMvOHdwHZUEXwSc9irz7zBUoNb LlGQWNZqZyK87inwJ08reh5mNPa10reVf5E3iMfqGVO287z41N5uRGHdCrJmdNU3PaSIdTAGQGU bTSB5Vt8jOPBSB0qSMclVDji4fLDc4Ugi8RJIFXiLMVP1YR81W4hACgQ4X13GO7C3YGgoJNxgaW D7Ip7l3Xj9EB+4N1CqBzbvnrk2hCpg3UC5g== X-Received: by 2002:a05:620a:4801:b0:89e:67a9:fced with SMTP id af79cd13be357-8c6a6789e6bmr1223537385a.66.1768759813364; Sun, 18 Jan 2026 10:10:13 -0800 (PST) X-Received: by 2002:a05:620a:4801:b0:89e:67a9:fced with SMTP id af79cd13be357-8c6a6789e6bmr1223533585a.66.1768759812755; Sun, 18 Jan 2026 10:10:12 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801fe44b37sm62162085e9.12.2026.01.18.10.10.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 10:10:12 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 18 Jan 2026 19:09:28 +0100 Subject: [PATCH v2 05/11] pinctrl: aw9523: Simplify locking with guard() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260118-pinctrl-cleanup-guard-v2-5-bd36f681bdc0@oss.qualcomm.com> References: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> In-Reply-To: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4481; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=Y+FQmd4rABqYPyTPKLcnkK9CTadziXSgsQ+69hWhimA=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpbSHyayuoBeIp9CFs/To0KGzg5wtCKMQchY4rd ZTVsgBVTRyJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaW0h8gAKCRDBN2bmhouD 18jKD/0Q73dFNHHnrM5068MUNMPnIOmN7objobVATcjCxeNYoQiN8W7ivD4SWKVqA/DdX1R5St3 0/tCDBGqXO12+uj40UIZE4ljdgKCD+fsn+WSOyeGFeJIxnFDyd8A6kCV+M957Av09NHGOuZzCz1 n84LPH3ZRBC3uEP8gG7lVsIgTJ7Wd71Udx4I6Tf07bk7F2r+44NHCHKRtu55X8WAjRvLmynm86Z YOKnbZ2UCIUPJ62n3gMymM0/Ir+JkYjini6adzG92nXecsMf8J7ulbe3ZCqT5uJ5jTnZRR3KKGb psXi0oNg+Osb0wrW5nqR6O2Im3Oqs44dXVV3i/kbow6pNJeKSmmU5W+l68bvNbT281ghjvLIslY vvnRwxod3eZUawpDeP6T//3MNuKK2Gg8x9Lq9ey+ddE7nCFUTBA3ypX1ErFjwFg0DHDk12c8WII gi08BdhYaU8LtIxZzranwWhmvK3EgkrmYF+5lIoiIaY0e8XcmSW8WsiZCwrGUt/cBly3O7IY92Y FNoDXLaqmlFiFgTiMN2tVA1DpqquhFr/7fQp130j1BwOiRjF1OVqoVodqNKRPARHoBOIEmZMpIC PcI+/h6wyzJPyYXnC1UAQaCuoEGdkdUU7RcbXCWBfUmrFfqNlwHm1DgkCLMLdyMmi3GmnFcSM1m fHjfP614CxYOwQA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE4MDE1OSBTYWx0ZWRfXyS+bcV6w/UGB 6JB2TXBK5fgYoY2+ZHeR5J8UQDtu3vJi5j5errMg46iNKuiJvL5oZ3arlHLffhqREKmJw2fcftO UA6uEjsKoHJEZaN+NIzx2AaVAYWRhQqBoaR/uTGi60iwPNEUnaWh6OEd0UkVTstv0FJcijsJyfK Erc6iGhdSzM0zRP31nDlIL8Lkuu5upUcpfcOdiNTrS2Rz7zd7sDIKdedeBvv+yGdCFaUrk8v9Yk Bgc16NfIQbdeULuVRZIJ2CuSIVW7RG9ta6I03832nRQFpd5BzQA6Tll3QpvOTx117y/FAyV/F22 boT5h2ily+6aU/Zr2xjqKwVZy6hjbhkk2BT8ztDKthBqPUF64zPrmMiw7aCXxQSYL2JAu/uHFyt 0SEPO7AW1m6iTeMz7JyFhYnfEAsbXvI5BwozDzKSa81a8E5xvdoFbAKRVtEyBBzr/Co8zZFtkMx nyp0VktRiMkS6aI8ljg== X-Proofpoint-ORIG-GUID: jEMUDnrLk03Jb_GTGYpH8xjOJ4M0seTY X-Authority-Analysis: v=2.4 cv=JcyxbEKV c=1 sm=1 tr=0 ts=696d2206 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=sJPWbbE6un6nfY-uGV8A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: jEMUDnrLk03Jb_GTGYpH8xjOJ4M0seTY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-17_03,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 adultscore=0 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601180159 Simplify error handling (less gotos) over locks with guard() which also removes possibility (at least by reading the code) of returning uninitialized rc/ret value in aw9523_pconf_set() and aw9523_gpio_get_multiple() functions. Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/pinctrl-aw9523.c | 53 +++++++++++++++++-------------------= ---- 1 file changed, 23 insertions(+), 30 deletions(-) diff --git a/drivers/pinctrl/pinctrl-aw9523.c b/drivers/pinctrl/pinctrl-aw9= 523.c index 479553a79216..02a24ac87ea4 100644 --- a/drivers/pinctrl/pinctrl-aw9523.c +++ b/drivers/pinctrl/pinctrl-aw9523.c @@ -291,14 +291,14 @@ static int aw9523_pconf_set(struct pinctrl_dev *pctld= ev, unsigned int pin, unsigned int mask, val; int i, rc; =20 - mutex_lock(&awi->i2c_lock); + guard(mutex)(&awi->i2c_lock); for (i =3D 0; i < num_configs; i++) { param =3D pinconf_to_config_param(configs[i]); arg =3D pinconf_to_config_argument(configs[i]); =20 rc =3D aw9523_pcfg_param_to_reg(param, pin, ®); if (rc) - goto end; + return rc; =20 switch (param) { case PIN_CONFIG_LEVEL: @@ -307,7 +307,7 @@ static int aw9523_pconf_set(struct pinctrl_dev *pctldev= , unsigned int pin, AW9523_REG_CONF_STATE(pin), BIT(regbit), 0); if (rc) - goto end; + return rc; =20 /* Then, fall through to config output level */ fallthrough; @@ -323,10 +323,9 @@ static int aw9523_pconf_set(struct pinctrl_dev *pctlde= v, unsigned int pin, break; case PIN_CONFIG_DRIVE_OPEN_DRAIN: /* Open-Drain is supported only on port 0 */ - if (pin >=3D AW9523_PINS_PER_PORT) { - rc =3D -ENOTSUPP; - goto end; - } + if (pin >=3D AW9523_PINS_PER_PORT) + return -ENOTSUPP; + mask =3D AW9523_GCR_GPOMD_MASK; val =3D 0; break; @@ -341,17 +340,15 @@ static int aw9523_pconf_set(struct pinctrl_dev *pctld= ev, unsigned int pin, val =3D AW9523_GCR_GPOMD_MASK; break; default: - rc =3D -ENOTSUPP; - goto end; + return -ENOTSUPP; } =20 rc =3D regmap_update_bits(awi->regmap, reg, mask, val); if (rc) - goto end; + return rc; } -end: - mutex_unlock(&awi->i2c_lock); - return rc; + + return 0; } =20 static const struct pinconf_ops aw9523_pinconf_ops =3D { @@ -599,14 +596,14 @@ static int aw9523_gpio_get_multiple(struct gpio_chip = *chip, u8 m, state =3D 0; int ret; =20 - mutex_lock(&awi->i2c_lock); + guard(mutex)(&awi->i2c_lock); =20 /* Port 0 (gpio 0-7) */ m =3D *mask; if (m) { ret =3D _aw9523_gpio_get_multiple(awi, 0, &state, m); if (ret) - goto out; + return ret; } *bits =3D state; =20 @@ -616,13 +613,12 @@ static int aw9523_gpio_get_multiple(struct gpio_chip = *chip, ret =3D _aw9523_gpio_get_multiple(awi, AW9523_PINS_PER_PORT, &state, m); if (ret) - goto out; + return ret; =20 *bits |=3D (state << 8); } -out: - mutex_unlock(&awi->i2c_lock); - return ret; + + return 0; } =20 static int aw9523_gpio_set_multiple(struct gpio_chip *chip, @@ -632,30 +628,28 @@ static int aw9523_gpio_set_multiple(struct gpio_chip = *chip, struct aw9523 *awi =3D gpiochip_get_data(chip); u8 mask_lo, mask_hi, bits_lo, bits_hi; unsigned int reg; - int ret =3D 0; + int ret; =20 mask_lo =3D *mask; mask_hi =3D *mask >> 8; bits_lo =3D *bits; bits_hi =3D *bits >> 8; =20 - mutex_lock(&awi->i2c_lock); + guard(mutex)(&awi->i2c_lock); if (mask_hi) { reg =3D AW9523_REG_OUT_STATE(AW9523_PINS_PER_PORT); ret =3D regmap_write_bits(awi->regmap, reg, mask_hi, bits_hi); if (ret) - goto out; + return ret; } if (mask_lo) { reg =3D AW9523_REG_OUT_STATE(0); ret =3D regmap_write_bits(awi->regmap, reg, mask_lo, bits_lo); if (ret) - goto out; + return ret; } =20 -out: - mutex_unlock(&awi->i2c_lock); - return ret; + return 0; } =20 static int aw9523_gpio_set(struct gpio_chip *chip, unsigned int offset, @@ -695,16 +689,15 @@ static int aw9523_direction_output(struct gpio_chip *= chip, u8 regbit =3D offset % AW9523_PINS_PER_PORT; int ret; =20 - mutex_lock(&awi->i2c_lock); + guard(mutex)(&awi->i2c_lock); ret =3D regmap_update_bits(awi->regmap, AW9523_REG_OUT_STATE(offset), BIT(regbit), value ? BIT(regbit) : 0); if (ret) - goto end; + return ret; =20 ret =3D regmap_update_bits(awi->regmap, AW9523_REG_CONF_STATE(offset), BIT(regbit), 0); -end: - mutex_unlock(&awi->i2c_lock); + return ret; } =20 --=20 2.51.0 From nobody Sun Feb 8 15:30:32 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E599E30275E for ; Sun, 18 Jan 2026 18:10:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759819; cv=none; b=WoitrfMnW4Ngsesy7kzT2DA0P5Qg/i/JykzGiEk2VCLLpz220SbOc1f1Ilhj1GSkVhe/1ZJmk2tpAlVEYQRJDixeoxkvxfC8O6gdwm2tVqCR5BePU8wmxIhDw0wEVukAYhP9X2mofdv7nE9Vb0I2+56muOBbHq94TbzQ9nJCdDI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759819; c=relaxed/simple; bh=7TcfQldnwsgDeNj9THUL7ZJpvo8wBH6EB0ftex+EuCs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JuzqFc1X0WTX1208MtxMfURwpacUHbNepzeLuj1duoArw46UlRm6dDCmzcRDebW1ERrtxdJLURwF6/o7VnGRgRs7S46XWYfBDFadanNb2alB0KgWg1TkbkIpz0nod3/c3pPWX1YPlbYrIiNtti8uagkXgtFNwL4yfjGQh2UCUpc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=japKNcnf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cfPXpjpG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="japKNcnf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cfPXpjpG" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60IBH9cP2445449 for ; Sun, 18 Jan 2026 18:10:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= N8rDVtwaqFFOKGAdA8c98jUQvXsuqYrjM/OKm05D9ak=; b=japKNcnfAcEprVtV 0bUawGTTXZfbthfW6B3TsG8SOrANCsLkg7+/n7DXtuSnDQSKAnz3usFRiyGjxOj2 +tPoYHPy0SDVDav2D8OMjbHMnyAIRUOJCc6YT7Ti8/Jsu0oJRI9rek6MgZf2St3c heEzwj4GUyubAeqSY6lo5q+3kGDRU7stWSWOAZ2olHVwkhtTkyTRJpQ1rr+wzOHB +wVhVSdyTbXGW4rCcE6MUCDGhhR16OCgC2i5uhHVrodFaAum1yFa5gvt3ks8eXrZ m2q+iBAO2sdTs4NNckCqDI+IQx8+BEUWCDxfo5lF8Ut1fbWYDdG0O/PFOwgxIs4y 0wCOwg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br2ke2rb7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 18 Jan 2026 18:10:16 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c6a5bc8c43so755695085a.2 for ; Sun, 18 Jan 2026 10:10:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768759816; x=1769364616; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=N8rDVtwaqFFOKGAdA8c98jUQvXsuqYrjM/OKm05D9ak=; b=cfPXpjpGOhSdEeMu4Wu/2L3sNveiCmvBuEO7ved61PodNu2FcL6QHq8sgC59SlEjFA vfClxH3Fo/dmvwDH7+WBpk05iVMxj80Qg8TXQPohjgRhSgTO2/4X1OpuU07Tv2DOlmpv xlruC0PsDc6bz31pM8KoO0lTTEfJW8DKlkPUTPp4HNT63UUoPl0WUizPRJDzvNF43nuL jiEBUNLRGFCZIROnsyXFVz08YhZblk3Ny3oGnKa/PZTs21oGNBcGDxnRLq2EI78egbXV K3o7N1tsIkh5CHx3HSpiJzCx1IekLQZtdqoi7Alnn0FPtWlqs9PZLAQtWwx77pV4bv3d 6KVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768759816; x=1769364616; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=N8rDVtwaqFFOKGAdA8c98jUQvXsuqYrjM/OKm05D9ak=; b=tTT8eV0pE/+hIeN8QiAJ5lDGU+nV3P7sec2F+CGpCNvuXU8rzHRDkNf4vh570+xXHT riSZ8naSXmByRd/HEFSB3ip1UtDXLJGweTGgy4ewiD7f515rzBXXx3x2fH8+G0T98MZJ tBodvYh3GeQPASLadVyuuyOEwEYSK/5XQEM1S4jiMMvpKRVA9cBkGNcnlZSw5HKazGM2 VjjCKffFPDAC3b6MCSOiGTxZh2Mp+eA0r0p2zZ6GzsUojzmAVI5RCElXZ19YljRmtZvB u1Po20DA8ZCNU0UUBUUVH1DH/0otbxfDtXVVUyG4/5QFRSRZWEhiR9iWnUKoYEA9iZxy T4ug== X-Forwarded-Encrypted: i=1; AJvYcCVOkTRSFp/s9jGg8jIvkgfzcXH1LdQePsseZDrA+4OvtirQQb9Qnxkz2+MEigXx9Ralgjrcqvv4bBkzOTI=@vger.kernel.org X-Gm-Message-State: AOJu0YxBKj62R/AmiQ0x2aFxq9M6LcJlfttckr/1nOVleAtR8BzU2k/0 VahQ6ATM+S8VujosK7el+V7ngbtqxNVfaAcIlQQ0A28W0wWe9ZKvU2QBYxR+KtVFcFtPF47dEIz Lali91Z1bodxI5xSxFQvqt09FsxZgFdLkqSA287z74gphMqRVJUB8y/Xt9fIZGjsChhg= X-Gm-Gg: AY/fxX7tPuJ79pPstafZpjW0Po0ntizR3TIHf4HWWPE4/AvRTEib3lH8WSeNPVdZj22 V/qui0AcsHkM+/+AtxxZRmr49U4+eKhxLqLmYIdbYAUmrebSmvwJPorfryokBfJgL4nx+YYm/IC yZfjMULCv9+chXdktMwkrQo6/YLNF2ZMgxqKK0JEFhaqfCDITvfiagzs9eX5QI6yw/Z0rEfOo/I hPp8f7F1ZtLUS8mogfgk6eG940oUUSORXQRM1IybQE3M8N6RSZxvO3GTxjfVbQlWeReuzmTq+1Y 65Nsg32xbG742vuIUzYxPvMENvmDKiJ4PhLu49HkYvs8XyERKfIkOmG44R86Z8Yx4HqmA7Tt/lB 4Aq1RVGJtBk4lFomIs5ciD74HbnyBeG0b5w== X-Received: by 2002:a05:620a:3942:b0:8b2:dafb:9089 with SMTP id af79cd13be357-8c6a67899b0mr1275483785a.67.1768759816083; Sun, 18 Jan 2026 10:10:16 -0800 (PST) X-Received: by 2002:a05:620a:3942:b0:8b2:dafb:9089 with SMTP id af79cd13be357-8c6a67899b0mr1275472285a.67.1768759814840; Sun, 18 Jan 2026 10:10:14 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801fe44b37sm62162085e9.12.2026.01.18.10.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 10:10:14 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 18 Jan 2026 19:09:29 +0100 Subject: [PATCH v2 06/11] pinctrl: microchip-sgpio: Simplify locking with guard() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260118-pinctrl-cleanup-guard-v2-6-bd36f681bdc0@oss.qualcomm.com> References: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> In-Reply-To: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1197; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=7TcfQldnwsgDeNj9THUL7ZJpvo8wBH6EB0ftex+EuCs=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpbSHzNyyJB2/5YcDkWVD78wo4fivaLa92BnhNE zEyQbnq1T+JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaW0h8wAKCRDBN2bmhouD 1/+ZD/9dLR0GeZEUoMpu1fyeS7gbRrh/E1fAhv5P7K1Wy6+T4QuZh0GJyRvYYNMop2bEXE+o/zg m0aJF5TNvzHCDEzDGh3hTWMW6zhEfdRW1x+41NwBiV+jUGVIHWeFXu64AMbTDIAep3SiKsUu5ur USeXISCYy7enjRAKdOU7c0fmdDnDnSSlMVF202nX4sHTfroJF4BlimVIpWz9/ILOSA18ewjMxl0 PaymU0l2amlmpZmIpE3edSB7zCVqvIGVyl1rD1g1v3Slmt66Wa0oJub3si4o9gWtDj/1mE2HGW+ YwsGcKQ0cx3eU9jda6IccRxjIrd1gwgf91zoZT6MdePaW7LZKOUWQ3TuPyA9SppV+7mNXJ6g7fg 5iv4i/aSKv878Z/9BjfRec+iDlhMHFlE1U/0TNLeQEiSePRFjzQkBZW/VD8h12mdLZyJ25RIeIq zcvbjxNdMPYNXX6zyo9KpdnIGRzqPn2eow9j7Ty/MvWaRS2UaQldkFjErgbKNlYyLyF4xueV36m JPYBzgnsAenS6V9TUf7bUvkG/jLLhifIhTXucaqJudGLGgqioXPok09zN5scbaryZOnU3poSZa3 r/njGSPDgsJ/i0ZuO82abROFWzVcuRbleDiqZ1V1y6SeGIH2EV1SlND3ueBORj8RHgxVja6hguI G262GYY0ih+1KCQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE4MDE1OSBTYWx0ZWRfX5SDFcMm27LiT m8kPNjqG59qYxcnrhlPHcQjMiidcgrJA4UzNhLSagdb1gpzYJNWGD5pRr4wi8TksRdysrwugc18 2XIvVs/N+qzqyZsglVxLtn6ujaDpj4QPSWtk3DolxMbyw4w7sS6eVhxlt3is7KqV+AX06YKj02S 2zri1Vdygkg7DKbIYiWetTsx5Kn+69ayFHvDMuV1WoL4cugol64i8/caatPk5f91sY/rQL/v+hu Qegkp90zwCiW9RStLNHIpsF5KFQ2nBCXOnzN0dqBhjWSU02ojABMtndgp10fBQpI/0MURDF5rZu j1Z5KG9QuGJYLyTPj9ZSC8k6dBOcwl7Akj5Invno2Ynt4tabkDNx3CXCTf1MkPHpGU0ig3l1onk QcAGDRFqRQ11hLJUA+PcffNJHwaP/YX3FpNyVwOe0Vky+ltQ4jPdLx2U3U6cN3OghQuIbv/GeqO iefQIR7ylhl89J4aJsw== X-Proofpoint-GUID: 40icBxLmZDcqXJqOsxRCnAnE-I3sbne_ X-Authority-Analysis: v=2.4 cv=EJgLElZC c=1 sm=1 tr=0 ts=696d2208 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=6VTnscBjb5kX48BWP-sA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: 40icBxLmZDcqXJqOsxRCnAnE-I3sbne_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-17_03,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 priorityscore=1501 malwarescore=0 spamscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601180159 Simplify error handling (less gotos) over locks with guard(). Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/pinctrl-microchip-sgpio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pi= nctrl-microchip-sgpio.c index b6363f3cdce9..7a6cb5f502b0 100644 --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c @@ -264,19 +264,17 @@ static int sgpio_single_shot(struct sgpio_priv *priv) * setting. * After the manual burst, reenable the auto repeat mode again. */ - mutex_lock(&priv->poll_lock); + guard(mutex)(&priv->poll_lock); ret =3D regmap_update_bits(priv->regs, addr, single_shot | auto_repeat, single_shot); if (ret) - goto out; + return ret; =20 ret =3D regmap_read_poll_timeout(priv->regs, addr, ctrl, !(ctrl & single_shot), 100, 60000); =20 /* reenable auto repeat mode even if there was an error */ ret2 =3D regmap_update_bits(priv->regs, addr, auto_repeat, auto_repeat); -out: - mutex_unlock(&priv->poll_lock); =20 return ret ?: ret2; } --=20 2.51.0 From nobody Sun Feb 8 15:30:32 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC0593033CA for ; Sun, 18 Jan 2026 18:10:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759823; cv=none; b=ECKOD40+sudTTzCMyfT+97VC5sVcEcK4ajGKPzte1M14Y5RoQx5MbSZy4mpawSo/H9XlFw/jplMFfYZTZlElSSZCNOdzPZG5oJ2y4JkWHg+hbdANNarBHtN62RImpEj1OIBBsY5a9E86nsXJizkFP+pp74KdUKHYpNZ2R48zqwQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759823; c=relaxed/simple; bh=adtV57CgOwnY60Si6YEP4k65ve4WmCO5x4rzf1ZqeaM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Psn0O5hfoDvkvw6voQLzPKnd7UUvKC7Q+/dPsXu2IKBexccdulcnQg1G52ztUb7t2A98zs1P7Ix2OfapywvlR0LWKFgf7An1zJNGIMZmFIqD85XRDNhEoW8NSJ5/YzxWjavUhF3Az7qLjygPTyEv3Ofig9IUQC/Ywt8RnlPsK/Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FLHmcbh8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QZOGH5Z2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FLHmcbh8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QZOGH5Z2" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60IBUhEI3465832 for ; Sun, 18 Jan 2026 18:10:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VMrQrzLzDincZEvSf3IY0LWe8Yq0vnY3RbOd9IgAleU=; b=FLHmcbh8VeT0Xx7u ocCWXxIuvjB9tBx5LxiCDtIBDccJU379nP+UmbRcoyBcr+3edNEdpueWK9J+M9dg On/6tG/zQrLm8kIshV6N+0lPrvBMlNib7FFNeOZ8S06q3klUrsezMEtoWQSE7x8a iEZVX+2oCVORqUTkeyErZZCtqx37t6TybdAYQxnbiueXwqeFCCkNWbDhB/sk9zJO wyGw/a/G1LG/16y68VMQZIcKCntDh2BsmDjLvW1Mt+2eHXhh9/2Fc79ypv3cnxJq yymNkMmzrvQoaprecP+D3OwcUzhJd+k9MUIKezJvfuCKhbJaAMB2BIcNG0+2rc9i yD93uQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br1e5jygu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 18 Jan 2026 18:10:18 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c5297cfe68so689276185a.0 for ; Sun, 18 Jan 2026 10:10:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768759818; x=1769364618; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VMrQrzLzDincZEvSf3IY0LWe8Yq0vnY3RbOd9IgAleU=; b=QZOGH5Z2uP0IlEOwDzLWQb0+GAkA/MvEwJ10alBhCv9IWIl83kQpZJVlZoITq5/UGD I8alMcOMWB31mRb4C5WT3WEPlFZNmjYmQ6e8mLGYIs0qXgnlTZkCndy60SHLbSXM0hkm bPIAaQv0ZsChjoRL5xn26zh/iGD4OYa1c9N2tZbhRTBZ9rSVBt+6kgMU+zOSEM8zp5yg vuRAOBvkRTTeng8LLkmJY+M0Ad0dxUDBvCylEnB3H+niJLYjP74+TRZM05PntmG5cVKK L1OHuUnH9c9ld9N9I/T1QAcDQMH31pwewoy0ECwaPVz1qmP/PBW+7ywJhJkVKBQKnhpu j4gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768759818; x=1769364618; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VMrQrzLzDincZEvSf3IY0LWe8Yq0vnY3RbOd9IgAleU=; b=i6FnFoW1W8gd9rg+GyiFDoX1QIWFObUxAqbr9WJ2MT8HDkHXdkAO484dsI4tXvIeqX +iTd20BgS6M3hO8GBAqNIgxnVPZ3yTstS1wDv8ZVImFlYJMWUrgrdKKXHiRmynpFFWan pwBp7vy7R6G5om0zpVW84m96i7N3dDG3QZEugDZI8Ijoy8kcGQ7h1kKIvZaGfcSuk10M 9jWI4SpLYLTrIgThvL3bkrZdFG59j8MEUEDIts50D8yxCoUYjrdYdbBlKBYJ/QjxCdKc INqoVBa4Lxr5ilb+Cjt3LbW/xwpYe9m+7BTaDeJ3cIsviMl5zFduY5hsZK9yjymk2QNy jzFw== X-Forwarded-Encrypted: i=1; AJvYcCVHHggGuZD0VmftnBt2CTEqOswXXB3bIJqGyd078jacfz/mPqreI2EBYm2JQ+xOSNF2lx0EmriC9hteOCE=@vger.kernel.org X-Gm-Message-State: AOJu0YybrH28tKI3majPlQZkIrGngO444D9QRflw1LgkhLAMFvIwsGa5 ch6FVHPIXByaLYrZZU/2wL5H8RGiaB5ypaaNi5hhTD6SfCOaniuzEbYRjzCE6dWx93qTFu/HnE4 YSYoG97eBF9zTKgjKHsHkiv0vUvKHArgbcIgZkfAB7CEFBa0Gvu0cjYeEE3grTPEZINc= X-Gm-Gg: AY/fxX44aEN4nljNlm+8Swga/ioI0i5ritfNy58rpQbqaLiDgM0qblFFypttdkCuUqe TKGa3Iofxm/av2hJs90tzi+U13RAUG8Amiqif07s8JsTV0vgxIQr7HfaKS5ZpIfVQEvcH8ztTCa H0CTtu/pDHfs+Dh2vowZbZJl5OuQYGdgaqCWxG/sYKAsUZZ7ilfxr4d+u8RvdM+zLMxpbNIfiLo yBRAq8xvyklB/IgxM9WsgqNaAnaU+Vy7pLf6Ew5m8YOlc8geBfOeGdBYBwzeGVrnLlYS42GymBF M9i3of10EhXdVtbJ59bSlI4uppHHtDdd93a7Ii7aWrxS8JmYG5iheiE+XMFkZq2039T5Ry2QDhN 6tj4wSwrgTmR6+3a/wgkHXmnnQyDqHKB3og== X-Received: by 2002:a05:620a:4543:b0:8c5:af6:3efa with SMTP id af79cd13be357-8c6a67bcd01mr1262132785a.86.1768759818324; Sun, 18 Jan 2026 10:10:18 -0800 (PST) X-Received: by 2002:a05:620a:4543:b0:8c5:af6:3efa with SMTP id af79cd13be357-8c6a67bcd01mr1262128485a.86.1768759817837; Sun, 18 Jan 2026 10:10:17 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801fe44b37sm62162085e9.12.2026.01.18.10.10.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 10:10:17 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 18 Jan 2026 19:09:30 +0100 Subject: [PATCH v2 07/11] pinctrl: tb10x: Simplify locking with guard() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260118-pinctrl-cleanup-guard-v2-7-bd36f681bdc0@oss.qualcomm.com> References: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> In-Reply-To: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2163; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=adtV57CgOwnY60Si6YEP4k65ve4WmCO5x4rzf1ZqeaM=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpbSH0P3baB5JzE0xj4EquivvpaBBrqdpm6amOt juDbwiBC2KJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaW0h9AAKCRDBN2bmhouD 18o1EACUQyCgNzHZcDtTGGjP0XngZqctytCl/BhtXdiN2scGWH47PeJ1EbokGmcu35oOMeMoF/P Ai/yJjffW+dvyctYiUkUjdX8qhiC2jEMnBnR8HZEw07kz1ropOT3VtM9UNzcOP4VVa6XiU986gx +A9IxfYMZgbHYem1kw5uWedXNzll31yR6NXl+qm3YmcapiaWrXfhMQr5W3+Y014NvLqFh0h0nY+ VxNPqKS0K7Oc6imDFiXRU50DUa2PRBddUY72TCkg8IbNE9LNnC+IouRZfrpjgzU+o1sRF5zlhhE I42rY1W2TwyfNm25FScOIOwekUr/tt7XHK3Q3KNa7vNG+uurb06yeOS0NW5zEIh+fH0e0tevRbL 5txnHIVmMgsVP9qzzc3Br1lDZbc52FUcLV7vvC9rMpyHoyONur5eBHMB2UKz3Xqa2NBtZPpWsFo wo5+VFlpkkdh5y2iBoS1iDvXQLvtiqBpaHj6Suu/4MiSLX+PkV0aId7KrTqfcC2PmJjOYVi5Q9Z vShD+pW5GDt3E9qbXvJRxs0a8bvIwVXqG8pg4P9bsL9v+rGt5VbCvR6FyNIf67jL9QRcUvEn4Px 54ALdRQJBLaZ4OkpCq7oTGr0tO4yjqNJDKYKdrn03h/zNzPbiXClpfTtiL9qzncdjmoS9IgEOV/ vTudhlAhqE6ovOA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE4MDE1OSBTYWx0ZWRfX7no+ZEeaWb9B 3J0fAE1RDc/I9x9ayJe3W1rjKHi0KCxbdzqMU7tbNLH5UMR1c5nzy904/g0ztlCTYRzqlP5nS+9 EwTpEEHXfu116HlM9m4rZZU8u3qAA/cDt4A5hZfsne3pGS6HMvNf/tt5iobHyvxEV6kQBDYodRn euNblBDmMeQcyHTgb9gx9L2aVXinqWLAwlsGRukWrWsm2ZExK010D/5/Z78Qm48Y8asTqDG98vA uJBZGei9mO9+ohlifuJzJVWKs7lbF42FPHEXcqEkzNgxwliMCivciQpX5U2bpmu6jlhvuxYim8H nFsomXkDpJU6xB7vImN7DStHTy7AOAXSbOw58I1JM0EiI0aM8e8gItmZT70gbLRL8sbvEqgWIQ0 V4D+nAxZ2y5pjbGSr4ETBKVc98yKi/sErGoY9cmBcU13QqCQmpRKrdZKZIXU8Bg1gEaVoAYn/bC AlXTmdE/JioXxy4BH0A== X-Proofpoint-GUID: E8isTLgiMAT3oFV-xMD2-rKOF2gZ84uk X-Authority-Analysis: v=2.4 cv=U5yfzOru c=1 sm=1 tr=0 ts=696d220a cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=fB2tTgKqvhDdEbG57mcA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: E8isTLgiMAT3oFV-xMD2-rKOF2gZ84uk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-17_03,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 spamscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601180159 Simplify error handling (less code in error case) over locks with guard(). Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/pinctrl-tb10x.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/pinctrl/pinctrl-tb10x.c b/drivers/pinctrl/pinctrl-tb10= x.c index 129fa51d13b1..3f581404a9b9 100644 --- a/drivers/pinctrl/pinctrl-tb10x.c +++ b/drivers/pinctrl/pinctrl-tb10x.c @@ -607,7 +607,7 @@ static int tb10x_gpio_request_enable(struct pinctrl_dev= *pctl, int muxmode =3D -1; int i; =20 - mutex_lock(&state->mutex); + guard(mutex)(&state->mutex); =20 /* * Figure out to which port the requested GPIO belongs and how to @@ -642,7 +642,6 @@ static int tb10x_gpio_request_enable(struct pinctrl_dev= *pctl, * Error: The requested pin is already * used for something else. */ - mutex_unlock(&state->mutex); return -EBUSY; } break; @@ -667,8 +666,6 @@ static int tb10x_gpio_request_enable(struct pinctrl_dev= *pctl, if (muxport >=3D 0) tb10x_pinctrl_set_config(state, muxport, muxmode); =20 - mutex_unlock(&state->mutex); - return 0; } =20 @@ -695,34 +692,28 @@ static int tb10x_pctl_set_mux(struct pinctrl_dev *pct= l, if (grp->port < 0) return 0; =20 - mutex_lock(&state->mutex); + guard(mutex)(&state->mutex); =20 /* * Check if the requested function is compatible with previously * requested functions. */ if (state->ports[grp->port].count - && (state->ports[grp->port].mode !=3D grp->mode)) { - mutex_unlock(&state->mutex); + && (state->ports[grp->port].mode !=3D grp->mode)) return -EBUSY; - } =20 /* * Check if the requested function is compatible with previously * requested GPIOs. */ for (i =3D 0; i < grp->pincnt; i++) - if (test_bit(grp->pins[i], state->gpios)) { - mutex_unlock(&state->mutex); + if (test_bit(grp->pins[i], state->gpios)) return -EBUSY; - } =20 tb10x_pinctrl_set_config(state, grp->port, grp->mode); =20 state->ports[grp->port].count++; =20 - mutex_unlock(&state->mutex); - return 0; } =20 --=20 2.51.0 From nobody Sun Feb 8 15:30:32 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE9D03043A4 for ; Sun, 18 Jan 2026 18:10:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759824; cv=none; b=NLQriNh6yiME7J0jGnwpeeL2xQypyYHwVrAicuQ0c9dlSypsORRlcQO9Iv/TZhloqsCywZYwqNw5sy3uzyDd51hQVm8boUCmJgyl7q5lB3QoAAnpF8CyQs/sYCBqTLfna2jq0EGLW2vsWrn0NSye1wQHTQkTd+NaqDWSIkSrftY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759824; c=relaxed/simple; bh=zwqMNlVzyh5eJuxel4QxILb1w1jSHcI3ic8DyOkYYFI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EOVZ4s25NZwk6Bl7069rtcujmKcQ+0WOQ5fxq+XHYLIkdUt1GDb+T3RsfqxhfHr9HBxoDAJjXAt2Skr0QMi8wAno6bD7lANzVlGIjebvQFEoXHh//uC4LNNckU5npjy+FHXzc/K0X+g+ESNZ42JCsOJLWhmnYV+7lrgrZYxXpCY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pgxM7ktr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dfCz9jTD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pgxM7ktr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dfCz9jTD" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60IBX6pr2016795 for ; Sun, 18 Jan 2026 18:10:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bq3v2rgJLKiDEOsLmXv7bz0bBd5gBl7Lr8FAESkXElU=; b=pgxM7ktrM3C6JNHs m+dptkkX0Qv+/1wvRYYLqNk06hFxp42qnRNeX85OydKUK3DfNxmAU/+bhQnSiBE9 5jFqrFFliVJbtloeqx2ulbLwmsj6LGPdxK8mJ+AOtKFLJ7/FTvUM3lulmSMjMd7z jWAXVmGvZ0nJaOhf9+EEzpdpwW0K7ncgLn6+kabCTPUEQ0HRjC4remHm5WAf3orp HTpFcUGejLERS01PkijD3DH0btzRlLQ3/O0KkA2D5XV3RZav6SLqyQ/JX39LEy2v IApUg/r+kFOm+p4BLIsQHdC+oVN2T7Q62++87p+3q1J62nfSHmj2FUGeDuinLNoy mEignw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bqysjb51b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 18 Jan 2026 18:10:20 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c52fd4cca2so937724485a.3 for ; Sun, 18 Jan 2026 10:10:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768759820; x=1769364620; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bq3v2rgJLKiDEOsLmXv7bz0bBd5gBl7Lr8FAESkXElU=; b=dfCz9jTDLYTHZLXPuZbKhmHyok73um4QNjkgoxn1GwDCr3b9wApgoPud8NXCMG/7aD lSG7lKi1T9pv6aisnx4AJ3lmyIr8d4VpYXOCGXBmHizqRqwtdTyE5OjUJqpKtFABcvRK lmetSC0BOumxz//awIJMy8w884ZOcKAdagEiNU/U8yMvZlvXIR8sbMRdfY0rl69m/EVP yr5D5WmfE7+aMo/iwtcnEYSYp7TtXPpZo4IpLYb26L5BNNIpcNa8BYp52DLSSoyNcJpe a8qI1zRMjSeBluPI8l9XsoTZe7rW4Rq7LjidNA+i1Rwcql0E2ejPTClN+1vvAEpPO0YH 3A3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768759820; x=1769364620; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bq3v2rgJLKiDEOsLmXv7bz0bBd5gBl7Lr8FAESkXElU=; b=VVJ9YNzFRnan96c1jxXh4ImQpebw7+P4AtW1bFE4enukxEyOgOlDt3y+VCfWVLazwm FWVDZARILbF+t+FDxK2XS8LxGzWmzCFS6m5yofDh1k6L6kFKEBa5IB5S16Z7wB8E9pND FNH2EoTfZGe2dsqEn/k91QKmULHu9slIhI3S35UnFdrLaDPG1H5bbheUbjRMM5erMQot Y1Hm/03D2K9NywKi8OCGhAxii/+EG7Z+lWE1ma2eEdqEbQ50/6pOKvOG3KKEjm1+pclK kOhQKWMOJWgcExA3onfoaaYUa8WqoU2IEIGKkjhD4NSbSEmKeMwBj9n0jho2uxVBcy4O /xWQ== X-Forwarded-Encrypted: i=1; AJvYcCWHihZeWNAtah24/LJukUcE7i9podltue9CkSs2Yn8GUL4aLjE/UE1+QBjTt/oFihDsnKQx3p1VkwWXtZQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwGpv1eiiZ2WRZXy7DakfAhg1fZbox+6rQaJGm48apzQH2i07tB ETEef8RPkU2l7yoq9+SnNDKuJH99cHGIZRIJo6WS4uyjtPP2ZK1NLNVrqMV/02zCMByDDG4T5KC QCkSbTvPZuSNQEWcgCSEqMM7ouLoD8FDrYnvcIRBB6m4IU8YjMd4blEgDflEIHfhnFuY= X-Gm-Gg: AY/fxX4YfeSyQaYdivSbTSfl7yAqCqnxPaKX/9kISkpPOseCdD5fbqvEi5zAkKJWm6M K3P1F8osoKCvBTBKlQEOlaN5R1mrEVskpGOBkYN0meFuHvXnByyMwcOi6DOvsiweW9iJy1ADToR 0FT3QQmqN/NHf56LkWb470lf7wpTBaG4iqdcpE/cErOpyE+AEOasCA+HHUnl6uEKi8JJwf/1NX/ t+hxWyAjU7yZ9AGzK5FBvMKo2Ro5P23Tc5eEv51h5bJ+QZaqa3xLlafZRUW2YJqjA5vUe9tmZkE bdcRsRJ7NOn0FnZvwM/FolIO6vcQ4XwUA1QI11mLY9ZWp8dfRBPVBxE6xZdrpnseNxRcJcYgIIV FH4EbmUOntQF0itxZeEJ2HEzQPwrDCrdklw== X-Received: by 2002:a05:620a:404d:b0:892:ca0f:fc21 with SMTP id af79cd13be357-8c6a671c788mr1272746685a.40.1768759820190; Sun, 18 Jan 2026 10:10:20 -0800 (PST) X-Received: by 2002:a05:620a:404d:b0:892:ca0f:fc21 with SMTP id af79cd13be357-8c6a671c788mr1272743485a.40.1768759819810; Sun, 18 Jan 2026 10:10:19 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801fe44b37sm62162085e9.12.2026.01.18.10.10.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 10:10:19 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 18 Jan 2026 19:09:31 +0100 Subject: [PATCH v2 08/11] pinctrl: tegra-xusb: Return void in padctl enable/disable functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260118-pinctrl-cleanup-guard-v2-8-bd36f681bdc0@oss.qualcomm.com> References: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> In-Reply-To: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Thierry Reding , Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1984; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=zwqMNlVzyh5eJuxel4QxILb1w1jSHcI3ic8DyOkYYFI=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpbSH023tp+pR8RcdVkgtrXrXPyyvJCiTJRQMKg Lvm/TsQPiKJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaW0h9AAKCRDBN2bmhouD 1wwNEACGkGa4R5iPxfciaNNGa26cpFVFOKNoQQ/zlFKjd9KdLdP3tK0fWadkQ6Hzg8vIuOQ0s/N v7S9aLNuDw74JQ3Y+27cgzgg2n/5allaBhi7p504JFNtRp9VuczJS9/aQzkHBhMBYb4qHa0hbMF 5B40sNT0sLeOazx6g5oH7IJuwLknyQHZ5fbOnNm3S+Rhbjt4X0zszXGk6S5rQ6TaJx8wStEz2hJ +lC51VjrnH7jRwQZzX+zzilyHJ/l+HI120tg6qO3suf4O0SY/DtDfqx147BUPRdV/wmxLJ57ggf 0TgH/14e1z7TwcuN6zs0miiAII0m2HYe/etu+gBd8fiBtv+uEcW1fdvtFo6xpRvM0cB+ToJ3epW J+WAhktebIvSeAt0KWbj0CP31V40a5j9h7uHmWaU7Hev8XkKhQb4BD1OrE9+7qS2Y9ZWqEa/b5O IHPpVLfe7pkjnOiOiy8BEgRkXThCYu6o3CyTClOaQRKzaR+YtzAPb+KL5GNuyB0Sj6wmRyqlRj0 1cOaOus9EEY6i/l6k7smRdmdWfEuQRoG9OOvnXlrwxjA+kZXKGddz4ythESHN77jK5FCbFlL9gl yc4UG9zGjHjhRMHycAqi6bFpO7IHu1HO61URwtcZ3WxZe89GryobQ4tMqNi6WqrOhlLfDy6NcCX iSdKZI6W2hyvuow== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=CaAFJbrl c=1 sm=1 tr=0 ts=696d220c cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Ikd4Dj_1AAAA:8 a=EUspDBNiAAAA:8 a=Ed5BEzkqmhObfCaRRI0A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: 96FMS-tOnffnIXgvUZ0NlN8DZ2Ww9DPJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE4MDE2MCBTYWx0ZWRfXy7JiqtAZMqzA xCyn1xP0znb10rPSg+VFYoJswSVj25Dwlg09CWIe2YJbR3YuoegT8lvJAd3Bw8/HTSC8j+h0dpC zp+zJ66kqJrZlNXkQaG149xH6nfHn4eHpvtWZpO38BztOe6rVevO4ssVzmWR8ohY+Xxn8U6HhRH 4AWasCqg4q411rmXl9rTlOYr2vCiUNSwbOrvNWiMDjWmJxzkVltTh1Ss5XiaYNjhhLFULv7z/rp /YM0xybrX8C3m366JIluJapeNsl35nCIu26bVDK+D56BCB7LRCIiiWWo34+Vyk2bwIVvm7hrzPu RRuuAhT/uQS0BHtlsm21371xkWrYerMTcII5X/MlQ5WcOsRMJTgUgKGb4xhy0DA9CD/Y9wV8tT4 Ko77a6d9Mj884jtmdQd0M6cFxn9jOrBiqwSN//ZhIEFr6YOIcmmTBKmdOqfm8dLM62J84FvcwcL W9AbIvbsRzBuyJY+IwQ== X-Proofpoint-GUID: 96FMS-tOnffnIXgvUZ0NlN8DZ2Ww9DPJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-17_03,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601180160 Make the padctl functions a bit simpler by returning void instead of always '0'. The callers - phy init/exit - still need to return 0, but these are smaller function without if/branching. Acked-by: Thierry Reding Reviewed-by: Jon Hunter Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c b/drivers/pinctrl/t= egra/pinctrl-tegra-xusb.c index 49c5edeba87f..34a373f7e04d 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c @@ -474,7 +474,7 @@ static const struct pinconf_ops tegra_xusb_padctl_pinco= nf_ops =3D { #endif }; =20 -static int tegra_xusb_padctl_enable(struct tegra_xusb_padctl *padctl) +static void tegra_xusb_padctl_enable(struct tegra_xusb_padctl *padctl) { u32 value; =20 @@ -501,10 +501,9 @@ static int tegra_xusb_padctl_enable(struct tegra_xusb_= padctl *padctl) =20 out: mutex_unlock(&padctl->lock); - return 0; } =20 -static int tegra_xusb_padctl_disable(struct tegra_xusb_padctl *padctl) +static void tegra_xusb_padctl_disable(struct tegra_xusb_padctl *padctl) { u32 value; =20 @@ -534,21 +533,24 @@ static int tegra_xusb_padctl_disable(struct tegra_xus= b_padctl *padctl) =20 out: mutex_unlock(&padctl->lock); - return 0; } =20 static int tegra_xusb_phy_init(struct phy *phy) { struct tegra_xusb_padctl *padctl =3D phy_get_drvdata(phy); =20 - return tegra_xusb_padctl_enable(padctl); + tegra_xusb_padctl_enable(padctl); + + return 0; } =20 static int tegra_xusb_phy_exit(struct phy *phy) { struct tegra_xusb_padctl *padctl =3D phy_get_drvdata(phy); =20 - return tegra_xusb_padctl_disable(padctl); + tegra_xusb_padctl_disable(padctl); + + return 0; } =20 static int pcie_phy_power_on(struct phy *phy) --=20 2.51.0 From nobody Sun Feb 8 15:30:32 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9478C23EA81 for ; Sun, 18 Jan 2026 18:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759826; cv=none; b=uH5W09mtbf041yKzH0+yVzZ0JKLVSgX0+UckBtt8jACZRddLB57PkMwhD8jiVs3Uh8dFovHmJf0e7UzD8yTx/eCd0vwGlp4w7nYmiD/41WC4bi/immuWYnUEhBaLq6d610Snz1avVN7Z/2WD4piPT93200OuOJrVMTy/fLHv/pA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759826; c=relaxed/simple; bh=FLZSR96VBkRrzhSP3/2OgTuUg9DxmOscsEadYFKjqPY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jHEnWxq3UY1tANvtjYZnuPmQdmsTlq/Z9nWCrZfHXmuYBqN75pUj4NyJhvdvUVYRmyzddGiE6iTgv9bLs117KXiIlOmerOHlcIytW3dE8y3IRLbbP7rJwcsErhUjOWvbG1lgKSiLZ4YlpyEIClhYUvJfKq6jsFTzrMuafP9/Zm4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oRpcLxOS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UNr9ICmN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oRpcLxOS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UNr9ICmN" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60IEavF9219372 for ; Sun, 18 Jan 2026 18:10:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RvEwfJnzPB9SKmFVJEQfF/6xbtK/stkjY8FP5vkfIg8=; b=oRpcLxOSIgnQcj/G yg8Hyar8Un3q7Ovi/gBJnj3R+oluHlUQFC1DHjF2h+VTk000kvwcmxlLWX/zOVUh w9fRrrwLuCluyalYVdPb3sZJZpCc/r/UNmi6zxL129lxgfQnpDDPVroP9f/ethIv c70ogb4hngTCCYaYJiWKzGJZLPlO4m8JtHNoJSa1MkMfEu7IoaWDAtkf6sJGjaRA ZsHfxqXTxLw9yGMPfIhg8nSFt/MiFAFZ+zVDeEuz121NLy0+IiSSFsIOgTKm5U4b S1oRRECpIpwXLg7Zc4h059rZyp9AmllxgFuqiGNWeKo/C6u4MPf7QevOiUl755ST oqvn7Q== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br36dars7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 18 Jan 2026 18:10:23 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8c52c921886so479321785a.2 for ; Sun, 18 Jan 2026 10:10:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768759822; x=1769364622; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RvEwfJnzPB9SKmFVJEQfF/6xbtK/stkjY8FP5vkfIg8=; b=UNr9ICmN/MxFBIybOtTRo3IjX+44iUMXqIzx9UOXBgJO6mHNDPlk3HcLt95rruKkXN Yw79/kUFACRwlVyN9L4Z2W+P5Z7ph7V8aEM/bPyiKrYHDxi+VzpeiUJGjusq4JFbUa4c /Wbz9ipWF1M58CkzxF0MlLamsGjWm0BLASKpBd9/SobLaOL52YmaG9A0WR20BK0kR4Q2 xIPt1QAp6cwpyU5EqM7ZKEGxc7p4O6OxrNYS6VlQe2tCA4fRh4xc/Oxh70TjnGgzwnfT DzT3x2ye1mFSELo4xYlNmitr3vkbfHpjz46y0KnifiZ6J360nTj8vFAkrDz0A/c4hpGP YQuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768759822; x=1769364622; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=RvEwfJnzPB9SKmFVJEQfF/6xbtK/stkjY8FP5vkfIg8=; b=K55zKhA7aqcQtsH0nKMdl8vkyCCg9elaypOxTjEHh/2euTZKOIp8rBEEXLyTd0I+zI A0Ly8YIBS6MLu7AynqSNjw3LmmYeEbG2fq2ONEeNy0lVsDqBRqsgH2M5Do28v5fPQDom rjgYKjK9XEDMJIHrmPKrBYZjJwzl/1j6SPOEwih6VKBUI9uedkuv7du6mtDIZLsu603U eYpZWyI7uK82hWzc3oAz6Z1p4F2MrkvxFNNUqnuHMQOBeZP+Wc19srfcXn9TnhVTJU3L 6qIDz3vbptke+TEweQ3jCEBzgfuoSmrLXcxm/139g7lJY9u4Bpi6PT62COjH5JtCjWFM mDpA== X-Forwarded-Encrypted: i=1; AJvYcCUNZROFPf6Lh/4jJ0bgDThpkUYIb9gkLaLIkGjEs9Edr1Ue0F7PF0ba4TghoUvlubH2VGoZSHH/nidHFs8=@vger.kernel.org X-Gm-Message-State: AOJu0YxBbuRg+w5tIQdlQqqiOerVy7s3nfBH461GD9JI+/RNND1cJrtU WO6IxzdBAl7g19wmqHV0JD5zT8jSjDqfT5e4t+YxWkqwNkwoYytSNffmC8tiEBEG8xszP3uky7P qCiVJh5H6MU/ZxCPcL8WVf1wnATSnZD6S1TArVN408cLG3qEIFZfnUiY4xR/xNc4cwk8= X-Gm-Gg: AY/fxX6QKpMnWngkt5NdamUxkPwBOUbsQUBEb8wEKICTQXH6uTJRjJ7NzJ/0wqN7Joq mDufkcRy7KXPdZkxK9CU6JI2N6Yamjkai6uxZ4WX6mPSwZisH0yyLu40nBK9H/zrEAXsLtZCq3G BUaNvUx65IPisdY9luwicaGh9eoGNVTYRt02VwevxbNNl//+Z0iVQY673q63UjAed1OZTJZcObh TjwrU047ohpLycszpWZ5uw4f9OBAmqpCYZT26EqYV7saU15KekDKTslfjAKayPnIWGlI1iI2rkP EcAIhPQ/s7+UgYrWY/GP1xRyYfe+HJvLdiTvPS1a/MwCHq9qlWKebn9i78RIV1Zix+wYpBPDzlv GhCSCxSdnXZ0WiXGLewFDzkC2C/dltAcZvQ== X-Received: by 2002:a05:620a:1a8b:b0:8c6:b315:1452 with SMTP id af79cd13be357-8c6b315184fmr728108885a.7.1768759822580; Sun, 18 Jan 2026 10:10:22 -0800 (PST) X-Received: by 2002:a05:620a:1a8b:b0:8c6:b315:1452 with SMTP id af79cd13be357-8c6b315184fmr728105485a.7.1768759822113; Sun, 18 Jan 2026 10:10:22 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801fe44b37sm62162085e9.12.2026.01.18.10.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 10:10:21 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 18 Jan 2026 19:09:32 +0100 Subject: [PATCH v2 09/11] pinctrl: tegra-xusb: Simplify locking with guard() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260118-pinctrl-cleanup-guard-v2-9-bd36f681bdc0@oss.qualcomm.com> References: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> In-Reply-To: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2035; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=FLZSR96VBkRrzhSP3/2OgTuUg9DxmOscsEadYFKjqPY=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpbSH12QqDR9lyHrdfWBYKu5wDAWLJ9ZakzQ3LT 0UuYPASn5+JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaW0h9QAKCRDBN2bmhouD 12VHD/9unxdOGDL9Cvw8qMe+777M4gAqFDHe661yf+QCRAMfaXbN3WSV5wByRbqTx3YfWy21YOQ PmUn8RHfADZRESRLJ40apeyBHwmf+X3aiVzCvJrIhssAEg8e6K7zet9KS39Wxq+ggSw4RMklgwR 648adqt9vMbooDA18DkIXowYvJNwPJKcEnez2js1gOhYtk9Et0iy/q7sWb1Pdi265zTYwxv9fSN 1XA2P6oDR2vvTZGfRM3Y3qL9sYGLOq+7J9B2IhXGsT4h0bakUH/HwP+otw1LPAta+OerExiolHI mYexTPNF9qC1iJTWw9c0TKj9KMWD6/7qUHNH6Na0WwHWYNyqKi68kjfdg8ye2KAuFsHc4AFBrlg D4+GUG4Z5YjPvImtD+ZxD49iaeWlpHrIs9/oPs8qcDvb4tIp237aGABh+JBRAXZIneYCMNNZaT1 StSPdDt7VhSHoNzlof1zSlpuaWaw1Pabz/Tr+4F1xEqFkZZFTdO26JMZcQMyZox72x7c/QHRR5A +YvVe+Z5+GsaGQttt1PTi5ccnDiKJoTagTW/dEGBAtL7aTvBTSan7k10tRuwFKj8ZWVzxHG4TSI Uw+E/NGfkjEagoYcsHuN9QA27EJwqMeW9WQTpq7JAAHx4NjypWFW+haLBXvrjgznmhZ8d0reg6W wSCbjewNTPr6JfA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE4MDE2MCBTYWx0ZWRfXxjRQgQDt4n0S Fy/Uau2H7OsWr/i0+C/WoGLY++1xnbwXXE1jYsB6yVfdRwGWisiBh57PIIonNtlbQ3TMpKV2qya xXouvg1P0963H72OPAysLArwpfly0eAsVjrjSIHG2UB+HjicC8Ztzkz3D/JZlfRL1KFI/fyjjP3 8koDrrbSK70NhFfSaZc9E7dFasUQ+MCqIxxNuWOGoxjzF6L7/9NqutAnwRq7C9m0rNeGq0BF5aD RrHdtUA+oXU2ZYvgwOrf4gb5+E6eE2LGlDPSUVN2KqcvT/7LfJNpFrWoNgEh+bseFxr88/Le4/S QD78xdJcZkhWzs/r6L+tUgU0hFhSSmL3xXSFJGXvzTaALBvk3MrOMdnQALF9xBf3NlxS/k8XH+y iPPy/aK5zQjHNJHJdEhVo4Nawh9HdraSJp6mQcevOyvkgT7nLUZ+huSC6JXrGQw7W3dvU/Sx+rG 6lsjO7/WZvNXulF26wQ== X-Proofpoint-GUID: 9lnp4Ys061CtGQmzIvfsY__B9qRP0TFT X-Authority-Analysis: v=2.4 cv=GJ0F0+NK c=1 sm=1 tr=0 ts=696d220f cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=aRO1tsgHJH1V1zxVpf4A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: 9lnp4Ys061CtGQmzIvfsY__B9qRP0TFT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-17_03,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601180160 Simplify error handling (less gotos) over locks with guard(). Signed-off-by: Krzysztof Kozlowski --- Changes in v2: 1. Drop stale mutex_unlock (Jon) --- drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c b/drivers/pinctrl/t= egra/pinctrl-tegra-xusb.c index 34a373f7e04d..c6a51bb21215 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c @@ -478,10 +478,10 @@ static void tegra_xusb_padctl_enable(struct tegra_xus= b_padctl *padctl) { u32 value; =20 - mutex_lock(&padctl->lock); + guard(mutex)(&padctl->lock); =20 if (padctl->enable++ > 0) - goto out; + return; =20 value =3D padctl_readl(padctl, XUSB_PADCTL_ELPG_PROGRAM); value &=3D ~XUSB_PADCTL_ELPG_PROGRAM_AUX_MUX_LP0_CLAMP_EN; @@ -498,22 +498,19 @@ static void tegra_xusb_padctl_enable(struct tegra_xus= b_padctl *padctl) value =3D padctl_readl(padctl, XUSB_PADCTL_ELPG_PROGRAM); value &=3D ~XUSB_PADCTL_ELPG_PROGRAM_AUX_MUX_LP0_VCORE_DOWN; padctl_writel(padctl, value, XUSB_PADCTL_ELPG_PROGRAM); - -out: - mutex_unlock(&padctl->lock); } =20 static void tegra_xusb_padctl_disable(struct tegra_xusb_padctl *padctl) { u32 value; =20 - mutex_lock(&padctl->lock); + guard(mutex)(&padctl->lock); =20 if (WARN_ON(padctl->enable =3D=3D 0)) - goto out; + return; =20 if (--padctl->enable > 0) - goto out; + return; =20 value =3D padctl_readl(padctl, XUSB_PADCTL_ELPG_PROGRAM); value |=3D XUSB_PADCTL_ELPG_PROGRAM_AUX_MUX_LP0_VCORE_DOWN; @@ -530,9 +527,6 @@ static void tegra_xusb_padctl_disable(struct tegra_xusb= _padctl *padctl) value =3D padctl_readl(padctl, XUSB_PADCTL_ELPG_PROGRAM); value |=3D XUSB_PADCTL_ELPG_PROGRAM_AUX_MUX_LP0_CLAMP_EN; padctl_writel(padctl, value, XUSB_PADCTL_ELPG_PROGRAM); - -out: - mutex_unlock(&padctl->lock); } =20 static int tegra_xusb_phy_init(struct phy *phy) --=20 2.51.0 From nobody Sun Feb 8 15:30:32 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A66792FE071 for ; Sun, 18 Jan 2026 18:10:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759832; cv=none; b=cO6KTYAM1PBEE8rZM966kWnFKrao675kR02l/GmL9+P3sUtLQCE+8La4fuAa+EbDotxJ1hoLpxISvuWTDBrku2cvbC8of5gY7kjPRxjzdxw/qJSeR60eEL79Hy3e0cmwaqHbIHGTnj3yiH51FQywcslw3gu8QJANQMbdMptWA5s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759832; c=relaxed/simple; bh=xHpKv/L+LPsJ9X96+TG0TkMyLzJ8lmjqPrbjckpJnLU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aygmJOf9QeL4RGuJW+I9qfPcEKG8gZmreGnf5rQ5ho2VcGjMEEmCciwlkeqktqM/qDy7ObGTGah35Em6q6f6kbGOVMDYouuZXkOcSbRjpmNtWWCAXEzuyocCTi5NfDvqUl4YgmoT8okARBY+z70DxHg7ldPha32wR/PAg1xz72U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Z6DB2YhG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Cf8PPIxe; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Z6DB2YhG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Cf8PPIxe" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60I7PKE01810398 for ; Sun, 18 Jan 2026 18:10:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UER+4Rm+CTn1fc42ps9UZK/VrM2V9tBgnOrD2NvWQKQ=; b=Z6DB2YhGkaLCOu3G dvJzrF9MGYlT25uf4akGK2B2DlOvGRwGmJkrWOY3hzsMZ9UZKt9Edh/p9bkWGcRw ajdURbQ8XtREwXTXybLIEXImTWYYnGNwOm2JsNhQGOtXgrTJfP0JCqqeKjwLBLit VU7tDcy+orbSwYYr5ZET5qJ/GHTAYICe8F06wtnrAv9XQ+ZekQSdskicVPmsod1j jXwEuDZ/7cpau5lyz9sJ3ZCk1xTKJju3RqwxrwYerQtNGXL4GV9TsZEV2RI6HFgM vUIkGVwtgZpSNCspbZo8ypNikiv8lENoW2W9dQ0qDWgj4faSZJsRXaFDd7Up2NXc o7I//w== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br2t72r4g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 18 Jan 2026 18:10:25 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c2a3a614b5so913548785a.0 for ; Sun, 18 Jan 2026 10:10:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768759825; x=1769364625; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UER+4Rm+CTn1fc42ps9UZK/VrM2V9tBgnOrD2NvWQKQ=; b=Cf8PPIxe3QExB3ydmvkmtzwX3c6mpxzPB+OIl7jplg3oo5NJraNV2fGtDl+17R2L9y rNq2jm0oE6MPZhf9wXWhyQCiMUvn+3ZHzm+7WuGD2y8xBr16e3I4AhN2hFkAWr1K8yG5 f2lD1EYtx7MlY5A0Prv/fzJpj8tE/7h3XfgzBSQxXbJqct6/oHUCb5Tw3C28b1wI6Cwc RN6864dmcIYkKJ9agN4jwQwdLRn2e3M9z279q1L1NSCRA3kA9Y5xOYJX2J9v5aHJ4gVY 0yHA+FSLEHDifs5joE5+GMmnIX8ZhaHBbzgkCbAPUiw2NoI838eAHGvfk+6AJWfICAO6 8lUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768759825; x=1769364625; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UER+4Rm+CTn1fc42ps9UZK/VrM2V9tBgnOrD2NvWQKQ=; b=snU/pJJ1JK2VfzlPgKtYOGccgV8Kcix1DHtNHXsciZYUJSr67W8aU51BOrSrtm1Bnz JmuR2YwqTD7ceVJNnBcHkC8FLvsg6vvyuKFhDs4S/Zdl2/enBv0Q7urE2Dw+FWofED8l rt+ly9wNsznTSzvdI1ePqQciK+NbVyf/46NiU61UpJIhNXTstf1fKNw8ruAsWd1RTdkv phPCrzfWR2aQsfIEBQsGCQ/7jUS0OC9wp5WCI2wFzFOhJxt4JqWsql1ZyNBce41pBc8/ KjkfkpAWvzLRAYaoviEtReQn1L/2QCzDvrzlSVYj4tK9P2UqLTIB7gqPk5iUhrmj8naq 3CzA== X-Forwarded-Encrypted: i=1; AJvYcCWrUAXHJdu+37L3m284++LxjcYTVPYvftsMFss2uWl6POQz9Vf63MIhxtNi7RHEu/9ZqQ/Xyn8MEUbmE3E=@vger.kernel.org X-Gm-Message-State: AOJu0YxrEuVBpKX2E2so2OIltv7MwuTdBUEGW0bPfjb0gB2PSmT273IM jj5P2ZGOcHO3dWpXvf2FD6Gn1M6ocAytSkQ3O0rT9ecRFzNjERP5lusocxc2z1joE+Xw/+EIGPl kOX7lejdGUnXa3HSRK3tNbU2ni9xA9FM0peAp2eFXgFjNiV4KusJqr84tDLZ1B3jkh0Y= X-Gm-Gg: AY/fxX4E596tmlYLQl0718rpMsnSu7ozQFJKzmHjnPvsaUrXja70TQ+ICIVULvFCHXa GBkF4uyMltoIqZcW3prxIc4xqqlAr3NslvhlK5ooAhAgT+8kmtxISg37t2d4Z0Sy2zk5sW7iLxY qukWWaSyS+O0ovx7vpnOVLEUwfwWchS5n9TVfWMqd9s3Oo9IoQ5d8CnaHCQSK2MDLiwBMtu/qs6 7aTUn9KMa1/KIdD4IN7sYdKiUrpo6775vzZH7yzGpIZCT5/N8GapYMflPXuc0wVKnOIibpH5rB0 tO9ZdI++2Bx7yzWksL3ganLiuwJLy7Ztpx8rA+OfkJcxYVlE7+ZIE0pnotyYIKU3avWnUmi8czp b94SYNJcpCpZDNyFBzHglQg9jc4gXkQ2+iQ== X-Received: by 2002:a05:620a:31a4:b0:8c5:3412:3aa6 with SMTP id af79cd13be357-8c591a1d06cmr1679914785a.42.1768759825062; Sun, 18 Jan 2026 10:10:25 -0800 (PST) X-Received: by 2002:a05:620a:31a4:b0:8c5:3412:3aa6 with SMTP id af79cd13be357-8c591a1d06cmr1679909785a.42.1768759824643; Sun, 18 Jan 2026 10:10:24 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801fe44b37sm62162085e9.12.2026.01.18.10.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 10:10:24 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 18 Jan 2026 19:09:33 +0100 Subject: [PATCH v2 10/11] pinctrl: rockchip: Simplify locking with scoped_guard() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260118-pinctrl-cleanup-guard-v2-10-bd36f681bdc0@oss.qualcomm.com> References: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> In-Reply-To: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1372; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=xHpKv/L+LPsJ9X96+TG0TkMyLzJ8lmjqPrbjckpJnLU=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpbSH2V7HCVVZQA8nE36OlRFJLPIeFm2jrQH0SA voGEok2auGJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaW0h9gAKCRDBN2bmhouD 138DD/9yYDuntgcWTSxWPvfXFutn8XLNtbjiww7N0//+LCDsOtjjM92dz6ezguNQS/QHM98IHRr SF6pn5H3zt8atlHdhCPpyf3x3oKRSwOS0Akm92SgBtUpRXGuMiq+7O2MsLdR/tIUF6gTEgn6yFV 84Lk5zDvgwOi0QlMHAVQZPovb6h/vY837EVCDSRCFQDUTEAR7na7JozMG8tp0VE0mE7bIWwPT/f v6lwP4dm5xYRh+B6HzZmHXrpwVUi9RbgeRK/PNZNadB3uz62KT1T0IT8R9nZUQtX9G4FMRwD3xH P5t30O/Hz6it1xvrvw1Lu5f3+AySnjjr6MZxix/zVD9DGKJE40H8HH7zTSSsREL4FwUU8zZS7HX dALPTXy6us1q2unNwiDi6kI/AVXWCCZ6sGl+XxvmbSBYYbIWREh+WyDt22jBLH1KeIKQYb7jH64 SyxqJFMRWZNJsMGxf5H4BjA+NqW9skDWnXCNH2FnpIxnCtdb32i8yyU24YQcB2qy+UqVOj/UGme M5VDHJie/HU+5EggRTKsw7A3HWxLO/5lpq8m0Aym+vl3+6ldnGSTLTfSdS07z4/0Eibgnw8tPUH +vVzE2zpO63gAjhez3qAdbhnW2A7TSbUiCJyYbYcgetBXMa20Xnn0pQEThXHPYBZKIK1KuGnnf6 /vUyVHqLHNNxN8A== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=Fdc6BZ+6 c=1 sm=1 tr=0 ts=696d2211 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=zo1y7j5tH0XFdPBYKCAA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: -yU8XuZAwzlPjPoO8MUx9zv6jB61-lIX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE4MDE1OSBTYWx0ZWRfXwp+b+HIjh1bU Ge+SjBCWA/6JzkAigASFVjO8/jegdVocahofEhZODzK+8MWvZt9PSFmelIiIiRMEoPPa0VboWpv l6exsLO0tl4DeXI5Vj86BAixT0wewrzOd/3z5kh3xOOH9df8mmzNLiT1L6SOJQzPe4UD/mxLBXS S8nvEpu1qBe4XHCvnD0fLjs1dkt6SJ4+kwSisnZgYcyD/qhX+VkXv2Ew3kqO3E9cV9uAUFcZY1P Sos6vvlMorZtzYpC9JP12tjwHJPVnMnW47I+pOxddmhZNSWYA3Oig65LY/JKmwxSR2xSG84TWoa 21lOq5pZoCg+TdQ8Xh0+bAYHSJnNECCeevxV40IWH41SrbmQinL3hA9pqkSnsXoqzEj0in1oZdm Db5+Uyt0AP5VIZe3lI690/MEZqlRZd+FgEFpgQT2EkA0tellaDv5Pu/ETNvMQQN7Q0+3S2AnEdl 09Ua4xDB05iPjxlRMLA== X-Proofpoint-GUID: -yU8XuZAwzlPjPoO8MUx9zv6jB61-lIX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-17_03,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601180159 Simplify error handling by removing two mutex_unlock() calls with scoped_guard(). Reviewed-by: Heiko Stuebner Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/pinctrl-rockchip.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-r= ockchip.c index e44ef262beec..bbe1cf712965 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -3640,17 +3640,16 @@ static int rockchip_pinconf_set(struct pinctrl_dev = *pctldev, unsigned int pin, * The lock makes sure that either gpio-probe has completed * or the gpio driver hasn't probed yet. */ - mutex_lock(&bank->deferred_lock); - if (!gpio || !gpio->direction_output) { - rc =3D rockchip_pinconf_defer_pin(bank, pin - bank->pin_base, param, - arg); - mutex_unlock(&bank->deferred_lock); - if (rc) - return rc; - - break; + scoped_guard(mutex, &bank->deferred_lock) { + if (!gpio || !gpio->direction_output) { + rc =3D rockchip_pinconf_defer_pin(bank, + pin - bank->pin_base, + param, arg); + if (rc) + return rc; + break; + } } - mutex_unlock(&bank->deferred_lock); } =20 switch (param) { --=20 2.51.0 From nobody Sun Feb 8 15:30:32 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 726D8301472 for ; Sun, 18 Jan 2026 18:10:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759835; cv=none; b=uzr9/ed2I/7PnWiFfCi+2jZNQ/5xXlbQnVcohcV2DgT+BrL49p/UVGh6MP55P5I/PMpySbXST4T9PJi3cKF+sbMGcD2JaX3OhTHWjW4eHR1CzHhRUufq6aJTM/uuTxisrIUnKcyP2YPkqQGgcN370IajxZn3AaC9lkXAwnhN4tg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768759835; c=relaxed/simple; bh=k1GvsBNYWO8pFPyazMMNabsh3Vpjdc1LSTY4GGhIuOk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q7BxQQrELL7ZpMo7UT17dOs9CKkjwBheXPl/JzAFa//kQJisOnWFitOT3nS0Law8QRmy8QA528wrAqpHSK9H8slBucD2cSb+iOWNlCWJxWa0k71OnXmki+UqNIAv4Lh6LiOBpTmIj6LLzmBhxTUXGdgLh/SwbobGfP8cj6n3MGA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CAJnBbDn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XPnOztoB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CAJnBbDn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XPnOztoB" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60IHuZ743785578 for ; Sun, 18 Jan 2026 18:10:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= N48lIvtnLb2IcsLS8pOSE3K1e123fF19xLaS4IvtzNQ=; b=CAJnBbDnA61W8ImL SnAgPRZ26uidWw6/crkIz13LXLfpToynIHrH8fGSxXxetED4wm5RJiZrZDg3rIfp I+yQhrd1CBcJ2Ad1lFGyf0FsGqwUca3zvkkfCL3ZCW32iOW4+BU+zFImpamvkP5L 3osMGujdYac1/k+nkBafEmhc9umBL/i3W2CHMm3rb7+w1xHJXWCVXvQUKh2K6id9 bp6GniMk26pToQycFEVVN2Av0pqMYej4EFc/gwjGx53qUMEe/dVECDdxjQSVVBKJ QGMQkydLLEne96NU+CuKEKwSYdrZH2VFYby+MaKWI8kzKlyfM27gyaBY1pIwxY0N TkbXFg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br2guju2t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 18 Jan 2026 18:10:29 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c52c921886so479326685a.2 for ; Sun, 18 Jan 2026 10:10:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768759828; x=1769364628; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=N48lIvtnLb2IcsLS8pOSE3K1e123fF19xLaS4IvtzNQ=; b=XPnOztoBqEthESAP1tnOH7Vi2lPZxfS83fCS14tTgZslzmzbvl9fEHOYjOZ+c7pkLS pL5LWEiNwPs+dms0fff8PPImuubS/FNe3hZ2awXh8wK10047p7128+k0lIVwWzh5xZVw vHfMdcSLCb4PVMvudxUOU1mraQmgpd3wHGARbOG9+C8E/F018AFoY2MJbUpgrjSZ8dmT RQZXadhgWlpuLjwYj6glAn9vrxM3V7ah/7TJh0qjukDZLv/qIaNYSbwepggHfRzN9w1x 64+99b+kMMsWuBkNNemFC+OlwYVOkU/JQz/HoTzPbVrRSEjD9yKCgnIXy2NKPnr/NbtM 35uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768759828; x=1769364628; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=N48lIvtnLb2IcsLS8pOSE3K1e123fF19xLaS4IvtzNQ=; b=V6nsu7O2wRjKTa1EYykR4VWNvlPa234MTEJ0gWCDkWU+aKR2+BiR/SE6dZb7TbZQhT W2al1e+supk9o8bNi4gXANpa4BBCIJlMY0C0pT9yYYdISac/BxT/y6DgBqEIzMep4TPq csn5aJNnJKTutbGCA6XGTaV92kyN3T9ZgxgixAWq/ywUEUchxB6loxyNFSlSHL05Sg7O BQ3tyeKaSyi0lJynE4tXjtlBDXubcUmzGfHTZra7CoE2mTSFUpa5vgIdzVluPzDEktsG drDAOdmkCLr0SuOXfCKTHH3cUkchOo3u1cbC4LWQ9frQorIM2mVGrDWaABhPf4k6B0hu 0rBw== X-Forwarded-Encrypted: i=1; AJvYcCVRJSpBmT2ZOD/swnDmD5jAIzIChO5M15EHvD4O0365tBlyIyHuOiIThbv2lgdp2enMb4+Y1aE1SdIBUz4=@vger.kernel.org X-Gm-Message-State: AOJu0YzMQhxM7gGFO4hsWahDh/iDqBQWvTzR2Owxk+yzdG9/WH1nXeEc eGsvSeA7p5CZ22SsRf8oFa62FR9pAQobml+EhXgLHHc71ZPVBfcLd68EDcumJ58QBfiCzFvZrKL 3zdlNlMgiNL5vwHLvN19ncFm07JW0mCGDLCYkXTx5M+nIErphEgk06UygrkncJjTphCo= X-Gm-Gg: AY/fxX6Hq+rt1f1iMudJK3U5AD/6zwF2tI7EnNNlWnrnzYMnsZUuqrAUubqUgjwqOJf l2OeXeDpyWdUwaJBO14n50k7+2UHDI3UQJJbAUiiWPGGc3FsVasTCliP4zMgLFH6XHdb7h8FdhB aOKv0NytwOO+Vl8/bW9iJvw990dfRT28VlP1hHGsEHhsVIw3x6IDFYBth3/T0ZUiFDjkLT4BCG/ Nsn+k5gqlW04oMrwqSIrSl1p+8b4eKIeLDcOQv9n+uSd5nyaAyxK+yvo/lP5eYq8xvqftC5RXlu V6erg4iOzMead49/u8mp2vP/g4ZASUsEFayeZJvhDJH7zzVTfryC51bSa20Fw0s/JhI+U2mFNpB MUSpP8/It/odhy7k3xpR1k3tvOIXYqhoW2g== X-Received: by 2002:a05:620a:2808:b0:8c1:ab1c:f2da with SMTP id af79cd13be357-8c6a67b79c5mr1285495285a.70.1768759828488; Sun, 18 Jan 2026 10:10:28 -0800 (PST) X-Received: by 2002:a05:620a:2808:b0:8c1:ab1c:f2da with SMTP id af79cd13be357-8c6a67b79c5mr1285491785a.70.1768759828043; Sun, 18 Jan 2026 10:10:28 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4801fe44b37sm62162085e9.12.2026.01.18.10.10.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jan 2026 10:10:27 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 18 Jan 2026 19:09:34 +0100 Subject: [PATCH v2 11/11] pinctrl: st: Annotate st_pinconf_dbg_show() as holding mutex Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260118-pinctrl-cleanup-guard-v2-11-bd36f681bdc0@oss.qualcomm.com> References: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> In-Reply-To: <20260118-pinctrl-cleanup-guard-v2-0-bd36f681bdc0@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1221; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=k1GvsBNYWO8pFPyazMMNabsh3Vpjdc1LSTY4GGhIuOk=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpbSH3xTqF1UPuWpw21q5i4y/0ItOY7uFl5LJRk I/zBJTe0SiJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaW0h9wAKCRDBN2bmhouD 14rID/9CmPz1fyhRfWxv8BXOtmT8JzPxM3Qn1vrvoEw3Redb2US4V07grJBDpsNMH2yrzXble41 qSybWyUX5o3mUWc71wO3IsMFu4uIK1mOxv3WeIRfETEaVH6Sn7DYx472fLtIqS9oZ+qA+sCBJja VZqb59C2Wu6FxIQy5jRXgkXFhzpMZX0nRzYzDwyQb/gPSnWoiBOSRkxbAxvnAWqmPNWAHehSuS+ S3lTrzXTkY98p1nxFqfdeU8afywPvhvwDpfmevQNjxy7iF3EVPf2z4pyHTOQREBUBBmC1perTa0 ANxtLXo2E8BaPttpb8EoZLHxfX7PIAA3ibfLPS0dPI9Yhlhkq9HgRSbSvTKCGxLSk4sxrjTofoP 8reJpHpMVSLdOfwPApz5sWcX+oq/L74sPON1vtXunQcS1QSf50DL+Abn0WjuoQWPqg6LsySITQc oE9X/C6PfDtxOP7YFCEU74SomVt5ZtAwYGK9tgAjJIhKXro4U0APc9TE5T0ekdeapQyKRAkQIlh 2oeg70iEhT2N/f16R6mk9EaIeneSiNYN/wqgMiPo418GRPwnMZVANUWr/har+gk+z3ScAHAYU4w LCmu/3TUFx8+BZXGjyqMjtcINUApT5RxEOVxvgAkv9Z4jn0eIIZd+UQuZn5nKG9jKV3FlgN0K7J BiN1rYOCb1j6Hng== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE4MDE1OSBTYWx0ZWRfXyfsXLGk71isF mGNQjjcpPTStKgIJs5HxjYHJIgDYgObVvBycyCeoVSwcNswaDUvoJzl0JsFmwqMurC8EtvIRAnd 3NS/1QBTjUPYXuGFyG72TBAhDlD9AvU5+IPEVExdVrpKskbPZppBPSb6B0CEVnvAZuMxdHcl+ar /XNc7i8Lwi4g4qwopWNjP3emwLuzqpucvj2mqqtS/TQDFEWTTGzwvRb8bkN4LguhmxBIeevmv49 dsTXak/6JO+rsMZ+Cm9ofTdQtTm9OvuBWwQ6fjsfucEeCGMwNiRFdS4NnerpVStErFfS58virOd QlekdSp4xW0ty1JSvQn5Bl/Ad5PevYH3cLqYuFt8U4NeAFhmWB1r+eB58sk3FI+2zBSXh+Sjeib w7p+zknZ/z3Iabrkw+qLjItSaPHB9FRKHEIXQ3FqTQpLZXSJX6zCcxnmgawKkmnrjDACE2+Sidd pRSOYeL82MPnvUDN2PA== X-Authority-Analysis: v=2.4 cv=Sev6t/Ru c=1 sm=1 tr=0 ts=696d2215 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=8b9GpE9nAAAA:8 a=EUspDBNiAAAA:8 a=RIxbnQC35JVfspY8PfAA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=T3LWEMljR5ZiDmsYVIUa:22 X-Proofpoint-GUID: 0MNSYceYmMvdfefDc7Uh80GTKSfg8ApA X-Proofpoint-ORIG-GUID: 0MNSYceYmMvdfefDc7Uh80GTKSfg8ApA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-17_03,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601180159 st_pinconf_dbg_show() unlocks and locks the pinctrl_dev mutex, so it must be called by the pinctrl core with the mutex hold. Annotate the function with sparse __must_hold, so any changes in pinctrl locking will be statically detected. Reviewed-by: Patrice Chotard Signed-off-by: Krzysztof Kozlowski --- I think this is still useful, although maybe a bit pointless if core explicitly always locks every pin_config_dbg_show() call? Anyway, pattern of unlock+lock feels to me like something worth annotating. I left the patch at the end of the set so it can be nicely discarded. --- drivers/pinctrl/pinctrl-st.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index d3cea3437d7f..8ce88e591f47 100644 --- a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c @@ -987,6 +987,7 @@ static int st_pinconf_get(struct pinctrl_dev *pctldev, =20 static void st_pinconf_dbg_show(struct pinctrl_dev *pctldev, struct seq_file *s, unsigned pin_id) + __must_hold(&pctldev->mutex) { struct st_pio_control *pc; unsigned long config; --=20 2.51.0