From nobody Sun Feb 8 18:24:00 2026 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E0F514A4F9 for ; Sat, 17 Jan 2026 14:03:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768658642; cv=none; b=DLP/KAphGsRRQ2qk45oTt9torNLd0EfvVqkZwT57bPSKQ4H7ZMQ8rh1F2qrZxZI6s+cdcUiwzYhx66PJCCfsI3oZYuwBwHQZZ09qsfywlwkeUa43jJRRj4axWQqdSmHMWxcWf+Ewinh/kmyTzD4Tc2sEsuf7U/f5htgz8GhhlIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768658642; c=relaxed/simple; bh=T2EP8YY8A1QEJG/l0Q9ZutSDVgcmLVrU4I+CmBcoaSI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=TVgHG+F+3OAM9aX6G5VrBUNuqHUFaW3RGZaOKMHs7goi1zpnDGNuldwqjDI/DjJwGhIbwC0FkJIE8S0N2DG8GTxavWFRfaixUi2cMwk/MzE4bty70jfuvc6rN1KftqZpi8fG0NmRXUwnqB0MQYUh7E0LEgE25McLuVkiz7CeQNA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TWh2mXm3; arc=none smtp.client-ip=209.85.210.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TWh2mXm3" Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-81e7477828bso1593967b3a.0 for ; Sat, 17 Jan 2026 06:03:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768658639; x=1769263439; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yvSd70I0U5DyZJZE/7/GpNsYtzxrPkdLztxfXI10Q04=; b=TWh2mXm3x7lNnqa7R1mhylySLbNBh+8eM+yEHzM9cY2qLu1biyFz3zQlLuO/2jt96F f67Ci1DGjkXZqtozm3LXJ4dDmlE/4sRCQTax99JooUAuAV7aNjKLLtkhz9vSt1MXNK92 ZNcAL4uO9kCfcbOxgNKHo1otcUuNi1M7k4zoqFeZz1/DURzWzob328G6rvZafBulhytP 0IyoGFW6VnJkADDtaOuHwqIYr6i7PkDKKZ5X2uyIpGV9W+/SkMno0lWMSuSPeF+C2VqH x87Xkdw3hLua668rKQF9boMOmu/iycXPGxasmIH1Bzdw3h3uiC2RXMiyXsAumZ+9cG7p 33Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768658639; x=1769263439; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yvSd70I0U5DyZJZE/7/GpNsYtzxrPkdLztxfXI10Q04=; b=unZVIuqIM/Uo5q89sUJNCLVScW/TJCBFP8DEvzTxp1BZlmeuDFcRv3aYSLEKMWWgWq ocu0q2F6vA9P+UVN5Qkw2WTky+h2H+D4oSBrYNJKAxUUMy4dCGhm3An45ptReRNqCL4Z ZTMo/G1UJrpfQjjyobIQvVnehk97Y1fHU2BEOtkMf59GPGYflzdchpYrcICwTQHy2y+X Oq7PHKtSY0OXvnT1fgufFijimvsnla1qgpMbKTfZGU6HFAIaZsxXA559eXgVQqVJBxLB sEhlk9EKdREmSWyenwpn6z1X7QKfkaxtpEsSrw75qY65jT/FRXZNVLM9N1TorvLyy7XV wBDA== X-Forwarded-Encrypted: i=1; AJvYcCU/Y6rQPhpHH79/Q5Pgn1ZEy0xkjp4ZhJ/y0yFw1mCMwCUfRAM4xIk7/acodKdDh1gwapiN70C9nPJ9VoU=@vger.kernel.org X-Gm-Message-State: AOJu0YzvhVcyAy5zNUyNazBKDmo0y/yudfk+Y5/Yc606iAs4JCcTkCKg MzHCf4T6Pk20X3Aq5InLw1aXvxZw/YxcFKpuFWisC/iCtxOeFThZ3Fzg X-Gm-Gg: AY/fxX5xKIOQ46xYbMgqW8S6OsR/vZMZOXqEU3BKN/DFNjiFB2OfBEnM8dUJ1Yit82j kg3EKZ2WDhSV69kC1zsVeKZ/V5/ujyk5P5S+WUFZfiv6XP8fcMZg8TbjNP7aAvNb8Qn1/6gofuk mwYvJlf8N+H5K0MLRY1ORXcT1Ixwh2F0PTzEkAm/kfXw0E/AQsJcsEMPAGOjN9wC/k1hfAG9gLT iO2o/pNmAXoTE/asXA50lz3haA3EGpr7RH3hrETpZ0E2XO/ef9vszbfMxLch1in6862pSMekCU1 IWEAZ3H0BqZ9gbQsOimbCwPljLXzroQZS8Znf5wPAC7wwgNI+InLwzsvkvmBT8UhueCJfz3hst9 aGUZZGO5MrXdqONU2LwdDy9KOklFlFH2MNOci1GYvRk7orR7Iumhm7ffeUnchDfqEh9H5Xav2Z3 P6j6qKRAknbKD1J12oFEKX X-Received: by 2002:a05:6a00:3e1c:b0:7e8:3fcb:9b03 with SMTP id d2e1a72fcca58-81f8f151940mr8455685b3a.25.1768658638797; Sat, 17 Jan 2026 06:03:58 -0800 (PST) Received: from localhost.localdomain ([1.203.169.108]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81fa10efc6bsm4213580b3a.29.2026.01.17.06.03.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Jan 2026 06:03:58 -0800 (PST) From: Xingjing Deng X-Google-Original-From: Xingjing Deng To: srini@kernel.org, amahesh@qti.qualcomm.com, arnd@arndb.de, gregkh@linuxfoundation.org Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Xingjing Deng , stable@vger.kernel.org Subject: [PATCH v5] misc: fastrpc: check qcom_scm_assign_mem() return in rpmsg_probe Date: Sat, 17 Jan 2026 22:03:51 +0800 Message-Id: <20260117140351.875511-1-xjdeng@buaa.edu.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the SDSP probe path, qcom_scm_assign_mem() is used to assign the reserved memory to the configured VMIDs, but its return value was not checked. Fail the probe if the SCM call fails to avoid continuing with an unexpected/incorrect memory permission configuration. The file has passed the check of checkpatch. Fixes: c3c0363bc72d4 ("misc: fastrpc: support complete DMA pool access to t= he DSP") Cc: stable@vger.kernel.org # 6.11-rc1 Signed-off-by: Xingjing Deng --- v5: - Squash the functional change and indentation fix into a single patch. - Link to v4: https://lore.kernel.org/linux-arm-msm/2026011637-statute-show= y-2c3f@gregkh/T/#t v4: - Format the indentation - Link to v3: https://lore.kernel.org/linux-arm-msm/20260113084352.72itrloj= 5w7qb5o3@hu-mojha-hyd.qualcomm.com/T/#t v3: - Add missing linux-kernel@vger.kernel.org to cc list. - Standarlize changelog placement/format. - Link to v2: https://lore.kernel.org/linux-arm-msm/20260113063618.e2ke47gy= 3hnfi67e@hu-mojha-hyd.qualcomm.com/T/#t v2: - Add Fixes: and Cc: stable tags. - Link to v1: https://lore.kernel.org/linux-arm-msm/20260113022550.4029635-= 1-xjdeng@buaa.edu.cn/T/#u --- drivers/misc/fastrpc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index fb3b54e05928..d9650efa443f 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -2338,8 +2338,13 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *= rpdev) if (!err) { src_perms =3D BIT(QCOM_SCM_VMID_HLOS); =20 - qcom_scm_assign_mem(res.start, resource_size(&res), &src_perms, - data->vmperms, data->vmcount); + err =3D qcom_scm_assign_mem(res.start, resource_size(&res), &src_perms, + data->vmperms, data->vmcount); + if (err) { + dev_err(rdev, "Failed to assign memory phys 0x%llx size 0x%llx err %d", + res.start, resource_size(&res), err); + goto err_free_data; + } } =20 } --=20 2.25.1