From nobody Sat Feb 7 22:07:58 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73B49274FD0 for ; Sat, 17 Jan 2026 10:26:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768645569; cv=none; b=Nn6TFwGDAbZ14nFJKYIni2xdz8bWpZ1vx/i3CH17qn1qdCWaV5EKWltE0U9yJwJo0hawrBW2IIYM+u6h3GBEiU13xUCjZvVUJXsH/uP3w8yeYSF4wmZN96sSpWFiBMwDmmBzLPXJI9fjNWAkShMHC6wg62bhfRSFbKUSK+M2sd8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768645569; c=relaxed/simple; bh=CxQKoQruU4PuoTTEFK0Ta9w0cD2W7HTN16sDMytzEo0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=J4OAadKshpe3jCZzOxYlYnjzposb2V/fFW440Af5tEctjezSPl7f3rz6knFiaXxWpj44kb7Ttqw5nybl6w2JZ/BQG3F2QUi6xkLQDevYm46JoJjoSV0tAm2VkGnlfzwdZ/UFOjInc3YPy/7/9jAzkPr1FockbUqT+jiOPVdhTsE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FCpUJ/BX; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FCpUJ/BX" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2a137692691so18126645ad.0 for ; Sat, 17 Jan 2026 02:26:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768645568; x=1769250368; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/3sTbYhpga/qcRSMrJpGdazmsm+F/+hOYrLEpetJDD8=; b=FCpUJ/BXPtq29dJ+9KJy1GSoqQV9dEM8uCJF09PFp8gOAZjdPM0fKbR8dnhgDKg7R0 F4JuNA1F48QkX1memVKJ1/aCGfLWXDW/8B1kEZFfRsbE7lMFwXpsEKXWItbiuK8qZZ6v vPXz0b2v/IqqztV1VaLioVFjiK9upUNezxQ9GeDh1qc0kKlAL6RnO++0M7CVYbJafwTn Ku+Bs+uZB31kU4CTPgzMGS2dqZJgwrMoUCbj6OSjPVFvJt2FDPypn28ua0dMqovOJRS2 s0Wj4Sc/6K8h2pTCuDzVQKMZ8rKpXTNV7XZoM8PtNvzeeJ1AuAC9QjLt2bc6tqFPNmPP 1Tbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768645568; x=1769250368; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/3sTbYhpga/qcRSMrJpGdazmsm+F/+hOYrLEpetJDD8=; b=vaJ1njb5tGEWO0GqJK01RmmqdmthYslX/EWm2XldEljZeTBVAVIu0xAMcasQmlYas+ mcRKLLvsT76IIVF3CqsGYJ3WyBpRuzbFQ5pWnCuq0yX+sTawCZMlfz4yDJZK3PLZudAy jJplxoJt79N4mLJSuLT7qcKsebwGYIX+MMKlB1yR7mMYcQE9ZWCJHXP13FSJDeaqmmoz vK/HlBj1w2WPtmjsRExpwFLrIUNXgbgBLqy+INAlF3WM8SXT7Jjos85C8kQfPS6fNWaW iksIc2hwgpkxlbecxqC/Atui5AvlQ7DM5RCCRhosdPsw5NzqL8uz4UZkCLXDg6lKLf2Q cvYw== X-Forwarded-Encrypted: i=1; AJvYcCVYiFmeygfAVxD0edw4HFtUvNHTDRo1yyKBwtvljCeZwYqGvn0NahPgzAV4P3HjtyLHhOUdzRaRKPtuxAM=@vger.kernel.org X-Gm-Message-State: AOJu0YyElmxtx2OnSNAXO9+G4TDSxSjl7iN17HfhlIXv3lR3KHJIDRvd ekUzqUeqaAxGa8ADPHsl5b+gVs6Wb8q2VPe1tP/SYWN2sJFDRaIA2hO4/CzLYA== X-Gm-Gg: AY/fxX5jL975ImQjzOflU2pZ479T3k7Ryy9yBuXjb9KtY2loH9tdxYvKaXlMtvi79xe ZxJPE/2RrphIBBLSguvaIFn38vZEXW405hFvmry0VyG5MkX/nXYQIRwAJbP47ckVnnTsqwLTs5Q eYpUgiJdGtzT6QUixtp/fF2H3zEMNfTSDUjaNd0qZPuamum/ALnzTnpnpPmHwhXQsMOWYJUeZzz awN8tkV/Y7k05w9y1ZBxefjITj8pRh7YSI1RAd66POD2ZnJ7uGqejiloUsWk7WXg79Q7c8WU804 6x1fNZb9RCGeJkqXXMCWKjkHwSLjh9OXC3Msc3NzmEla1ZGU+RMWWSP/QHbpBfjSe0WT+Fe0era 5uC2QLN0tEcTZgzXlGeHjXZjKwQKfhXpMz/+Xc+L9BVjO6UMtwBfshzetXQRAR20+kgJXb4PmGW bhRi7WnF1gX39CmT4M3eb2lZtmr9G8ZxDiIhFCORsbBI/tgywBtICv2Otp02WQXA8xVTNxRMGtR mFwgLfig4A6hMo6b7w04qjn8NfefiKs4FwCqcpa2OBYEB4= X-Received: by 2002:a17:902:ce0c:b0:297:c71d:851c with SMTP id d9443c01a7336-2a7175c324cmr59842255ad.36.1768645567778; Sat, 17 Jan 2026 02:26:07 -0800 (PST) Received: from c8971f1abf06.ap-southeast-2.compute.internal (ec2-54-252-206-51.ap-southeast-2.compute.amazonaws.com. [54.252.206.51]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a7190eee39sm43069865ad.45.2026.01.17.02.26.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Jan 2026 02:26:07 -0800 (PST) From: Weigang He To: masahiroy@kernel.org Cc: petr.pavlu@suse.com, sam@ravnborg.org, linux-kernel@vger.kernel.org, Weigang He Subject: [PATCH] genksyms: fix file pointer leaks on error paths Date: Sat, 17 Jan 2026 10:26:02 +0000 Message-Id: <20260117102602.534734-1-geoffreyhe2@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The option parsing loop processes multiple command-line options sequentially. When -r or -T options successfully open their files, but a later option causes an early return (e.g., -h for help, an unknown option, or a failed fopen), the previously opened file pointers are leaked. Fix this by closing ref_file and dumpfile before each early return in the option parsing switch statement. Fixes: 64e6c1e12372 ("genksyms: track symbol checksum changes") Signed-off-by: Weigang He --- scripts/genksyms/genksyms.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/scripts/genksyms/genksyms.c b/scripts/genksyms/genksyms.c index 83e48670c2fcf..dee9216797935 100644 --- a/scripts/genksyms/genksyms.c +++ b/scripts/genksyms/genksyms.c @@ -776,6 +776,8 @@ int main(int argc, char **argv) ref_file =3D fopen(optarg, "r"); if (!ref_file) { perror(optarg); + if (dumpfile) + fclose(dumpfile); return 1; } break; @@ -784,6 +786,8 @@ int main(int argc, char **argv) dumpfile =3D fopen(optarg, "w"); if (!dumpfile) { perror(optarg); + if (ref_file) + fclose(ref_file); return 1; } break; @@ -792,9 +796,17 @@ int main(int argc, char **argv) break; case 'h': genksyms_usage(); + if (ref_file) + fclose(ref_file); + if (dumpfile) + fclose(dumpfile); return 0; default: genksyms_usage(); + if (ref_file) + fclose(ref_file); + if (dumpfile) + fclose(dumpfile); return 1; } { --=20 2.34.1