From nobody Sun Feb 8 20:35:51 2026 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C4013016E9 for ; Sat, 17 Jan 2026 02:09:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768615747; cv=none; b=U85oTQb6oY0wByDEUhOzlveAbcDUFj8yTBRwt7RkQjUJduMrkXi8rohb02iXsZFges1oztjQIC5HMv+krBUe5vnog5xj4GHD7yAbZX86LCKeviFnBoEhCnepvQ1rdW22BHCFWeN7rGW+Hmy6UfT3+wLA3kUM70EYthteA+Ma2iY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768615747; c=relaxed/simple; bh=zUbIGwe8lxI86EmEfhv9auKl/80P2MRCcEDChc1S4iI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Nx+s+fUvW9IwPRaRpEkYnWYfYT3Kmo6pbCZvRXeM2BiDy8YT/Wem2vh489QkE5WZhoIaaQ+z/qh6k9+/DjZfa1J+tQsYdmZGcUgyfy1g2w/EO9UAK05hMaU3KdW0DG/QkkdpYRtQDRTuBlO2yoL6rayu+WB8CmxQjwxFrpKd7X8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=gb+09gFi; arc=none smtp.client-ip=220.197.31.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="gb+09gFi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=kz AShONMxakgZx0sMYCMguuiF9B/PMQXpLKQ0x5T1IA=; b=gb+09gFiNvV18PWSlk VqTY1i2FJ54L0Lea7/OtUu8wuFTH9Gp4NnrmyAump/wnoIuvnnHCMQd4kiRi/1Vh L55S/vpsLoSnHR9oc7iytM0C8Qk/21OzCEFFxe+Ms2LNLXzZ/bbK54eTMNdjoxCy z5MEYxaVaoOS87xEfFAZspMXM= Received: from ProDesk-480.. (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wDn8vbr7mpp2WGKGA--.116S2; Sat, 17 Jan 2026 10:07:44 +0800 (CST) From: Andy Yan To: heiko@sntech.de Cc: hjc@rock-chips.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Yan Subject: [PATCH v2] drm/rockchip: vop2: Add mode valid callback for crtc Date: Sat, 17 Jan 2026 10:07:30 +0800 Message-ID: <20260117020738.294825-1-andyshrk@163.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDn8vbr7mpp2WGKGA--.116S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7urWrGw1UXrWDZr43uF15Arb_yoW8CF4xpa 17JFWYgr48WFZFgF1kJF1DCr1Ykw1ayayxJrs3W3W3Zas3tr4DX3WrCryUCry3XFy7Ga43 KrnrAFW5AFWI9F7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jOb18UUUUU= X-CM-SenderInfo: 5dqg52xkunqiywtou0bp/xtbCxhDsS2lq7vBudAAA32 Content-Type: text/plain; charset="utf-8" From: Andy Yan The different Video Ports support different maximum resolutions. Reject resolutions that are not supported by a specific VP. Only the output width is checked because the hardware itself does not have a hard output height limit. Filter the mode that can't output by the VP/crtc. Signed-off-by: Andy Yan Reviewed-by: Sebastian Reichel Tested-by: Sebastian Reichel # Sige5 --- Changes in v2: - Add more detailed commit message drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm= /rockchip/rockchip_drm_vop2.c index 498df0ce4680..74fba29bfff3 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -1439,6 +1439,17 @@ static void vop2_crtc_disable_vblank(struct drm_crtc= *crtc) vop2_crtc_disable_irq(vp, VP_INT_FS_FIELD); } =20 +static enum drm_mode_status vop2_crtc_mode_valid(struct drm_crtc *crtc, + const struct drm_display_mode *mode) +{ + struct vop2_video_port *vp =3D to_vop2_video_port(crtc); + + if (mode->hdisplay > vp->data->max_output.width) + return MODE_BAD_HVALUE; + + return MODE_OK; +} + static bool vop2_crtc_mode_fixup(struct drm_crtc *crtc, const struct drm_display_mode *mode, struct drm_display_mode *adj_mode) @@ -1884,6 +1895,7 @@ static void vop2_crtc_atomic_flush(struct drm_crtc *c= rtc, =20 static const struct drm_crtc_helper_funcs vop2_crtc_helper_funcs =3D { .mode_fixup =3D vop2_crtc_mode_fixup, + .mode_valid =3D vop2_crtc_mode_valid, .atomic_check =3D vop2_crtc_atomic_check, .atomic_begin =3D vop2_crtc_atomic_begin, .atomic_flush =3D vop2_crtc_atomic_flush, --=20 2.43.0 base-commit: 1613a67b5360d6ff78f62143a1cf123414a1b4d9 branch: rk3576-dp-upstream