From nobody Tue Feb 10 05:27:10 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2783318ED0 for ; Sat, 17 Jan 2026 06:36:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768631773; cv=none; b=iRiKDBtbCAe6ZDpfot1pThwhUo/yo7q1UC34FhVh/MQbOY8I0le3j+R2FRhknWN1iEc8b8BaQEkC9iZVt/9U6S9XCwrw3GZ3bdiWAMIghQCKuuygMVQhB2twk/dIs5lrN5LPtjF+xwZZswP4opA+/VHJNcm0cX3afd1XZQ1dO+0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768631773; c=relaxed/simple; bh=Nivgddh/dUUg9vaUGrpQO4Ar4VNMexa7P2jWIqnrNXA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=l5Ww1HJ1ex6FQ8EtGR3U3Wdp0DiKhjlb/oqpTjPNqmnr8UHiUI6eulKZRE9lCl7ZdJ6zpeQaZIC1YBQy8leYcUvUuOK2owOCGnTrbRPzikTAzaPwm6FAnEdiOsxhZRBYTYwW2OpNZVbYVjnYLsCs0PgENhcEhSZyvixCp7JvBVQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=alhhBRdd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bGtptQiy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="alhhBRdd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bGtptQiy" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60H5PXa03151510 for ; Sat, 17 Jan 2026 06:36:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kDDelXBrEvb7s+N6wl54GgAwBWnoeXlC1C+qi++VsB8=; b=alhhBRddnYNXM3H2 I2oLrclleXsei9fX4OGMXnR4JmGbg384oxIViAxFkdDy6TyQ7qjw5l1/1cxRCpZM DaigZhb1fVngZR5NutWaHgXrn2f69DH9gOLWh94Iwv5I0rofqf/QE9o7h7Pzwr9f yMp3HUCD5AiS1DPvyfuNLHD7sq981zQsFVT12ZlQuIIVf2yFtBy/okQxGeBFPA0n sqvdDb4rzhfN8Fr5tjU1x9/e+9W4wx327YN+uUhd3cGzkVo3ntZELPIWQohZu7vW BX863w6gmgkHDpG/LUZtG6dnCbEqNSDDpaaLlwwYCnd+Kn4iWVlEHVIfZkWByzhd P/+Ttg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br2ke0a74-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Jan 2026 06:36:10 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c6a291e7faso795298385a.3 for ; Fri, 16 Jan 2026 22:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768631770; x=1769236570; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kDDelXBrEvb7s+N6wl54GgAwBWnoeXlC1C+qi++VsB8=; b=bGtptQiyqxk13EgJJcH+CHUroXCyoTrAbV+/BG/oeHBihUElwiOc9MSVPRyKhbknJa /JBvFdcbYl/kd2gUqj7lFXQsm5U//U0couxNXLwJdsgwa1nieoBopM8l5JerhleoHm/I uazgLHi5AlWFqVrTWUiDog6y2/eE91GnQtT3rdvwuYASbFv0J8Yme7bTjDfWX/qOSVv+ mliLuhp7CIjOh/F9nJXT/Hm2VOBc7inu0N1Cef4vJ8zFwCsL8xJOwaLChH4ycqyGM8NS 9g29V6Us5vmBQK5JqfrbUZ9f7zlVxZW1Jg9omp3y9xTAbhjilwHzkcUTjOmUvxrCCZCu /STw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768631770; x=1769236570; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kDDelXBrEvb7s+N6wl54GgAwBWnoeXlC1C+qi++VsB8=; b=wFm+cnmOO5NGALm0tfECyh6G5ib8PJQm3undxWGf01I8bY+gUc4/5coTevKzEF86vz gZlTSBUyBHHDweD5IEWiDGkqSpRArHTlbYS/WZvZJT2m91K5o7eW4XuafbCFbJRrkNcd OBKIRYF4frrsJ1gTmre6FPIxtQnPdmQXku9BP4s1QzSp1PTEni0vqKitc3PhpSM1+ysF rurPrlTqtC4Rwp0g7M/ftw1k2saIdx4jLwmxssgRVD6CrNYbUvGKR4i0uF+3cV6uQ7ib RKBQeYCFOrPthWQ1aZCW0S9eOJ4UCsfO8iK9jLzAB3jJJuxGeQPcR1pOscJpI7vsl7LE 8n1Q== X-Forwarded-Encrypted: i=1; AJvYcCVIeNAIwY0hDPVfEC/D7dDxt/FYitRh0tbUdQlbscmC8+NaDJX/7KOKhuffIgUrqKkshJuWTr3iVaYMYv8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz84g1oHxGIkZ7irCzUig/LTuLNCcL08Y3Qp9J3dpPZpUum4jUo pa/gQ03nTDyDnvpLLda8DmwXWdbVfwjaFKgd16gH0n7Dix2gjNVgG4eFnTf/dnhHmPqkIGKDpPY Sz5ryJvGlfevFcqc3JFqIMkxhJPi2m5hEbvESo414gI2JbK76HiMO4DpKYyVFEWR3TQ8= X-Gm-Gg: AY/fxX4GfPUfX2z8C+no48X5ft/2wcfaqY+46fBLHhIP9WsNkCSUWER0ojebZzcgoLY LtHeJJVWmafb4eDF2GmakYsmX4qFaCyZHUukmfncwaVqKKG+pc9RQlCyRMzLeOqofeBYAe+YsVv 6h+J3DGzguNYBQRjLQ37gnZJwP44Ot9PTOIyDCmhzI275kzs0SunR8+5VrwyxzpsHy+DKuzAqoC jns+TcAC/al8MYgEzaOi39ys4rswcuscSib1D1AZ7Xq/RFUR/RQJDQ0sdPWN5urK/xBs+5Zimc0 71WS/hInapkbRSlNeFK1o2cprKaa6UDJyF9fev3eK+x376AVtkOLRtduD9nso3YuDYrJ0iM5QY9 qUFK0fYPYNIx1saRzMv5tb4HdVWw1w6R0Jf29ky1NyaPPOblswpdmIcCFKPv8Wks6lPloCVKqAi EnymEhyPH99nvYenmMkW9ESIg= X-Received: by 2002:a05:620a:199d:b0:8b0:f04c:9f0f with SMTP id af79cd13be357-8c6a69633c0mr674357085a.63.1768631770249; Fri, 16 Jan 2026 22:36:10 -0800 (PST) X-Received: by 2002:a05:620a:199d:b0:8b0:f04c:9f0f with SMTP id af79cd13be357-8c6a69633c0mr674356085a.63.1768631769829; Fri, 16 Jan 2026 22:36:09 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38384e790fdsm14049851fa.23.2026.01.16.22.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 22:36:07 -0800 (PST) From: Dmitry Baryshkov Date: Sat, 17 Jan 2026 08:35:57 +0200 Subject: [PATCH 4/4] drm/msm/dpu: fix SSPP_UBWC_STATIC_CTRL programming on UBWC 5.x+ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260117-msm-ubwc-fixes-v1-4-d5c65ea552c7@oss.qualcomm.com> References: <20260117-msm-ubwc-fixes-v1-0-d5c65ea552c7@oss.qualcomm.com> In-Reply-To: <20260117-msm-ubwc-fixes-v1-0-d5c65ea552c7@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2678; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Nivgddh/dUUg9vaUGrpQO4Ar4VNMexa7P2jWIqnrNXA=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpay3M9+mHB6GMiAL1TbuPcebrQTrgtuwmLGi4D GiKsoP1qW6JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaWstzAAKCRCLPIo+Aiko 1TMgB/4jx9mONQw02I/OWAPUriWFeBex6wD887DlDc6s0+G9WkEZkdTH9Wu+/UBsAcvhtSvJpzG /90E5DUuS0HbdWP6sO9qw1nn8idesZSermRuXFGbHUpdzQ6u9kDt3bM9yliVOW0Jy3yyAgqk6v9 veL16e6sq5TuoT1fLiAKNkr7qbdvK+bFjAkaw4RGCHkcAeXDWnkG+ioFavRYRTSD7pIn2XcaiFb jpupZkvbREab3jYC1aByrUt5V+yGDQaMFlWhXRh/uzFkK7oAl3wbQF5y718Ces3iB72USL3S9Av KELU4umFJl1Xp9wBdcAvJ82rn5z5wAsOC14IjbJRHjnz5z75 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE3MDA1MiBTYWx0ZWRfX8IjqSynlxniX n1XMR1CZ/Yewe0R2uU2LDnl/1PuEcrS+Zsx/OnV7Cxpqd23XyOibBbZM4xlPdWU02Xb6Jj9VFK+ 0C2j3c+OY4SiNLVwswRAA1hrh9Go5//wrbA7FuTyTZx5OqhXtWcl8h8FG2lqXV7DxI32iLkTByC VSwU8403hhcFJmKJ+ohniyrQTHt5BOg7ROVXE3jeA65Qnfu4+/RZXZuHkho+PSS3u83164rD1GF pP337N280SvYrXU+XME8k+2IDi10eWabiVLJ/zS5nwDdm8wVidJShLXDA3cZGJADsG4WefoemVa d/ftMKVRAgK7+5aeJEpf/Y85DoHw/MAGcARj/BYUbd2CRAdec29bG3mCm2d0BsmSxfMrMkTrMjl /D09wJayXUHw7XCN33uCSBL0vByz2RYNEH6TMqx42tlk0LCr2y4G7HjF9nnta7wmdysS/IABOS3 7p1hVPq4CcH2yIqqaYg== X-Proofpoint-GUID: 6ipoYHPgBdI3okPS0OatoZ_h-KV6YI7i X-Authority-Analysis: v=2.4 cv=EJgLElZC c=1 sm=1 tr=0 ts=696b2dda cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=7FpWx5GjbivZIX0HvvoA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: 6ipoYHPgBdI3okPS0OatoZ_h-KV6YI7i X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-16_09,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 priorityscore=1501 malwarescore=0 spamscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601170052 Code in dpu_hw_sspp_setup_format() doesn't handle UBWC versions bigger than 4.0. Replace switch-case with if-else checks, making sure that the register is initialized on UBWC 5.x (and later) hosts. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 41 ++++++++++++++-----------= ---- 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index a99e33230514..b0c97f5e47ea 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -279,6 +279,7 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pipe= *pipe, =20 if (fmt->fetch_mode !=3D MDP_FETCH_LINEAR) { u32 hbb =3D ctx->ubwc->highest_bank_bit - 13; + u32 ctrl_val; =20 if (MSM_FORMAT_IS_UBWC(fmt)) opmode |=3D MDSS_MDP_OP_BWC_EN; @@ -286,30 +287,28 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, DPU_REG_WRITE(c, SSPP_FETCH_CONFIG, DPU_FETCH_CONFIG_RESET_VALUE | hbb << 18); - switch (ctx->ubwc->ubwc_enc_version) { - case UBWC_1_0: + + if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_1_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | - BIT(8) | - (hbb << 4)); - break; - case UBWC_2_0: + ctrl_val =3D fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | + BIT(8) | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_2_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - fast_clear | (ctx->ubwc->ubwc_swizzle) | - (hbb << 4)); - break; - case UBWC_3_0: - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - BIT(30) | (ctx->ubwc->ubwc_swizzle) | - (hbb << 4)); - break; - case UBWC_4_0: - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30)); - break; + ctrl_val =3D fast_clear | ctx->ubwc->ubwc_swizzle | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_3_0) { + ctrl_val =3D BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_4_0) { + ctrl_val =3D MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30); + } else { /* UBWC 5.0+ */ + if (MSM_FORMAT_IS_YUV(fmt)) + ctrl_val =3D 0; + else if (MSM_FORMAT_IS_DX(fmt)) /* or FP16, but it's unsupported */ + ctrl_val =3D BIT(30); + else + ctrl_val =3D BIT(30) | BIT(31); } + + DPU_REG_WRITE(c, ubwc_static_ctrl_off, ctrl_val); } =20 opmode |=3D MDSS_MDP_OP_PE_OVERRIDE; --=20 2.47.3