From nobody Tue Feb 10 01:59:52 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69087318B94 for ; Sat, 17 Jan 2026 06:36:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768631773; cv=none; b=nmBdhwlmDBvGpFHjUKrk/Uz09knyNirv4BYGJ9xqDC5HSx24HS/eR5D9cJe6SUo59z2cNnVrRsD7KqcxCoBV7ralr8O5Hmcs/rKXaAJvN+/vdsyim06Grc2u1UFFLFICtgYo2KNB7bPHAhDJZPA86Bx3Lm7IqOAOkK3XNY2rXp4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768631773; c=relaxed/simple; bh=nlqM4pS5tehTmTBqQ+prrjj8JpfEcAuwIhsTGK973JQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lK52ZImdFaIqaVMe87lLVKoMMQx0PuPndKzfWfw4qDY7HhRv9ZI0aU83e/h5eVR5HKV97oJlP1Nzwwe7uIj307w5VPS6BquiNK+X7lN6Pq54/MNACSZLn3CLU6ADPrUwFLyHqe+fZP6pz0zjP7gIWoumA7xm/zOCvj26cvaXN84= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T2gYMz8j; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ov3BPqlM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T2gYMz8j"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ov3BPqlM" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60H3QOqS3465864 for ; Sat, 17 Jan 2026 06:36:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /NThq6KSUJeukEL9pMouMMZw++r4/wpGPMWQ27LsLSs=; b=T2gYMz8j2ONQNJ3o hWYBszQOTJd/zdTcGiIVqNeTY9BYcS8tQpzgJc8quajCh3nztuRGf51hcCQQMWYB dsmWdjOJjLCdIndAxduSTqHlQEj3KoDIKKuctKL03+Lmz+9cVtVyf7uvCw4lsTfW 2lug7JVRp4opxaTQQEgddhUBX+NxuvHNvm5cRVrKZcgxfpanp2mC5l615suczTos His4Mtz+vt3dtsZ7vaJ+mSXhhUlRs1gomgLqBTYRe+uhqAEBR+pd7TEcMVrS6IMT HwsFYUFrS/3iYripUxZfzpcwYj6SEpyiZ4ffiqMnowPfEeHeYVGagtUG98ThGFJ6 6rBn6g== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br2gugata-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Jan 2026 06:36:07 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c6a4c50fe5so726990085a.3 for ; Fri, 16 Jan 2026 22:36:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768631767; x=1769236567; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/NThq6KSUJeukEL9pMouMMZw++r4/wpGPMWQ27LsLSs=; b=Ov3BPqlMJDSXuKAs0/bRuaWH2MhegDt2Bd5cwdmccCOYpPTWI4J2qVW9WJUg8UnXh/ AWQMwNXvlk14lMwQm4+d44QTvUXEpIp9pHAzUH37L2rkFST8c3OJN8XXlh7erACjHjFr CbX6eY1zNpGDg7xmu4awWsI/rYQzrb/O60paBCAJsiJkCoSuJ5YFzd2DgGGOSjXWCeNK bgi81L0IvvJgkWpX7sQEBC9EXb2sSoicgingNFTVcqplTFwM0HrmshQWS4ILRRNoCWoT ek57LwKNh28NswUoNn7BBL/i3s/ThMfxOCUImSEn+8N60fGkWuWYIXsskI9grM9VAryX Kcgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768631767; x=1769236567; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/NThq6KSUJeukEL9pMouMMZw++r4/wpGPMWQ27LsLSs=; b=fsLKfCvlbIf9klJvZco8EOdyb+MvzLQLqOHnaWE32VVVY6D3H7jg7jpwViVo3kmESf eJx+oJFD7cgAep93xtKKwE5qzlmKPdDwXkVLI1LVCF0SzaXL99LdSMrXSWLUpKEO+j7u cQTynhj8w0l3vFBctqob0LIJxBJlv0f23YYZ0ITBzKAwQyLG9PTFSTx+0ZxVjVVQtrjt yz9O4n88aNVz3K9w+cNIGApTsMkR8gTHOO3bd781v9NEcURSWw5fqHY/IYkLc6k14a2k 7WbFhxs/dt3EQ8PvYM1Scu2XQrXBqdOXnHwkCJSx7+gR7SIfwkNY8stpgSgbzdphyujk Tq5A== X-Forwarded-Encrypted: i=1; AJvYcCWBY/x1oSRl3ReJwxa4Ob/ZLn9nsxz2jrLRb/9a9Amuc9VpYfKgq90+xmk0eC2aG18xoMIMbweW4UotRuQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyAH75D2KAtys0gnNt/zXz6/sjWOFzMNcLXyivq/vsg2bIY9ljy IUHJkYDG8OaPoaoENeujb2gggkl7Ge2QIB1FgNknmWaShOK+srwaRC+4msIMg53KSDIs2awgmab EU+9jK2dsQCZUIfrBb+8tZDAATxPMfkNaRGyX3ZARXbkVcPoXufbHtgKe6zmgw5oQepI= X-Gm-Gg: AY/fxX4iq5CVHJ6TD4AjmAgofAbMHxr8hI5nOKOicYopL/QXXEkvv2xXwgftWXLGLxm 1+X/6i/2ZAtSVAGuQ/RWS1TEa0BNVv9IBCMVpopJVhFpId2BJXeH/gqRLjgtHPe5n902/IW/psx NYriOXrZcMnXFW4kxSI1dwvVJor2R3K5H4a+ysB3o+aLbtJVLVqjvCUPUqK6x7JqtNxGuFK8F6h FtPwNlyKXKc/VBgrVXOfDAWclksuNuJB31Ah5wudlDJ+WXXvuCURlNUeUV5ebX9Zs1PKr26Twz0 0vr5WWFb2aXbnicmDF/qCHW3QXji7/3YJLe04mBI6aA6ESF8690Z5YAnLZCS+0k+5hR2Qpmvc9D mMYEZWbkshyECkH3xMmMxt40iSwlpBa0io+Cpi/Kb83IhK76k77xWAy7fcqA7y7N47ttPfF+fZm MpoHotirT99RoUbpm42XWsX8k= X-Received: by 2002:a05:620a:178d:b0:8c6:a67e:61bf with SMTP id af79cd13be357-8c6a68febfemr761758685a.35.1768631766667; Fri, 16 Jan 2026 22:36:06 -0800 (PST) X-Received: by 2002:a05:620a:178d:b0:8c6:a67e:61bf with SMTP id af79cd13be357-8c6a68febfemr761755485a.35.1768631765900; Fri, 16 Jan 2026 22:36:05 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38384e790fdsm14049851fa.23.2026.01.16.22.36.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 22:36:05 -0800 (PST) From: Dmitry Baryshkov Date: Sat, 17 Jan 2026 08:35:56 +0200 Subject: [PATCH 3/4] drm/msm/dpu: program correct register for UBWC config on DPU 8.x+ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260117-msm-ubwc-fixes-v1-3-d5c65ea552c7@oss.qualcomm.com> References: <20260117-msm-ubwc-fixes-v1-0-d5c65ea552c7@oss.qualcomm.com> In-Reply-To: <20260117-msm-ubwc-fixes-v1-0-d5c65ea552c7@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2979; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=nlqM4pS5tehTmTBqQ+prrjj8JpfEcAuwIhsTGK973JQ=; b=kA0DAAoBizyKPgIpKNUByyZiAGlrLcuiL8MkgPFSm3o4qmPlZP11oUebtpgD/SJwLhgu7To09 YkBMwQAAQoAHRYhBExwhJVcsmNW8LiVf4s8ij4CKSjVBQJpay3LAAoJEIs8ij4CKSjVQw4IAInW 3Ud8Kly5piacDGSG67f1XD8kBrTVNYzH+daL0OOoid1NYcYu+6e04YS1FRmgxV9A4EMbieuVUiJ 5JTH55BdEJNXMZCNGe6+hk/brfvRNlpgP2YiM2Xda6EFSBqxHPQj6Bgs9FjphEdFveUDbAAf8HO lDXWEnWNQX48uXCcghWrquoJfmfNNyVDu8h9H3wZcfFiTpYMyerxioJDhkYc+DMAaa4pXp8vyWC A+NcwUIrQFBaQyBvebJrJ0fP27Bum4GSHFf+c7iwbMU/0mXF0cBaOrdiu7Mo4KZTlWKOGjGZptO LibpxAowXKlxsSSbSIwY8e5G7cxM1YMFJDuD9Ys= X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE3MDA1MiBTYWx0ZWRfX9lEyRqFUAkmW XX8vTsHKo+ziotkulQhmkyfkwOZ5hYONpymAelCmSKXuH9ifAtSfzm32/UzcsMPKEicgpd0E+Wx 5A38g14Fo8YGJtwNw3QAb7ZKqX3N5H4AdMWf6GxOFR0ZntEmS4lLxDCCWcvI9Va6tPjRH2mHyfV /jdteeP5juWuYidUBfioxH9xdbo7x5svEXzBx3mNwo4/8iLC9P8jI2xhOfy+VA8Vos9Nj53C/Ej QMArI46EqhmlsvdeBYWn1wt6SDTHGHMEdIAfLV8HElmFl5ywERgHtHXxRgdaQWFeBd1IEnZv0O3 ilsh06BdMLjJU0UYQq34SnHpd0e5CjdkrOKt82VwU/mgpigiXJWB1SghU/BA54YEZFoS88N//uQ m3jxJtVs7LxgjlEv2Y2FUuCMuUOyLV0uUA1LHKaQN+X1HscxRCWieotghsF6xMqK+chCxd68G/s aCivwnQLtx4PeeoXaXA== X-Authority-Analysis: v=2.4 cv=Sev6t/Ru c=1 sm=1 tr=0 ts=696b2dd7 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=7tap2HhiP8zdS8EL3YEA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: jXb9ywx9oE4vvjeJDA0OWLZZaw8uj4Pp X-Proofpoint-ORIG-GUID: jXb9ywx9oE4vvjeJDA0OWLZZaw8uj4Pp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-16_09,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601170052 Since DPU 8.0 there is a separate register for the second rectangle, which needs to be programmed with the UBWC config if multirect is being used. Write pipe's UBWC configuration to the correct register. Fixes: 100d7ef6995d ("drm/msm/dpu: add support for SM8450") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index b66c4cb5760c..a99e33230514 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -72,6 +72,7 @@ #define SSPP_EXCL_REC_XY_REC1 0x188 #define SSPP_EXCL_REC_SIZE 0x1B4 #define SSPP_EXCL_REC_XY 0x1B8 +#define SSPP_UBWC_STATIC_CTRL_REC1 0x1c0 #define SSPP_CLK_CTRL 0x330 =20 /* SSPP_SRC_OP_MODE & OP_MODE_REC1 */ @@ -215,7 +216,7 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pipe= *pipe, u32 chroma_samp, unpack, src_format; u32 opmode =3D 0; u32 fast_clear =3D 0; - u32 op_mode_off, unpack_pat_off, format_off; + u32 op_mode_off, unpack_pat_off, format_off, ubwc_static_ctrl_off; =20 if (!ctx || !fmt) return; @@ -225,10 +226,17 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, op_mode_off =3D SSPP_SRC_OP_MODE; unpack_pat_off =3D SSPP_SRC_UNPACK_PATTERN; format_off =3D SSPP_SRC_FORMAT; + ubwc_static_ctrl_off =3D SSPP_UBWC_STATIC_CTRL; } else { op_mode_off =3D SSPP_SRC_OP_MODE_REC1; unpack_pat_off =3D SSPP_SRC_UNPACK_PATTERN_REC1; format_off =3D SSPP_SRC_FORMAT_REC1; + + /* reg wasn't present before DPU 8.0 */ + if (ctx->mdss_ver->core_major_ver >=3D 8) + ubwc_static_ctrl_off =3D SSPP_UBWC_STATIC_CTRL_REC1; + else + ubwc_static_ctrl_off =3D SSPP_UBWC_STATIC_CTRL; } =20 c =3D &ctx->hw; @@ -281,24 +289,24 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, switch (ctx->ubwc->ubwc_enc_version) { case UBWC_1_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_static_ctrl_off, fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | BIT(8) | (hbb << 4)); break; case UBWC_2_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_static_ctrl_off, fast_clear | (ctx->ubwc->ubwc_swizzle) | (hbb << 4)); break; case UBWC_3_0: - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_static_ctrl_off, BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4)); break; case UBWC_4_0: - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_static_ctrl_off, MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30)); break; } --=20 2.47.3