From nobody Sun Feb 8 14:31:25 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C5CF329E75 for ; Sat, 17 Jan 2026 06:36:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768631764; cv=none; b=S1OYlxveNBH1DJUkzlTYuLzfPfZhXvfcp2VBHbRGHaqggYhU/Z4kzCZfbnay/RXO6XU6Yoh2Woc62jE21bKSlQ5vHoznd8SLt/+Xg0q4/TG0QAhBvzhZ7p9GTsneFM6yDGDgZUmq1fJWX0IcbYPk25em1XxGflAqmCXXcHi0jaI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768631764; c=relaxed/simple; bh=Rj8iAyMfVncSKRo62kAtziE4yMoYdmQABsHSh5kDWEY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IVYBwhISJH3wqE64bDqniQu9t5v/jXc/oTbpeVBD9yiMvC5qrwgH6GUWLCOGceR6BJRhjDEVaZ/7lBXLQqlu3eXrNtVlzAyDS1PHVlrgUvS90flD+hiHtXvp2IoZrvkeh7GW241BMO2IHOdXjaGpnYPeQjH36Vrw9Ivo+uUtuMM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=H6ZGO5UD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=F/DAWdB1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="H6ZGO5UD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="F/DAWdB1" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60H3jYVh2738969 for ; Sat, 17 Jan 2026 06:36:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2tTHPmj2NBaJb//qs7JmAmt97xPSCIRHJxgVnBNp34c=; b=H6ZGO5UDfKJ9ThXp 7/j2frgM59P/RJzsMIxNqq8aC3y2O1gGrrd+B8xRl66TbCGN1tKHdXeBN3QhSPKN Cn0NsVJsdLbMz42ZdAEBbVAlpDTrpRBCmtlkT7o09788wg8m1pXIA6rFVGvIjBZZ qrhZg+PNfq1OAChIaEgcABeratz0aNbfHuLdx3BVywrBpocXRweW+ObUyC49xWHd no7vRTHWgoWpeLPgBsKM+m5ntou0TXja8Ge9dSTxsUsv9JcT5IsoBl7BGB2dffUp RFKCOWbMBcDlPHN9H6iC67F0mdAfqrvVJaT2/D3BYbG+lCtJfoGJwRNd7XwBN1mi Bjs3eQ== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br2t709wr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Jan 2026 06:36:02 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8823f4666abso71351056d6.0 for ; Fri, 16 Jan 2026 22:36:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768631761; x=1769236561; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2tTHPmj2NBaJb//qs7JmAmt97xPSCIRHJxgVnBNp34c=; b=F/DAWdB1z0kKynDKFV/e1KR5O1gy5MOHGYxLuyze3SHfkWm9A9PpYUwzMUAS6OHmFj MBbtbZA30nPne0JoTh+0RKIdW33Gq+TFbSJOuDWcDpCRBiMSwQG0I/vPHtOeyNcNYfuN xwFbiFlEVu8i+64/hD/pyg84HPw3qaVRHurzpjd0ZSPMc9UcMw64UuzW1tybedJ6wxZO qPlsMZS5ZGhjpUd0ISaOfatPdjmiXMqRN1iwbTwAyPHJMUwTU+kPW7wLYV40JFhvo/kP HLyaTjIcUlz+cnSOPSrj7syYIg88k2okPNd6LyCJpgyOj6kQKh61FiYwiaU2eaBVtckK dAPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768631761; x=1769236561; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2tTHPmj2NBaJb//qs7JmAmt97xPSCIRHJxgVnBNp34c=; b=MeByBY2OAn+bvCjCym/BK5+LEVtbNmWnbI47XLlgXoOzrcxmpaBIXGa6t3D68qICa9 rlClzWt5KM4xtIq01ImVR4HQbNgaFsLIZ31o9bEtcSjS6EfoBhjPcejEf45Hm4+yPcez O7C/vKYQVjXcIijN2h/rp145jbKNsGUQDlR+uu+x+oipluKUFLjetx4g5aDzOLJhCH3m lkbXWA4QdvX92I6+qAk8mTW7zDCAc8Xr9vBeHkBYT78KOlQRzhd8phSbYlIA4pLBhnWP wEwQ5oWqWr5YdaXFY5mKp3vQt4/Jv2uiAVjzLbkcW8YiRiZk2eZ8LdUjXuHsw6IpDODC 6puA== X-Forwarded-Encrypted: i=1; AJvYcCU+5KScB2k8dp0NZ1TkHHruJ/9AJH3nIvbdRd72OXcNdjfndyorAbb01R7FxGSIAOjQ6mK5OAAe2TVN3Po=@vger.kernel.org X-Gm-Message-State: AOJu0YxTtKXU2KlibroTe/UF/kc0YhLff9q8wr/tJ6y68HMCIauQ2ELf MItDoKaXGqMjpCyYQONWkBZjwp9ossOrupQzsQphOlF1RqzNYBMerYmjzh1R5X4qgAlUsz9KKW0 LIm/JmKP4KqNAzXd71s6WaWyrl2ZOto0B8MS4e++a41/q9ytkSEsDquAQEjepnQcUeN4= X-Gm-Gg: AY/fxX4H3aMf4eKYfo3+bIuV8rCGWiXMn/wmiQ5Fvei3Jws7r/ItGPrEXbrWaZTZPqy ORfPRNsN145W2LcnKPKObDUNWXnzCmxymdDJHUwd4+Qo77aVPSuEEHaYhCqQaEUV5tJUmJSovKe 2J7gLXtBNQKGC9d5GJuonxx//yO4v393FF1mm/5sn20ROmi/km0B1pvup6Es1Xe+srB9OLlg/wc njU1G1dxAMCZUbbqGubF93H1+OFn7CJsrH7wKoMAkP385jZDdhaNbsQtVaJXcvUsFcDcqfqBeJ5 yRP9DebLjC2kNzyYDNJfRhKlAcrXwoYQ/svDWQVzLQcBFIatP6jaoP+Hn4Z6PIOYsoCMpwM2bjE T8H5qEs5EcH5E0M2oHRb4vnRdHN1aJKR6hGL+l4BOMkS+GTlneyzS/APiwbCIpU3+UfovX7Q8UL ZcviWUlziUaV8omtSJpRecRgY= X-Received: by 2002:a05:620a:2a02:b0:8c5:3869:3f28 with SMTP id af79cd13be357-8c6a695902fmr797747385a.85.1768631761501; Fri, 16 Jan 2026 22:36:01 -0800 (PST) X-Received: by 2002:a05:620a:2a02:b0:8c5:3869:3f28 with SMTP id af79cd13be357-8c6a695902fmr797744785a.85.1768631761035; Fri, 16 Jan 2026 22:36:01 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38384e790fdsm14049851fa.23.2026.01.16.22.35.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 22:36:00 -0800 (PST) From: Dmitry Baryshkov Date: Sat, 17 Jan 2026 08:35:54 +0200 Subject: [PATCH 1/4] drm/msm/mdss: correct HBB programmed on UBWC 5.x and 6.x devices Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260117-msm-ubwc-fixes-v1-1-d5c65ea552c7@oss.qualcomm.com> References: <20260117-msm-ubwc-fixes-v1-0-d5c65ea552c7@oss.qualcomm.com> In-Reply-To: <20260117-msm-ubwc-fixes-v1-0-d5c65ea552c7@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1114; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Rj8iAyMfVncSKRo62kAtziE4yMoYdmQABsHSh5kDWEY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpay3LXy7BviCDiClLOQ2PK8+jm9Hcs0eMu17i7 xUfA2+3DIWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaWstywAKCRCLPIo+Aiko 1V/KB/46WgKJQQ+Lx/fXdiYXGiGzZRRziXq0o8DqaUBQZkJIKcpHd/e3QAEcEzG1qzWUoKJDGVM CWj5dcjoOz4GOfBp02RahyGcVMfRWym/6KWCmq/5onHWRgctC/scP9O/8j9W5gHMIR1H93ijpIo It2YM/n/pooiBA3EHr6Dx5r51y44w4kSrwNo1t3Pl8sbQxq/xHuIYFLXnIvLDxXdTOcwExyzlXe kAeomzjiB3znPgp28UWNmTb5tyBYNSTFgOCAoVKS8tBX4VbnWUGB6CijhL619Nb5TOkvAu/2Yz4 /Ybne8HeCKGMg8aQMXO83qJyYQWiWZ1lUHur2rjvge8JL5zy X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=Fdc6BZ+6 c=1 sm=1 tr=0 ts=696b2dd2 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=iGWu5DhtBPyiFZBs7r8A:9 a=+jEqtf1s3R9VXZ0wqowq2kgwd+I=:19 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-ORIG-GUID: 5gVKByFxIsPlZpVjo8r0ofiSUSkdv9Z8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE3MDA1MiBTYWx0ZWRfX3kFHJfIwobbW sYxQdvZ2HUzAfA+SuJFcvaziK2D3MSWaEWzXGmV/42YIlxdgdS5/oHtzQ+i2yrGZcV3CE3zsqQd ux2ZNVyJEueFBTddfkGne5jHkhLM48B4Gs8KCVKQ+n6RtedAIIGbiJ6jOf7+1EWUTR+cLQtCj60 ncwaeKgdO7PBE9IhdZ2ww7JDBN/pIcWMyJvhJwdyxHVp4rEzZGRL56tXYexHHt5spVGsUt9tBjT sEHxumPC8RyT1JXSs9pU+skGYv48JKO3+UF+txbLyC5bEAQMmQG6rLH322zDEVXiazZwBFN3jIs h9MGUnSLhybsasrQE/XQi8hj+88oQHxCnLy0Q9NxI+QMX5671STW2S55yVOyAOe3DpLciAcJmkE L10IXDqFb314iWtqcaY6ktdvAYuq7iO5LbrE0ObR+rsp07QrE83SuTiJmjjLGV94V+sBCbrgDs3 o318o6w6yBNndTcewNQ== X-Proofpoint-GUID: 5gVKByFxIsPlZpVjo8r0ofiSUSkdv9Z8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-16_09,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601170052 As in the previous generations, on UBWC 5.x and 6.x devices the Highest Bank Bit value should be programmed into the hardware with the offset of -13. Correct the value written into the register to prevent unpredictable results. Fixes: 227d4ce0b09e ("drm/msm: Offset MDSS HBB value by 13") Signed-off-by: Dmitry Baryshkov Tested-by: Val Packett # x1e80100-dell-latitude-7455 --- drivers/gpu/drm/msm/msm_mdss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index bf9a33e925ac..910242f5a71f 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -229,7 +229,7 @@ static void msm_mdss_setup_ubwc_dec_50(struct msm_mdss = *msm_mdss) { const struct qcom_ubwc_cfg_data *data =3D msm_mdss->mdss_data; u32 value =3D MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | - MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit); + MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); =20 if (data->ubwc_bank_spread) value |=3D MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; --=20 2.47.3 From nobody Sun Feb 8 14:31:25 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32C313093C4 for ; Sat, 17 Jan 2026 06:36:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768631768; cv=none; b=lzQeN/ZRFw1eS7i5LJiYi5w/5I6Si8r+7GTw3gBTEFd6Wmnf0WB42ywHHZJn8FFRvmoisvc7Oi7IRqabxYSYa9qV7sg6gv0Ybeytl1NbVlkYgmeLa2jQKqdlFlharDKiLM9Y6ZC5TqK5Gdsa7B1aWBsWqJ/wbH70qUYRFd0vZvc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768631768; c=relaxed/simple; bh=pAwvHUCEcXNpm+LDy8SETL5I47IZwg6IMDS0FVV1308=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jCUvaWdMpT6tK30St9gDYALDsKyE0OoeVjl+LKZMTP8xxOA2J2JTGoK1h/KZj/xiSvvIc8RtIbEXZJPXTRUKOTO/LljNIcZkIxvdiE//yESdiJbfcXJOSJwsYgY7RZ+QymSNs6lHTEG9RnZ1F5JilRcmQABP9IpFWR85hKo1pZQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jLcE31w2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VcHSWqeM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jLcE31w2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VcHSWqeM" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60H2pmTm2151654 for ; Sat, 17 Jan 2026 06:36:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Q2s2/Y+rMi8EkXfWOzNwWPKg5Sl+rEgH1nG07NabTws=; b=jLcE31w2IBpt0At+ bSqTZkfYMVmDjqiDGwxdmFUD3RXLSvubWclXzxJI/RuGrSFeYYMVpUS0xFTA/S2n vDz6zji4Qfk/t8FKzkLPr+U5PqeZ22kRKHR2W4eMDhsfmfqbTw7v4Jmq2lvqUKsm J/LopY85UWUt71jhKzdFyRgZBKMVRlUFmT6QLRYoQKBtT9LANSSBAzfN3hY1svEr H2LjS7meoDvxjKHT4j3E2RqkYZ95MadpYCzAwvfhxMOsSKXKL5rJu3f/KuFEuiwH 54885+EzmjuN6ONWGEwhGHNriU4uJFPmUME5Q45Gg7xlIDqjU2zVrY01QLL6ceAE 1Abo1Q== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br20x0dsy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Jan 2026 06:36:05 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c6b20137a6so138040885a.3 for ; Fri, 16 Jan 2026 22:36:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768631765; x=1769236565; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Q2s2/Y+rMi8EkXfWOzNwWPKg5Sl+rEgH1nG07NabTws=; b=VcHSWqeMe2AWdc2pTqdyDtuXiQsRXPNXQ929xMeAoDQe+KsKCcmvp3ljzM2isr44Di jVyLmy5KQa82G3dmXmkb7ZFUK6MZ0dCqLWM6ZBKtZ8PG9NlrKbwnz5zbvozDLMTphLPX gWsqXenyQ8YEBNrW7X/xSK8RjoGAeKg5/fOT/LLn6/zUuufpJ1ZoyM6j7J4HLu7CPT8V LZzFvg7znviiCZd1WFO4RzvEiLbX10+IZ934akOsNu27U1nU6VdWzzvjWGWFPzq4RhdQ gOldVJgyIUWpJOxEZmH/HFFCak/7mY7VKPQygxaPg/XNsQCEeOl+YGQVgfJq6L7DPu4n 2Q2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768631765; x=1769236565; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Q2s2/Y+rMi8EkXfWOzNwWPKg5Sl+rEgH1nG07NabTws=; b=Kz1kKfTjIxJ1a1+ufaX6Daz2A149V0sgm5kYOzpiHaxSQ53ITcMVJOW6iJCOtxUBKr gf4PIYTvZgU4o0V7eiZYIZO4+nz/wveZn2h0lKbYYvQtD1mbyu/6I+t/dK5K0V4qK+D/ 6ShaVz7ooyg3W3HCJTcBFoVp2vy1DEehIBA6SE3pukWKS7kt+q0VjilQchCIeoJfEm65 Uch4/2Xw2ihzfr3qkvhdLmYD5zedA3I0iApisONTF2FlEQpkKPaNNzcc0LL/cxTXFNht MumJZTaP4sGJDJzpBzcZ4qgjuQ7FYYT8ebHNNMGckdsp7JB6YVZ2LURLXkyux3LlnA/a wEwQ== X-Forwarded-Encrypted: i=1; AJvYcCW6nOzou061D62/gYJIgSwAB0iCM01WjdSrJipHn6dOkg/tDQC+hcwwmnxpAmPAq7xS3EY2fYJ1iqBuApI=@vger.kernel.org X-Gm-Message-State: AOJu0YxALiMW17S+GeQJO/NjyDPfm8ui53oU5uCGcquYZx8psFGsk8eS w5PJ1CmH4OWO0Srte8SXk0IyZHryE1Bb399tcDvS1DsSHkRCGx8OapvUmjOByN7N3bWQWl53N0B q42LGlZGLMjEPZgAZlCrYlvhO9QwO1L7GUdnVU0VZLX2Dt0C83uYjE3qlBUJ9VcAvMn0= X-Gm-Gg: AY/fxX6Cn4vEg+FFoAVV4bZV1T37wLEdLKYC2VRiTt78aN9TmKbNGby97WQsiApFTxN hjY07LGqSECs7EzE3WAW6busYdEc9+wbSrLNpM/0mfGIcyPj2X6cfqNu/7ubr8x/HOzBVbn1ltn 98KqdupIm3hpPmiXHm4a0v7b0/iSLjmc1zeGnd6cs8rv3DlYbdSpqQW/RwFOKqAqG94Ihm7X1bT QHDK9RFzCLTDceHOGSHCCvRUbL+cxw/U1JTwZ5avW44o1lZp4c8Snckk/YPqxQaoMnqBhLD01h2 8fElMgtZJ9A9jY4RfgKp0q/SijNHHqzw1L2JLL//2iOm9fyHt98xlPhe7/iXqqcIysNN4uYdEwK mPTBIJoYvrqk+sfOWzKH6u6x5VsbpV0Cnr7LRs3EGeFPlGBaa0TJPe4cB1xZRdCsYzWzbBhcdBv 6Qet4e/PDS18KI+OS8dbu3jDg= X-Received: by 2002:a05:620a:2699:b0:8b2:de6a:ca with SMTP id af79cd13be357-8c6a6764a8dmr777936485a.52.1768631765267; Fri, 16 Jan 2026 22:36:05 -0800 (PST) X-Received: by 2002:a05:620a:2699:b0:8b2:de6a:ca with SMTP id af79cd13be357-8c6a6764a8dmr777933485a.52.1768631764752; Fri, 16 Jan 2026 22:36:04 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38384e790fdsm14049851fa.23.2026.01.16.22.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 22:36:02 -0800 (PST) From: Dmitry Baryshkov Date: Sat, 17 Jan 2026 08:35:55 +0200 Subject: [PATCH 2/4] drm/msm/dpu: offset HBB values written to DPU by -13 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260117-msm-ubwc-fixes-v1-2-d5c65ea552c7@oss.qualcomm.com> References: <20260117-msm-ubwc-fixes-v1-0-d5c65ea552c7@oss.qualcomm.com> In-Reply-To: <20260117-msm-ubwc-fixes-v1-0-d5c65ea552c7@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1982; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=pAwvHUCEcXNpm+LDy8SETL5I47IZwg6IMDS0FVV1308=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpay3LwLtC+kj2HBoDxcWwc+QhCyCWUb0ECl5wO d89f5P+uvaJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaWstywAKCRCLPIo+Aiko 1XrhCACVi4wbYAVIcssEV3/mLOyF3vso5kep+hgNtASJMx/eNsD5wt/+iZRV8Q1XNOfcPViiQ8Y OPdGumJpMcoPhXkkmxMJ6yWcFSWmZu90i165KrX/iUssDk++S4UwhqBWnp6RGxhTr4hnhS9xNQl kHc2bjThbFxBTSWpyperO3O6sZuJih1IEDCeedXq9AJxKwmFzEw/UCQYLQ+MBm/f0/rZR5/27+s 7rc1GO8L3+KWKXb/1FqL3Ids2kLd957fdGtr2o18GBY1rIkR6p/r9Z0W5ZwFBrfo2lGsxI4Cq/F 0yEOxI3POI8B4USsdj9seca0a3LcJznUlIG6rp2XliYvnCm7 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE3MDA1MiBTYWx0ZWRfXxPO+JBu4A+/p Go3u2TIP3aQeiJpQsS7WcFnamrv/Ar/12g+ADe0Jna2rnEejkbtJ5OTWte1AYdexgaCZT7gSKJF Mp3c5VhQq1UzIc6oLz5RG8lRmG+mVq4nT8GT3TqqwZ/nSV7a1vWIeyzy5BS+9a3hkplJVDPrRgb MFDa0YYStU0v+6QPs2sN8Kpg5mJKZXCZtNrKfIuGHClAUrGFWHcT5sW9BcncAQkq5y6RvfyLk0C T10mkd/oss4OVwtJW1oLT4ctkAfrfJXeXQyOehfntSZQONTgs1b9FoCJC/6/uuGUC+GfNa2n25D Ojr1BAg+cvlZMwDrO/HaRgqFgOYxGwRad+9ni6wGxX6Dk9CBcxEzwM0LrVvrmab7Nv76QzNenPT Le5vWfLBY3D8ibyJuNwh2Ou3SXcdZIVLoKgUWAdS2Ct0bM3NHt8N54rHSWIF+F6vDeFXCQUz49E lx2/wKI2W2yvJYewb8g== X-Proofpoint-ORIG-GUID: 7scAlZXBhEZ3pbdcQaR_uU3py6tvSYu9 X-Proofpoint-GUID: 7scAlZXBhEZ3pbdcQaR_uU3py6tvSYu9 X-Authority-Analysis: v=2.4 cv=abRsXBot c=1 sm=1 tr=0 ts=696b2dd5 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=iGWu5DhtBPyiFZBs7r8A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-16_09,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601170052 As in all other places, the Highest Bank Bit value should be programmed into the hardware with the offset of -13. Correct the value written into the register to prevent unpredictable results. Fixes: 227d4ce0b09e ("drm/msm: Offset MDSS HBB value by 13") Signed-off-by: Dmitry Baryshkov Tested-by: Val Packett # x1e80100-dell-latitude-7455 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index 6f1fc790ad6d..b66c4cb5760c 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -270,30 +270,32 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, ((fmt->bpp - 1) << 9); =20 if (fmt->fetch_mode !=3D MDP_FETCH_LINEAR) { + u32 hbb =3D ctx->ubwc->highest_bank_bit - 13; + if (MSM_FORMAT_IS_UBWC(fmt)) opmode |=3D MDSS_MDP_OP_BWC_EN; src_format |=3D (fmt->fetch_mode & 3) << 30; /*FRAME_FORMAT */ DPU_REG_WRITE(c, SSPP_FETCH_CONFIG, DPU_FETCH_CONFIG_RESET_VALUE | - ctx->ubwc->highest_bank_bit << 18); + hbb << 18); switch (ctx->ubwc->ubwc_enc_version) { case UBWC_1_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | BIT(8) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_2_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, fast_clear | (ctx->ubwc->ubwc_swizzle) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_3_0: DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, BIT(30) | (ctx->ubwc->ubwc_swizzle) | - (ctx->ubwc->highest_bank_bit << 4)); + (hbb << 4)); break; case UBWC_4_0: DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, --=20 2.47.3 From nobody Sun Feb 8 14:31:25 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69087318B94 for ; Sat, 17 Jan 2026 06:36:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768631773; cv=none; b=nmBdhwlmDBvGpFHjUKrk/Uz09knyNirv4BYGJ9xqDC5HSx24HS/eR5D9cJe6SUo59z2cNnVrRsD7KqcxCoBV7ralr8O5Hmcs/rKXaAJvN+/vdsyim06Grc2u1UFFLFICtgYo2KNB7bPHAhDJZPA86Bx3Lm7IqOAOkK3XNY2rXp4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768631773; c=relaxed/simple; bh=nlqM4pS5tehTmTBqQ+prrjj8JpfEcAuwIhsTGK973JQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lK52ZImdFaIqaVMe87lLVKoMMQx0PuPndKzfWfw4qDY7HhRv9ZI0aU83e/h5eVR5HKV97oJlP1Nzwwe7uIj307w5VPS6BquiNK+X7lN6Pq54/MNACSZLn3CLU6ADPrUwFLyHqe+fZP6pz0zjP7gIWoumA7xm/zOCvj26cvaXN84= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T2gYMz8j; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ov3BPqlM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T2gYMz8j"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ov3BPqlM" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60H3QOqS3465864 for ; Sat, 17 Jan 2026 06:36:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /NThq6KSUJeukEL9pMouMMZw++r4/wpGPMWQ27LsLSs=; b=T2gYMz8j2ONQNJ3o hWYBszQOTJd/zdTcGiIVqNeTY9BYcS8tQpzgJc8quajCh3nztuRGf51hcCQQMWYB dsmWdjOJjLCdIndAxduSTqHlQEj3KoDIKKuctKL03+Lmz+9cVtVyf7uvCw4lsTfW 2lug7JVRp4opxaTQQEgddhUBX+NxuvHNvm5cRVrKZcgxfpanp2mC5l615suczTos His4Mtz+vt3dtsZ7vaJ+mSXhhUlRs1gomgLqBTYRe+uhqAEBR+pd7TEcMVrS6IMT HwsFYUFrS/3iYripUxZfzpcwYj6SEpyiZ4ffiqMnowPfEeHeYVGagtUG98ThGFJ6 6rBn6g== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br2gugata-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Jan 2026 06:36:07 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c6a4c50fe5so726990085a.3 for ; Fri, 16 Jan 2026 22:36:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768631767; x=1769236567; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/NThq6KSUJeukEL9pMouMMZw++r4/wpGPMWQ27LsLSs=; b=Ov3BPqlMJDSXuKAs0/bRuaWH2MhegDt2Bd5cwdmccCOYpPTWI4J2qVW9WJUg8UnXh/ AWQMwNXvlk14lMwQm4+d44QTvUXEpIp9pHAzUH37L2rkFST8c3OJN8XXlh7erACjHjFr CbX6eY1zNpGDg7xmu4awWsI/rYQzrb/O60paBCAJsiJkCoSuJ5YFzd2DgGGOSjXWCeNK bgi81L0IvvJgkWpX7sQEBC9EXb2sSoicgingNFTVcqplTFwM0HrmshQWS4ILRRNoCWoT ek57LwKNh28NswUoNn7BBL/i3s/ThMfxOCUImSEn+8N60fGkWuWYIXsskI9grM9VAryX Kcgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768631767; x=1769236567; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/NThq6KSUJeukEL9pMouMMZw++r4/wpGPMWQ27LsLSs=; b=fsLKfCvlbIf9klJvZco8EOdyb+MvzLQLqOHnaWE32VVVY6D3H7jg7jpwViVo3kmESf eJx+oJFD7cgAep93xtKKwE5qzlmKPdDwXkVLI1LVCF0SzaXL99LdSMrXSWLUpKEO+j7u cQTynhj8w0l3vFBctqob0LIJxBJlv0f23YYZ0ITBzKAwQyLG9PTFSTx+0ZxVjVVQtrjt yz9O4n88aNVz3K9w+cNIGApTsMkR8gTHOO3bd781v9NEcURSWw5fqHY/IYkLc6k14a2k 7WbFhxs/dt3EQ8PvYM1Scu2XQrXBqdOXnHwkCJSx7+gR7SIfwkNY8stpgSgbzdphyujk Tq5A== X-Forwarded-Encrypted: i=1; AJvYcCWBY/x1oSRl3ReJwxa4Ob/ZLn9nsxz2jrLRb/9a9Amuc9VpYfKgq90+xmk0eC2aG18xoMIMbweW4UotRuQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyAH75D2KAtys0gnNt/zXz6/sjWOFzMNcLXyivq/vsg2bIY9ljy IUHJkYDG8OaPoaoENeujb2gggkl7Ge2QIB1FgNknmWaShOK+srwaRC+4msIMg53KSDIs2awgmab EU+9jK2dsQCZUIfrBb+8tZDAATxPMfkNaRGyX3ZARXbkVcPoXufbHtgKe6zmgw5oQepI= X-Gm-Gg: AY/fxX4iq5CVHJ6TD4AjmAgofAbMHxr8hI5nOKOicYopL/QXXEkvv2xXwgftWXLGLxm 1+X/6i/2ZAtSVAGuQ/RWS1TEa0BNVv9IBCMVpopJVhFpId2BJXeH/gqRLjgtHPe5n902/IW/psx NYriOXrZcMnXFW4kxSI1dwvVJor2R3K5H4a+ysB3o+aLbtJVLVqjvCUPUqK6x7JqtNxGuFK8F6h FtPwNlyKXKc/VBgrVXOfDAWclksuNuJB31Ah5wudlDJ+WXXvuCURlNUeUV5ebX9Zs1PKr26Twz0 0vr5WWFb2aXbnicmDF/qCHW3QXji7/3YJLe04mBI6aA6ESF8690Z5YAnLZCS+0k+5hR2Qpmvc9D mMYEZWbkshyECkH3xMmMxt40iSwlpBa0io+Cpi/Kb83IhK76k77xWAy7fcqA7y7N47ttPfF+fZm MpoHotirT99RoUbpm42XWsX8k= X-Received: by 2002:a05:620a:178d:b0:8c6:a67e:61bf with SMTP id af79cd13be357-8c6a68febfemr761758685a.35.1768631766667; Fri, 16 Jan 2026 22:36:06 -0800 (PST) X-Received: by 2002:a05:620a:178d:b0:8c6:a67e:61bf with SMTP id af79cd13be357-8c6a68febfemr761755485a.35.1768631765900; Fri, 16 Jan 2026 22:36:05 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38384e790fdsm14049851fa.23.2026.01.16.22.36.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 22:36:05 -0800 (PST) From: Dmitry Baryshkov Date: Sat, 17 Jan 2026 08:35:56 +0200 Subject: [PATCH 3/4] drm/msm/dpu: program correct register for UBWC config on DPU 8.x+ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260117-msm-ubwc-fixes-v1-3-d5c65ea552c7@oss.qualcomm.com> References: <20260117-msm-ubwc-fixes-v1-0-d5c65ea552c7@oss.qualcomm.com> In-Reply-To: <20260117-msm-ubwc-fixes-v1-0-d5c65ea552c7@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2979; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=nlqM4pS5tehTmTBqQ+prrjj8JpfEcAuwIhsTGK973JQ=; b=kA0DAAoBizyKPgIpKNUByyZiAGlrLcuiL8MkgPFSm3o4qmPlZP11oUebtpgD/SJwLhgu7To09 YkBMwQAAQoAHRYhBExwhJVcsmNW8LiVf4s8ij4CKSjVBQJpay3LAAoJEIs8ij4CKSjVQw4IAInW 3Ud8Kly5piacDGSG67f1XD8kBrTVNYzH+daL0OOoid1NYcYu+6e04YS1FRmgxV9A4EMbieuVUiJ 5JTH55BdEJNXMZCNGe6+hk/brfvRNlpgP2YiM2Xda6EFSBqxHPQj6Bgs9FjphEdFveUDbAAf8HO lDXWEnWNQX48uXCcghWrquoJfmfNNyVDu8h9H3wZcfFiTpYMyerxioJDhkYc+DMAaa4pXp8vyWC A+NcwUIrQFBaQyBvebJrJ0fP27Bum4GSHFf+c7iwbMU/0mXF0cBaOrdiu7Mo4KZTlWKOGjGZptO LibpxAowXKlxsSSbSIwY8e5G7cxM1YMFJDuD9Ys= X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE3MDA1MiBTYWx0ZWRfX9lEyRqFUAkmW XX8vTsHKo+ziotkulQhmkyfkwOZ5hYONpymAelCmSKXuH9ifAtSfzm32/UzcsMPKEicgpd0E+Wx 5A38g14Fo8YGJtwNw3QAb7ZKqX3N5H4AdMWf6GxOFR0ZntEmS4lLxDCCWcvI9Va6tPjRH2mHyfV /jdteeP5juWuYidUBfioxH9xdbo7x5svEXzBx3mNwo4/8iLC9P8jI2xhOfy+VA8Vos9Nj53C/Ej QMArI46EqhmlsvdeBYWn1wt6SDTHGHMEdIAfLV8HElmFl5ywERgHtHXxRgdaQWFeBd1IEnZv0O3 ilsh06BdMLjJU0UYQq34SnHpd0e5CjdkrOKt82VwU/mgpigiXJWB1SghU/BA54YEZFoS88N//uQ m3jxJtVs7LxgjlEv2Y2FUuCMuUOyLV0uUA1LHKaQN+X1HscxRCWieotghsF6xMqK+chCxd68G/s aCivwnQLtx4PeeoXaXA== X-Authority-Analysis: v=2.4 cv=Sev6t/Ru c=1 sm=1 tr=0 ts=696b2dd7 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=7tap2HhiP8zdS8EL3YEA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: jXb9ywx9oE4vvjeJDA0OWLZZaw8uj4Pp X-Proofpoint-ORIG-GUID: jXb9ywx9oE4vvjeJDA0OWLZZaw8uj4Pp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-16_09,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601170052 Since DPU 8.0 there is a separate register for the second rectangle, which needs to be programmed with the UBWC config if multirect is being used. Write pipe's UBWC configuration to the correct register. Fixes: 100d7ef6995d ("drm/msm/dpu: add support for SM8450") Signed-off-by: Dmitry Baryshkov Tested-by: Val Packett # x1e80100-dell-latitude-7455 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index b66c4cb5760c..a99e33230514 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -72,6 +72,7 @@ #define SSPP_EXCL_REC_XY_REC1 0x188 #define SSPP_EXCL_REC_SIZE 0x1B4 #define SSPP_EXCL_REC_XY 0x1B8 +#define SSPP_UBWC_STATIC_CTRL_REC1 0x1c0 #define SSPP_CLK_CTRL 0x330 =20 /* SSPP_SRC_OP_MODE & OP_MODE_REC1 */ @@ -215,7 +216,7 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pipe= *pipe, u32 chroma_samp, unpack, src_format; u32 opmode =3D 0; u32 fast_clear =3D 0; - u32 op_mode_off, unpack_pat_off, format_off; + u32 op_mode_off, unpack_pat_off, format_off, ubwc_static_ctrl_off; =20 if (!ctx || !fmt) return; @@ -225,10 +226,17 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, op_mode_off =3D SSPP_SRC_OP_MODE; unpack_pat_off =3D SSPP_SRC_UNPACK_PATTERN; format_off =3D SSPP_SRC_FORMAT; + ubwc_static_ctrl_off =3D SSPP_UBWC_STATIC_CTRL; } else { op_mode_off =3D SSPP_SRC_OP_MODE_REC1; unpack_pat_off =3D SSPP_SRC_UNPACK_PATTERN_REC1; format_off =3D SSPP_SRC_FORMAT_REC1; + + /* reg wasn't present before DPU 8.0 */ + if (ctx->mdss_ver->core_major_ver >=3D 8) + ubwc_static_ctrl_off =3D SSPP_UBWC_STATIC_CTRL_REC1; + else + ubwc_static_ctrl_off =3D SSPP_UBWC_STATIC_CTRL; } =20 c =3D &ctx->hw; @@ -281,24 +289,24 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, switch (ctx->ubwc->ubwc_enc_version) { case UBWC_1_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_static_ctrl_off, fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | BIT(8) | (hbb << 4)); break; case UBWC_2_0: fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_static_ctrl_off, fast_clear | (ctx->ubwc->ubwc_swizzle) | (hbb << 4)); break; case UBWC_3_0: - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_static_ctrl_off, BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4)); break; case UBWC_4_0: - DPU_REG_WRITE(c, SSPP_UBWC_STATIC_CTRL, + DPU_REG_WRITE(c, ubwc_static_ctrl_off, MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30)); break; } --=20 2.47.3 From nobody Sun Feb 8 14:31:25 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2783318ED0 for ; Sat, 17 Jan 2026 06:36:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768631773; cv=none; b=iRiKDBtbCAe6ZDpfot1pThwhUo/yo7q1UC34FhVh/MQbOY8I0le3j+R2FRhknWN1iEc8b8BaQEkC9iZVt/9U6S9XCwrw3GZ3bdiWAMIghQCKuuygMVQhB2twk/dIs5lrN5LPtjF+xwZZswP4opA+/VHJNcm0cX3afd1XZQ1dO+0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768631773; c=relaxed/simple; bh=Nivgddh/dUUg9vaUGrpQO4Ar4VNMexa7P2jWIqnrNXA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=l5Ww1HJ1ex6FQ8EtGR3U3Wdp0DiKhjlb/oqpTjPNqmnr8UHiUI6eulKZRE9lCl7ZdJ6zpeQaZIC1YBQy8leYcUvUuOK2owOCGnTrbRPzikTAzaPwm6FAnEdiOsxhZRBYTYwW2OpNZVbYVjnYLsCs0PgENhcEhSZyvixCp7JvBVQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=alhhBRdd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bGtptQiy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="alhhBRdd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bGtptQiy" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60H5PXa03151510 for ; Sat, 17 Jan 2026 06:36:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kDDelXBrEvb7s+N6wl54GgAwBWnoeXlC1C+qi++VsB8=; b=alhhBRddnYNXM3H2 I2oLrclleXsei9fX4OGMXnR4JmGbg384oxIViAxFkdDy6TyQ7qjw5l1/1cxRCpZM DaigZhb1fVngZR5NutWaHgXrn2f69DH9gOLWh94Iwv5I0rofqf/QE9o7h7Pzwr9f yMp3HUCD5AiS1DPvyfuNLHD7sq981zQsFVT12ZlQuIIVf2yFtBy/okQxGeBFPA0n sqvdDb4rzhfN8Fr5tjU1x9/e+9W4wx327YN+uUhd3cGzkVo3ntZELPIWQohZu7vW BX863w6gmgkHDpG/LUZtG6dnCbEqNSDDpaaLlwwYCnd+Kn4iWVlEHVIfZkWByzhd P/+Ttg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4br2ke0a74-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Jan 2026 06:36:10 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c6a291e7faso795298385a.3 for ; Fri, 16 Jan 2026 22:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768631770; x=1769236570; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kDDelXBrEvb7s+N6wl54GgAwBWnoeXlC1C+qi++VsB8=; b=bGtptQiyqxk13EgJJcH+CHUroXCyoTrAbV+/BG/oeHBihUElwiOc9MSVPRyKhbknJa /JBvFdcbYl/kd2gUqj7lFXQsm5U//U0couxNXLwJdsgwa1nieoBopM8l5JerhleoHm/I uazgLHi5AlWFqVrTWUiDog6y2/eE91GnQtT3rdvwuYASbFv0J8Yme7bTjDfWX/qOSVv+ mliLuhp7CIjOh/F9nJXT/Hm2VOBc7inu0N1Cef4vJ8zFwCsL8xJOwaLChH4ycqyGM8NS 9g29V6Us5vmBQK5JqfrbUZ9f7zlVxZW1Jg9omp3y9xTAbhjilwHzkcUTjOmUvxrCCZCu /STw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768631770; x=1769236570; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kDDelXBrEvb7s+N6wl54GgAwBWnoeXlC1C+qi++VsB8=; b=wFm+cnmOO5NGALm0tfECyh6G5ib8PJQm3undxWGf01I8bY+gUc4/5coTevKzEF86vz gZlTSBUyBHHDweD5IEWiDGkqSpRArHTlbYS/WZvZJT2m91K5o7eW4XuafbCFbJRrkNcd OBKIRYF4frrsJ1gTmre6FPIxtQnPdmQXku9BP4s1QzSp1PTEni0vqKitc3PhpSM1+ysF rurPrlTqtC4Rwp0g7M/ftw1k2saIdx4jLwmxssgRVD6CrNYbUvGKR4i0uF+3cV6uQ7ib RKBQeYCFOrPthWQ1aZCW0S9eOJ4UCsfO8iK9jLzAB3jJJuxGeQPcR1pOscJpI7vsl7LE 8n1Q== X-Forwarded-Encrypted: i=1; AJvYcCVIeNAIwY0hDPVfEC/D7dDxt/FYitRh0tbUdQlbscmC8+NaDJX/7KOKhuffIgUrqKkshJuWTr3iVaYMYv8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz84g1oHxGIkZ7irCzUig/LTuLNCcL08Y3Qp9J3dpPZpUum4jUo pa/gQ03nTDyDnvpLLda8DmwXWdbVfwjaFKgd16gH0n7Dix2gjNVgG4eFnTf/dnhHmPqkIGKDpPY Sz5ryJvGlfevFcqc3JFqIMkxhJPi2m5hEbvESo414gI2JbK76HiMO4DpKYyVFEWR3TQ8= X-Gm-Gg: AY/fxX4GfPUfX2z8C+no48X5ft/2wcfaqY+46fBLHhIP9WsNkCSUWER0ojebZzcgoLY LtHeJJVWmafb4eDF2GmakYsmX4qFaCyZHUukmfncwaVqKKG+pc9RQlCyRMzLeOqofeBYAe+YsVv 6h+J3DGzguNYBQRjLQ37gnZJwP44Ot9PTOIyDCmhzI275kzs0SunR8+5VrwyxzpsHy+DKuzAqoC jns+TcAC/al8MYgEzaOi39ys4rswcuscSib1D1AZ7Xq/RFUR/RQJDQ0sdPWN5urK/xBs+5Zimc0 71WS/hInapkbRSlNeFK1o2cprKaa6UDJyF9fev3eK+x376AVtkOLRtduD9nso3YuDYrJ0iM5QY9 qUFK0fYPYNIx1saRzMv5tb4HdVWw1w6R0Jf29ky1NyaPPOblswpdmIcCFKPv8Wks6lPloCVKqAi EnymEhyPH99nvYenmMkW9ESIg= X-Received: by 2002:a05:620a:199d:b0:8b0:f04c:9f0f with SMTP id af79cd13be357-8c6a69633c0mr674357085a.63.1768631770249; Fri, 16 Jan 2026 22:36:10 -0800 (PST) X-Received: by 2002:a05:620a:199d:b0:8b0:f04c:9f0f with SMTP id af79cd13be357-8c6a69633c0mr674356085a.63.1768631769829; Fri, 16 Jan 2026 22:36:09 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38384e790fdsm14049851fa.23.2026.01.16.22.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 22:36:07 -0800 (PST) From: Dmitry Baryshkov Date: Sat, 17 Jan 2026 08:35:57 +0200 Subject: [PATCH 4/4] drm/msm/dpu: fix SSPP_UBWC_STATIC_CTRL programming on UBWC 5.x+ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260117-msm-ubwc-fixes-v1-4-d5c65ea552c7@oss.qualcomm.com> References: <20260117-msm-ubwc-fixes-v1-0-d5c65ea552c7@oss.qualcomm.com> In-Reply-To: <20260117-msm-ubwc-fixes-v1-0-d5c65ea552c7@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2678; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Nivgddh/dUUg9vaUGrpQO4Ar4VNMexa7P2jWIqnrNXA=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpay3M9+mHB6GMiAL1TbuPcebrQTrgtuwmLGi4D GiKsoP1qW6JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaWstzAAKCRCLPIo+Aiko 1TMgB/4jx9mONQw02I/OWAPUriWFeBex6wD887DlDc6s0+G9WkEZkdTH9Wu+/UBsAcvhtSvJpzG /90E5DUuS0HbdWP6sO9qw1nn8idesZSermRuXFGbHUpdzQ6u9kDt3bM9yliVOW0Jy3yyAgqk6v9 veL16e6sq5TuoT1fLiAKNkr7qbdvK+bFjAkaw4RGCHkcAeXDWnkG+ioFavRYRTSD7pIn2XcaiFb jpupZkvbREab3jYC1aByrUt5V+yGDQaMFlWhXRh/uzFkK7oAl3wbQF5y718Ces3iB72USL3S9Av KELU4umFJl1Xp9wBdcAvJ82rn5z5wAsOC14IjbJRHjnz5z75 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE3MDA1MiBTYWx0ZWRfX8IjqSynlxniX n1XMR1CZ/Yewe0R2uU2LDnl/1PuEcrS+Zsx/OnV7Cxpqd23XyOibBbZM4xlPdWU02Xb6Jj9VFK+ 0C2j3c+OY4SiNLVwswRAA1hrh9Go5//wrbA7FuTyTZx5OqhXtWcl8h8FG2lqXV7DxI32iLkTByC VSwU8403hhcFJmKJ+ohniyrQTHt5BOg7ROVXE3jeA65Qnfu4+/RZXZuHkho+PSS3u83164rD1GF pP337N280SvYrXU+XME8k+2IDi10eWabiVLJ/zS5nwDdm8wVidJShLXDA3cZGJADsG4WefoemVa d/ftMKVRAgK7+5aeJEpf/Y85DoHw/MAGcARj/BYUbd2CRAdec29bG3mCm2d0BsmSxfMrMkTrMjl /D09wJayXUHw7XCN33uCSBL0vByz2RYNEH6TMqx42tlk0LCr2y4G7HjF9nnta7wmdysS/IABOS3 7p1hVPq4CcH2yIqqaYg== X-Proofpoint-GUID: 6ipoYHPgBdI3okPS0OatoZ_h-KV6YI7i X-Authority-Analysis: v=2.4 cv=EJgLElZC c=1 sm=1 tr=0 ts=696b2dda cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=7FpWx5GjbivZIX0HvvoA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: 6ipoYHPgBdI3okPS0OatoZ_h-KV6YI7i X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-16_09,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 priorityscore=1501 malwarescore=0 spamscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601170052 Code in dpu_hw_sspp_setup_format() doesn't handle UBWC versions bigger than 4.0. Replace switch-case with if-else checks, making sure that the register is initialized on UBWC 5.x (and later) hosts. Signed-off-by: Dmitry Baryshkov Tested-by: Val Packett # x1e80100-dell-latitude-7455 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 41 ++++++++++++++-----------= ---- 1 file changed, 20 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/= msm/disp/dpu1/dpu_hw_sspp.c index a99e33230514..b0c97f5e47ea 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c @@ -279,6 +279,7 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pipe= *pipe, =20 if (fmt->fetch_mode !=3D MDP_FETCH_LINEAR) { u32 hbb =3D ctx->ubwc->highest_bank_bit - 13; + u32 ctrl_val; =20 if (MSM_FORMAT_IS_UBWC(fmt)) opmode |=3D MDSS_MDP_OP_BWC_EN; @@ -286,30 +287,28 @@ static void dpu_hw_sspp_setup_format(struct dpu_sw_pi= pe *pipe, DPU_REG_WRITE(c, SSPP_FETCH_CONFIG, DPU_FETCH_CONFIG_RESET_VALUE | hbb << 18); - switch (ctx->ubwc->ubwc_enc_version) { - case UBWC_1_0: + + if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_1_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | - BIT(8) | - (hbb << 4)); - break; - case UBWC_2_0: + ctrl_val =3D fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | + BIT(8) | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_2_0) { fast_clear =3D fmt->alpha_enable ? BIT(31) : 0; - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - fast_clear | (ctx->ubwc->ubwc_swizzle) | - (hbb << 4)); - break; - case UBWC_3_0: - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - BIT(30) | (ctx->ubwc->ubwc_swizzle) | - (hbb << 4)); - break; - case UBWC_4_0: - DPU_REG_WRITE(c, ubwc_static_ctrl_off, - MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30)); - break; + ctrl_val =3D fast_clear | ctx->ubwc->ubwc_swizzle | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_3_0) { + ctrl_val =3D BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4); + } else if (ctx->ubwc->ubwc_enc_version =3D=3D UBWC_4_0) { + ctrl_val =3D MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30); + } else { /* UBWC 5.0+ */ + if (MSM_FORMAT_IS_YUV(fmt)) + ctrl_val =3D 0; + else if (MSM_FORMAT_IS_DX(fmt)) /* or FP16, but it's unsupported */ + ctrl_val =3D BIT(30); + else + ctrl_val =3D BIT(30) | BIT(31); } + + DPU_REG_WRITE(c, ubwc_static_ctrl_off, ctrl_val); } =20 opmode |=3D MDSS_MDP_OP_PE_OVERRIDE; --=20 2.47.3