From nobody Mon Feb 9 19:25:24 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61EA731327B for ; Fri, 16 Jan 2026 23:21:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768605679; cv=none; b=lTtkNT1G/qvB5bpDmt+sNIqrRZbI2ht8jYUMB94BJZfr0kHYF61kIKa6I2MTWZM6bty+teXq3qz1aE4Ya95SkLam5ks6LP3rRdoJZ+Oy2vLO7pb7QnCjdbLoObsbeQfN0S6ZJdpU7WDJaIFm+SAz2oWGWXsl3hkqtIt4K290jRw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768605679; c=relaxed/simple; bh=9B1FnLaHALjYfJ8RPCg5eOxKik1XLzUO5cKu4vZ+ZZw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=C6YY1R4b42E+CNA2QTpK+s8Apd+pV7jI+rzcnCei2UHq0t+9L1x1He+iot2tMaEjsJKYttu+mZhiVyOe2oGrnG7SNgkPLOKtaFjhOTcaVR4ekzijZYDMD9Ows+3PZzVgfNb8yEWcj6mFok4HM9hH00VjLn/VDXJUEqoMJsyZlvE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jjrCbHT9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WHQfUpUW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jjrCbHT9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WHQfUpUW" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60GNDxPf2648035 for ; Fri, 16 Jan 2026 23:21:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=1qylKAN4jaI gqx7JT64dI6YQstiaPDg+rYzw4T90x1I=; b=jjrCbHT9ad7FMPlIIlaPJ/C0/BM 1AFKriWmjUFqj8IAXFfDlJ10BpXqzgzVn0RruFWXNtwlku1CyvhMuJgzRVC6/271 plk4aJE1pOO06jIEmInlKZ682VWu01dZHtAwVkJsMsoROXeGHCkcyKr578YLeBnE 6dtBUgnMapH/gKopOTdhTC+TiuXX3W2/7FRDL0HQ7+LSok8ugNIkmZwfoaXY63RO JBzwGBiSIJCmo1LSq8jUQ2dJq9MuOifcp+PS4jNqZ8phB1xXvLAiAAFNZqoNEvRP e16YNkzyBjzKWQp2UTNW69iSURciaBEunHkFxNoKQNAQn2gSuC8cr4nmsSQ== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bqvedrbj5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 16 Jan 2026 23:21:12 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2b6a8afb513so2858114eec.0 for ; Fri, 16 Jan 2026 15:21:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768605672; x=1769210472; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1qylKAN4jaIgqx7JT64dI6YQstiaPDg+rYzw4T90x1I=; b=WHQfUpUWxIdb22saXBmXZw4MzbPDOsuxZzHtvpievIPTwcCyqgXxgE/Xxi0qsD2piJ //Sf3UsK6OIxoFG8pjbcc/AS5ZB3asWQhTG9RZQrB8i/BjEstIuzDB1WMbe1ZGl4Lb+Z kTsVVUVBLvIogvlhLCi/N1yx+jlSkIQ2m7T177BIHe+SPm3XcQT9DrU2cYmS9YSZrMdd Iwa8jciQOtWyECwbUvH7dmyFCokyz0JfjEeeMgJ62pFO3XeU2fgD/Tc0mLla3VbvOq4t rNppMopCIrzjfFl2hH+hs/GDySiq7MmVb03gCpZGu3Z+qs5uTirhgQGXLNkf4HIo65Zm 0r9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768605672; x=1769210472; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1qylKAN4jaIgqx7JT64dI6YQstiaPDg+rYzw4T90x1I=; b=GgBP0Tgl+GdWpAXBK3NFTgs7IURyuCR9wToC35sOlnLYVrbZeFTYLsn55rDjcjkjQ1 sSmFb6LUtH35wN8iD6mGhrZfgllBpYWZaoV7/3Fmc0nbkVfse9yaSiGhETfTror5I2V3 kl/OLzR1vPbKAmsajwGXECyAjBo+r85NUq3gZo2Ejv7g44bGKXPZXGDRqMUh+OoqOglz RVsGdd1r//z/v/rhZFPwIXFwNDzC6iMmp2qAT79GS68dM/V9YTalkDHKzSvIXu905Ka+ ows6FQ656al1G5LpiWBAWTJgsLx3ysCe4rp5N181k4vIf9kslxXy6vROlIn2zi1JKAuD FR5g== X-Forwarded-Encrypted: i=1; AJvYcCVlqGn0QjmLvEQcr/HIkXfvb4EaUS5P3pyW+sZOrc5pfQ99cpIDtSvG1sNI2lOPe0cvaPJNBjaMftI15cI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzj6SXa7Kzb7EaChrvWg215+fI3Cn8YeIf65V/C6/0KooncDd7W D/+Yry6XJFzvyeZhB8CcSJbkcw4IJ/8G5O16J28GbFGjvAZiwhKihHh+lxo5442qtx0mhC3VA/7 JPNBcavSe2IoC9yJGf499G+4ek8E402fYulotX7diBlBw8aKZxb9GIiPOIBKy+DnfXZA= X-Gm-Gg: AY/fxX6C8yh0GBx4HXSTLS157oup/kJ0HHuYkG46QcJ8SlS8vh9jqoP5gUpN6aEDfoc ASO0m8RAWlzqqfCQP3sXWXqWiO7RPZ1/78k4vjcAlAVZn8Px1Nky128DvuWb40cb3rgK8AP7vco sZXh2pdpuCe6Y5AB/JFqzYy5m9uu9DBq3UKGKJaZoUy7fRbYydmKi8CZ0nnQOLguBJy4uNriMgC 7iwtDboRAsRsNf/ZUzXgBCGsz2alB58PJFnxg6JuPOcmxU1rxTPVtCN7pzsrmf5Yk11rMh/TWL+ wUo4iGcJicZqhfs7NM8pKljdJWcJDLCn//YSmIp63EiQEKXpfy+piVJgDzJ/ClQiqR30qlkCfxo 3AHAXJXWotKVSSwTkCnN6ouNX+lGj6iYhp4Nn4xjVY45Tekd7dkt2XrulNKNTF8k= X-Received: by 2002:a05:7022:6081:b0:11b:c1fb:89a with SMTP id a92af1059eb24-1244b35f486mr3286737c88.32.1768605671986; Fri, 16 Jan 2026 15:21:11 -0800 (PST) X-Received: by 2002:a05:7022:6081:b0:11b:c1fb:89a with SMTP id a92af1059eb24-1244b35f486mr3286723c88.32.1768605671499; Fri, 16 Jan 2026 15:21:11 -0800 (PST) Received: from hu-eserrao-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1244af10e21sm4611267c88.16.2026.01.16.15.21.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 15:21:11 -0800 (PST) From: Elson Serrao To: Greg Kroah-Hartman , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Souradeep Chowdhury Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/9] usb: misc: qcom_eud: improve enable_store API Date: Fri, 16 Jan 2026 15:21:02 -0800 Message-Id: <20260116232106.2234978-6-elson.serrao@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260116232106.2234978-1-elson.serrao@oss.qualcomm.com> References: <20260116232106.2234978-1-elson.serrao@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: ZIF3_hKp02gBni33tKAHlSNHVEd6bQ4h X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE2MDE3NSBTYWx0ZWRfX1bxOMN9YWk+v eRYEWQeiMJvOv0Mf0apeMcb6pubzUzXu4YemSMA+vqxU4nSU0gMNn09NVDAOXpvPpGTgnYF1IMd 8p9qP9oPY8mWc1ZakZJp3Vjbk3JrOzHYfV3PhPy9e41mLPh24GxbhmuDrZNwVMggJEP9tJVvGk0 w18ITfhTlaJAOVsqpZ3laVrVw6SR7LxPuUKQcCCkssMT7Ejge6ULadFtBqjcM+eUaIRAHCe9kz/ 1C2iXKt+DbEn7kGo7AWqck4Vg135mEzdN1/yNmrukLT55jRUdIH8AGEMu5yPHiQ1HLBCJ1/jCot 9sbopOB+e9wYlO2frEcMSlHoJm1PG0p+4NQtpogb5sdfP0DNaiJUzHkP06x0X9nEOjFhC6A7Gy4 1EiuArFOtmnFjYypRzrVSyTM8E+KdBdDn1KoE+Cvw9gjeX8N5wxB6bILaClgETQBuvD2rNtIujF CGEsK8UYnkCJY6sWpIA== X-Proofpoint-ORIG-GUID: ZIF3_hKp02gBni33tKAHlSNHVEd6bQ4h X-Authority-Analysis: v=2.4 cv=A4Bh/qWG c=1 sm=1 tr=0 ts=696ac7e8 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=iEam2xx7WbKG8qDqzoQA:9 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-16_08,2026-01-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 adultscore=0 clxscore=1011 priorityscore=1501 impostorscore=0 suspectscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601160175 Content-Type: text/plain; charset="utf-8" Currently enable_store() allows operations irrespective of the EUD state, which can result in redundant operations. Avoid this by adding duplicate state checks to skip requests when EUD is already in the desired state. Additionally, improve error handling with explicit logging to provide better feedback. Signed-off-by: Elson Serrao --- drivers/usb/misc/qcom_eud.c | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/usb/misc/qcom_eud.c b/drivers/usb/misc/qcom_eud.c index a58022f50484..0ea6491f963c 100644 --- a/drivers/usb/misc/qcom_eud.c +++ b/drivers/usb/misc/qcom_eud.c @@ -168,18 +168,27 @@ static ssize_t enable_store(struct device *dev, if (kstrtobool(buf, &enable)) return -EINVAL; =20 + /* Skip operation if already in desired state */ + if (chip->enabled =3D=3D enable) + return count; + if (enable) { ret =3D enable_eud(chip); - if (!ret) - chip->enabled =3D enable; - else - disable_eud(chip); - + if (ret) { + dev_err(chip->dev, "failed to enable eud\n"); + return ret; + } } else { ret =3D disable_eud(chip); + if (ret) { + dev_err(chip->dev, "failed to disable eud\n"); + return ret; + } } =20 - return ret < 0 ? ret : count; + chip->enabled =3D enable; + + return count; } =20 static DEVICE_ATTR_RW(enable); --=20 2.34.1