From nobody Mon Feb 9 23:00:35 2026 Received: from mail-oa1-f98.google.com (mail-oa1-f98.google.com [209.85.160.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D56F3A1A59 for ; Fri, 16 Jan 2026 19:38:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.98 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768592306; cv=none; b=tYbSLK5o0eyWj5Tmk9o7DeqwQQSMV7IMkuXcWIWObtfDD87HxkQptHFI9GjTlsIaB+gM2DwprFly26RXFfPrYGprsNWeBD7Y/mnBg3v+qDco+wOgektpG76gkrDODTXVbGvt9tnCHkVTKHNUbX9gla6lj3rSQ4fA3jSTDs2Tp6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768592306; c=relaxed/simple; bh=Lds7sMXzJrLrd0gBwEEuZ07H+OYaihFRhMfpOkt8Sd0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gNvLvGQBWotvg36+ZXnKvWcZPTV9yAFvo1xV8Cjokjl3GD3B+f3+IEmfIO7Ul+w885SlLkO3Bu+oKwRG/RTp+M2WISrU85G5InyhUr0fKU35+Vx7hla5ECwdcyaWmJw83ZB3e38QLxM8MpS7ibMtFGPbCtjoy/Hi2hoaYh7LktA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=K2R1lkKJ; arc=none smtp.client-ip=209.85.160.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="K2R1lkKJ" Received: by mail-oa1-f98.google.com with SMTP id 586e51a60fabf-4043eea60a3so1148120fac.2 for ; Fri, 16 Jan 2026 11:38:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768592303; x=1769197103; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4dWnjTr3AjoXWLMl2brB8ngehg3o0HcGu3374LRPyGE=; b=deRmIF7IeFQz+GHbYOuIEtCoq5mGS92snPYWZ6/u9FWM3GDPVDcaeJdsXI1NcsUAPC wD9v5F5i9ZOF3SNQbMTOktVeWots5/gDaAR5s38qgbzyoX51XZnn8ygX5rLttmwtbMcM SVKa5h2rrVXcnzkkadNABnKmdNCZpODrr5O6CI2lylBXHQnDUlgpQFEmHOvIhkYrvwxw qF8M1982Gzokz5lSKNuX8+dXKM0pj+vqdmSdRxJg2u89uSEMAg4JrBg+UNM7N631sJtU jRnkB444GRfAqHEbqO0lYm5acmu52bRlfDVZqZqIrAQugSPRSUhxjgCOUM/Mpj29wJ+v 8YlQ== X-Forwarded-Encrypted: i=1; AJvYcCVnfE1eO5NvavdztKG5OsmCJaF3RkL1sh8z73hsRs2jr8EORZ8ZpaZGiFUhbdzCZ5LzEJKxQPBNMYdA94Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxxrW6vqqD74HgZrQj+fYtMpK43YD9bWixDk6qAUDMv/Y0k912V 2Wn6CmKXMVQLUmT8pCMLWZSmMFO4/Qdi0ncvl3V0HlATTTS8kokZYCYZenz9C4QiS9Dxh7bo0km 1aU6X7XVa054fzSMmZZAN+jdQY6dUXXLqVaMLG+QxqzLigWdAoLbJfSQBN88QPPl5NmwPAoXxn/ c8GRKKkodflUpZ+fWiauoVdOBq8/dfTIHyQJJGVz0i9Bvs3y+3kgzAs4hfS/HAkebUyJexKoG1k 24ppQWyruPeDlQrv7W1j77JcQ== X-Gm-Gg: AY/fxX5OeJNYGgYA2m2Oy8aUbJ5JtwdHxPZ3//sDbksLaVFNTm5z/HI9QCG2AaPld1w PjacO9jd3qlNV6wVLLnzumcGonGESG/giOVqc1+dGYja3NXikoTMuEQFk/wC3mp5Pnn6FkwOoLB 9hbHs0aD1HXIsieJTLalZdd+sNeyJDcxl0Ukqx4FiHnEp8pnUuvUlAgKyHhskCmb0XJoQYQEwvD 4Rkiy0rgRRyvYSSe6WwR9vcojIO3PYvVGxK9SdgcCJ8awP2NwyWuFJMmZHFNiAqyOdp6KXtWV1E tdNXkAd2YSPukeayYfydXneULqQWx9ACpRisEBLNm3FG9FxusuMOnt6CVJJcN0EUH4MMEQNNF9H 2rGC9YSnJ1Q16ENdMNlGwEXlzbddSihkIEC46+D4cUu3z9aITnMmbcyMQbg51ySND0wSQFp6Wxf K5ZoLP0HmyO0DCE7J9KOUOL0w0gS6l1J1oyluykJxXsgFzkC99WCs= X-Received: by 2002:a05:6870:64a0:b0:3d2:c24:30fc with SMTP id 586e51a60fabf-4044c492471mr1838014fac.48.1768592303103; Fri, 16 Jan 2026 11:38:23 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-72.dlp.protect.broadcom.com. [144.49.247.72]) by smtp-relay.gmail.com with ESMTPS id 586e51a60fabf-4044bb0a87csm377605fac.2.2026.01.16.11.38.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Jan 2026 11:38:23 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-34c704d5d15so4006469a91.1 for ; Fri, 16 Jan 2026 11:38:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1768592302; x=1769197102; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4dWnjTr3AjoXWLMl2brB8ngehg3o0HcGu3374LRPyGE=; b=K2R1lkKJa0McK6CL+LhmhlnysA+O8YjMyUDRJKjhtHmRUb4qlN6vGuE9biNvB7eQ/c 4GXkui3CnZOtPMRMXCmAAkZYNw7erggX5ikobgVQwIL+nZPWbhj9B/xvKH2yHL9+gSDD WwhBwkjd1g1x1DDj1IOB2w4PcHseRLJRjz01c= X-Forwarded-Encrypted: i=1; AJvYcCUfLC55EA0gbwdS5h8BpqvrZlsmVCV/Wdj50BJFRml0HS+I+90eVlqknUNoSLeVkPhtlrpOdGME2R5v+TA=@vger.kernel.org X-Received: by 2002:a17:90b:5485:b0:349:9d63:8511 with SMTP id 98e67ed59e1d1-35272faec68mr3198762a91.25.1768592301736; Fri, 16 Jan 2026 11:38:21 -0800 (PST) X-Received: by 2002:a17:90b:5485:b0:349:9d63:8511 with SMTP id 98e67ed59e1d1-35272faec68mr3198753a91.25.1768592301391; Fri, 16 Jan 2026 11:38:21 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35273121856sm2764909a91.15.2026.01.16.11.38.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 11:38:20 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, ajit.khaparde@broadcom.com, Bhargava Marreddy , Rahul Gupta Subject: [v5, net-next 5/8] bng_en: Add ndo_features_check support Date: Sat, 17 Jan 2026 01:07:29 +0530 Message-ID: <20260116193732.157898-6-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260116193732.157898-1-bhargava.marreddy@broadcom.com> References: <20260116193732.157898-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Implement ndo_features_check to validate hardware constraints per-packet: - Disable SG if nr_frags exceeds hardware limit. - Disable GSO if packet/fragment length exceeds supported maximum. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Ajit Kumar Khaparde Reviewed-by: Rahul Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 1 + .../net/ethernet/broadcom/bnge/bnge_txrx.c | 23 +++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_txrx.h | 3 +++ 3 files changed, 27 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 2c1df5d48b5e..2c8f8949d500 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2420,6 +2420,7 @@ static const struct net_device_ops bnge_netdev_ops = =3D { .ndo_open =3D bnge_open, .ndo_stop =3D bnge_close, .ndo_start_xmit =3D bnge_start_xmit, + .ndo_features_check =3D bnge_features_check, }; =20 static void bnge_init_mac_addr(struct bnge_dev *bd) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c b/drivers/net/e= thernet/broadcom/bnge/bnge_txrx.c index 9e069faf2a58..dffb8c17babe 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c @@ -960,3 +960,26 @@ netdev_tx_t bnge_start_xmit(struct sk_buff *skb, struc= t net_device *dev) dev_core_stats_tx_dropped_inc(dev); return NETDEV_TX_OK; } + +netdev_features_t bnge_features_check(struct sk_buff *skb, + struct net_device *dev, + netdev_features_t features) +{ + u32 len; + +#if (MAX_SKB_FRAGS > TX_MAX_FRAGS) + if (skb_shinfo(skb)->nr_frags > TX_MAX_FRAGS) + features &=3D ~NETIF_F_SG; +#endif + + if (skb_is_gso(skb)) + len =3D bnge_get_gso_hdr_len(skb) + skb_shinfo(skb)->gso_size; + else + len =3D skb->len; + + len >>=3D 9; + if (unlikely(len >=3D ARRAY_SIZE(bnge_lhint_arr))) + features &=3D ~NETIF_F_GSO_MASK; + + return vlan_features_check(skb, features); +} diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.h b/drivers/net/e= thernet/broadcom/bnge/bnge_txrx.h index 81a24d8f9689..32be5eb46870 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.h @@ -119,4 +119,7 @@ irqreturn_t bnge_msix(int irq, void *dev_instance); netdev_tx_t bnge_start_xmit(struct sk_buff *skb, struct net_device *dev); void bnge_reuse_rx_data(struct bnge_rx_ring_info *rxr, u16 cons, void *dat= a); int bnge_napi_poll(struct napi_struct *napi, int budget); +netdev_features_t bnge_features_check(struct sk_buff *skb, + struct net_device *dev, + netdev_features_t features); #endif /* _BNGE_TXRX_H_ */ --=20 2.47.3