From nobody Mon Feb 9 12:42:34 2026 Received: from mail-yw1-f226.google.com (mail-yw1-f226.google.com [209.85.128.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 866993939AE for ; Fri, 16 Jan 2026 19:38:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.226 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768592298; cv=none; b=CsJ3V1QnyIZWllehp1PPlZcg3fCFC7is6ZGfF46eNbsmJW2sEMsFmgDwsSi2qBjBGotuTL6NQb3qclh+crgwY/THA0qB6ffGkC5FZsMwsLF2QHr3Xik1JN4KoehP5GelDL0Xj5MiiU8wyfQbetpdRh8sXvd47SJVBuLfL7Ea3Tc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768592298; c=relaxed/simple; bh=x88N3oxkXRPiWEgxunQ43AN6MNHv3SUlHx6gqxlfUpc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Rpyqu+85uxVrtLh6yP450MUeWRP+lky4EwGC8suP7g16xIJkP23+GWU7nmRGTyd2iwDl/wmfv6gBAVXRMOrsrzcRmLS902COn6JKfjiYmU4RwytifMntjPiQ2ZULpomXvfdYNOUwjUO+9yIcr6CX8p4mJwlX0hiXs66lWny2bSQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=SfMzVjzF; arc=none smtp.client-ip=209.85.128.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="SfMzVjzF" Received: by mail-yw1-f226.google.com with SMTP id 00721157ae682-78d6a3c3b77so38089167b3.0 for ; Fri, 16 Jan 2026 11:38:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768592295; x=1769197095; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dzdMWEzSJ2Iibm3SBd/RgNfSnuzOKnyQSBjs/m3tLHM=; b=p0mXj76IjeICINJtp7CizJ/cMRnYz+/6en4osggsHM33kBCtCDWc6SsNXEsgWZX+P2 l3acEkd34eDjRi9XZRP/va+j23gZNj/paKt9qT9nnpuAZKJWDxHfTzYwV3jI+N5/U49H nxJGCMd1Zdek3C8SBjJd2sJ3EMhHDPfdfI9m0bB6/vJ7P8ppHbBqyAQJTcNNaAO9qyX5 3g1atP5WUxSd+zmuZ6U2K2sJUdCX7Rj+0saTNdI4ZAEZsTF/fz7/wTv9FlB1Gi1YcPTP dInh1XAbpOWGhmpNSX5Jcb702BCk2OziMhdPfz4HfL38XKMMvvAll0DuaASszFjBvS6a Y00w== X-Forwarded-Encrypted: i=1; AJvYcCWS0yQSUZAnToc+E8EEdkonpADJshPSI4RieEVSo1bNtS1sSh9No4VEbhueg4NVLZWLGgvhife7QU7K+gg=@vger.kernel.org X-Gm-Message-State: AOJu0YyEYJK3cb0cs3DezFN9AwKv8TE30dX0EFl5VvoYy5dxF1dfAw/1 V3TFjv/NdJTW/k7/RXTE4qyRIIpKl4BCTcnk1YqC9KGMMIYI8BKAkLx4n0T9gCLHb5/hPtuJQgD 9CJcWDqDMx23chIeoNeywEYX/dIZJ59FzoEngallyoOAKrirQCqFcyBZKEO3Chw1Goa9G3uFHnq sSc7DMeWJlyfvGK8u1D5OyGxdx5XNqyFGJKLzF6g54USz4ZmKvt14RRAi5EnXIKWiR/v7LETBCC XpGvDj9QqGJi+coA6hvOl2GkQ== X-Gm-Gg: AY/fxX5fTwf8kEmX/MM9SC9LAZ4JFuDrwl75NZPYaLOAFe9XCi57e19lST91OZsYuo7 6KNCj4s545fYsmFYAbXfc8UNka9yCbbmUb7RyM+FUq13ITWqhlClNhpAXlpBJmRHwvII3X+peNr WTEfJ+BZZrkJjjk4Mxo3M0PTfSr144UfKJ69DOCmU6lZ75uFO3zybPnZcxB+XNW3tpDuV0itupv jAutZlPlPqLhtM+yBOI+OSEyTJQmrqLcT8AdWn/8mRE9cvEcqYltpsA6MQl85RtxnoItu3B+CbW yAX2BpfPxIbAe/6PlvZdfYFVSK6J5ItSDHyfTxe1PtuPKkYd9qqJ0t5BDMqRGruL3jMxL2KbgQG bSiO73a6tVnSYfPm0eUVT+5/oipaO18JsjJsyHTC3pM38j8+Krl/83bv7oDae1Mt339+SIg/So6 6y24m1XDQduiBcFGYw73Z8pdgTXXE3uGG+iqc8z5CieXsVa3Fy0+E= X-Received: by 2002:a05:690e:1489:b0:646:5127:a024 with SMTP id 956f58d0204a3-6490a5eefc2mr5721293d50.7.1768592295381; Fri, 16 Jan 2026 11:38:15 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-72.dlp.protect.broadcom.com. [144.49.247.72]) by smtp-relay.gmail.com with ESMTPS id 956f58d0204a3-649170a0137sm207287d50.13.2026.01.16.11.38.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Jan 2026 11:38:15 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-34ab8aafd24so2484719a91.0 for ; Fri, 16 Jan 2026 11:38:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1768592293; x=1769197093; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dzdMWEzSJ2Iibm3SBd/RgNfSnuzOKnyQSBjs/m3tLHM=; b=SfMzVjzFlsMlS8ZDFW+a84yJQMMRF8dqqIsWP+9zcQkCI6KwNdRTlwRalWHgznecpc 7URm9t7hjlam6SiukRvsm/G03oP/iAZDRXpRQnr17yDPCeMMTNzbWzfh47Odv0+RpZQ2 UwsGyzZJ/mlEXDuwCILYFLSAbQLoZDnBjmMLQ= X-Forwarded-Encrypted: i=1; AJvYcCWz368utDwRafJcW0x9wEavZ6PtysDy4B/MDAeCHOslvjmNeGiO+STfEERI/wme1R/ocUmvnTmfV1m7dbo=@vger.kernel.org X-Received: by 2002:a17:90b:2246:b0:34a:a16d:77c3 with SMTP id 98e67ed59e1d1-35272bcb638mr3448713a91.2.1768592292459; Fri, 16 Jan 2026 11:38:12 -0800 (PST) X-Received: by 2002:a17:90b:2246:b0:34a:a16d:77c3 with SMTP id 98e67ed59e1d1-35272bcb638mr3448694a91.2.1768592292011; Fri, 16 Jan 2026 11:38:12 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35273121856sm2764909a91.15.2026.01.16.11.38.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 11:38:11 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, ajit.khaparde@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [v5, net-next 3/8] bng_en: Handle an HWRM completion request Date: Sat, 17 Jan 2026 01:07:27 +0530 Message-ID: <20260116193732.157898-4-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260116193732.157898-1-bhargava.marreddy@broadcom.com> References: <20260116193732.157898-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Since the HWRM completion for a sent request lands on the NQ, add functions to handle the HWRM completion event. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 3 +- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + .../net/ethernet/broadcom/bnge/bnge_txrx.c | 44 ++++++++++++++++++- 3 files changed, 45 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index aef22f77e583..594e83759802 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2303,8 +2303,7 @@ static int bnge_open(struct net_device *dev) =20 static int bnge_shutdown_nic(struct bnge_net *bn) { - /* TODO: close_path =3D 0 until we make NAPI functional */ - bnge_hwrm_resource_free(bn, 0); + bnge_hwrm_resource_free(bn, 1); return 0; } =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 9303305733b4..4cc69b6cf30c 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -77,6 +77,7 @@ struct tx_cmp { #define CMPL_BASE_TYPE_HWRM_FWD_REQ 0x22UL #define CMPL_BASE_TYPE_HWRM_FWD_RESP 0x24UL #define CMPL_BASE_TYPE_HWRM_ASYNC_EVENT 0x2eUL + #define CMPL_BA_TY_HWRM_ASY_EVT CMPL_BASE_TYPE_HWRM_ASYNC_EVENT #define TX_CMP_FLAGS_ERROR (1 << 6) #define TX_CMP_FLAGS_PUSH (1 << 7) u32 tx_cmp_opaque; diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c b/drivers/net/e= thernet/broadcom/bnge/bnge_txrx.c index 850e3c67e9ac..360ff6e2fa58 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c @@ -377,6 +377,43 @@ static void __bnge_poll_work_done(struct bnge_net *bn,= struct bnge_napi *bnapi, } } =20 +static void +bnge_hwrm_update_token(struct bnge_dev *bd, u16 seq_id, + enum bnge_hwrm_wait_state state) +{ + struct bnge_hwrm_wait_token *token; + + rcu_read_lock(); + hlist_for_each_entry_rcu(token, &bd->hwrm_pending_list, node) { + if (token->seq_id =3D=3D seq_id) { + WRITE_ONCE(token->state, state); + rcu_read_unlock(); + return; + } + } + rcu_read_unlock(); + dev_err(bd->dev, "Invalid hwrm seq id %d\n", seq_id); +} + +static int bnge_hwrm_handler(struct bnge_dev *bd, struct tx_cmp *txcmp) +{ + struct hwrm_cmpl *h_cmpl =3D (struct hwrm_cmpl *)txcmp; + u16 cmpl_type =3D TX_CMP_TYPE(txcmp), seq_id; + + switch (cmpl_type) { + case CMPL_BASE_TYPE_HWRM_DONE: + seq_id =3D le16_to_cpu(h_cmpl->sequence_id); + bnge_hwrm_update_token(bd, seq_id, BNGE_HWRM_COMPLETE); + break; + + case CMPL_BASE_TYPE_HWRM_ASYNC_EVENT: + default: + break; + } + + return 0; +} + static int __bnge_poll_work(struct bnge_net *bn, struct bnge_cp_ring_info = *cpr, int budget) { @@ -427,8 +464,11 @@ static int __bnge_poll_work(struct bnge_net *bn, struc= t bnge_cp_ring_info *cpr, rx_pkts++; else if (rc =3D=3D -EBUSY) /* partial completion */ break; + } else if (unlikely(cmp_type =3D=3D CMPL_BASE_TYPE_HWRM_DONE || + cmp_type =3D=3D CMPL_BASE_TYPE_HWRM_FWD_REQ || + cmp_type =3D=3D CMPL_BA_TY_HWRM_ASY_EVT)) { + bnge_hwrm_handler(bn->bd, txcmp); } - raw_cons =3D NEXT_RAW_CMP(raw_cons); =20 if (rx_pkts && rx_pkts =3D=3D budget) { @@ -546,6 +586,8 @@ int bnge_napi_poll(struct napi_struct *napi, int budget) work_done +=3D __bnge_poll_work(bn, cpr, budget - work_done); nqr->has_more_work |=3D cpr->has_more_work; + } else { + bnge_hwrm_handler(bn->bd, (struct tx_cmp *)nqcmp); } raw_cons =3D NEXT_RAW_CMP(raw_cons); } --=20 2.47.3