From nobody Mon Feb 9 11:47:25 2026 Received: from mail-vk1-f228.google.com (mail-vk1-f228.google.com [209.85.221.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D05E36A036 for ; Fri, 16 Jan 2026 19:38:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.228 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768592289; cv=none; b=jRVcjWTMD6bHtbPa+7udpHd4PAP/Ghqp4Nm1+z85AeFDrJ6szkj8nQEnKI7vWPqhUP0W++BrJ8n6etNJX8Bt3BtnN6NNg5VeBkYlIuuvLTUHaAuUtVgzkseNwkoDfGi4ooOwwZIiK44Wp461XGXWR9TWh9FlIDFL1dcG9OvX6uw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768592289; c=relaxed/simple; bh=G42HEdK63RMSkNcCPQGCk4X08ncSFrRURRT8K21yxRE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CTo0EAsq0jaKdDZbAJGy2g4XmEbFiROYIM2wuVIAfHMuaAfL9xs3RLAHCtkqBzMLyt0/ZWlBn5ribnkxkuzdk5qX9ykNreZDH7Y/5h6zXGxUBXwZu2p7jHoq8R/0chjfnYBc0VVRui/V2ebVwfCynUBSOBBsenuAWUrT6WysAUg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=TnqKRr2H; arc=none smtp.client-ip=209.85.221.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="TnqKRr2H" Received: by mail-vk1-f228.google.com with SMTP id 71dfb90a1353d-5636227a6e6so789880e0c.3 for ; Fri, 16 Jan 2026 11:38:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768592286; x=1769197086; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P5v6be/rvU1Ddm94jt+LcDTFwMP9w1kpc8KK4AcGhZ4=; b=j+LZXKqMgWYLVyBOeC4F2lWpaTvH4xkFAKNX+z/IZvpZPtJv97WlopGXnuWhZDIraM YRL32ML5MXDR15iplXVsm2usNcnUeGgBbhA4YnGrPW1s9iiYxmO+tmwhyqOq6EsVhKqg 5y3WtkhCOHAvtt6EHCFzoRnoTxyb9nZoPkpuqW9fQ85f0gyzBE2gJwJioCUOUWD6qiuw ElARVZ2B/yr53MnrL76RivTRiroCnoGkAm292wMH8qKNYHC8sR5Ucd69F7MCQsLN/hJr e4mwYqY2PeL30xCKG2KCTGAtF1Z4PuA+QTkKeB6MwuuOApxEoT6I1gmkY4XqR1Z1ubN9 T8aA== X-Forwarded-Encrypted: i=1; AJvYcCVMtWEX2BrWORSQHDhN8xY3YG5fade1PKmpZyaM3EFADamUihkJSc/ba1soctyNcUNuWYd2TMADUZhVT5k=@vger.kernel.org X-Gm-Message-State: AOJu0YzsFobcgUwjeES6gyOdHDbhYaA8ICT8KfUzdSuYhG6DinKvdxcs VudVljg/6yAOeIL8QPe6l4Wtzgn5N05bSGWsgwOWVqfK5a2kY0LfZzsiVtU3fI65phS7hE7ccra VgED37w2B24I4/q/UkEfVbbqiAhYYAKd25JirmvTyvBXNsp7ngZpV0VB7QH1xCF/cr9xMIW1gMU FOFZT7fkWu1Qb+48kHwa9kLT5pHaPOzzfn+a980Cqp5yxFLYWvXpfaTwolVUWNqoZDwRg//C9CX Gip6Cq8Fch1NIgLMVSB5TLYRw== X-Gm-Gg: AY/fxX6Omp73EYF52P+xgMpV2Y8APU2JqBCUGXyFX0E2ZAB0cn6bQ4IWO6uGjXpTs8e 8mpnQ4AAzxVpxlAn6oEysdJY44nHWxbhW+AeLHIaZ0OrJN0S9Rd6UZHbp2u7yomsMh8qDBJjlzK 2+H0BnKtWp/q6xdm0Yk6Ukkdqa3d9x3K1RlqIl3GY/1lbIDtv6r1N4k41JTCbsmu+uHkKat9drb B5SY2ZP6jvopX+Pox/qOpAfnxaucMRTiCt2mcdryMIcrpPd8CK7z3Wi5hXaQnPIZn38QsX5L54H nNbgLD+70fdOMxm32W50Q/o9egxQvSU+3bihdvITtkRttrBPhWB/RLeqIv31zR3PTv1+J09umN4 vxEStihQL77OZEibhqFpz8UHxp/pjLp+nIVY4jXQM7tilIBrsObKLg4mEXGpBqjv1e/lp1OHLgD KcS1zHm9XAXGZNjUX1sPtS6N7CCnGx85WR6nH+ZOp1h3AcQtFt94s= X-Received: by 2002:a05:6122:925:b0:54a:a048:45a4 with SMTP id 71dfb90a1353d-563b5c9f3e9mr1386620e0c.16.1768592284418; Fri, 16 Jan 2026 11:38:04 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-72.dlp.protect.broadcom.com. [144.49.247.72]) by smtp-relay.gmail.com with ESMTPS id 71dfb90a1353d-563b70f24f5sm401073e0c.5.2026.01.16.11.38.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Jan 2026 11:38:04 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-34ac814f308so3552782a91.3 for ; Fri, 16 Jan 2026 11:38:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1768592283; x=1769197083; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P5v6be/rvU1Ddm94jt+LcDTFwMP9w1kpc8KK4AcGhZ4=; b=TnqKRr2HJHW6c7Y1BW+NnwDF82gK1C9hQtuWGPxPAVs/vPqPC2UC0IBhzjHDGkcWyE LZa8Gz16qHm4WOMHSD12eb1aIR5j/WAUc876En9QBdHQFH8CVYQF9OlFJK+jeY6+X8En qC4WzFTJtxWYPLSzmzGMR26zjaZywyn746yLI= X-Forwarded-Encrypted: i=1; AJvYcCWf6zDB2QxUwka1HOhCwhP+bGVXJVIwyMN7sxvNTjI8N0aAlA7prCPQsI1Sful7hauoWWZSjSPh1B95ZfQ=@vger.kernel.org X-Received: by 2002:a17:90b:3890:b0:34c:99d6:175d with SMTP id 98e67ed59e1d1-35272ec5844mr3471682a91.2.1768592282931; Fri, 16 Jan 2026 11:38:02 -0800 (PST) X-Received: by 2002:a17:90b:3890:b0:34c:99d6:175d with SMTP id 98e67ed59e1d1-35272ec5844mr3471669a91.2.1768592282527; Fri, 16 Jan 2026 11:38:02 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35273121856sm2764909a91.15.2026.01.16.11.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jan 2026 11:38:02 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, ajit.khaparde@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [v5, net-next 1/8] bng_en: Extend bnge_set_ring_params() for rx-copybreak Date: Sat, 17 Jan 2026 01:07:25 +0530 Message-ID: <20260116193732.157898-2-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260116193732.157898-1-bhargava.marreddy@broadcom.com> References: <20260116193732.157898-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Add rx-copybreak support in bnge_set_ring_params() Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 19 +++++++++++++++++-- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 5 +++-- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 832eeb960bd2..8bd019ea55a2 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include =20 @@ -2295,7 +2296,6 @@ void bnge_set_ring_params(struct bnge_dev *bd) rx_space =3D rx_size + ALIGN(NET_SKB_PAD, 8) + SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); =20 - bn->rx_copy_thresh =3D BNGE_RX_COPY_THRESH; ring_size =3D bn->rx_ring_size; bn->rx_agg_ring_size =3D 0; bn->rx_agg_nr_pages =3D 0; @@ -2334,7 +2334,10 @@ void bnge_set_ring_params(struct bnge_dev *bd) bn->rx_agg_ring_size =3D agg_ring_size; bn->rx_agg_ring_mask =3D (bn->rx_agg_nr_pages * RX_DESC_CNT) - 1; =20 - rx_size =3D SKB_DATA_ALIGN(BNGE_RX_COPY_THRESH + NET_IP_ALIGN); + rx_size =3D max3(BNGE_DEFAULT_RX_COPYBREAK, + bn->rx_copybreak, + bn->netdev->cfg_pending->hds_thresh); + rx_size =3D SKB_DATA_ALIGN(rx_size + NET_IP_ALIGN); rx_space =3D rx_size + NET_SKB_PAD + SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); } @@ -2367,6 +2370,17 @@ void bnge_set_ring_params(struct bnge_dev *bd) bn->cp_ring_mask =3D bn->cp_bit - 1; } =20 +static void bnge_init_ring_params(struct bnge_net *bn) +{ + u32 rx_size; + + bn->rx_copybreak =3D BNGE_DEFAULT_RX_COPYBREAK; + /* Try to fit 4 chunks into a 4k page */ + rx_size =3D SZ_1K - + NET_SKB_PAD - SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); + bn->netdev->cfg->hds_thresh =3D max(BNGE_DEFAULT_RX_COPYBREAK, rx_size); +} + int bnge_netdev_alloc(struct bnge_dev *bd, int max_irqs) { struct net_device *netdev; @@ -2456,6 +2470,7 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_ir= qs) bn->rx_dir =3D DMA_FROM_DEVICE; =20 bnge_set_tpa_flags(bd); + bnge_init_ring_params(bn); bnge_set_ring_params(bd); =20 bnge_init_l2_fltr_tbl(bn); diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index fb3b961536ba..557cca472db6 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -135,7 +135,8 @@ struct bnge_ring_grp_info { u16 nq_fw_ring_id; }; =20 -#define BNGE_RX_COPY_THRESH 256 +#define BNGE_DEFAULT_RX_COPYBREAK 256 +#define BNGE_MAX_RX_COPYBREAK 1024 =20 #define BNGE_HW_FEATURE_VLAN_ALL_RX \ (NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_STAG_RX) @@ -186,7 +187,7 @@ struct bnge_net { u32 rx_buf_size; u32 rx_buf_use_size; /* usable size */ u32 rx_agg_ring_size; - u32 rx_copy_thresh; + u32 rx_copybreak; u32 rx_ring_mask; u32 rx_agg_ring_mask; u16 rx_nr_pages; --=20 2.47.3